openldap-commit2devel@OpenLDAP.org wrote:
A ref change was pushed to the OpenLDAP (openldap.git) repository. It will be available in the public mirror shortly.
The branch, master has been updated via 2d5996ac603391ddbd618425f88eb13e5e0e2cc0 (commit) via 5324d283d9ff1ba0f608d1130be683eb698f831e (commit) from 9f97c1d2efdabc8817538464cd7d08d55f7e51fd (commit)
Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below.
- Log -----------------------------------------------------------------
commit 2d5996ac603391ddbd618425f88eb13e5e0e2cc0 Author: Howard Chu hyc@openldap.org Date: Wed Oct 28 14:22:58 2015 +0000
ITS#8054 Cleanup duration patch Don't need op->o_hr_time, just use o_tincr, that's what it was intended for anyway. Use "etime=" like other products do. Simplify ifdefs. Use gettimeofday, it's always available now.commit 5324d283d9ff1ba0f608d1130be683eb698f831e Author: Emily Backes ebackes@symas.com Date: Thu Feb 5 18:52:19 2015 -0800
ITS#8054 operation duration logging
Summary of changes: include/ldap_log.h | 6 ++++++ servers/slapd/operation.c | 32 +++++++++++++++++++++++--------- servers/slapd/result.c | 42 ++++++++++++++++++++++++++++++++---------- servers/slapd/slap.h | 20 ++++++++++++++++++++ 4 files changed, 81 insertions(+), 19 deletions(-)
A note about this revised patch - accesslog uses op->o_time/op->o_tincr to generate its RDNs. We actually have a problem here in that microsecond resolution may no longer be adequate. Back in January I was on site with a customer whose 64-core server was hitting ~1 million queries/sec. Granted, that was with syslog and accesslog disabled; with logging enabled we're far more limited.
Very soon we're going to need higher resolution when logging is enabled.
Howard Chu wrote:
A note about this revised patch - accesslog uses op->o_time/op->o_tincr to generate its RDNs. We actually have a problem here in that microsecond resolution may no longer be adequate. Back in January I was on site with a customer whose 64-core server was hitting ~1 million queries/sec. Granted, that was with syslog and accesslog disabled; with logging enabled we're far more limited.
Very soon we're going to need higher resolution when logging is enabled.
At that speed I'm mostly concerned about entryCSN values and MMR conflict resolution.
Ciao, Michael.
Michael Ströder wrote:
Howard Chu wrote:
A note about this revised patch - accesslog uses op->o_time/op->o_tincr to generate its RDNs. We actually have a problem here in that microsecond resolution may no longer be adequate. Back in January I was on site with a customer whose 64-core server was hitting ~1 million queries/sec. Granted, that was with syslog and accesslog disabled; with logging enabled we're far more limited.
Very soon we're going to need higher resolution when logging is enabled.
At that speed I'm mostly concerned about entryCSN values and MMR conflict resolution.
Note that CSNs already support finer than microsecond resolution. But since delta-syncrepl relies on accesslog, that's more of a concern.
As for syslog - currently, with my experimental syslog() code, my best result still takes 60% longer when running with -s256 (STATS loglevel) vs -s0. If I comment out the send() on the /dev/log socket to rsyslogd, and leave all the message formatting code intact, it's only 10% slower. So most of the slowdown is in the actual send() syscall.
(Using the original code is around 2.5x slower for -s256 than -s0)
-
Howard Chu -
Michael Ströder