asserts and manadatory build instructions (was ITS#8240)
by Michael Ströder
hyc(a)symas.com wrote in ITS#8240:
> Our patch response was too hasty. There is no OpenLDAP bug here, the real
> issue is production binaries being built with asserts enabled instead of
> compiling with -DNDEBUG. That's an issue for packagers and distros to resolve.
> Closing this ITS, not an OpenLDAP bug.
Maybe I missed something. But this is the first time I've heard about -DNDEBUG
being mandatory when compiling binary packages for production use. Does it
have other effects?
And what are general rules for assert statements in OpenLDAP code?
In my own (Python) code assert statements are supposed to be only triggered if
something goes wrong *internally* (type issues etc.). If somebody manages to
trigger an assert statement with invalid input from "outside" I always
consider this to be a serious bug revealing insufficient error handling even
though e.g. web2ldap just logs the exception but won't crash. YMMV, but please
clarify.
I also wonder whether there are more mandatory rules for building packages and
where I can find them.
Please don't get me wrong: My inquiry is in good faith to avoid unnecessary
ITS based on misunderstanding.
Ciao, Michael.
1 year, 3 months
2.4 commit review
by Quanah Gibson-Mount
A few commits stacking up, so would like to review them for inclusion in an
eventual 2.4.49.
I think all of the following look good for RE24, but wanted to confirm
specifically on (a) the GnuTLS changes, (b) the cleaner error handling
during connection setup, and (c) the Totp changes.
OpenLDAP:
ITS#9067 fix syntax evaluation of preferredDeliveryMethod
ITS#8753 Set minimum GnuTLS version to 3.2.2
ITS#9071 Document "tls none" for back-ldap
ITS#9069 Do not call gnutls_global_set_mutex()
ITS#9077 slapo-unique Let the loop finish
ITS#9095 insert missing commit at end of slapindex processing
ITS#9091 drop attr mappings added in an aborted txn
ITS#9100 relax domainScope check for absent value
ITS#9112 cleaner error handling during connection setup
Contrib:
Totp: ITS#9055 Introduce a combined password scheme
TotP: ITS#9055 Accept previous token
LMDB:
ITS#9068 fix backslash escaping
Thanks,
Quanah
--
Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>
3 years
ldap0 does not work with RE24
by Michael Ströder
HI!
It seems I'm experiencing a regression when running tests of
python-ldap0 with current RE24 which does not fail with 2.4.48:
test016_cancel (__main__.Test00_LDAPObject) ... munmap_chunk(): invalid
pointer
ERROR
There was this change for ITS#9124. So I guess it's causing this regression.
Could someone look into this?
Ciao, Michael.
3 years, 1 month
dynlist enhancements, ITS#9121
by Howard Chu
There's some ambiguities that still need to be resolved, around the memberOf functionality.
The dynlist code only adds memberOf values for dynamic groups. It doesn't do anything about
static group memberships. This implies that you still need to use the memberOf overlay too,
if you want to also support static groups.
The dynlist overlay doesn't define the memberOf attribute schema. Something else needs to
do that, either loading it as user-defined schema, or relying on the memberof overlay to
already be initialized.
This seems like a messy loose end to leave dangling, but not sure what a better approach would be.
Suggestions?
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
3 years, 1 month
