asserts and manadatory build instructions (was ITS#8240)
by Michael Ströder
hyc(a)symas.com wrote in ITS#8240:
> Our patch response was too hasty. There is no OpenLDAP bug here, the real
> issue is production binaries being built with asserts enabled instead of
> compiling with -DNDEBUG. That's an issue for packagers and distros to resolve.
> Closing this ITS, not an OpenLDAP bug.
Maybe I missed something. But this is the first time I've heard about -DNDEBUG
being mandatory when compiling binary packages for production use. Does it
have other effects?
And what are general rules for assert statements in OpenLDAP code?
In my own (Python) code assert statements are supposed to be only triggered if
something goes wrong *internally* (type issues etc.). If somebody manages to
trigger an assert statement with invalid input from "outside" I always
consider this to be a serious bug revealing insufficient error handling even
though e.g. web2ldap just logs the exception but won't crash. YMMV, but please
clarify.
I also wonder whether there are more mandatory rules for building packages and
where I can find them.
Please don't get me wrong: My inquiry is in good faith to avoid unnecessary
ITS based on misunderstanding.
Ciao, Michael.
10 months, 3 weeks
Re: back-llog
by Howard Chu
Michael Ströder wrote:
> Howard Chu wrote:
>> Michael Ströder wrote:
>>> Howard Chu wrote:
>>>> Was just thinking we could do a quite simple backend for use with the accesslog
>>>> overlay and delta-syncrepl. It would write into flat files and do typical
>>>> logfile rotation on its own. The backing store would have a minimum of two files
>>>> - one for the suffix entry, one for the current chunk of logs. There would be a
>>>> configurable number of logfiles, with the oldest simply being deleted when it's
>>>> time to purge.
>>>
>>> Two things I'd consider helpful for long-time archiving/auditing:
>>>
>>> 1. filenames to allow of "merging" different log flat files into one big file
>>> store on a different slapd instance.
>>
>> Not sure what you mean by this. As sequential logs you could just cat them if
>> you want to combine files into one, what does the filename have to do with it?
>
> Sorry for unclear wording.
> I'd like to move archived files of all MMR replicas into another single
> filesystem directory and let a special auditing slapd with back-llog search in
> them without having to muck with file names.
Then you would have to merge them entry-by-entry to preserve chronological order.
>> If we just use datestamps for filenames YYYYMMDD it should be no problem for you
>> to cat them in proper order.
>
> There could be conflicting timestamps from different MMR replicas. Maybe
> appending the serverID could be a solution?
Just keep them all in their own separate filesystem directories.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
6 years, 1 month
Re: back-llog
by Howard Chu
Michael Ströder wrote:
> Howard Chu wrote:
>> Was just thinking we could do a quite simple backend for use with the accesslog
>> overlay and delta-syncrepl. It would write into flat files and do typical
>> logfile rotation on its own. The backing store would have a minimum of two files
>> - one for the suffix entry, one for the current chunk of logs. There would be a
>> configurable number of logfiles, with the oldest simply being deleted when it's
>> time to purge.
>
> Two things I'd consider helpful for long-time archiving/auditing:
>
> 1. filenames to allow of "merging" different log flat files into one big file
> store on a different slapd instance.
Not sure what you mean by this. As sequential logs you could just cat them if
you want to combine files into one, what does the filename have to do with it?
If we just use datestamps for filenames YYYYMMDD it should be no problem for
you to cat them in proper order.
> 2. instead of deleting moving files to an archive directory.
Sounds fine as an option.
> I know it's a different use-case but quite handy.
>
> Ciao, Michael.
>
>
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
6 years, 1 month
back-llog
by Howard Chu
Was just thinking we could do a quite simple backend for use with the
accesslog overlay and delta-syncrepl. It would write into flat files and do
typical logfile rotation on its own. The backing store would have a minimum of
two files - one for the suffix entry, one for the current chunk of logs. There
would be a configurable number of logfiles, with the oldest simply being
deleted when it's time to purge. It would only support Add/Search in general,
and Modify on the suffix entry.
A rolling append-only format like this would allow much higher throughput for
accesslog recording. Using a binary entry format would of course also help.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
6 years, 1 month
