openldap-devel October 2012

openldap-devel@openldap.org

6 participants
6 discussions

Support readonly MDB slaptools on readonly filesystems
by Hallvard Breien Furuseth 27 Oct '12

27 Oct '12

Back-mdb needs this test, copied from libmdb, to make use of the libmdb support for read-only filesystems. I don't know if Windows sets errno=EROFS for fopen(fname, "w") when fname is on a read-only FS, if so the #ifndef _WIN32 is unnecessary. --- servers/slapd/back-mdb/config.c +++ servers/slapd/back-mdb/config.c @@ -561,3 +561,8 @@ mdb_cf_gen( ConfigArgs *c ) ch_free( testpath ); - if ( !f ) { +#ifndef _WIN32 + if ( !(f || ((slapMode & SLAP_TOOL_READONLY) && errno == EROFS)) ) +#else + if ( !(f || ((slapMode & SLAP_TOOL_READONLY) && GetLastError() == ERROR_WRITE_PROTECT)) ) +#endif + { snprintf( c->cr_msg, sizeof( c->cr_msg ), "%s: invalid path: %s", -- Hallvard

1 0

Re: openldap.git branch mdb.master updated. ef2092eac9f35b77eae250801c96dfa515c6d4b2
by Hallvard Breien Furuseth 25 Oct '12

25 Oct '12

> commit ef2092eac9f35b77eae250801c96dfa515c6d4b2 > Author: Howard Chu <hyc(a)symas.com> > Date: Thu Oct 25 05:28:55 2012 -0700 > > MDB_DEBUG tweak for old compilers This changes which page DPRINTF says got popped, since mc_top is now read after the "mc->mc_top--;" statement. I think it should have been: --- mdb.c +++ mdb.c @@ -298,4 +298,5 @@ #else # define DPRINTF(fmt, ...) ((void) 0) +# define MDB_DEBUG_SKIP #endif /** Print a debug string. @@ -3684,5 +3685,5 @@ { if (mc->mc_snum) { -#if MDB_DEBUG +#ifndef MDB_DEBUG_SKIP MDB_page *top = mc->mc_pg[mc->mc_top]; #endif Or use the DPRINTF((args)) hack after all, and a helper macro to unpack the arguments. -- Hallvard

2 1

RE24 testing call #2 (OpenLDAP 2.4.33)
by Quanah Gibson-Mount 13 Oct '12

13 Oct '12

If you know how to build OpenLDAP manually, and would like to participate in testing the next set of code for the 2.4.33 release, please do so. Generally, get the code for RE24: <http://www.openldap.org/devel/gitweb.cgi?p=openldap.git;a=snapshot;h=refs/h…> Configure & build. Execute the test suite (via make test) after it is built. Thanks! --Quanah -- Quanah Gibson-Mount Sr. Member of Technical Staff Zimbra, Inc A Division of VMware, Inc. -------------------- Zimbra :: the leader in open source messaging and collaboration

2 1

2.4.33 is ready for release (Contributors)
by Quanah Gibson-Mount 08 Oct '12

08 Oct '12

2.4.33 is ready for release. Significant contributors are: Howard Chu (Symas Corp) Hallvard Furuseth (University of Oslo) Quanah Gibson-Mount (VMware, Inc) --Quanah -- Quanah Gibson-Mount Sr. Member of Technical Staff Zimbra, Inc A Division of VMware, Inc. -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

Manual should tell the data range of the configuration parameter
by Tianyin Xu 04 Oct '12

04 Oct '12

Hi, guys, I was quite confused with "index_intlen". ---------- what the manual says ---------- * * *index_intlen* <*integer*> Specify the key length for ordered integer indices. The most significant bytes of the binary integer will be used for index keys. The default value is 4, which provides exact indexing for 31 bit values. A floating point representation is used to index too large values. ------------------------------------------------------ Ok, what the manual told me is that 4 is the default value, and large values can be handled. But I finally figured out that 4 is not only the default value but also the minimum value. >From the source code, I knew the index_intlen is with the data range [4, 255]. Any out-of-range value will be converted to the boundaries without notifying users: #define SLAP_INDEX_INTLEN_DEFAULT 4 /* servers/slapd/bconfig.c */ static int config_generic(ConfigArgs *c) { ... case CFG_IX_INTLEN: if ( c->value_int < SLAP_INDEX_INTLEN_DEFAULT ) c->value_int = SLAP_INDEX_INTLEN_DEFAULT; else if ( c->value_int > 255 ) c->value_int = 255; index_intlen = c->value_int; ... } To my opinion, as a configuration knob for user tuning, such behavior (especially the range) should be explicitly exposed to users. I would suggest to make it explicit by 1. print out logs to notify users 2. write in the manual. * * Thanks a lot! Tianyin -- Tianyin XU, http://cseweb.ucsd.edu/~tixu/

2 1

RE24 testing all #1 (OpenLDAP 2.4.33)
by Quanah Gibson-Mount 03 Oct '12

03 Oct '12

3 4

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-devel October 2012