asserts and manadatory build instructions (was ITS#8240)
by Michael Ströder
hyc(a)symas.com wrote in ITS#8240:
> Our patch response was too hasty. There is no OpenLDAP bug here, the real
> issue is production binaries being built with asserts enabled instead of
> compiling with -DNDEBUG. That's an issue for packagers and distros to resolve.
> Closing this ITS, not an OpenLDAP bug.
Maybe I missed something. But this is the first time I've heard about -DNDEBUG
being mandatory when compiling binary packages for production use. Does it
have other effects?
And what are general rules for assert statements in OpenLDAP code?
In my own (Python) code assert statements are supposed to be only triggered if
something goes wrong *internally* (type issues etc.). If somebody manages to
trigger an assert statement with invalid input from "outside" I always
consider this to be a serious bug revealing insufficient error handling even
though e.g. web2ldap just logs the exception but won't crash. YMMV, but please
clarify.
I also wonder whether there are more mandatory rules for building packages and
where I can find them.
Please don't get me wrong: My inquiry is in good faith to avoid unnecessary
ITS based on misunderstanding.
Ciao, Michael.
1 year, 4 months
Two log lines for SRCH parameters?
by Michael Ströder
HI!
I'm wondering why there are two log lines for listing the search
parameters for a single search operation:
SRCH base="dc=ae-dir,dc=example,dc=org" scope=2 deref=0
filter="(objectClass=aePerson)"
SRCH attr=cn givenName sn mail aeStatus
Is there any rationale for that? Wouldn't it be better to also list
attr= along with the other search parameters? The attributes could also
be listed as comma-separated list, so parsing with space as separator
would be easy.
I'm asking for a rather *small* change. I deliberately do not want to
start a let's-fix-all-the-log-issues discussion.
Ciao, Michael.
3 years, 1 month
Suggested minor change: LMDB FNV hash code license
by Dan Shearer
Hello all,
In using liblmdb in LumoSQL, we noticed that the FNV code in mdb.c has
a non-binding license comment that doesn't match the way it is used in
lmdb:
"please do not copyright this code. This code is in the public domain."
followed by a typical public domain disclaimer.
I asked Landon Curt Noll, the author of this code, who proposed this
alternative:
Title: FNV Hash
Author: Landon Curt Noll - http://www.isthe.com/chongo/
Source: http://www.isthe.com/chongo/tech/comp/fnv
License: CC BY 4.0 - https://creativecommons.org/licenses/by/4.0/
Share - copy and redistribute the material in any medium or format
Adapt - remix, transform, and build upon the material for any purpose,
even commercially.
The licensor cannot revoke these freedoms as long as you follow the
license terms.
NOTE: This code was changed to use the 'CC BY 4.0' license by
permission of the author.
Would the project accept a patch that makes this change?
Thanks,
--
Dan Shearer
dan(a)shearer.org
3 years, 1 month
get rid of -releng suffix
by Michael Ströder
HI!
Is the releng suffix for the shared libs still needed? It made sense in
former times.
But given automatic testing in VMs, containers, CI/CD delivery pipelines
it just adds this small extra complexity without any benefit. I suggest
to drop it for 2.5.x.
Opinions?
Ciao, Michael.
3 years, 1 month
Re: RE25 branch testing
by Gavin Henry
Will have a shot!
On Tue, 4 Feb 2020, 00:07 Quanah Gibson-Mount, <quanah(a)symas.com> wrote:
> Unfortunately, it's very clear that zero people have been using/testing
> the
> RE25 code branch, as it was completely unusable until today (wouldn't even
> compile).
>
> I have gotten it now to the point where it both compiles and passes make
> test, although my tests do not include any SSL libraries at the moment.
>
> If anyone on the list could compile, test, and deploy (in a non-production
> environment) RE25, that would be great. I'm working on updating the
> announcement file with the numerous new features available. Once that's
> complete, I'll start looking at getting an alpha tarball together.
>
> It would also be extremely helpful if there were people who could help
> write up documentation as necessary (particularly for the admin guide) on
> the new features (or heck, even the numerous unfinished pages for existing
> features :( ).
>
> Thanks,
> Quanah
>
>
>
> --
>
> Quanah Gibson-Mount
> Product Architect
> Symas Corporation
> Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
> <http://www.symas.com>
>
>
3 years, 1 month
RE25 branch testing
by Quanah Gibson-Mount
Unfortunately, it's very clear that zero people have been using/testing the
RE25 code branch, as it was completely unusable until today (wouldn't even
compile).
I have gotten it now to the point where it both compiles and passes make
test, although my tests do not include any SSL libraries at the moment.
If anyone on the list could compile, test, and deploy (in a non-production
environment) RE25, that would be great. I'm working on updating the
announcement file with the numerous new features available. Once that's
complete, I'll start looking at getting an alpha tarball together.
It would also be extremely helpful if there were people who could help
write up documentation as necessary (particularly for the admin guide) on
the new features (or heck, even the numerous unfinished pages for existing
features :( ).
Thanks,
Quanah
--
Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>
3 years, 1 month