1:09 a.m.
On 02/21/2013 10:57 AM, openldap-commit2devel(a)OpenLDAP.org wrote:
- Log
-----------------------------------------------------------------
commit 04b95ec6eeaaf2e669d25a8e06e5a2ed73fbcf2c
Author: Howard Chu <hyc(a)openldap.org>
Date: Thu Feb 21 01:56:58 2013 -0800
ITS#7525 more for quoting
Howard,
I'm not sure this needs quoting. The URI needed quoting because
multiple URIs are listed in a single value, and the first URI needs the
DN portion.
On the contrary, subtree-{in|ex}clude are multiple-valued attributes
which are parsed independently, so no quoting is needed (actually,
quoting breaks parsing).
I'm keen to reverting this, unless I'm missing something.
p.
--
Pierangelo Masarati
Associate Professor
Dipartimento di Scienze e Tecnologie Aerospaziali
Politecnico di Milano
1:20 a.m.
New subject: openldap.git branch master updated. 04b95ec6eeaaf2e669d25a8e06e5a2ed73fbcf2c
Pierangelo Masarati wrote:
On 02/21/2013 10:57 AM, openldap-commit2devel(a)OpenLDAP.org wrote:
> - Log -----------------------------------------------------------------
> commit 04b95ec6eeaaf2e669d25a8e06e5a2ed73fbcf2c
> Author: Howard Chu <hyc(a)openldap.org>
> Date: Thu Feb 21 01:56:58 2013 -0800
>
> ITS#7525 more for quoting
Howard,
I'm not sure this needs quoting. The URI needed quoting because
multiple URIs are listed in a single value, and the first URI needs the
DN portion.
On the contrary, subtree-{in|ex}clude are multiple-valued attributes
which are parsed independently, so no quoting is needed (actually,
quoting breaks parsing).
I'm keen to reverting this, unless I'm missing something.
When I tested with the included config in the ITS, parsing ignored the values
without this patch, and there was no corresponding value in the cn=config
entry. If your testing shows otherwise, please elaborate...
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
4:09 a.m.
New subject: openldap.git branch master updated. 04b95ec6eeaaf2e669d25a8e06e5a2ed73fbcf2c
On 02/27/2013 10:20 AM, Howard Chu wrote:
Pierangelo Masarati wrote:
> On 02/21/2013 10:57 AM, openldap-commit2devel(a)OpenLDAP.org wrote:
>
>> - Log -----------------------------------------------------------------
>> commit 04b95ec6eeaaf2e669d25a8e06e5a2ed73fbcf2c
>> Author: Howard Chu <hyc(a)openldap.org>
>> Date: Thu Feb 21 01:56:58 2013 -0800
>>
>> ITS#7525 more for quoting
>
> Howard,
>
> I'm not sure this needs quoting. The URI needed quoting because
> multiple URIs are listed in a single value, and the first URI needs the
> DN portion.
>
> On the contrary, subtree-{in|ex}clude are multiple-valued attributes
> which are parsed independently, so no quoting is needed (actually,
> quoting breaks parsing).
>
> I'm keen to reverting this, unless I'm missing something.
When I tested with the included config in the ITS, parsing ignored the
values without this patch, and there was no corresponding value in the
cn=config entry. If your testing shows otherwise, please elaborate...
The original issue was related to the presence of ARG_STRING, which you
fixed. Now a value is emitted. But the value is quoted, because you
added ARG_QUOTE. As a consequence, now starting slapd using -F fails
because quotes are present, while IMHO they should not be needed.
p.
--
Pierangelo Masarati
Associate Professor
Dipartimento di Scienze e Tecnologie Aerospaziali
Politecnico di Milano
3868
days inactive
3868
days old
2 comments
2 participants
participants (2)
-
Howard Chu -
Pierangelo Masarati