--On Friday, January 15, 2010 5:53 PM +0000 hallvard@OpenLDAP.org wrote:
Update of /repo/OpenLDAP/pkg/ldap/servers/slapd
Modified Files: sl_malloc.c 1.67 -> 1.68 zn_malloc.c 1.14 -> 1.15
Log Message: Gentler message when falling back to ch_malloc
CVS Web URLs: http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/ http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/sl_malloc.c http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/zn_malloc.c
Changes are generally available on cvs.openldap.org (and CVSweb) within 30 minutes of being committed.
The new error message doesn't make sense, English wise. It doesn't even parse.
- "slap_sl_malloc of %lu bytes failed, using ch_malloc\n", + "slap_sl_malloc of %lu bytes falling back to ch_malloc\n",
I.e., what would get logged is:
slap_sl_malloc of 700 bytes falling back to ch_malloc
Which really gives the end user no idea what is wrong.
I would suggest something like:
+ "slap_sl_malloc of %lu bytes failed, falling back to ch_malloc\n",
Similar with the slap_zn_malloc error message.
--Quanah
--
Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration
[Reply for reference, reflecting offline discussions]
Quanah Gibson-Mount writes:
sl_malloc.c 1.67 -> 1.68 zn_malloc.c 1.14 -> 1.15 Gentler message when falling back to ch_malloc
The new error message doesn't make sense, English wise. It doesn't even parse.
"slap_sl_malloc of %lu bytes failed, using ch_malloc\n",
"slap_sl_malloc of %lu bytes falling back to ch_malloc\n",
Looks fine to me, but maybe I wrote "English in Norwegian". <<slap_sl_malloc> <of %lu bytes>> <<falling back> <to ch_malloc>>.
Anyway, removing the English words fixes the problem since it's just a trace message of little interest to users.
Which really gives the end user no idea what is wrong.
Yes, since nothing is wrong yet the message claimed it failed, so people were asking what's wrong.
Unless ch_malloc also fails, then it might help a little to see that it came from e.g. slap_sl_malloc of 18446744073709550382 bytes.
--On Thursday, April 15, 2010 9:23 AM +0200 Hallvard B Furuseth h.b.furuseth@usit.uio.no wrote:
[Reply for reference, reflecting offline discussions]
Quanah Gibson-Mount writes:
sl_malloc.c 1.67 -> 1.68 zn_malloc.c 1.14 -> 1.15 Gentler message when falling back to ch_malloc
The new error message doesn't make sense, English wise. It doesn't even parse.
"slap_sl_malloc of %lu bytes failed, using ch_malloc\n",
"slap_sl_malloc of %lu bytes falling back toch_malloc\n",
Looks fine to me, but maybe I wrote "English in Norwegian". <<slap_sl_malloc> <of %lu bytes>> <<falling back> <to ch_malloc>>.
Anyway, removing the English words fixes the problem since it's just a trace message of little interest to users.
Certainly. The only issue with the message as it was is there was a lack of context between "bytes" and "falling back". I.e., something like "attempted" or "failed" (although I know we want to avoid the word "failed").
I think the end suggesting on #openldap-devel was something like:
slap_sl_malloc %lu bytes: ch_malloc
or similar. Completely a trace message, which will remain usefully meaningless to the end user, but still give back context for anyone who needs it. ;)
--Quanah
--
Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration
-
Hallvard B Furuseth -
Quanah Gibson-Mount