--On Friday, January 15, 2010 5:53 PM +0000 hallvard@OpenLDAP.org wrote:

Update of /repo/OpenLDAP/pkg/ldap/servers/slapd

Modified Files: sl_malloc.c 1.67 -> 1.68 zn_malloc.c 1.14 -> 1.15

Log Message: Gentler message when falling back to ch_malloc

CVS Web URLs: http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/ http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/sl_malloc.c http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/zn_malloc.c

Changes are generally available on cvs.openldap.org (and CVSweb) within 30 minutes of being committed.

The new error message doesn't make sense, English wise. It doesn't even parse.

- "slap_sl_malloc of %lu bytes failed, using ch_malloc\n", + "slap_sl_malloc of %lu bytes falling back to ch_malloc\n",

I.e., what would get logged is:

slap_sl_malloc of 700 bytes falling back to ch_malloc

Which really gives the end user no idea what is wrong.

I would suggest something like:

+ "slap_sl_malloc of %lu bytes failed, falling back to ch_malloc\n",

Similar with the slap_zn_malloc error message.

--Quanah

--

Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration