Re: commit "ITS#8226 limit size of read txns in searches" has a bug

Леонид Юрьев wrote:

Hi, Howard.

wwctx.txn may be uninitialized, see lines 712-720 of back-mdb/search.c http://www.openldap.org/devel/gitweb.cgi?p=openldap.git;a=blob;f=servers/sla...

And therefore mdb_rtxn_snap() may segfault when will called from line 1127. http://www.openldap.org/devel/gitweb.cgi?p=openldap.git;a=blob;f=servers/sla...

I think, one of the following should be:

• wwctx should be initialize completely at 712;

or

• an additional condition should be checked at 1123-1125.

Thanks, you're right. If the current operation doesn't own the transaction (e.g. search called while evaluating the ACL in some other operation) then it must leave the transaction alone. Fixed now.