Hallvard B Furuseth wrote:
But we could put the test for "BerkeleyDB version incompatible" just below finding major and minor version. Also I think the texts can be clarified:
checking for Berkeley DB major version in db.h... 4 checking for Berkeley DB minor version in db.h... 2 checking Berkeley DB version supported by BDB/HDB backends... no configure: error: BerkeleyDB version 4.2 incompatible with BDB/HDB backends (or success above:) checking for Berkeley DB link (-ldb-4.2)... yes checking for Berkeley DB version match (header vs. library)... yes checking for Berkeley DB thread support... yes
Could remove some cruft too. OL_BERKELEY_COMPAT_DB in build/openldap.m4 seems to be unused. And the code which searches for minor/major version numbers could be a for(version) loop.
All this has been like this for years though, so I think we don't need to hold up next 2.4 release for this.
Well, now that we have new ITSs holding it up, probably no harm in making these changes. I'll take a look.