5 Sep
2008
5 Sep
'08
11:15 p.m.
On Sat, Sep 6, 2008 at 4:01 AM, Howard Chu hyc@symas.com wrote:
Pretty good. Just a couple points - it's not necessary to strdup c->argv[] before processing it. Since this overlay is the final consumer of the argv, there's no reason to preserve it. Trash it at will. strtok should probably be used instead of strtok_r in your config code since strtok_r is not universal and the code is single-threaded already.
Also, strcat/strncat are never to be used, use lutil_strcopy/strncopy instead.
ci_ad_len should probably be ci_ad_num; "_len" is always used for the length of strings, "_num" to count anything else.
Have made suggested changes, thanks :)
New diff is attached...
Cheers Brett