openldap-devel

openldap-devel@openldap.org

1418 discussions

RE24 testing for 2.4.18
by Quanah Gibson-Mount 24 Aug '09

24 Aug '09

Please test RE24. Thanks! --Quanah -- Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration

9 15

Re: commit: ldap/servers/slapd/overlays pcache.c
by masarati＠aero.polimi.it 21 Aug '09

21 Aug '09

> Update of /repo/OpenLDAP/pkg/ldap/servers/slapd/overlays > > Modified Files: > pcache.c 1.193 -> 1.194 > > Log Message: > ITS#6152 add tests for cache refresh and Bind caching Valgrind is complaining about uninit'ed values in pcache configuration, and some leaks in cached entries. I might look at this later, no time right now. p.

1 0

Re: commit: ldap/servers/slapd/overlays pcache.c
by masarati＠aero.polimi.it 19 Aug '09

19 Aug '09

> Update of /repo/OpenLDAP/pkg/ldap/servers/slapd/overlays > > Modified Files: > pcache.c 1.189 -> 1.190 > > Log Message: > more cache monitoring (ITS#5178) I'm just exposing counters. I see few inconsistencies, though. The number of pcacheQueryURL values corresponds to pcacheNumQueries, but the pcacheNumEntries seems quite erratic. Different executions of test020 report a number of cached entries ranging from 10 to 12. Searching the cache with the privDB control always returns 10 entries with pcacheQueryID=* in the cache. After cleanup, the counter in fact drops by 10, although the database is empty (apart from the glue entries, of course). p.

1 0

Re: commit: ldap/doc/man/man3 ldap_get_option.3
by Howard Chu 19 Aug '09

19 Aug '09

ando(a)OpenLDAP.org wrote: > Update of /repo/OpenLDAP/pkg/ldap/doc/man/man3 > > Modified Files: > ldap_get_option.3 1.11 -> 1.12 > > Log Message: > document all options, including TLS and (not yet complete) SASL. Needs expert review I would drop LDAP_OPT_X_TLS; it basically turns on ldaps. This has been unnecessary ever since ldap_initialize() was provided and is only likely to cause problems. (E.g., URI says "ldap://" but library opens ldaps session -> massive confusion.) -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

2 1

Re: commit: ldap/doc/man/man3 ldap_get_option.3
by Howard Chu 19 Aug '09

19 Aug '09

ando(a)OpenLDAP.org wrote: > Update of /repo/OpenLDAP/pkg/ldap/doc/man/man3 > > Modified Files: > ldap_get_option.3 1.11 -> 1.12 > > Log Message: > document all options, including TLS and (not yet complete) SASL. Needs expert review LDAP_OPT_X_TLS_CONNECT_CB / _ARG is implemented, but probably not useful. I used it to obtain the SSL session handle on a newly allocated session to insert it into the OpenSSL session cache. These days I would instead add generic hooks for enabling an implementation-specific session cache. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

HAVE_GMTIME_R?
by masarati＠aero.polimi.it 19 Aug '09

19 Aug '09

The code is littered with tests like #ifdef HAVE_GMTIME_R, but there's no longer tests for gmtime_r() in configure. Is it time to cleanup a bit? p.

5 14

Re: Signedness issue in utf-8 code?
by masarati＠aero.polimi.it 19 Aug '09

19 Aug '09

> In libldap/utf-8-conv.c:194 > > if( wchar < 0x80000000 ) > > I get a warning about signed/unsigned comparison. What seems to happen is > that wchar (which is of type wchar_t) is a signed integer (on my i386,it's > a 4 byte int) and thus it's always < 0x80000000 by definition. ANSI C > converts 0x80000000 to unsigned, thus the warning. That code is only in use when sizeof(wchar_t) >= 4. The C library standard mandates wchar_t to be integer, thus signed. If I promote 0x80000000 to 0x80000000LL, when sizeof(wchar_t) == 4, like in my case, the test will always be true, and the compiler will complain about the test always being true. Everything would be fine otherwise. p.

2 3

Signedness issue in utf-8 code?
by masarati＠aero.polimi.it 19 Aug '09

19 Aug '09

In libldap/utf-8-conv.c:194 if( wchar < 0x80000000 ) I get a warning about signed/unsigned comparison. What seems to happen is that wchar (which is of type wchar_t) is a signed integer (on my i386,it's a 4 byte int) and thus it's always < 0x80000000 by definition. ANSI C converts 0x80000000 to unsigned, thus the warning. p.

1 0

Re: commit: ldap/include ldap_pvt.h
by Howard Chu 19 Aug '09

19 Aug '09

hallvard(a)OpenLDAP.org wrote: > Update of /repo/OpenLDAP/pkg/ldap/include > > Modified Files: > ldap_pvt.h 1.110 -> 1.111 > > Log Message: > Fix previous commit: move struct lutil_tm declaration out of prototype scope That's fine, but this tends to imply that the lutil_tm stuff needs to move into libldap as well. Of course, there's a lot of useful stuff in liblutil that would make life easier if it was included in libldap, or otherwise available on an installed image... -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

3 2

Re: commit: ldap/servers/slapd bconfig.c
by masarati＠aero.polimi.it 19 Aug '09

19 Aug '09

> Update of /repo/OpenLDAP/pkg/ldap/servers/slapd > > Modified Files: > bconfig.c 1.385 -> 1.386 > > Log Message: > More ITS#6234: // comment from rev 1.384 -> /**/ Sorry, that was supposed to be removed, along with the rest of the LDAP_TCP_BUFFER_X_ORDERED stuff, as the olcTCPBuffer attr does not need to be ordered. I'll modify it later. p.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-devel