hyc(a)symas.com wrote in ITS#8240:
> Our patch response was too hasty. There is no OpenLDAP bug here, the real
> issue is production binaries being built with asserts enabled instead of
> compiling with -DNDEBUG. That's an issue for packagers and distros to resolve.
> Closing this ITS, not an OpenLDAP bug.
Maybe I missed something. But this is the first time I've heard about -DNDEBUG
being mandatory when compiling binary packages for production use. Does it
have other effects?
…
[View More]And what are general rules for assert statements in OpenLDAP code?
In my own (Python) code assert statements are supposed to be only triggered if
something goes wrong *internally* (type issues etc.). If somebody manages to
trigger an assert statement with invalid input from "outside" I always
consider this to be a serious bug revealing insufficient error handling even
though e.g. web2ldap just logs the exception but won't crash. YMMV, but please
clarify.
I also wonder whether there are more mandatory rules for building packages and
where I can find them.
Please don't get me wrong: My inquiry is in good faith to avoid unnecessary
ITS based on misunderstanding.
Ciao, Michael.
[View Less]
> If a client has thousands or more requests in flight at the same time, it has to
> look up the right request every time it receives a response. As the requests are
> tracked in a doubly-linked list, lookup tends to take O(n) steps whichever
> direction we take and things generally get out of hand from there on.
>
> The linked branch puts them into a TAvl for quicker lookup, with another commit
> to let people test as (t)avl code is part of liblutil at the moment.
Is it …
[View More]worth putting parts of liblutil into libldap or maybe letting
liblutil be dynamically linked so it can be used from there?
Are there other options on the table?
--
Ondřej Kuzník
Senior Software Engineer
Symas Corporation http://www.symas.com
Packaged, certified, and supported LDAP solutions powered by OpenLDAP
[View Less]
I noticed that OpenSSL 1.1 now has an explicit dependency on Pthreads. Which means that now
even our "non-threaded" libldap, when built with OpenSSL, must actually be linked with the
threads library. In this age of multicore processors, is it really important to have a single-threaded
LDAP library any more? Should we just make libldap_r become the standard library?
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/…
[View More]Chief Architect, OpenLDAP http://www.openldap.org/project/
[View Less]
There have been some reports coming in to the ITS system that likely should
go into OpenLDAP 2.4.48/LMDB 0.9.23. These are:
ITS#8969 - Tweak to LMDB page splits (already committed to LMDB RE0.9)
ITS#8968 - ASYNC connect mode does not work on Solaris
(<https://github.com/quanah/openldap-scratch/tree/its8968>)
ITS#8967 - back-mdb "unchecked" limits broken with particular search
scopes. Needs fix.
ITS#8957 - ASYNC TLS mode is broken
(<https://github.com/quanah/openldap-scratch/…
[View More]tree/its8957>)
ITS#8963 - StartTLS failures with back-ldap due to bug in timeout
calculation. Needs fix.
ITS#8472 - only do index DB cleanup if DB is running (fix committed to
master)
ITS#8952 - High CPU usage when idletime is < 4 (fix committed to master)
Any objections to me syncing these over into RE24?
--Quanah
--
Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>
[View Less]