October 2015 - openldap-bugs

(ITS#8275) [PATCH 1/2] Add mdb_dbi_name() function to get database name from a handle

by pmedvedev＠gmail.com

Full_Name: Pavel Medvedev Version: OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (217.25.225.40) --- libraries/liblmdb/lmdb.h | 15 +++++++++++++++ libraries/liblmdb/mdb.c | 9 +++++++++ 2 files changed, 24 insertions(+) diff --git a/libraries/liblmdb/lmdb.h b/libraries/liblmdb/lmdb.h index e080e76..933a862 100644 - - a/libraries/liblmdb/lmdb.h +++ b/libraries/liblmdb/lmdb.h @@ -1136,6 +1136,21 @@ int mdb_stat(MDB_txn *txn, MDB_dbi dbi, MDB_stat *stat); */ int mdb_dbi_flags(MDB_txn *txn, MDB_dbi dbi, unsigned int *flags); + /** @brief Return the DB name that was used in #mdb_dbi_open(). + * + * @param[in] txn A transaction handle returned by #mdb_txn_begin() + * @param[in] dbi A database handle returned by #mdb_dbi_open() + * @param[out] path Address of a string pointer to contain the path. This + * is the actual string in the database, not a copy. It should not be + * altered in any way. + * @return A non-zero error value on failure and 0 on success. Some possible + * errors are: + * <ul> + * <li>EINVAL - an invalid parameter was specified. + * </ul> + */ +int mdb_dbi_name(MDB_txn *txn, MDB_dbi dbi, const char **name); + /** @brief Close a database handle. Normally unnecessary. Use with care: * * This call is not mutex protected. Handles should only be closed by diff --git a/libraries/liblmdb/mdb.c b/libraries/liblmdb/mdb.c index 8f7f3b3..a2763f8 100644 --- a/libraries/liblmdb/mdb.c +++ b/libraries/liblmdb/mdb.c @@ -9541,6 +9541,15 @@ int mdb_dbi_flags(MDB_txn *txn, MDB_dbi dbi, unsigned int *flags) return MDB_SUCCESS; } +int mdb_dbi_name(MDB_txn *txn, MDB_dbi dbi, const char **name) +{ + if (!TXN_DBI_EXIST(txn, dbi, DB_USRVALID) || !name) + return EINVAL; + /* safe since md_name is 0-terminated with strdup in mdb_dbi_open */ + *name = txn->mtbxbxs[dbi].md_name.mv_data; + return MDB_SUCCESS; +} + /** Add all the DB's pages to the free list. * @param[in] mc Cursor on the DB to free. * @param[in] subs non-Zero to check for sub-DBs in this DB.

7 years, 5 months

1
0
0 / 0

Re: (ITS#8270) win32: fix conversion error

by nacho.resa＠gmail.com

--f46d0444813d6e6086052274a949 Content-Type: text/plain; charset=UTF-8 Sorry! I did indeed meant to change just the windows part, for some reason I thought it was already ifdeffed that part. https://github.com/nice-software/lmdb/commit/42577fe173923c1166f8382a5352... This is the right patch. On Mon, Oct 19, 2015 at 1:43 PM, Hallvard Breien Furuseth < h.b.furuseth(a)usit.uio.no> wrote: > On 19. okt. 2015 08:57, nacho.resa(a)gmail.com wrote: > >> I do not understand, I tested also with mingw64 (...) >> > > There's no LPTHREAD_START_ROUTINE type on non-Windows machines. > You could replace 'start' with '(LPTHREAD_START_ROUTINE)(start)' > in the _WIN32 variant of '#define THREAD_CREATE...'. > > However, it's still wrong to call a function via another prototype. > Maybe that'd fall on 32-bit Windows or something, I don't know > how LPTHREAD_START_ROUTINE is defined. The safe way would be to > give mdb_env_copythr() a prototype which does not need a cast. > There is some code for that already. Maybe it can be improved. > > -- > Hallvard > -- Ignacio Casal Quinteiro --f46d0444813d6e6086052274a949 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Sorry! I did indeed meant to change just the windows = part, for some reason I thought it was already ifdeffed that part. <a hr= ef=3D"https://github.com/nice-software/lmdb/commit/42577fe173923c1166f8382a= 53523a31479f9d43">https://github.com/nice-software/lmdb/commit/42577fe17392= 3c1166f8382a53523a31479f9d43</a> </div>This is the right patch. <= /div><div class=3D"gmail_extra"> <div class=3D"gmail_quote">On Mon, Oct = 19, 2015 at 1:43 PM, Hallvard Breien Furuseth <<a href= =3D"mailto:h.b.furuseth@usit.uio.no" target=3D"_blank">h.b.furuseth(a)usit.ui= o.no</a>> wrote: <blockquote class=3D"gmail_quote" style=3D"ma= rgin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 19. okt. 20= 15 08:57, <a href=3D"mailto:nacho.resa@gmail.com" target=3D"_blank">nacho.r= esa(a)gmail.com</a> wrote: <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> I do not understand, I tested also with mingw64 (...) </blockquote> There's no LPTHREAD_START_ROUTINE type on non-Windows machines. You could replace 'start' with '(LPTHREAD_START_ROUTINE)(start)= ' in the _WIN32 variant of '#define THREAD_CREATE...'. However, it's still wrong to call a function via another prototype. Maybe that'd fall on 32-bit Windows or something, I don't know how LPTHREAD_START_ROUTINE is defined.=C2=A0 The safe way would be to give mdb_env_copythr() a prototype which does not need a cast. There is some code for that already. Maybe it can be improved. -- Hallvard </blockquote></div> -- <div clas= s=3D"gmail_signature">Ignacio Casal Quinteiro</div> </div> --f46d0444813d6e6086052274a949--

7 years, 5 months

1
0
0 / 0

Re: (ITS#8270) win32: fix conversion error

by h.b.furuseth＠usit.uio.no

On 19. okt. 2015 08:57, nacho.resa(a)gmail.com wrote: > I do not understand, I tested also with mingw64 (...) There's no LPTHREAD_START_ROUTINE type on non-Windows machines. You could replace 'start' with '(LPTHREAD_START_ROUTINE)(start)' in the _WIN32 variant of '#define THREAD_CREATE...'. However, it's still wrong to call a function via another prototype. Maybe that'd fall on 32-bit Windows or something, I don't know how LPTHREAD_START_ROUTINE is defined. The safe way would be to give mdb_env_copythr() a prototype which does not need a cast. There is some code for that already. Maybe it can be improved. -- Hallvard

7 years, 5 months

1
0
0 / 0

(ITS#8274) Review lmdb cyrus-sasl backend changes

by nacho.resa＠gmail.com

Full_Name: Ignacio Casal Quinteiro Version: OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (89.202.223.30) Hi Howard Chu, since you made the backend for cyrus-sasl, any chance you could review the patches here: https://github.com/nice-software/cyrus-sasl/commits/wip/lmdb before they get upstream? Cheers.

7 years, 5 months

1
0
0 / 0

(ITS#8273) file:// URLs broken on Windows

by hyc＠openldap.org

Full_Name: Howard Chu Version: 2.4 OS: Win32 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (78.155.231.14) Submitted by: hyc file URLs with absolute paths are parsed incorrectly on Windows. The current code expects an absolute path in Unix form: file:///etc/ldap.conf In our test suites we just concatenate "file://" with an absolute path. On Windowsn ababsolute path starts with a drive letter and a colon, so our test suite doing simple concatenation uses file://C:/some/thing This is actually invalid; the proper form would be file:///C:/some/thing but the current parser won't do the right thing for either form. It MUST be fixed to accept the latter form with 3 slashes. I'm inclined to also accept the form with 2 slashes, to avoid hacking up our test suite to handle this case.

7 years, 5 months

1
0
0 / 0

Re: (ITS#8270) win32: fix conversion error

by nacho.resa＠gmail.com

--f46d044289f661da1905226fa6a2 Content-Type: text/plain; charset=UTF-8 I do not understand, I tested also with mingw64 and here is the result I get with my patches applied: $ make gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mdb.c mdb.c: In function 'mdb_strerror': cc1.exe: warning: function may return address of local variable [-Wreturn-local-addr] mdb.c:1453:7: note: declared here char buf[1024], *ptr = buf; ^ gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c midl.c ar rs liblmdb.a mdb.o midl.o C:\msys64\mingw64\bin\ar.exe: creating liblmdb.a gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -fPIC -c mdb.c -o mdb.lo mdb.c:1:0: warning: -fPIC ignored for target (all code is position independent) /** @file mdb.c ^ mdb.c: In function 'mdb_strerror': cc1.exe: warning: function may return address of local variable [-Wreturn-local-addr] mdb.c:1453:7: note: declared here char buf[1024], *ptr = buf; ^ gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -fPIC -c midl.c -o midl.lo midl.c:1:0: warning: -fPIC ignored for target (all code is position independent) /** @file midl.c ^ gcc -pthread -shared -o liblmdb.so mdb.lo midl.lo gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mdb_stat.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mdb_stat.o liblmdb.a -o mdb_stat gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mdb_copy.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mdb_copy.o liblmdb.a -o mdb_copy gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mdb_dump.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mdb_dump.o liblmdb.a -o mdb_dump gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mdb_load.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mdb_load.o liblmdb.a -o mdb_load gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mtest.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mtest.o liblmdb.a -o mtest gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mtest2.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mtest2.o liblmdb.a -o mtest2 gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mtest3.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mtest3.o liblmdb.a -o mtest3 gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mtest4.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mtest4.o liblmdb.a -o mtest4 gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mtest5.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mtest5.o liblmdb.a -o mtest5 On Mon, Oct 19, 2015 at 8:35 AM, Howard Chu <hyc(a)symas.com> wrote: > Ignacio Casal Quinteiro wrote: > >> I am ok not fixing the MSVC warnings because it is picky even though some >> of >> them might make sense even for mingw, but in this case it is an error and >> this >> really small change enable msvc to build without errors. Can't you >> reconsider >> the change? Specially since it will build fine with mingw as well. >> > > No, since it will break Unix builds. > >> >> On Sat, Oct 17, 2015 at 7:54 PM, Howard Chu <hyc(a)symas.com >> <mailto:hyc@symas.com>> wrote: >> >> nacho.resa(a)gmail.com <mailto:nacho.resa@gmail.com> wrote: >> >> Full_Name: Ignacio Casal Quinteiro >> Version: >> OS: Windows 7 >> URL: ftp://ftp.openldap.org/incoming/ >> Submission from: (NULL) (2a01:111f:9fa:7f00:864b:f5ff:fe34:ddaa) >> >> >> >> https://github.com/nice-software/lmdb/commit/076281a2c03356667fca7cce1a89... >> >> >> I see no error when compiling with gcc -Wall. Closing this ITS. >> >> -- >> -- Howard Chu >> CTO, Symas Corp. http://www.symas.com >> Director, Highland Sun http://highlandsun.com/hyc/ >> Chief Architect, OpenLDAP http://www.openldap.org/project/ >> >> >> >> >> -- >> Ignacio Casal Quinteiro >> > > > -- > -- Howard Chu > CTO, Symas Corp. http://www.symas.com > Director, Highland Sun http://highlandsun.com/hyc/ > Chief Architect, OpenLDAP http://www.openldap.org/project/ > -- Ignacio Casal Quinteiro --f46d044289f661da1905226fa6a2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">I do not understand, I tested also with mingw64 and here i= s the result I get with my patches applied: $ make gcc -pthread -= O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized=C2= =A0=C2=A0 -c mdb.c mdb.c: In function 'mdb_strerror': cc1.exe= : warning: function may return address of local variable [-Wreturn-local-ad= dr] mdb.c:1453:7: note: declared here =C2=A0 char buf[1024], *ptr =3D= buf; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ gcc -pthread -O2 -g -W -= Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 = -c midl.c ar rs liblmdb.a mdb.o midl.o C:\msys64\mingw64\bin\ar.exe: = creating liblmdb.a gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -W= bad-function-cast -Wuninitialized=C2=A0 -fPIC=C2=A0 -c mdb.c -o mdb.lo m= db.c:1:0: warning: -fPIC ignored for target (all code is position independe= nt) =C2=A0/** @file mdb.c =C2=A0^ mdb.c: In function 'mdb_stre= rror': cc1.exe: warning: function may return address of local variab= le [-Wreturn-local-addr] mdb.c:1453:7: note: declared here =C2=A0 cha= r buf[1024], *ptr =3D buf; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ gcc= -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wunini= tialized=C2=A0 -fPIC=C2=A0 -c midl.c -o midl.lo midl.c:1:0: warning: -fP= IC ignored for target (all code is position independent) =C2=A0/** @file= midl.c =C2=A0^ gcc=C2=A0 -pthread -shared -o liblmdb.so mdb.lo midl.= lo gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cas= t -Wuninitialized=C2=A0=C2=A0 -c mdb_stat.c gcc -pthread -O2 -g -W -Wall= -Wno-unused-parameter -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 mdb_= stat.o liblmdb.a=C2=A0 -o mdb_stat gcc -pthread -O2 -g -W -Wall -Wno-unu= sed-parameter -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 -c mdb_copy.c= gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast = -Wuninitialized=C2=A0=C2=A0 mdb_copy.o liblmdb.a=C2=A0 -o mdb_copy gcc -= pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuniniti= alized=C2=A0=C2=A0 -c mdb_dump.c gcc -pthread -O2 -g -W -Wall -Wno-unuse= d-parameter -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 mdb_dump.o libl= mdb.a=C2=A0 -o mdb_dump gcc -pthread -O2 -g -W -Wall -Wno-unused-paramet= er -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 -c mdb_load.c gcc -pt= hread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitial= ized=C2=A0=C2=A0 mdb_load.o liblmdb.a=C2=A0 -o mdb_load gcc -pthread -O2= -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized=C2= =A0=C2=A0 -c mtest.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter = -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 mtest.o liblmdb.a=C2=A0 -o = mtest gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-= cast -Wuninitialized=C2=A0=C2=A0 -c mtest2.c gcc -pthread -O2 -g -W -Wal= l -Wno-unused-parameter -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 mte= st2.o liblmdb.a=C2=A0 -o mtest2 gcc -pthread -O2 -g -W -Wall -Wno-unused= -parameter -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 -c mtest3.c g= cc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuni= nitialized=C2=A0=C2=A0 mtest3.o liblmdb.a=C2=A0 -o mtest3 gcc -pthread -= O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized=C2= =A0=C2=A0 -c mtest4.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter= -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 mtest4.o liblmdb.a=C2=A0 -= o mtest4 gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-functi= on-cast -Wuninitialized=C2=A0=C2=A0 -c mtest5.c gcc -pthread -O2 -g -W -= Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 = mtest5.o liblmdb.a=C2=A0 -o mtest5 </div><div class=3D"gmail_extra">= <div class=3D"gmail_quote">On Mon, Oct 19, 2015 at 8:35 AM, Howard Chu = <<a href=3D"mailto:hyc@symas.com" target=3D"_blank">hy= c(a)symas.com</a>> wrote: <blockquote class=3D"gmail_quote" styl= e=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ignacio Casal Quinteiro wrote: <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> I am ok not fixing the MSVC warnings because it is picky even though some o= f them might make sense even for mingw, but in this case it is an error and t= his really small change enable msvc to build without errors. Can't you reco= nsider the change? Specially since it will build fine with mingw as well. </blockquote> No, since it will break Unix builds. <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> On Sat, Oct 17, 2015 at 7:54 PM, Howard Chu <<a href=3D"mailto:hyc@symas= .com" target=3D"_blank">hyc(a)symas.com</a> <mailto:<a href=3D"mailto:hyc@symas.com" target=3D"_blank">hyc(a)symas.com= </a>>> wrote: =C2=A0 =C2=A0 <a href=3D"mailto:nacho.resa@gmail.com" target=3D"_blank">nac= ho.resa(a)gmail.com</a> <mailto:<a href=3D"mailto:nacho.resa@gmail.com" ta= rget=3D"_blank">nacho.resa(a)gmail.com</a>> wrote: =C2=A0 =C2=A0 =C2=A0 =C2=A0 Full_Name: Ignacio Casal Quinteiro =C2=A0 =C2=A0 =C2=A0 =C2=A0 Version: =C2=A0 =C2=A0 =C2=A0 =C2=A0 OS: Windows 7 =C2=A0 =C2=A0 =C2=A0 =C2=A0 URL: <a href=3D"ftp://ftp.openldap.org/incoming= /" rel=3D"noreferrer" target=3D"_blank">ftp://ftp.openldap.org/incoming/</a= > =C2=A0 =C2=A0 =C2=A0 =C2=A0 Submission from: (NULL) (2a01:111f:9fa:7f00:864= b:f5ff:fe34:ddaa) =C2=A0 =C2=A0 =C2=A0 =C2=A0 <a href=3D"https://github.com/nice-software/lmd= b/commit/076281a2c03356667fca7cce1a898a4f155e3dce" rel=3D"noreferrer" targe= t=3D"_blank">https://github.com/nice-software/lmdb/commit/076281a2c03356667= fca7cce1a898a4f155e3dce</a> =C2=A0 =C2=A0 I see no error when compiling with gcc -Wall. Closing this IT= S. =C2=A0 =C2=A0 -- =C2=A0 =C2=A0 =C2=A0 =C2=A0-- Howard Chu =C2=A0 =C2=A0 =C2=A0 =C2=A0CTO, Symas Corp. <a href=3D"http://www.symas.com= " rel=3D"noreferrer" target=3D"_blank">http://www.symas.com</a> =C2=A0 =C2=A0 =C2=A0 =C2=A0Director, Highland Sun <a href=3D"http://highlan= dsun.com/hyc/" rel=3D"noreferrer" target=3D"_blank">http://highlandsun.com/= hyc/</a> =C2=A0 =C2=A0 =C2=A0 =C2=A0Chief Architect, OpenLDAP <a href=3D"http://www.= openldap.org/project/" rel=3D"noreferrer" target=3D"_blank">http://www.open= ldap.org/project/</a> -- Ignacio Casal Quinteiro </blockquote><div class=3D"HOEnZb"><div class=3D"h5"> -- =C2=A0 -- Howard Chu =C2=A0 CTO, Symas Corp.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"= http://www.symas.com" rel=3D"noreferrer" target=3D"_blank">http://www.symas= .com</a> =C2=A0 Director, Highland Sun=C2=A0 =C2=A0 =C2=A0<a href=3D"http://highland= sun.com/hyc/" rel=3D"noreferrer" target=3D"_blank">http://highlandsun.com/h= yc/</a> =C2=A0 Chief Architect, OpenLDAP=C2=A0 <a href=3D"http://www.openldap.org/p= roject/" rel=3D"noreferrer" target=3D"_blank">http://www.openldap.org/proje= ct/</a> </div></div></blockquote></div> -- <div class= =3D"gmail_signature">Ignacio Casal Quinteiro</div> </div> --f46d044289f661da1905226fa6a2--

7 years, 5 months

1
0
0 / 0

Re: (ITS#8270) win32: fix conversion error

by hyc＠symas.com

Ignacio Casal Quinteiro wrote: > I am ok not fixing the MSVC warnings because it is picky even though some of > them might make sense even for mingw, but in this case it is an error and this > really small change enable msvc to build without errors. Can't you reconsider > the change? Specially since it will build fine with mingw as well. No, since it will break Unix builds. > > On Sat, Oct 17, 2015 at 7:54 PM, Howard Chu <hyc(a)symas.com > <mailto:hyc@symas.com>> wrote: > > nacho.resa(a)gmail.com <mailto:nacho.resa@gmail.com> wrote: > > Full_Name: Ignacio Casal Quinteiro > Version: > OS: Windows 7 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (2a01:111f:9fa:7f00:864b:f5ff:fe34:ddaa) > > > https://github.com/nice-software/lmdb/commit/076281a2c03356667fca7cce1a89... > > > I see no error when compiling with gcc -Wall. Closing this ITS. > > -- > -- Howard Chu > CTO, Symas Corp. http://www.symas.com > Director, Highland Sun http://highlandsun.com/hyc/ > Chief Architect, OpenLDAP http://www.openldap.org/project/ > > > > > -- > Ignacio Casal Quinteiro -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

7 years, 5 months

1
0
0 / 0

Re: (ITS#8270) win32: fix conversion error

by nacho.resa＠gmail.com

--047d7bfd0df8f33b1905226f06af Content-Type: text/plain; charset=UTF-8 I am ok not fixing the MSVC warnings because it is picky even though some of them might make sense even for mingw, but in this case it is an error and this really small change enable msvc to build without errors. Can't you reconsider the change? Specially since it will build fine with mingw as well. On Sat, Oct 17, 2015 at 7:54 PM, Howard Chu <hyc(a)symas.com> wrote: > nacho.resa(a)gmail.com wrote: > >> Full_Name: Ignacio Casal Quinteiro >> Version: >> OS: Windows 7 >> URL: ftp://ftp.openldap.org/incoming/ >> Submission from: (NULL) (2a01:111f:9fa:7f00:864b:f5ff:fe34:ddaa) >> >> >> >> https://github.com/nice-software/lmdb/commit/076281a2c03356667fca7cce1a89... >> >> >> I see no error when compiling with gcc -Wall. Closing this ITS. > > -- > -- Howard Chu > CTO, Symas Corp. http://www.symas.com > Director, Highland Sun http://highlandsun.com/hyc/ > Chief Architect, OpenLDAP http://www.openldap.org/project/ > -- Ignacio Casal Quinteiro --047d7bfd0df8f33b1905226f06af Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">I am ok not fixing the MSVC warnings because it is picky e= ven though some of them might make sense even for mingw, but in this case i= t is an error and this really small change enable msvc to build without err= ors. Can't you reconsider the change? Specially since it will build fin= e with mingw as well. </div><div class=3D"gmail_extra"> <div class=3D= "gmail_quote">On Sat, Oct 17, 2015 at 7:54 PM, Howard Chu <<a href=3D"mailto:hyc@symas.com" target=3D"_blank">hyc(a)symas.com</a>&g= t; wrote: <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0= .8ex;border-left:1px #ccc solid;padding-left:1ex"><a href=3D"mailto:nacho.= resa(a)gmail.com" target=3D"_blank">nacho.resa(a)gmail.com</a> wrote: <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> Full_Name: Ignacio Casal Quinteiro Version: OS: Windows 7 URL: <a href=3D"ftp://ftp.openldap.org/incoming/" rel=3D"noreferrer" target= =3D"_blank">ftp://ftp.openldap.org/incoming/</a> Submission from: (NULL) (2a01:111f:9fa:7f00:864b:f5ff:fe34:ddaa) <a href=3D"https://github.com/nice-software/lmdb/commit/076281a2c03356667fc= a7cce1a898a4f155e3dce" rel=3D"noreferrer" target=3D"_blank">https://github.= com/nice-software/lmdb/commit/076281a2c03356667fca7cce1a898a4f155e3dce</a><= br> </blockquote> I see no error when compiling with gcc -Wall. Closing this ITS. -- =C2=A0 -- Howard Chu =C2=A0 CTO, Symas Corp.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"= http://www.symas.com" rel=3D"noreferrer" target=3D"_blank">http://www.symas= .com</a> =C2=A0 Director, Highland Sun=C2=A0 =C2=A0 =C2=A0<a href=3D"http://highland= sun.com/hyc/" rel=3D"noreferrer" target=3D"_blank">http://highlandsun.com/h= yc/</a> =C2=A0 Chief Architect, OpenLDAP=C2=A0 <a href=3D"http://www.openldap.org/p= roject/" rel=3D"noreferrer" target=3D"_blank">http://www.openldap.org/proje= ct/</a> </blockquote></div> -- <div clas= s=3D"gmail_signature">Ignacio Casal Quinteiro</div> </div> --047d7bfd0df8f33b1905226f06af--

7 years, 5 months

1
0
0 / 0

Re: (ITS#8267) contributing a new overlay unicodepw

by ingo.voss＠freenet.de

Am 17.10.2015 um 20:58 schrieb Howard Chu: > ingo.voss(a)gmail.com wrote: >> Full_Name: Ingo Voss >> Version: >> OS: >> URL: ftp://ftp.openldap.org/incoming/contrib-slapd-modules-unicodepw.tar >> Submission from: (NULL) (78.53.86.212) >> >> >> Hello, >> >> I wrote a small overlay, that restricts all LDAP modification >> requests, so that >> only password changes for MS unicodePwd are possible. >> All other LDAP requests will not be observed. >> If someone needs a read-only proxy (in a e.g. dmz) for an MS Active >> Directory, >> but password changes must be possible, then unicodepw is the right >> overlay. >> For more informations, a manual page is included. > > If you want a read-only proxy, shouldn't this overlay also intercept > and deny all Add/Delete/ModDN requests? > Yes, you are right! But such overlay (denyop) exist already and it is working well. The manual page for unicodepw refers to denyop and describes the complete configuration in detail. Kindly regards Ingo

7 years, 5 months

1
0
0 / 0

Re: (ITS#8267) contributing a new overlay unicodepw

by hyc＠symas.com

ingo.voss(a)gmail.com wrote: > Full_Name: Ingo Voss > Version: > OS: > URL: ftp://ftp.openldap.org/incoming/contrib-slapd-modules-unicodepw.tar > Submission from: (NULL) (78.53.86.212) > > > Hello, > > I wrote a small overlay, that restricts all LDAP modification requests, so that > only password changes for MS unicodePwd are possible. > All other LDAP requests will not be observed. > If someone needs a read-only proxy (in a e.g. dmz) for an MS Active Directory, > but password changes must be possible, then unicodepw is the right overlay. > For more informations, a manual page is included. If you want a read-only proxy, shouldn't this overlay also intercept and deny all Add/Delete/ModDN requests? -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

7 years, 5 months

1
0
0 / 0

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs October 2015