11:52 a.m.
hyc(a)OpenLDAP.org writes:
backend.c 1.412 -> 1.413
ITS#6393 syncrepl internal connids are now <= -1000
backend.c: 'op->o_connid <= -1000' is wrong. o_connid is unsigned long,
so this is compiled as 'op->o_connid <= (unsigned long) -1000'.
I haven't looked at possible connid values, but maybe you want
o_connid >= (unsigned long)-1000.
--
Hallvard
12:25 p.m.
New subject: commit: ldap/servers/slapd backend.c
hyc(a)OpenLDAP.org writes:
> backend.c 1.412 -> 1.413
> ITS#6393 syncrepl internal connids are now <= -1000
backend.c: 'op->o_connid <= -1000' is wrong. o_connid is unsigned long,
so this is compiled as 'op->o_connid <= (unsigned long) -1000'.
Right. Also, since o_connid is unsigned long, -1000-rid is a valid connid.
Perhaps, a char in the Connection structure, or yet another value in some
bitmask would be better.
p.
12:30 p.m.
New subject: commit: ldap/servers/slapd backend.c
masarati(a)aero.polimi.it wrote:
> hyc(a)OpenLDAP.org writes:
>> backend.c 1.412 -> 1.413
>> ITS#6393 syncrepl internal connids are now <= -1000
>
> backend.c: 'op->o_connid <= -1000' is wrong. o_connid is unsigned
long,
> so this is compiled as 'op->o_connid <= (unsigned long) -1000'.
Right. Also, since o_connid is unsigned long, -1000-rid is a valid connid.
Perhaps, a char in the Connection structure, or yet another value in some
bitmask would be better.
Except that doesn't help the issue with syncrepl and slap_graduate_commit_csn().
Another suggestion is to reserve connids 0-999 for syncrepl, and start the
real connections at 1000.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
12:40 p.m.
New subject: commit: ldap/servers/slapd backend.c
syncrepl.c accepts rids up to SLAP_SYNC_SID_MAX = 4095,
rather than up to SLAP_SYNC_RID_MAX = 999.
Also I suppose SLAPD_SYNC_SYNCCONN_OFFSET should be
-SLAP_SYNC_RID_MAX-1, so that constant is only hardcoded once.
(I don't know what a rid and a sid actually is though.)
--
Hallvard
12:51 p.m.
New subject: commit: ldap/servers/slapd backend.c
Hallvard B Furuseth wrote:
syncrepl.c accepts rids up to SLAP_SYNC_SID_MAX = 4095,
rather than up to SLAP_SYNC_RID_MAX = 999.
Also I suppose SLAPD_SYNC_SYNCCONN_OFFSET should be
-SLAP_SYNC_RID_MAX-1, so that constant is only hardcoded once.
(I don't know what a rid and a sid actually is though.)
http://www.openldap.org/its/index.cgi/Archive.Development?id=5108;selecti...
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
4764
days inactive
4764
days old
5 comments
3 participants
participants (3)
-
Hallvard B Furuseth -
Howard Chu -
masaratiļ¼ aero.polimi.it