ber_ptrlen() should return ber_len_t
- First Post
- Replies
- Stats
-
Go to
- ----- 2023 -----
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
In fact, it makes no sense that ber_ptr < ber_buf; if it happens, the
BerElement is corrupted, and an assertion failure may be more appropriate.
Right now, no test is done, and the (trivial) function could be replaced
with a macro... Since this is part of the private API, its change should
be harmless. Also, it should be renamed ber_int_ptrlen().
p.
masarati(a)aero.polimi.it writes:
In fact, it makes no sense that ber_ptr < ber_buf; if it happens,
the
BerElement is corrupted, and an assertion failure may be more appropriate.
Right now, no test is done, and the (trivial) function could be replaced
with a macro... Since this is part of the private API, its change should
be harmless. Also, it should be renamed ber_int_ptrlen().
Leave this for RE25 or later. Many of the ber functions could use such
a change. Changing just one which happens not to be exported makes
little difference. See the comments I added in encode.c, for example.
Also, remember that we often subtract pointers, so possibly we should
make max(ber_slen_t) the supported maximum instead of max(ber_len_t).
--
Hallvard
masarati(a)aero.polimi.it writes:
In fact, it makes no sense that ber_ptr < ber_buf; if it happens,
the
BerElement is corrupted, and an assertion failure may be more appropriate.
Right now, no test is done, and the (trivial) function could be replaced
with a macro... Since this is part of the private API, its change should
be harmless. Also, it should be renamed ber_int_ptrlen().
The macro exists: ber_pvt_ber_write() in libraries/liblber/lber-int.h.
I'll be introducing a new function
ber_tag_t ber_skip_element(BerElement *ber, struct berval *contents);
or something like that, you might find that useful instead. Will
point *contents into the BerElement, with no alloc or \0-termination.
--
Hallvard
5048
days inactive
5048
days old
2 comments
2 participants
tags (0)
participants (2)
-
Hallvard B Furuseth -
masaratiļ¼ aero.polimi.it