quanah@OpenLDAP.org wrote:
Update of /repo/OpenLDAP/pkg/ldap/libraries/libldap
Modified Files: Tag: OPENLDAP_REL_ENG_2_4 Makefile.in 1.79.2.6 -> 1.79.2.7 Added Files: Tag: OPENLDAP_REL_ENG_2_4 deref.c NONE -> 1.2.2.1
Log Message: ITS#5768
This commit breaks 2.4 because LDAP_CONTROL_X_DEREF is only defined when LDAP_DEVEL is, but it is used in libldap/deref.c without #ifdef. Probably, the macro declaration should be moved outside #ifdef LDAP_DEVEL. I don't want to intervene while you're consolidating 2.4, though.
Cheers, p.
Ing. Pierangelo Masarati OpenLDAP Core Team
SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ----------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Fax: +39 0382 476497 Email: ando@sys-net.it -----------------------------------
--On Tuesday, November 11, 2008 12:26 AM +0100 Pierangelo Masarati ando@sys-net.it wrote:
quanah@OpenLDAP.org wrote:
Update of /repo/OpenLDAP/pkg/ldap/libraries/libldap
Modified Files: Tag: OPENLDAP_REL_ENG_2_4 Makefile.in 1.79.2.6 -> 1.79.2.7 Added Files: Tag: OPENLDAP_REL_ENG_2_4 deref.c NONE -> 1.2.2.1
Log Message: ITS#5768
This commit breaks 2.4 because LDAP_CONTROL_X_DEREF is only defined when LDAP_DEVEL is, but it is used in libldap/deref.c without #ifdef. Probably, the macro declaration should be moved outside #ifdef LDAP_DEVEL. I don't want to intervene while you're consolidating 2.4, though.
Feel free to fix it, I've caught up on 2.4 commits, and am currently looking at the diff between HEAD/RE24.
--Quanah
--
Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration
-
Pierangelo Masarati -
Quanah Gibson-Mount