Howard Chu wrote:
I think the amount of comments is too few. It takes more than one read thru the code to understand what an rdynlist_entry_t is used for; this should have been noted in a comment. Likewise for rdynlist_filter_t.
In the attached Technology Preview version no. 2 I have fixed all of the bugs You pointed out, and a few additional ones. I have also added the much needed comments.
I have tested it, and it works without problems (at least on my setup).
Try it with a database with about 1 million users, with 900,000 or so members of a dynamic group.
I see the problem, but even static groups with 900,000 member attributes are slow in updating, so this slowdown is unfortunately unavoidable.
While it's good that you got this code working, I still believe you've completely missed the point of dynamic groups.
I agree with you that this is not a truly dynamic group. This overlay is more of a "automatically updated static group," so maybe the name of this overlay is not representing what it does exactly. But without modifying much of the OpenLDAP codebase I don't see a better way to do it (but maybe I'm wrong, so feel free to correct me). -- Michał Szulczyński Praktykant Altkom Akademia S.A. http://www.altkom.pl Warszawa, ul. Chłodna 51
Sąd Rejonowy dla m.st. Warszawy w Warszawie, XII Wydział Gospodarczy Krajowego Rejestru Sądowego, KRS: 0000120139, NIP 118-00-08-391, Kapitał zakładowy: 1000 000 PLN. Adres rejestrowy Firmy - ul. Stawki 2, 00-193 Warszawa. Niniejsza wiadomość zawiera informacje zastrzeżone i stanowiące tajemnicę przedsiębiorstwa firmy Altkom Akademia S.A. Ujawnianie tych informacji osobom trzecim lub nieuprawnione wykorzystanie ich do własnych celów jest zabronione. Jeżeli otrzymaliście Państwo niniejszą wiadomość omyłkowo, prosimy o niezwłoczne skontaktowanie się z nadawcą oraz usunięcie wszelkich kopii niniejszej wiadomości. This message contains proprietary information and trade secrets of Altkom Akademia S.A. company. Unauthorized use or disclosure of this information to any third party is prohibited. If you received this message by mistake, please contact the sender immediately and delete all copies of this message.