openldap-devel

openldap-devel@openldap.org

1416 discussions

Re: commit: ldap/servers/slapd/overlays collect.c
by Howard Chu 17 Oct '08

17 Oct '08

hallvard(a)OpenLDAP.org wrote: > Update of /repo/OpenLDAP/pkg/ldap/servers/slapd/overlays > > Modified Files: > collect.c 1.11 -> 1.12 > > Log Message: > ITS#5747: Only use C99 flexible array member when supported > > CVS Web URLs: > http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/overlays/ > http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/overlays/collect.c > > Changes are generally available on cvs.openldap.org (and CVSweb) > within 30 minutes of being committed. > Just set it to *ci_ad[1] and leave it at that. Ifdefing this situation is unnecessary. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

2 1

sorted values vs. compare errors
by Hallvard B Furuseth 17 Oct '08

17 Oct '08

I don't know if this is a false alarm or not, but anyway: Sorted values, as with SLAP_ATTR_SORTED_VALS in attr_valfind(), needs an unambiguous ordering. However value_match() can return error, and does not say which of the compared values caused the error. Are there sorted value examples where it can return error both because of the stored value and because of the assertion value? Or overlays like rwm which can cause this? If so the sort order of (normal value, value causing error) will depend on the order of arguments to the compare function. Then if we manage to insert an "ambiguously-sorted" attribute value into the sorted list of values, then a binary search for an existing normal value can fail if it hits the naughty value as a pivot entry. Or it can cause a new value to be inserted at the wrong place. Possibly there are also some other strange matching rules where the ordering is ambiguous, I don't know. In any case, I think this whould mean that: - value_match() and ordering-compare functions should try to define unambiguous orderings of (normal value, truble value). I think sorting of (trouble value 1, truble value 2) does not matter. - maybe Sorted values should only be supported for attributes whose compare functions do define such an ordering. However there are also inequality filters vs. sorted attribute values. This code in slapd/filterentry.c:test_ava_filter() is similarly broken if there is an error-generating value at either end of the array of values: if (( a->a_flags & SLAP_ATTR_SORTED_VALS ) && type != LDAP_FILTER_APPROX ) { unsigned slot; int ret; /* For Ordering matches, we just need to do one comparison with * either the first (least) or last (greatest) value. */ if ( use == SLAP_MR_ORDERING ) { const char *text; int match, which; which = (type == LDAP_FILTER_LE) ? 0 : a->a_numvals-1; ret = value_match( &match, a->a_desc, mr, use, &a->a_nvals[which], &ava->aa_value, &text ); if ( ret != LDAP_SUCCESS ) return ret; For such a value, and with a normal assertion value, the function ought to search for the nearest non-error-generating value and compare with that. -- Hallvard

1 0

Re: commit: ldap/doc/man/man5 slapd.conf.5
by Hallvard B Furuseth 17 Oct '08

17 Oct '08

ando(a)OpenLDAP.org writes: > slapd.conf.5 1.291 -> 1.292 > minor clarifications Remember slapd-config.5. -- Hallvard

1 0

Trivial build fixes for addpartial
by Buchan Milne 16 Oct '08

16 Oct '08

I should have reported this when I first enabled addpartial (but it was most likely near distribution release time ...), but I had patched the Makefile to build more sanely: http://svn.mandriva.com/cgi- bin/viewvc.cgi/packages/cooker/openldap/current/SOURCES/openldap-2.4.8- addpartial-makefile.patch?revision=189682&view=markup Since some things have now been fixed (but others not), I had to re-diff to address the outstanding items: 1)-fPIC is required in LDFLAGS to build on x86_64 (I didn't check to see if there's a more portable way) 2)I don't see a reason to call the overlay addpartial-overlay, we all know it is an overlay. http://svn.mandriva.com/cgi- bin/viewvc.cgi/packages/cooker/openldap/current/SOURCES/openldap-2.4.8- addpartial-makefile.patch?revision=293664&view=markup Regards, Buchan

3 2

Re: commit: ldap/doc/man/man5 slapd-bdb.5
by Hallvard B Furuseth 15 Oct '08

15 Oct '08

hyc(a)OpenLDAP.org writes: > slapd-bdb.5 1.40 -> 1.41 > Add dbpagesize keyword for configuring DB file page sizes If I understand the DB doc correctly, a pagesize parameter which means "use the file system's block size" could also be useful, at least for data integrity. Unless that's already the default. -- Hallvard

2 8

Re: commit: ldap/libraries/libldap gssapi.c
by Hallvard B Furuseth 13 Oct '08

13 Oct '08

hyc writes: > gssapi.c NONE -> 1.1 > > ITS#5369 SASL/GSSAPi refactoring from Stefan Metzmacher <metze(a)samba.org> > and Rafal Szczeniak <mimir(a)samba.org>, with minor cleanups This is buggy: pkt_len is used uninitialized in sb_sasl_gssapi_decode(). guess_service_principal() is broken: It uses 'ret' uninitialized, as if a return value from malloc. It passes (buffer length - 1) instead of buffer length to snprintf, which I think fails for the (allow_remote && givenstr) case. snprintf() unnecessary anyway since the function can malloc the exact needed size. Also it's preferable to only use a string literal as format argument, so gcc can verify the printf (instead of warning that it can't). Format errors: OM_uint32 printed as %u, size_t/ber_len_t as %lu. Here is a draft patch. Untested. Note I've not looked at how this actually works, just how to get rid of warnings. http://folk.uio.no/hbf/OpenLDAP/gssapi.txt Finally, some header files should declare these functions: ldap_gssapi_bind_s(), ldap_int_gssapi_close(), ldap_int_gssapi_config(), ldap_int_gssapi_get_option(), ldap_int_gssapi_set_option(), ldap_pvt_sasl_generic_install(), ldap_pvt_sasl_generic_remove(), and be #included by bind.c, cyrus.c, gssapi.c, init.c, options.c, request.c. -- Regards, Hallvard

3 3

ldap_sasl_interactive_bind support
by Howard Chu 09 Oct '08

09 Oct '08

I think we need to move the lutil_sasl_interact stuff into libldap. Clients ought to be able to use libldap's SASL support without having to #include Cyrus's <sasl.h> themselves. Right now they're forced to write their own interact handlers and the handlers must know about the SASL_CB constants etc. This is ugly; callers shouldn't need to know anything about what the underlying SASL implementation is doing. Actually the lutil_sasl_ code should be cleaned up a bit, not used in libldap as-is. In particular, we should define a callback whose only purpose is to display a provided prompt string and retrieve user input. This callback's interface must have zero dependencies on <sasl.h>. We can provide a generic callback that writes to stderr and uses getpassphrase, but callers should be able to replace this with GUI dialog callbacks etc. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

2 1

Re: RE24 final testing
by Brett ＠Google 09 Oct '08

09 Oct '08

> Ok, please proceed with testing RE24. Solaris 10 test OK using native gcc compiler in /usr/sfw/bin. had to use --disable-perl and --disable-slapi to solve compiler issues - but this is not unusual / or a regression, i think for Solaris 10 the build process still assumes a sun compiler in a few places (although CC=gcc and sun compiler not installed, so should not) -bash-3.00$ gcc -v Reading specs from /usr/sfw/lib/gcc/sparc-sun-solaris2.10/3.4.3/specs Configured with: /sfw10/builds/build/sfw10-patch/usr/src/cmd/gcc/gcc-3.4.3/configure --prefix=/usr/sfw --with-as=/usr/ccs/bin/as --without-gnu-as --with-ld=/usr/ccs/bin/ld --without-gnu-ld --enable-languages=c,c++ --enable-shared Thread model: posix gcc version 3.4.3 (csl-sol210-3_4-branch+sol_rpath) -bash-3.00$ uname -a SunOS mytesthost 5.10 Generic_127111-11 sun4v sparc SUNW,Sun-Fire-T200

1 1

Re: RE24 final testing
by Quanah Gibson-Mount 08 Oct '08

08 Oct '08

--On Tuesday, October 07, 2008 9:57 AM +1000 brett.maxfield(a)gmail.com wrote: > are all (test050 etc.,) changes comitted to RE24 cvs now? > > i was running on suse 10.3 dual core xen kernel about 12h ago and had > a failure.. i will re-test tonight > > checked out vanilla re24 with bdb 4.7 + patches. Hold off a little bit, the latest ITS fix has revealed some other long-standing bugs. --Quanah -- Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration

7 11

StartTLS URL extension
by Howard Chu 07 Oct '08

07 Oct '08

We really ought to have a way to allow clients to make libldap use StartTLS without having to code their own calls into libldap for that purpose. I think it would be useful to allow specifying StartTLS in the extension field of the LDAP URL. Then at least it can be configured into ldap.conf forgotten about. The code for ldap_initialize() should look for the URL extension field, and act on it if StartTLS / 1.3.6.1.4.1.1466.20037 is present. Any comments? -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

6 15

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-devel