openldap-devel

openldap-devel@openldap.org

1416 discussions

Re: commit: ldap/servers/slapd config.c
by Hallvard B Furuseth 22 Nov '09

22 Nov '09

ando(a)OpenLDAP.org writes: > config.c 1.506 -> 1.507 > silence signedness warnings > > - } else if ( rc == ARG_BAD_CONF ) { > + } else if ( (unsigned long)rc == ARG_BAD_CONF ) { That breaks working code. Never shut up signedness warnings without working through what the expressions do, it's too easy to go wrong. rc is an int. ARG_BAD_CONF = 0xdead0000: an unsigned int if int is 32-bit. Consider 32-bit int, 64-bit long, with rc == (int)ARG_BAD_CONF: rc < 0 so (unsigned long)rc sign-extends to 0xffffffffdead0000, but ARG_BAD_CONF itself is positive so it is not sign-extended. The old code worked as far as I can tell: It converted rc to unsigned int, yielding the original ARG_BAD_CONF. The same functinality change happens with the other changes below that one, I haven't looked at whether that is a fix of broken code or if it breaks working code. (Or it is breaks broken code in a new way:-) -- Hallvard

2 2

Re: commit: ldap/servers/slapd backend.c
by Hallvard B Furuseth 21 Nov '09

21 Nov '09

hyc(a)OpenLDAP.org writes: > backend.c 1.412 -> 1.413 > ITS#6393 syncrepl internal connids are now <= -1000 backend.c: 'op->o_connid <= -1000' is wrong. o_connid is unsigned long, so this is compiled as 'op->o_connid <= (unsigned long) -1000'. I haven't looked at possible connid values, but maybe you want o_connid >= (unsigned long)-1000. -- Hallvard

3 5

Re: commit: ldap/servers/slapd backend.c
by masarati＠aero.polimi.it 21 Nov '09

21 Nov '09

> Update of /repo/OpenLDAP/pkg/ldap/servers/slapd > > Modified Files: > backend.c 1.412 -> 1.413 > > Log Message: > ITS#6393 syncrepl internal connids are now <= -1000 What about checking this through a macro? #define SLAPD_SYNC_CONN_OFFSET (-1000) #define SLAPD_SYNC_CONN(connid) ((connid) <= SLAPD_SYNC_CONN_OFFSET) p.

2 1

Re: RE24 (2.4.20) testing call #3
by Gavin Henry 20 Nov '09

20 Nov '09

----- "Dieter Kluenter" <dieter(a)dkluenter.de> wrote: > Quanah Gibson-Mount <quanah(a)zimbra.com> writes: > > > A few new changes, please re-sync and test. Thanks! Hopefully > this > > will be the last of it. In particular, watch test050 please. ;) > > Success, x86_64, openSUSE-11.1 +1 for i386 Fedora 11. -- Kind Regards, Gavin Henry. OpenLDAP Engineering Team. E ghenry(a)OpenLDAP.org Community developed LDAP software. http://www.openldap.org/project/

1 0

forcing valgrind dumps
by Hallvard B Furuseth 19 Nov '09

19 Nov '09

Here is a patch to force valgrind to dump memory leaks or all allocations while running. Next we need a patch to filter old allocations out from new one, leaving recent allocations. Dunno if it belongs in the source code or not... IIRC we do have #ifdefs for some external malloc debug stuff already, but I didn't find that now:-( Index: servers/slapd/daemon.c =================================================================== RCS file: /repo/OpenLDAP/pkg/ldap/servers/slapd/daemon.c,v retrieving revision 1.442 diff -u -2 -r1.442 daemon.c --- servers/slapd/daemon.c 13 Nov 2009 22:48:51 -0000 1.442 +++ servers/slapd/daemon.c 18 Nov 2009 23:18:29 -0000 @@ -36,4 +36,22 @@ #include <ac/unistd.h> +#ifdef USE_VALGRIND +/* + * When running under valgrind, make kill -USR1 force a leak/alloc dump + * to stderr, in addition to its usual "wake listener" function. + * After SIGUSR1 there will also be a dump before shutdown. + * + * Usage: + * valgrind --leak-check=yes --show-reachable=yes slapd -d0 2>slapd.out & + * kill -USR1 <slapd or valgrind process> + * + * For recent leaks/allocs only, do kill -USR1 after startup and again + * sometime later. Then filter out from the 2nd dump the occurrences of + * allocs from the 1st dump. + */ +#include <ac/signal.h> +#include <valgrind/memcheck.h> +#endif /* USE_VALGRIND */ + #include "slap.h" #include "ldap_pvt_thread.h" @@ -664,4 +682,25 @@ #endif /* ! epoll && ! /dev/poll */ +#ifdef USE_VALGRIND +static sig_atomic_t slap_valgrind_requested = 0; +#define slap_valgrind_request() ((void) (slap_valgrind_requested = 2)) +static void +slap_valgrind_check( int when, const char *msg ) +{ + if ( slap_valgrind_requested >= when && RUNNING_ON_VALGRIND ) { + Debug( LDAP_DEBUG_TRACE, "Valgrind dump %s\n", msg, 0, 0 ); + /* Needed for terminator between valgrind -q dumps */ + VALGRIND_PRINTF( "==> Valgrind dump %s\n", msg ); + VALGRIND_DO_LEAK_CHECK; + VALGRIND_PRINTF( "<== Valgrind dump %s\n", msg ); + slap_valgrind_requested = 1; + } +} + +#else /* !USE_VALGRIND */ +#define slap_valgrind_check(when, msg) ((void) 0) +#define slap_valgrind_request() ((void) 0) +#endif /* USE_VALGRIND */ + #ifdef HAVE_SLP /* @@ -2308,4 +2347,6 @@ struct re_s* rtask; + slap_valgrind_check( 2, "while running" ); + now = slap_get_time(); @@ -2760,4 +2801,6 @@ } + slap_valgrind_check( 1, "before shutdown" ); + if ( slapd_gentle_shutdown != 2 ) close_listeners ( 0 ); @@ -2942,4 +2985,6 @@ int save_errno = errno; + slap_valgrind_request(); + WAKE_LISTENER(1);

2 2

Re: commit: ldap/servers/slapd connection.c slap.h
by Hallvard B Furuseth 19 Nov '09

19 Nov '09

hyc(a)OpenLDAP.org writes: > slap.h 1.881 -> 1.882 > >- int c_struct_state; /* structure management state */ >- int c_conn_state; /* connection state */ >+ enum sc_struct_state c_struct_state; /* structure management state */ >+ enum sc_conn_state c_conn_state; /* connection state */ Note that this is potentially a binary incompatible change. I'm never clear on how hard we try to avoid those in slapd... These enum types need not take more than 1 byte each. (OTOH enum constants declared _in_ the enum have type int.) -- Hallvard

2 1

RE24 (2.4.20) testing call #2
by Quanah Gibson-Mount 19 Nov '09

19 Nov '09

Please test current RE24 CVS. Several issues identified in the first round have been resolved. Thanks! --Quanah -- Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration

4 4

Please test RE24 for 5.0.20 candidate
by Quanah Gibson-Mount 19 Nov '09

19 Nov '09

Please test current RE24, thanks! --Quanah -- Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration

5 5

contrib/slapd-modules/passwd/sha2
by Michael Ströder 18 Nov '09

18 Nov '09

HI! Is there any chance that contrib/slapd-modules/passwd/sha2 will make it to being a standard feature like e.g. password scheme {SSHA} within 2.4 release series? Ciao, Michael. -- Michael Ströder E-Mail: michael(a)stroeder.com http://www.stroeder.com

1 0

contextCSN interaction between syncrepl and syncprov
by Rein Tollevik 17 Nov '09

17 Nov '09

The remaining errors and race condition that test058 demonstrates cannot be solved unless syncrepl is changed to always store the contextCSN in the suffix of the database where it is configured, not the suffix of its glue database as it does today. Assuming serverID 0 is reserved for the single master case, syncrepl and syncprov can in that case only be configured within the same database context if syncprov is a pure forwarding server I.e, it will not update any CSN value and syncrepl have no need to fetch any values from it. In the multi-master case it is only the contextCSN whose SID matches the current serverID that syncprov maintains, the other are all received by syncrepl. So, the only time syncrepl should need an updated CSN from syncprov is when it is about to present it to its peer, i.e when it initiates a refresh phase. Actually, a race condition that would render the state of the database undetermined could occur if syncrepl fetches an updated CSN from syncprov during the initial refresh phase. So, it should be sufficient to read the contextCSN values from the database before a new refresh phase is initiated, independent of whether syncprov is in use or not. Syncrepl will receive updates to the contextCSN value with its own SID from its peers, at least with ITS#5972 and ITS#5973 in place. I.e, the normal ignoring of updates tagged with a too old contextCSN value will continue to work. It should also be safe to ignore all updates tagged with a contextCSN or entryCSN value whose SID is the current servers non-zero serverID, provided a complete refresh cycle is known to have taken place. I.e, when a contextCSN value with the current non-zero serverID was read from the database before the refresh phase started, or after the persistent phase have been entered. The state of the database will be undetermined unless an initial refresh (i.e starting from an empty database or CSN set) have been run to completion. I cannot see how this can be avoided, and as far as I know it is so now too. It might be worth mentioning in the doc. though (unless it already is). Syncprov must continue to monitor the contextCSN updates from syncrepl. When it receives updates destined for the suffix of the database it itself is configured it must replace any CSN value whose SID matches its own non-zero serverID with the value it manages itself (which should be greater or equal to the value syncrepl tried to store unless something is seriously wrong). Updates to "foreign" contextCSN values (i.e those with a SID not matching the current non-zero serverID) should be imported into the set of contextCSN values syncprov itself maintain. Syncprov could also short-circuit the contextCSN update and delay it to its own checkpoint. I'm not sure what effect the checkpoint feature have today when syncrepl constantly updates the contextCSN.. Syncprov must, when syncrepl updates the contextCSN in the suffix of a subordinate DB, update its own knowledge of the "foreign" CSNs to be the *lowest* CSN with any given SID stored in all the subordinate DBs (where syncrepl is configured). And no update must take place unless a contextCSN value have been stored in *all* the syncrepl-enabled subordinate DBs. Any values matching the current non-zero serverID should be updated in this case too, but a new value should probably not be inserted. These changes should (unless I'm completely lost that is..) create a cleaner interface between syncrepl and syncprov without harming the current multi-master configurations, and make asymmetric multiple masters configurations like the one in test058 work. Comments please? Rein

2 4

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-devel