openldap-devel

openldap-devel@openldap.org

1443 discussions

Re: commit: ldap/tests/scripts test049-sync-config defines.sh
by Howard Chu 23 Jan '07

23 Jan '07

hyc(a)OpenLDAP.org wrote: > Update of /repo/OpenLDAP/pkg/ldap/tests/scripts > > Modified Files: > defines.sh 1.147 -> 1.148 > Added Files: > test049-sync-config NONE -> 1.1 > > Log Message: > Test slave bootstrapping via syncrepl For anyone curious, this test shows how to use back-config and syncrepl to dynamically configure and populate a server. Two stub entries (cn=config and olcdatabase=config,cn=config) are slapadded to initialize the master and slave configurations. Then ldapadd/ldapmodify are used to load the syncprov module, add a syncrepl consumer to the config database, and add the syncprov overlay to the config database on the master. Then ldapmodify is used to start a syncrepl consumer on the slave's config database. The rest of the script adds schema, a database backend and content for the backend on the master, all of which get replicated to the slave. The dilemma of how not to wipe out the consumer configuration once the complete master configuration is replicated onto it is solved with this trick: the master has both a provider and a consumer configured on it, and the consumer points at the master. The syncrepl config handler checks to see if its providerURI matches any of the current server's listenerURIs. If there's a match, the config is a no-op. (It gets parsed but no consumer task is triggered.) -- -- Howard Chu Chief Architect, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc OpenLDAP Core Team http://www.openldap.org/project/

2 3

Modrdn replication
by Pierangelo Masarati 21 Jan '07

21 Jan '07

ITS#4809 reports that when replicating modrdn via slurpd, operational attributes don't get replicated. This appears to be intrinsically caused by the definition of the modrdn operation, which, unlike the modify and add operations, doesn't contemplate the possibility to add/modify attributes other than the naming ones. So add/modify can be easily exploited for replication by adding/modifying the write-related operational attributes during replication, while modrdn can't. Assuming there's any intention to fix slurpd replication until slurpd is dismissed, we need to find a means to attach modification of write-related operational attributes to a modrdn operation, to complement the modrdn operation itself. The proposed solution consists in explicitly modifying the necessary (operational) attributes by means of an additional modify operation that is attached to modrdn. This may be occasionally useful regardless of slurpd replication, which makes it more appealing for OpenLDAP developers, so that the required effort wouldn't be just wasted by slurpd dismissal. The additional modify could be wrapped into a control's value, and that control might be the "relax" control itself, so that the original operation, augmented by the optional modify, would need to succeed as a whole or abort, extending the capabilities of the "relax" control by allowing extra modifications to be added, in order to preserve the integrity of the object after the operation. Comments? p.

3 4

Re: commit: ldap/servers/slapd acl.c slap.h
by Pierangelo Masarati 16 Jan '07

16 Jan '07

ando(a)OpenLDAP.org wrote: > allow to specify the required access privileges in internal operations (ITS#4806) > Note that one does not need to use the same access privileges for testing the filter and testing data return: in fact, when issuing an internal search, when required one could set o_acl_priv to the privilege desired for filter testing; then, in sc_response(), one could change it to the privilege desired for data return testing, and return it back in sc_cleanup(), and so back and forth. p.

1 0

Re: slapo-dynlist desgin question(s)
by Quanah Gibson-Mount 16 Jan '07

16 Jan '07

--On January 16, 2007 6:34:39 PM +0100 Pierangelo Masarati <ando(a)sys-net.it> wrote: > Quanah Gibson-Mount wrote: > >> This patch also does not work, continuing to use the credentials of the >> bound user. > > > What operation are you performing when it gets to evaluate that filter? > Can you describe it a little bit further? ldapsearch -LLL -Q -h ldap-dev1 -b "cn=groups,cn=applications,dc=stanford,dc=edu" cn=registry-consult -- Quanah Gibson-Mount Principal Software Developer ITS/Shared Application Services Stanford University GnuPG Public Key: http://www.stanford.edu/~quanah/pgp.html

1 0

subclass matching in be_fetch()
by Pierangelo Masarati 11 Jan '07

11 Jan '07

I think in many cases it would be useful to have be_entry_get_rw() match entries based on their class not only exactly, as now, but also if the entry's class is subordinate to the one passed to be_entry_get_rw(). I have a patch that adds a flag parameter for the objectClass value. In most cases, to preserve the current behavior, the flag is set to 0; however I believe in many cases where be_entry_get_rw() or be_fetch() are used, it should definitely be set to SLAP_OCF_CHECK_SUP. If there's no objection, and I didn't overlook anything serious, I'd commit it. p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.n.c. Via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ------------------------------------------ Office: +39.02.23998309 Mobile: +39.333.4963172 Email: pierangelo.masarati(a)sys-net.it ------------------------------------------

1 0

rootdn -> admindn?
by Hallvard B Furuseth 10 Jan '07

10 Jan '07

I've had it with explaining that the suffix is the root of the database which is not the rootdn which is not the Unix user "root". Any hope of renaming rootdn and rootpw to admindn and adminpw, with rootdn/pw as backwards-compatible and eventually undocumented aliases? -- Hallvard

8 10

Notice of disconnection
by Lars Hesel Christensen XX (AH/LMD) 10 Jan '07

10 Jan '07

Hi all I've been looking at the Notice of disconnection handling in OpenLDAP and there is a thing that is confusing me a bit. in result.c, the function try_read1msg reads data from socket and creates a new message from that. If we receive an unsolicited message, e.g, notice of disconnection, then the msgId will be zero, and we will go through the following code(taken from /* $OpenLDAP: /libraries/libldap/result.c,v 1.144 2006/12/17 21:04:25 ando Exp $ */): /* message id */ if ( ber_get_int( ber, &id ) == LBER_ERROR ) { ber_free( ber, 1 ); ld->ld_errno = LDAP_DECODING_ERROR; return( -1 ); } /* if it's been abandoned, toss it */ if ( ldap_abandoned( ld, id, &idx ) ) { <REMOVED since the msgId is not abandoned> retry_ber: ber_free( ber, 1 ); if ( ber_sockbuf_ctrl( lc->lconn_sb, LBER_SB_OPT_DATA_READY, NULL ) ) { goto retry; } --> return( LDAP_MSG_X_KEEP_LOOKING ); /* continue looking */ } lr = ldap_find_request_by_msgid( ld, id ); if ( lr == NULL ) { const char *msg = "unknown"; /* the message type */ tag = ber_peek_tag( ber, &len ); switch ( tag ) { case LBER_ERROR: break; default: msg = ldap_int_msgtype2str( tag ); break; } Debug( LDAP_DEBUG_ANY, "no request for response on ld %p msgid %ld message type %s (tossing)\n", (void *)ld, (long)id, msg ); goto retry_ber; } Assuming there is no more data to be read from the socket we will return in the line marked with the arrow '-->' since ldap_find_request_by_msgid() returns NULL. What confuses me is that later on in try_read1msg we get to (after constructing the message: /* is this the one we're looking for? */ if ( msgid == LDAP_RES_ANY || id == msgid ) { if ( all == LDAP_MSG_ONE || ( newmsg->lm_msgtype != LDAP_RES_SEARCH_RESULT && newmsg->lm_msgtype != LDAP_RES_SEARCH_ENTRY && newmsg->lm_msgtype != LDAP_RES_SEARCH_REFERENCE ) ) { *result = newmsg; ld->ld_errno = LDAP_SUCCESS; return( tag ); } else if ( newmsg->lm_msgtype == LDAP_RES_SEARCH_RESULT) { foundit = 1; /* return the chain later */ } } Do we have a test case testing notice of disconnection? I tried to grep the 'tests' directory for 'notice', 'disconnection' and 'unsolicited' but nothing came up. Perhaps I'm misunderstanding something here, so if I am I would very much appreciate a hint. Happy newyear everyone, Lars Hesel Christensen -- Lars Hesel Christensen Ericsson Denmark A/S, Telebit lars.hesel.xx.christensen(a)ericsson.com

3 9

Re: pthread rdwr locks
by Howard Chu 09 Jan '07

09 Jan '07

Howard Chu wrote: > I just noticed that we're explicitly disabling support for native rdwr > locks in ldap_int_thread.h, and it's been that way since 2000. Any > reason not to use the native locks instead of our emulation routines? At least on Linux the native pthread locks are faster than our emulation. However, the glibc header files don't expose the phtread_rwlock_t definition by default, and getting the definition exposed involves a bit of pain. I haven't investigated on any other platforms. -- -- Howard Chu Chief Architect, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc OpenLDAP Core Team http://www.openldap.org/project/

1 0

Re: BerkeleyDB performance on Linux
by Howard Chu 08 Jan '07

08 Jan '07

Rick Jones wrote: > Howard Chu wrote: >> The attached patch makes O_DIRECT work on Linux in BerkeleyDB 4.5.20. >> (You will need to manually define LINUX_NEEDS_PAGE_ALIGNMENT if you're >> using a kernel older than 2.6.) >> >> The main reason to use this patch is to conserve memory - ordinarily, >> all the I/O that BDB does to its files gets cached in the Linux >> filesystem buffer cache. This caching is redundant since BDB always >> does its own caching, and it effectively makes the BDB environment >> consume twice as much memory as it needs. Using O_DIRECT on I/Os >> disables the filesystem buffer cache for those I/Os, thus freeing up a >> sizable chunk of memory. > > Long ago and far away I was having "fun" with SPECweb99 on Linux and > found that eventually the access logs would grow and cast-out otherwise > usefully cached URLs. I then found the posix_fadvise call, which can be > used to tell the system that a certain range is no longer required: Yes, but posix_fadvise is not supported on Linux kernels before 2.6, returns ENOSYS. -- -- Howard Chu Chief Architect, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc OpenLDAP Core Team http://www.openldap.org/project/

1 0

BerkeleyDB performance on Linux
by Howard Chu 07 Jan '07

07 Jan '07

The attached patch makes O_DIRECT work on Linux in BerkeleyDB 4.5.20. (You will need to manually define LINUX_NEEDS_PAGE_ALIGNMENT if you're using a kernel older than 2.6.) The main reason to use this patch is to conserve memory - ordinarily, all the I/O that BDB does to its files gets cached in the Linux filesystem buffer cache. This caching is redundant since BDB always does its own caching, and it effectively makes the BDB environment consume twice as much memory as it needs. Using O_DIRECT on I/Os disables the filesystem buffer cache for those I/Os, thus freeing up a sizable chunk of memory. The caching problem is particularly aggravated on Linux because the memory manager doesn't give program pages higher priority than cache pages. So when your system is tight on memory, the kernel will start swapping program data pages before it starts reclaiming buffer cache pages, and application performance plummets. (Possibly that indicates a kernel bug, or at least a misfeature.) Note that you must configure BerkeleyDB with --enable-o_direct to enable the support, and you must add "set_flags DB_DIRECT_DB" to your DB_CONFIG to enable it in a particular environment. With this patch, a slapd that occupies 6.8GB on a system with 8GB of RAM can run continuously without swapping, delivering a sustained 11,500 authentications per second. Without the patch, swapping starts when the process hits the 4.5GB mark (because over 3GB of buffer cache is in use), and performance drops to only *hundreds* of authentications per second. -- -- Howard Chu Chief Architect, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc OpenLDAP Core Team http://www.openldap.org/project/ --- dbinc/mp.h.orig 2006-09-07 14:31:58.000000000 -0700 +++ dbinc/mp.h 2007-01-06 19:14:56.000000000 -0800 @@ -378,6 +378,23 @@ #define BH_FREE_REUSE 0x02 #define BH_FREE_UNLOCKED 0x04 +#ifdef DIAG_MVCC +#define BH_ALIGNED +#define VM_PAGESIZE 4096 +#endif + +/* Linux O_DIRECT needs aligned buffers. 2.6 kernel allows 512 byte + * alignment, otherwise need page sized (4096). + */ +#if defined(linux) && !defined(BH_ALIGNED) +#define BH_ALIGNED +#ifdef LINUX_NEEDS_PAGE_ALIGNMENT +#define VM_PAGESIZE 4096 +#else /* Linux 2.6+ */ +#define VM_PAGESIZE 512 +#endif +#endif + /* * BH -- * Buffer header. @@ -404,7 +421,7 @@ roff_t td_off; /* MVCC: creating TXN_DETAIL offset. */ SH_CHAIN_ENTRY vc; /* MVCC: version chain. */ -#ifdef DIAG_MVCC +#ifdef BH_ALIGNED u_int16_t align_off; /* Alignment offset for diagnostics.*/ #endif @@ -465,15 +482,14 @@ (dbc->txn != NULL && F_ISSET(dbc->txn, TXN_SNAPSHOT) && \ dbc->txn->td != NULL && __memp_skip_curadj(dbc, pgno)) -#if defined(DIAG_MVCC) && defined(HAVE_MPROTECT) -#define VM_PAGESIZE 4096 -#define MVCC_BHSIZE(mfp, sz) do { \ +#ifdef BH_ALIGNED +#define BHSIZE(mfp, sz) do { \ sz += VM_PAGESIZE + sizeof(BH); \ if (mfp->stat.st_pagesize < VM_PAGESIZE) \ sz += VM_PAGESIZE - mfp->stat.st_pagesize; \ } while (0) -#define MVCC_BHALIGN(mfp, p) do { \ +#define BHALIGN(mfp, p) do { \ if (mfp != NULL) { \ BH *__bhp; \ void *__orig = (p); \ @@ -493,13 +509,19 @@ } \ } while (0) -#define MVCC_BHUNALIGN(mfp, p) do { \ +#define BHUNALIGN(mfp, p) do { \ if ((mfp) != NULL) { \ BH *bhp = (BH *)(p); \ (p) = ((u_int8_t *)bhp - bhp->align_off); \ } \ } while (0) +#else +#define BHSIZE(mfp, sz) do {} while (0) +#define BHALIGN(mfp, p) do {} while (0) +#define BHUNALIGN(mfp, p) do {} while (0) +#endif +#if defined(DIAG_MVCC) && defined(HAVE_MPROTECT) #ifdef linux #define MVCC_MPROTECT(buf, sz, mode) do { \ int __ret = mprotect((buf), (sz), (mode)); \ @@ -513,11 +535,7 @@ } \ } while (0) #endif /* linux */ - -#else /* defined(DIAG_MVCC) && defined(HAVE_MPROTECT) */ -#define MVCC_BHSIZE(mfp, sz) do {} while (0) -#define MVCC_BHALIGN(mfp, p) do {} while (0) -#define MVCC_BHUNALIGN(mfp, p) do {} while (0) +#else #define MVCC_MPROTECT(buf, size, mode) do {} while (0) #endif --- mp/mp_alloc.c.orig 2006-09-07 14:32:03.000000000 -0700 +++ mp/mp_alloc.c 2007-01-06 19:14:56.000000000 -0800 @@ -66,7 +66,7 @@ if (mfp != NULL) { len = SSZA(BH, buf) + mfp->stat.st_pagesize; /* Add space for alignment padding for MVCC diagnostics. */ - MVCC_BHSIZE(mfp, len); + BHSIZE(mfp, len); } MPOOL_REGION_LOCK(dbenv, infop); @@ -91,10 +91,10 @@ c_mp->stat.st_pages++; MPOOL_REGION_UNLOCK(dbenv, infop); /* - * For MVCC diagnostics, align the pointer so that the buffer + * If necessary, align the pointer so that the buffer * starts on a page boundary. */ - MVCC_BHALIGN(mfp, p); + BHALIGN(mfp, p); found: if (offsetp != NULL) *offsetp = R_OFFSET(infop, p); @@ -447,7 +447,7 @@ MPOOLFILE *mfp; void *buf; { - MVCC_BHUNALIGN(mfp, buf); + BHUNALIGN(mfp, buf); COMPQUIET(mfp, NULL); __db_shalloc_free(infop, buf); } --- mp/mp_fget.c.orig 2006-09-13 09:22:42.000000000 -0700 +++ mp/mp_fget.c 2007-01-06 19:14:56.000000000 -0800 @@ -708,7 +708,7 @@ * the hash bucket's priority. */ /*lint --e{668} (flexelint: bhp cannot be NULL). */ -#ifdef DIAG_MVCC +#ifdef BH_ALIGNED memset(bhp, 0, SSZ(BH, align_off)); #else memset(bhp, 0, sizeof(BH));

2 6

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-devel