openldap-devel August 2009

openldap-devel@openldap.org

17 participants
37 discussions

Re: commit: ldap/doc/man/man3 ldap_get_option.3
by Howard Chu 19 Aug '09

19 Aug '09

ando(a)OpenLDAP.org wrote: > Update of /repo/OpenLDAP/pkg/ldap/doc/man/man3 > > Modified Files: > ldap_get_option.3 1.11 -> 1.12 > > Log Message: > document all options, including TLS and (not yet complete) SASL. Needs expert review I would drop LDAP_OPT_X_TLS; it basically turns on ldaps. This has been unnecessary ever since ldap_initialize() was provided and is only likely to cause problems. (E.g., URI says "ldap://" but library opens ldaps session -> massive confusion.) -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

2 1

Re: commit: ldap/doc/man/man3 ldap_get_option.3
by Howard Chu 19 Aug '09

19 Aug '09

ando(a)OpenLDAP.org wrote: > Update of /repo/OpenLDAP/pkg/ldap/doc/man/man3 > > Modified Files: > ldap_get_option.3 1.11 -> 1.12 > > Log Message: > document all options, including TLS and (not yet complete) SASL. Needs expert review LDAP_OPT_X_TLS_CONNECT_CB / _ARG is implemented, but probably not useful. I used it to obtain the SSL session handle on a newly allocated session to insert it into the OpenSSL session cache. These days I would instead add generic hooks for enabling an implementation-specific session cache. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

HAVE_GMTIME_R?
by masarati＠aero.polimi.it 19 Aug '09

19 Aug '09

The code is littered with tests like #ifdef HAVE_GMTIME_R, but there's no longer tests for gmtime_r() in configure. Is it time to cleanup a bit? p.

5 14

Re: Signedness issue in utf-8 code?
by masarati＠aero.polimi.it 19 Aug '09

19 Aug '09

> In libldap/utf-8-conv.c:194 > > if( wchar < 0x80000000 ) > > I get a warning about signed/unsigned comparison. What seems to happen is > that wchar (which is of type wchar_t) is a signed integer (on my i386,it's > a 4 byte int) and thus it's always < 0x80000000 by definition. ANSI C > converts 0x80000000 to unsigned, thus the warning. That code is only in use when sizeof(wchar_t) >= 4. The C library standard mandates wchar_t to be integer, thus signed. If I promote 0x80000000 to 0x80000000LL, when sizeof(wchar_t) == 4, like in my case, the test will always be true, and the compiler will complain about the test always being true. Everything would be fine otherwise. p.

2 3

Signedness issue in utf-8 code?
by masarati＠aero.polimi.it 19 Aug '09

19 Aug '09

In libldap/utf-8-conv.c:194 if( wchar < 0x80000000 ) I get a warning about signed/unsigned comparison. What seems to happen is that wchar (which is of type wchar_t) is a signed integer (on my i386,it's a 4 byte int) and thus it's always < 0x80000000 by definition. ANSI C converts 0x80000000 to unsigned, thus the warning. p.

1 0

Re: commit: ldap/include ldap_pvt.h
by Howard Chu 19 Aug '09

19 Aug '09

hallvard(a)OpenLDAP.org wrote: > Update of /repo/OpenLDAP/pkg/ldap/include > > Modified Files: > ldap_pvt.h 1.110 -> 1.111 > > Log Message: > Fix previous commit: move struct lutil_tm declaration out of prototype scope That's fine, but this tends to imply that the lutil_tm stuff needs to move into libldap as well. Of course, there's a lot of useful stuff in liblutil that would make life easier if it was included in libldap, or otherwise available on an installed image... -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

3 2

Re: commit: ldap/servers/slapd bconfig.c
by masarati＠aero.polimi.it 19 Aug '09

19 Aug '09

> Update of /repo/OpenLDAP/pkg/ldap/servers/slapd > > Modified Files: > bconfig.c 1.385 -> 1.386 > > Log Message: > More ITS#6234: // comment from rev 1.384 -> /**/ Sorry, that was supposed to be removed, along with the rest of the LDAP_TCP_BUFFER_X_ORDERED stuff, as the olcTCPBuffer attr does not need to be ordered. I'll modify it later. p.

1 0

ITS#6152 pcache enhancements
by Howard Chu 18 Aug '09

18 Aug '09

Just starting to look at implementing Time-To-Refresh, and wondering how it impacts other parameters. proxysavequeries allows queries to be saved and reloaded across restarts. Currently it will only reload non-expired queries. The implication of setting the offline mode is that expired entries may remain in the cache. Should they in fact be reloadable too? The proxytemplate directive has gotten a bit cumbersome, with optional negative TTL and sizelimit TTL added on. This would be the natural place to add the TTR config as well. Should there be independent TTR for negative and sizelimit too? (And it seems we should move from positional arguments to named arguments here...) Given the existence of a TTR feature, I'm less concerned about the proxysavequeries behavior. One should simply set a long TTL and set TTR as needed to keep the cache fresh. As a side point, I'd prefer more consistency in the config keyword names, we should have used "pcache" as the prefix for all the keywords... pcache <database> ... pcacheattrset <index> ... pcachemaxqueries <queries> pcachevalidate <bool> pcachepersist <bool> pcacheset template=<string> attrset=<index> ttl=<secs> [negttl=<secs>] ... pcacheposition (head|tail) -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 2

Re: commit: ldap/libraries/libldap ldap-int.h util-int.c
by Hallvard B Furuseth 18 Aug '09

18 Aug '09

ando(a)OpenLDAP.org writes: > util-int.c 1.61 -> 1.62 You are returning the static pointer from gmtime(), not the provided result pointer or NULL. -- Hallvard

1 0

Re: HAVE_GMTIME_R?
by masarati＠aero.polimi.it 18 Aug '09

18 Aug '09

As far as I can tell (I cannot tell), the only issue should be with the WIN32 version of lutil_gettime(); the modifications I'm finalizing get rid of all mutexes except for directly 'round gmtime(3), but I don't know whether the WIN32 function GetSystemTime( &st ); is reentrant or not. I bet it is, since it works on a buffer passed by the caller. p.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-devel August 2009