openldap-devel

openldap-devel@openldap.org

1 participants
1423 discussions

About REP_TEXT_MUSTBEFREED (ITS#6138)
by Hallvard Breien Furuseth 30 Jul '21

30 Jul '21

REP_TEXT_MUSTBEFREED looks like a bad idea, at lest for now: Errors can happen anywhere, and then sr_text is usually set to a string constant. If REP_TEXT_MUSTBEFREED is already set, slapd will then later try to free that constant. To add this flag, first add result.c:rs_replace_text() or something similar, like rs_replace_entry(). Modify all code which modifies sr_text to use this function/macro, and encourage 3rd party code to do the same. Also look at code which copies a SlapReply. Each REP_*_MUSTBEFREED flag and its related data should be managed by a similar function/macro, really. (I tried to add a comment in Github, but that didn't seem to work, so mailing here instead.)

3 4

Re: New logging system ideas
by Howard Chu 18 Jul '21

18 Jul '21

Ondřej Kuzník wrote: > On Wed, Jul 14, 2021 at 03:40:35PM +0100, Howard Chu wrote: >> Howard Chu wrote: >>> Just some initial thoughts on what a new logging daemon should do for us: >> >> Scaling back to something easier for now: >> >> We'll use the existing Debug msgs as-is. The olcLogFile directive will specify the >> path of a local logging file to write to. Currently, writing to this logfile is >> controlled by the -d debuglevel flags, not the -s sysloglevel flags. When a logfile >> is configured, debug messages go to both stderr and the logfile. >> >> We'll add a new option olcLogFileOnly (boolean), which will force messages to only >> go to the logfile (and skip writing any to stderr). Since the point of using the >> local file logging facility is for performance, it will be desirable to avoid this >> double-writing of messages. >> >> We'll add an olcLogFileRotate option that specifies a logfile maxsize and rotation >> interval, in megabytes and hours, respectively. Any message that would cause the >> current logfile to exceed the specified size will cause the file to be closed/rotated/reopened. >> Any message that arrives after the specified number of hours will do likewise. >> Rotated files will be renamed to <logfile>.YYYYMMDDHHMM. > > This sounds too complicated, you'd need to measure time and/or size > written everywhere and all the time. Yes, that's exactly what https://git.openldap.org/openldap/openldap/-/merge_requests/358 does. > Solutions already exist that do this and everyone knows how to use them: > logrotate(8). We just need to register a signal (SIGHUP or SIGUSR1 are > used most often) and freopen(3) the stderr stream in the handler. No > locks needed, job done. The reason we're discussing rotate functionality is because of a requirement that no other system dependencies are needed. So, we can't just tell people to use logrotate. Also, freopen() is not async-signal-safe and so isn't legal inside a signal handler. Nor is it clear that freopen() is atomic within a threaded program. As such, you would still need at least a mutex. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

New logging system ideas
by Howard Chu 18 Jul '21

18 Jul '21

Just some initial thoughts on what a new logging daemon should do for us: The primary goal - we want to use a binary message format with as few format conversions as possible between log sender and log processor. I'm thinking that we use message catalogs; we will need a tool to preprocess every logging invocation in the source tree and replace them with a integer messageID. So at runtime only the messageID and the message parameters need to be sent, not any plaintext. The message catalog will be compiled into the binary. When it performs its "openlog" to talk to the logging server, it will send the UUID of its catalog. If the logging server doesn't know this UUID, it will transmit the message catalog to the logging server, before doing anything else. (It may make more sense just to use a SHA hash here instead of a UUID.) This way the logging server will work with any version of the binaries, and we don't need to do special coordination to update message catalogs between revisions. The logging server will just know that a specific catalog is to be used with a particular logging session. The message protocol will be length-prefixed. We may even just use DER, since that would allow us to encode arrays of parameters, and other such stuff. The logging server will write the log messages to disk/network verbatim, doing no parsing at all. It may prefix the records with a log session ID, so that a postprocessor can lookup the catalog that belongs to the session, for dumping out as text. The logging server can store its received catalogs in an LMDB database. The postprocessor can then lookup individual messageIDs in this database, interpolate the parameters, and dump out in text. ... that's what I have so far. It's a bit worrisome because of the additional moving parts: message catalog creator, log server, log postprocessor. There's definitely more complexity here, but most of it is moved out of the runtime hot path, which is the main goal. Suggestions? -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

5 12

Bugzilla spam (was: [Issue 9606] New: What is [..])
by Michael Ströder 07 Jul '21

07 Jul '21

HI! This looks like spam to me: https://bugs.openldap.org/show_bug.cgi?id=9606 Please make this bug invisible so nobody clicks on the link. Ciao, Michael.

2 1

Re: New OpenLDAP TLS backend? (wolfSSL)
by Hayden Roche 20 May '21

20 May '21

Hi, Unfortunately, all my time is allocated to other wolfSSL tasks at the moment, so I won't be able to work on this for 2.6. This will probably be the case until a customer of ours comes along requesting a port of OpenLDAP to wolfSSL, as customer demands drive most of our development. If that changes, I will let you know, though. Thanks, Hayden On Thu, May 20, 2021 at 9:56 AM Quanah Gibson-Mount <quanah(a)symas.com> wrote: > > > --On Thursday, February 25, 2021 1:53 PM -0600 Hayden Roche > <haydenroche5(a)gmail.com> wrote: > > > > > Quanah and Howard, > > > > > > Thanks for your quick replies! I'm glad to hear there's interest in this. > > I think 2.6 is a more realistic target, as I'll need to get my boss to > > allocate time for this work amongst other wolfSSL tasks I've been > > assigned. Look forward to a merge request in the (hopefully near) future! > > The openldap mainline code branch is now open for 2.6 development, so this > would be a good time for work to start on this item for inclusion. > > Regards, > Quanah > > > -- > > Quanah Gibson-Mount > Product Architect > Symas Corporation > Packaged, certified, and supported LDAP solutions powered by OpenLDAP: > <http://www.symas.com> >

1 0

Re: New OpenLDAP TLS backend? (wolfSSL)
by Hayden Roche 20 May '21

20 May '21

Quanah and Howard, Thanks for your quick replies! I'm glad to hear there's interest in this. I think 2.6 is a more realistic target, as I'll need to get my boss to allocate time for this work amongst other wolfSSL tasks I've been assigned. Look forward to a merge request in the (hopefully near) future! Thanks, Hayden On Thu, Feb 25, 2021 at 1:17 PM Quanah Gibson-Mount <quanah(a)symas.com> wrote: > > > --On Thursday, February 25, 2021 12:38 PM -0600 Hayden Roche > <haydenroche5(a)gmail.com> wrote: > > > (thanks JoBbZ). I was also pointed to this > > issue in your issue tracking system, where a developer (Quanah > > Gibson-Mount) > > Same person. ;) > > > > Is there still interest in getting wolfSSL working with OpenLDAP's latest > > version and integrated upstream? > > OpenLDAP 2.4 is closed to development. If you want this in for OpenLDAP > 2.5, you'll need to get the work in ASAP, otherwise it will have to wait > for 2.6 > > Generally: > > Sign up for an account on our gitlab instance: https://git.openldap.org > > Fork a copy of the openldap repo. > > Create a branch for ITS9303 and do the work in that branch > > Push the branch > > Open a merge request for review > > Additionally, you'll need to add an IPR statement to ITS#9303 as > documented > at <https://www.openldap.org/devel/contributing.html#notice> > > A link to the MR should also be put into the ITS. > > Regards, > Quanah > > -- > > Quanah Gibson-Mount > Product Architect > Symas Corporation > Packaged, certified, and supported LDAP solutions powered by OpenLDAP: > <http://www.symas.com> >

2 1

ssl_cipher_list_to_bytes:no ciphers available
by Michael Ströder 06 May '21

06 May '21

HI! I have issues with OpenSSL ciphers on my openSUSE Tumbleweed and release 2.5.4 when connecting to an 2.4 provider: TLS: can't connect: error:141A90B5:SSL routines:ssl_cipher_list_to_bytes:no ciphers available. An 2.4.58 consumer replica works just fine. There is this commit in RE25 and I'm not sure whether that introduces a regression on my system: b72bce2400ce303766f355a1dd37f4012754c942 ITS#9521 Set TLSv1.3 cipher suites for OpenSSL 1.1 BTW: openSUSE has implemented something like a crypto policy configuration: https://build.opensuse.org/package/view_file/security:tls/openssl-1_1/opens… Any clue what's going on? Ciao, Michael.

2 9

slapo-ppolicy 2.4 vs. 2.5
by Michael Ströder 04 May '21

04 May '21

HI! slapo-ppolicy in OpenLDAP 2.5 shows slightly different behaviour in python-ldap0 tests (see test output below). Tests: https://gitlab.com/ae-dir/python-ldap0/-/blob/master/tests/test_ppolicy.py When working with Ondřej for solving ITS#9279 I finally "fixed" ldap0 tests to accomodate the behaviour of OpenLDAP 2.4.x. I did not feel comfortable back then because it was not clear to me whether it was the correct fix. Do you have any tests you could run against 2.4 and 2.5 to verify whether both have same behaviour? Ciao, Michael. ====================================================================== FAIL: test003_ppolicy_grace_logins (tests.test_ppolicy.TestPPolicy) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/michael/Proj/ae-dir/python-ldap0/tests/test_ppolicy.py", line 235, in test003_ppolicy_grace_logins self.assertEqual( AssertionError: 'Password expired! 1 grace logins left.' != 'Password expired! 2 grace logins left.' - Password expired! 1 grace logins left. ? ^ + Password expired! 2 grace logins left. ? ^ ====================================================================== FAIL: test001_pwdpolicy_expiration (tests.test_ppolicy.TestPwdPolicy) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/michael/Proj/ae-dir/python-ldap0/tests/test_ppolicy.py", line 285, in test001_pwdpolicy_expiration self.assertIsInstance(bind_res.ctrls[0], PasswordExpiringControl) AssertionError: <ldap0.controls.pwdpolicy.PasswordExpiredControl object at 0x7efc9d8ca760> is not an instance of <class 'ldap0.controls.pwdpolicy.PasswordExpiringControl'> ====================================================================== FAIL: test002_pwdpolicy_expired (tests.test_ppolicy.TestPwdPolicy) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/michael/Proj/ae-dir/python-ldap0/tests/test_ppolicy.py", line 306, in test002_pwdpolicy_expired l.simple_bind_s(self.user_dn, user_password.encode('utf-8')) AssertionError: INVALID_CREDENTIALS not raised

3 6

OpenLDAP 2.5 Release Candidate Testing (OpenLDAP 2.5.4)
by Quanah Gibson-Mount 22 Apr '21

22 Apr '21

This is a testing call for OpenLDAP 2.5 Release Candidate (OpenLDAP 2.5.4) Depending on the results, this may be the only testing call. Generally, get the code for RE25: <https://git.openldap.org/openldap/openldap/-/archive/OPENLDAP_REL_ENG_2_5/o…> Extract, configure, and build. Execute the test suite (via make test) after it is built. Optionally, cd tests && make its to run through the regression suite. Note that there are new features in 2.5, so please examine the options available with configure carefully. Some examples: The new load balancer, which can either be built as a module for slapd (--enable-balancer=mod) or as a standalone server (--enable-balancer=yes) The libargon2 password module (--enable-argon2). Systemd notification support (--with-systemd=yes). Thanks! Regards, Quanah -- Quanah Gibson-Mount Product Architect Symas Corporation Packaged, certified, and supported LDAP solutions powered by OpenLDAP: <http://www.symas.com>

1 0

ldap_sasl_interactive_bind_s and LDAP_SASL_QUIET
by Jordan Brown 25 Mar '21

25 Mar '21

ldap_sasl_interactive_bind_s prints SASL-related messages on stderr by default, unless you specify LDAP_SASL_QUIET. This seems wrong. The whole point of the "interact" function is to handle any required conversation with the user. In particular, in a GUI application these messages won't go to the user; more likely they will just clutter up some log. Would the OpenLDAP community be receptive to a patch that directs these messages through the "interact" function? (I think they have very little value and should just be dropped; that would be OK too.) SASL username: somename(a)EXAMPLE.COM SASL SSF: 56 SASL data security layer installed. -- Jordan Brown, Oracle ZFS Storage Appliance, Oracle Solaris

2 2

← Newer
1
2
3
4
5
6
7
...
143
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-devel