On 17/11/18 11:42 AM, Howard Chu wrote:
> douglas.royds(a)taitradio.com wrote:
>> URL: ftp://ftp.openldap.org/incoming/douglas-royds-181026.patch
>> This updated patch also sets the date and time strings to the
> Are you intending a SOURCE_DATE_EPOCH to be a Unix time value? I.e., an integer?
> This value format needs to be documented.
> Unfortunately, your use of date -d is nonportable, it appears that only the GNU
> understand this option. It will fail on other platforms like *BSD, Solaris, that
> using a GNU userland.
> Why can't you simply provide an already formatted date & time that can be
> directly, instead of needing to be reformatted here?
Good point about BSD, my mistake. I have modified the patch to support
BSD platforms as well, though I don't have access to a BSD platform to
I have added a code comment with a link to the SOURCE_DATE_EPOCH
A more human-readable description and tips for its use can be found
Thanks. According to this link, we shouldn't even need the date/time portion
of this patch.
Under the section "Reading the Variable" we have
gcc (>= 7, Debian >= 5.3.1-17, Debian >= 6.1.1-1)
I.e., gcc itself will set __DATE__ and __TIME__ accordingly if SOURCE_DATE_EPOCH is set.
I'm inclined to just tweak WHOWHERE and let gcc handle the rest.
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/