douglas.royds(a)taitradio.com wrote:
> URL:
ftp://ftp.openldap.org/incoming/douglas-royds-181026.patch
>
> This updated patch also sets the date and time strings to the
> SOURCE_DATE_EPOCH.
Are you intending a SOURCE_DATE_EPOCH to be a Unix time value? I.e., an integer?
This value format needs to be documented.
Unfortunately, your use of date -d is nonportable, it appears that only the GNU tools
understand this option. It will fail on other platforms like *BSD, Solaris, that
aren't
using a GNU userland.
Why can't you simply provide an already formatted date & time that can be used
directly, instead of needing to be reformatted here?
Good point about BSD, my mistake. I have modified the patch to support
BSD platforms as well, though I don't have access to a BSD platform to
test it.
I have added a code comment with a link to the SOURCE_DATE_EPOCH
specification: