https://bugs.openldap.org/show_bug.cgi?id=10186
Issue ID: 10186 Summary: Overlay response callbacks should ignore op->o_abandon Product: OpenLDAP Version: 2.6.7 Hardware: All OS: All Status: UNCONFIRMED Keywords: needs_review Severity: normal Priority: --- Component: overlays Assignee: bugs@openldap.org Reporter: hyc@openldap.org Target Milestone: ---
Overlays that need to perform other DB write operations in their response callbacks usually create a new Operation by copying the existing *op. If the op had its o_abandon flag set, then every op the overlay starts will be immediately abandoned instead of executing. They should zero out the op->o_abandon flag, because the fact that the response callback got invoked means the original operation already completed. If the main op actually observed the abandon request, the response callbacks wouldn't have gotten triggered.
This in particular affects the memberof overlay, which must perform other modifications after the main op completes. It also affects the contrib autogroup overlay. It might be relevant for accesslog as well, but I haven't looked at that yet.
https://bugs.openldap.org/show_bug.cgi?id=10186
Howard Chu hyc@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |IN_PROGRESS Ever confirmed|0 |1 Assignee|bugs@openldap.org |hyc@openldap.org
--- Comment #1 from Howard Chu hyc@openldap.org --- https://git.openldap.org/openldap/openldap/-/merge_requests/693
https://bugs.openldap.org/show_bug.cgi?id=10186
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|needs_review | Target Milestone|--- |2.5.18
https://bugs.openldap.org/show_bug.cgi?id=10186
--- Comment #2 from Quanah Gibson-Mount quanah@openldap.org --- note: accesslog not affected
https://bugs.openldap.org/show_bug.cgi?id=10186
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED
--- Comment #3 from Quanah Gibson-Mount quanah@openldap.org --- head:
• 7015ad65 by Howard Chu at 2024-03-06T14:57:15+00:00 ITS#10186 overlay response callbacks should ignore op->o_abandon
RE26:
• 9fd8cd20 by Howard Chu at 2024-03-26T17:02:34+00:00 ITS#10186 overlay response callbacks should ignore op->o_abandon
RE25:
• 8deecaf3 by Howard Chu at 2024-03-26T17:03:48+00:00 ITS#10186 overlay response callbacks should ignore op->o_abandon
https://bugs.openldap.org/show_bug.cgi?id=10186
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED