[Issue 10045] New: back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif

List overview All Threads
Download

newer

older

[Issue 10085] New: test029 can't...

[Issue 10095] New: Race condition...

openldap-its＠openldap.org

26 Apr 2023 26 Apr '23

9:04 a.m.

https://bugs.openldap.org/show_bug.cgi?id=10045

Issue ID: 10045 Summary: back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif Product: OpenLDAP Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Keywords: needs_review Severity: normal Priority: --- Component: slapd Assignee: bugs@openldap.org Reporter: ondra@mistotebe.net Target Milestone: ---

slap_pause_server() can take an unbounded time to process and it is possible the operation is abandoned in the meantime (e.g. the connection is lost and the loss is still noticed at this point). However the processing still goes ahead and passed onto back-ldif - where it is discarded as abandoned already so we can end up with an inconsistent view of our persistent configuration.

Checking op->o_abandon again after slap_pause_server() finishes might be enough.

-- You are receiving this mail because: You are on the CC list for the issue.

Show replies by date

openldap-its＠openldap.org

8 May 8 May

9:36 a.m.

New subject: [Issue 10045] back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif

https://bugs.openldap.org/show_bug.cgi?id=10045

Quanah Gibson-Mount quanah@openldap.org changed:

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

15 May 15 May

12:25 p.m.

New subject: [Issue 10045] back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif

https://bugs.openldap.org/show_bug.cgi?id=10045

Quanah Gibson-Mount quanah@openldap.org changed:

--- Comment #1 from Quanah Gibson-Mount quanah@openldap.org --- head:

• 525b631e by Ondřej Kuzník at 2023-04-27T19:37:02+00:00 ITS#10045 Also check for abandon when things have settled

RE26:

• e79ccbee by Ondřej Kuzník at 2023-05-15T17:15:11+00:00 ITS#10045 Also check for abandon when things have settled

RE25:

• 58dd1467 by Ondřej Kuzník at 2023-05-15T17:31:36+00:00 ITS#10045 Also check for abandon when things have settled

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

10 Jul 10 Jul

2:08 p.m.

New subject: [Issue 10045] back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif

https://bugs.openldap.org/show_bug.cgi?id=10045

Quanah Gibson-Mount quanah@openldap.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

31 Jul 31 Jul

9:53 a.m.

New subject: [Issue 10045] back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif

https://bugs.openldap.org/show_bug.cgi?id=10045

Quanah Gibson-Mount quanah@openldap.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|2.5.15 |2.5.16

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

9:53 a.m.

New subject: [Issue 10045] back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif

https://bugs.openldap.org/show_bug.cgi?id=10045

Quanah Gibson-Mount quanah@openldap.org changed:

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

10:59 a.m.

New subject: [Issue 10045] back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif

https://bugs.openldap.org/show_bug.cgi?id=10045

Quanah Gibson-Mount quanah@openldap.org changed:

--- Comment #3 from Quanah Gibson-Mount quanah@openldap.org --- head:

• 2738a32d by Ondřej Kuzník at 2023-07-31T16:46:12+00:00 ITS#10045 Make sure we only unpause when paused

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

11:38 a.m.

New subject: [Issue 10045] back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif

https://bugs.openldap.org/show_bug.cgi?id=10045

Quanah Gibson-Mount quanah@openldap.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Resolution|TEST |FIXED

--- Comment #4 from Quanah Gibson-Mount quanah@openldap.org --- RE26:

Author: Ondřej Kuzník ondra@mistotebe.net Date: Tue Jul 25 11:08:30 2023 +0100

ITS#10045 Make sure we only unpause when paused

RE25:

commit 2de4a9539e5a80b92609a6b9c438f13aea5fc22c Author: Ondřej Kuzník ondra@mistotebe.net Date: Tue Jul 25 11:08:30 2023 +0100

ITS#10045 Make sure we only unpause when paused

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

1:46 p.m.

New subject: [Issue 10045] back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif

https://bugs.openldap.org/show_bug.cgi?id=10045

Quanah Gibson-Mount quanah@openldap.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

23 Oct 23 Oct

7:30 a.m.

New subject: [Issue 10045] back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif

https://bugs.openldap.org/show_bug.cgi?id=10045

Ondřej Kuzník ondra@mistotebe.net changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |aimass@yabarana.com

--- Comment #5 from Ondřej Kuzník ondra@mistotebe.net --- *** Issue 10120 has been marked as a duplicate of this issue. ***

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

9:14 a.m.

New subject: [Issue 10045] back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif

https://bugs.openldap.org/show_bug.cgi?id=10045

--- Comment #6 from Alejandro Imass aimass@yabarana.com --- Target Milestone says 2.5.16 and we are running 2.6.5 Do you happen to know in which version will this fix be included ? TIA!

-- You are receiving this mail because: You are on the CC list for the issue.

Ondřej Kuzník

9:21 a.m.

New subject: [Issue 10045] back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif

On Mon, Oct 23, 2023 at 04:14:59PM +0000, openldap-its@openldap.org wrote:

...

Target Milestone says 2.5.16 and we are running 2.6.5 Do you happen to know in which version will this fix be included ? TIA!

As I said before, the regression has been fixed in 2.6.6.

You see 2.5.16 on this ticket because Bugzilla doesn't allow more than one target version. Generally, a 2.5.x target means it will also be included in the next feature release, whichever that is (in this case 2.6.6 was released at the appropriate time). And you can always check the release changelog to see for yourself.

Regards,

-- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

openldap-its＠openldap.org

9:21 a.m.

New subject: [Issue 10045] back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif

https://bugs.openldap.org/show_bug.cgi?id=10045

--- Comment #7 from Ondřej Kuzník ondra@mistotebe.net --- On Mon, Oct 23, 2023 at 04:14:59PM +0000, openldap-its@openldap.org wrote:

...

Target Milestone says 2.5.16 and we are running 2.6.5 Do you happen to know in which version will this fix be included ? TIA!

As I said before, the regression has been fixed in 2.6.6.

Regards,

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

24 Oct 24 Oct

12:47 a.m.

New subject: [Issue 10045] back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif

https://bugs.openldap.org/show_bug.cgi?id=10045

--- Comment #8 from Alejandro Imass aimass@yabarana.com --- Thank you!

-- You are receiving this mail because: You are on the CC list for the issue.

208

Age (days ago)

389

Last active (days ago)

openldap-bugs@openldap.org

13 comments

2 participants

tags (0)

participants (2)

Ondřej Kuzník
openldap-its＠openldap.org