[Issue 10045] New: back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif
https://bugs.openldap.org/show_bug.cgi?id=10045
Issue ID: 10045 Summary: back-config operations abandoned while waiting in slap_pause_server() aren't committed to ldif Product: OpenLDAP Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Keywords: needs_review Severity: normal Priority: --- Component: slapd Assignee: bugs@openldap.org Reporter: ondra@mistotebe.net Target Milestone: ---
slap_pause_server() can take an unbounded time to process and it is possible the operation is abandoned in the meantime (e.g. the connection is lost and the loss is still noticed at this point). However the processing still goes ahead and passed onto back-ldif - where it is discarded as abandoned already so we can end up with an inconsistent view of our persistent configuration.
Checking op->o_abandon again after slap_pause_server() finishes might be enough.
https://bugs.openldap.org/show_bug.cgi?id=10045
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@openldap.org |ondra@mistotebe.net Target Milestone|--- |2.5.15 Keywords|needs_review |
https://bugs.openldap.org/show_bug.cgi?id=10045
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED
--- Comment #1 from Quanah Gibson-Mount quanah@openldap.org --- head:
• 525b631e by Ondřej Kuzník at 2023-04-27T19:37:02+00:00 ITS#10045 Also check for abandon when things have settled
RE26:
• e79ccbee by Ondřej Kuzník at 2023-05-15T17:15:11+00:00 ITS#10045 Also check for abandon when things have settled
RE25:
• 58dd1467 by Ondřej Kuzník at 2023-05-15T17:31:36+00:00 ITS#10045 Also check for abandon when things have settled
https://bugs.openldap.org/show_bug.cgi?id=10045
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED
https://bugs.openldap.org/show_bug.cgi?id=10045
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|2.5.15 |2.5.16
https://bugs.openldap.org/show_bug.cgi?id=10045
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|VERIFIED |CONFIRMED Resolution|FIXED |---
https://bugs.openldap.org/show_bug.cgi?id=10045
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |TEST Status|CONFIRMED |RESOLVED
--- Comment #3 from Quanah Gibson-Mount quanah@openldap.org --- head:
• 2738a32d by Ondřej Kuzník at 2023-07-31T16:46:12+00:00 ITS#10045 Make sure we only unpause when paused
https://bugs.openldap.org/show_bug.cgi?id=10045
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|TEST |FIXED
--- Comment #4 from Quanah Gibson-Mount quanah@openldap.org --- RE26:
Author: Ondřej Kuzník ondra@mistotebe.net Date: Tue Jul 25 11:08:30 2023 +0100
ITS#10045 Make sure we only unpause when paused
RE25:
commit 2de4a9539e5a80b92609a6b9c438f13aea5fc22c Author: Ondřej Kuzník ondra@mistotebe.net Date: Tue Jul 25 11:08:30 2023 +0100
ITS#10045 Make sure we only unpause when paused
https://bugs.openldap.org/show_bug.cgi?id=10045
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED
https://bugs.openldap.org/show_bug.cgi?id=10045
Ondřej Kuzník ondra@mistotebe.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |aimass@yabarana.com
--- Comment #5 from Ondřej Kuzník ondra@mistotebe.net --- *** Issue 10120 has been marked as a duplicate of this issue. ***
https://bugs.openldap.org/show_bug.cgi?id=10045
--- Comment #6 from Alejandro Imass aimass@yabarana.com --- Target Milestone says 2.5.16 and we are running 2.6.5 Do you happen to know in which version will this fix be included ? TIA!
On Mon, Oct 23, 2023 at 04:14:59PM +0000, openldap-its@openldap.org wrote:
Target Milestone says 2.5.16 and we are running 2.6.5 Do you happen to know in which version will this fix be included ? TIA!
As I said before, the regression has been fixed in 2.6.6.
You see 2.5.16 on this ticket because Bugzilla doesn't allow more than one target version. Generally, a 2.5.x target means it will also be included in the next feature release, whichever that is (in this case 2.6.6 was released at the appropriate time). And you can always check the release changelog to see for yourself.
Regards,
https://bugs.openldap.org/show_bug.cgi?id=10045
--- Comment #7 from Ondřej Kuzník ondra@mistotebe.net --- On Mon, Oct 23, 2023 at 04:14:59PM +0000, openldap-its@openldap.org wrote:
Target Milestone says 2.5.16 and we are running 2.6.5 Do you happen to know in which version will this fix be included ? TIA!
As I said before, the regression has been fixed in 2.6.6.
You see 2.5.16 on this ticket because Bugzilla doesn't allow more than one target version. Generally, a 2.5.x target means it will also be included in the next feature release, whichever that is (in this case 2.6.6 was released at the appropriate time). And you can always check the release changelog to see for yourself.
Regards,
https://bugs.openldap.org/show_bug.cgi?id=10045
--- Comment #8 from Alejandro Imass aimass@yabarana.com --- Thank you!
-
Ondřej Kuzník -
openldap-its＠openldap.org