Re: (ITS#8919) common.c:2329: suspicious expression ?

dcb314@hotmail.com wrote:

Full_Name: David Binderman Version: 2.4.46 OS: Linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (79.65.83.114)

common.c:2329:10: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]

Source code is

 if ( !tool_ctrl_response[j].mask & tool_type ) {

Maybe better code:

 if ( !(tool_ctrl_response[j].mask & tool_type) ) {

I can recommend compiling the openldap product with the clang C/C++ compiler.

Please use diff.