Re: (ITS#6812) Confused syncprov return codes

h.b.furuseth@usit.uio.no wrote:

Full_Name: Hallvard B Furuseth Version: HEAD OS: URL: Submission from: (NULL) (129.240.6.233) Submitted by: hallvard

syncprov_state_ctrl(), syncprov_done_ctrl(), syncprov_sendinfo() and thus findpres_cb() can return either an LDAP result code, or a negative number on BER error. I see no code which expects both classes of error codes. The first functions's callers set rs->sr_err = return value. At best I guess it'll be ignored or interpreted as LDAP_SERVER_DOWN.

I've fixed the return codes. They still get ignored in a few places.