https://bugs.openldap.org/show_bug.cgi?id=9990
--- Comment #3 from Ondřej Kuzník ondra@mistotebe.net --- On Tue, Jan 31, 2023 at 02:25:21PM +0000, openldap-its@openldap.org wrote:
Hi Ondrej,
It looks like we have a communication disconnect :-) Please note that there are *two* commits in this merge request:
- commit #1 to ppolicy_text_cleanup() in ppolicy.c. This commit is fine
-- it only cleans up its own callback, no problems there. (This is what I meant by "the rest of the ITS#8698 functionality...worked as expected")
- commit #2 to passwd_extop() in passwd.c. This is the commit that is
causing the problem. I am only asking to revert this part of the change.
Hi Kartik, ppolicy_text_cleanup is added onto op->o_callback, however it wasn't being called because passwd_extop would remove it and the memory still wasn't being freed, hence the other patch you're objecting to.
As mentioned, it might be that ppolicy_text_cleanup doesn't do the right thing when it's removing itself afterwards and that's what you're seeing?