openldap-bugs

openldap-bugs@openldap.org

1 participants
20961 discussions

Re: (ITS#7363) libmdb should use POSIX semaphores on non-apple BSD systems too.
by hyc＠symas.com 22 Aug '12

22 Aug '12

cmikk(a)qwest.net wrote: > Full_Name: Chris Miikkelson > Version: 2.4.32 > OS: FreeBSD > URL: > Submission from: (NULL) (204.147.85.37) > > > mdb on BSD-derived systems other than OS X also needs to use POSIX semaphores > for inter-process synchronization. I was working around this by adding > "-D__APPLE__" to CFLAGS, but that could have side-effects on some systems. The > following patch tells mdb to use posix semaphores if either BSD or __APPLE__ is > defined, which seems like a more targeted fix. > > http://mikk.net/~chris/patches/0001-Use-posix-semaphores-on-apple-and-bsd-s… > > Thanks for the patch, applied. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#7363) libmdb should use POSIX semaphores on non-apple BSD systems too.
by cmikk＠qwest.net 22 Aug '12

22 Aug '12

Full_Name: Chris Miikkelson Version: 2.4.32 OS: FreeBSD URL: Submission from: (NULL) (204.147.85.37) mdb on BSD-derived systems other than OS X also needs to use POSIX semaphores for inter-process synchronization. I was working around this by adding "-D__APPLE__" to CFLAGS, but that could have side-effects on some systems. The following patch tells mdb to use posix semaphores if either BSD or __APPLE__ is defined, which seems like a more targeted fix. http://mikk.net/~chris/patches/0001-Use-posix-semaphores-on-apple-and-bsd-s…

1 0

Re: (ITS#7362) back-mdb: slapadd -q fails
by quanah＠zimbra.com 22 Aug '12

22 Aug '12

--On Wednesday, August 22, 2012 4:44 PM +0000 quanah(a)zimbra.com wrote: > --On Wednesday, August 22, 2012 4:40 PM +0000 openldap-its(a)OpenLDAP.org > wrote: > >> > > data.mdb is zero sized: > > mail:/opt/zimbra/data/ldap/mdb/db # ls -l > total 4 > -rw------- 1 zimbra zimbra 0 2012-08-22 12:32 data.mdb > -rw------- 1 zimbra zimbra 8192 2012-08-22 12:32 lock.mdb > > mail:/opt/zimbra/data/ldap/mdb/db # df -h . > Filesystem Size Used Avail Use% Mounted on > /dev/mapper/system-zimbra > 39G 33G 6.7G 83% /opt/zimbra > > > maxsize is 84GB, but the actual DB will be < 26MB when it is finished > being created. Is this because maxsize > total free disk space? This is definitely not an OpenLDAP bug. Apparently some OSes block max allocation, even if blocking it is disabled. This particular server is running SLES11 SP1: Linux mail 2.6.32.49-0.3-default #1 SMP 2011-12-02 11:28:04 +0100 x86_64 x86_64 x86_64 GNU/Linux Something at the OS level is blocking the mdb memory allocation. This same issue does not occur on other SLES11 installations we have, so I'm somewhat at a loss to explain it. --Quanah -- Quanah Gibson-Mount Sr. Member of Technical Staff Zimbra, Inc A Division of VMware, Inc. -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

Re: (ITS#7362) back-mdb: slapadd -q fails
by quanah＠zimbra.com 22 Aug '12

22 Aug '12

--On Wednesday, August 22, 2012 4:40 PM +0000 openldap-its(a)OpenLDAP.org wrote: > data.mdb is zero sized: mail:/opt/zimbra/data/ldap/mdb/db # ls -l total 4 -rw------- 1 zimbra zimbra 0 2012-08-22 12:32 data.mdb -rw------- 1 zimbra zimbra 8192 2012-08-22 12:32 lock.mdb mail:/opt/zimbra/data/ldap/mdb/db # df -h . Filesystem Size Used Avail Use% Mounted on /dev/mapper/system-zimbra 39G 33G 6.7G 83% /opt/zimbra maxsize is 84GB, but the actual DB will be < 26MB when it is finished being created. Is this because maxsize > total free disk space? --Quanah -- Quanah Gibson-Mount Sr. Member of Technical Staff Zimbra, Inc A Division of VMware, Inc. -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

(ITS#7362) back-mdb: slapadd -q fails
by quanah＠OpenLDAP.org 22 Aug '12

22 Aug '12

Full_Name: Quanah Gibson-Mount Version: 2.4.32 + ITS7356 OS: Linux 2.6 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (74.196.25.250) slapadd fails with: 5035099b mdb_db_open: database "" cannot be opened, err 12. Restore from backup! 5035099b backend_startup_one (type=mdb, suffix=""): bi_db_open failed! (12) slap_startup failed

1 0

Re: (ITS#7359) [PATCH] MozNSS: prefer unlocked slot when getting private key
by jvcelak＠redhat.com 22 Aug '12

22 Aug '12

> >> 1) the recent patches do not adhere to the existing whitespace > >> conventions. > >> Please fix this. > > > > Sorry for that. Looks like you already committed the patch. I will send > > you > > a patch fixing just the whitespaces in my recent changes. > > Thanks. The patch is uploaded. I have touched only lines modified by me as a last one. ftp://ftp.openldap.org/incoming/jvcelak-20120822-moznss-fix-my-coding- standard.patch The attached file is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by Red Hat. Red Hat has not assigned rights and/or interest in this work to any party. I, Jan Vcelak am authorized by Red Hat, my employer, to release this work under the following terms. Red Hat hereby place the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice.

1 0

Re: (ITS#7358) Patch to fix Visual Studio build broken by 2.4.32
by mbooth＠apache.org 22 Aug '12

22 Aug '12

On 21 August 2012 23:17, Howard Chu <hyc(a)symas.com> wrote: > mbooth(a)apache.org wrote: >> Full_Name: Mat Booth >> Version: 2.4.32 >> OS: Windows XP >> URL: http://people.apache.org/~mbooth/0001-Fix-build-error-syntax-error-missing-… >> Submission from: (NULL) (77.86.30.139) >> >> >> The provided patch fixes a build problem for Visual Studio 2005 that was >> introduced with OpenLDAP 2.4.32. > > Thanks for the report. A different fix is now in git master. > >> * libraries/libldap/init.c >> Use C89-style variable declarations because Visual C does not support C99-style >> declarations. Avoids a "syntax error : missing ; before type" compile-time error >> with Microsoft compilers. > > -- > -- Howard Chu > CTO, Symas Corp. http://www.symas.com > Director, Highland Sun http://highlandsun.com/hyc/ > Chief Architect, OpenLDAP http://www.openldap.org/project/ Thanks for committing a better fix -- I wasn't sure if the LDAP_MUTEX_* macros needed to be in that scope for a reason I couldn't discern. :-) Mat

1 0

Re: (ITS#7359) [PATCH] MozNSS: prefer unlocked slot when getting private key
by hyc＠symas.com 22 Aug '12

22 Aug '12

Jan Včelák wrote: > On Tuesday 21 of August 2012 13:38:41, Howard Chu wrote: >> The quality of this code seems to be getting progressively worse. It seems >> I've been accepting the last several patches without giving feedback though. > > So thank you for feedback on this patch. > >> 1) the recent patches do not adhere to the existing whitespace conventions. >> Please fix this. > > Sorry for that. Looks like you already committed the patch. I will send you > a patch fixing just the whitespaces in my recent changes. Thanks. >> 2) the code in this patch is unnecessarily clumsy: > > It's a matter of opinion. In general, I rather see less levels of indentation. > That's why I used this construct. But right, you are the maintainer. This code > is too short to say that it is more readable and the code produced by the > compiler will be the same. Assuming how the compiler behaves is unsafe and nonportable. Even if you're only working on a single platform (which we are not) the compiler behavior can change drastically depending on optimization flags. During debugging you tend to need to compile without optimization, to be able to see clearly what's going on. It is best practice to write code that doesn't rely on the optimizer to kill redundancies, to minimize the difference between debug versions and deployed/optimized versions. These are facts, not opinions. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#7359) [PATCH] MozNSS: prefer unlocked slot when getting private key
by jvcelak＠redhat.com 22 Aug '12

22 Aug '12

On Tuesday 21 of August 2012 13:38:41, Howard Chu wrote: > The quality of this code seems to be getting progressively worse. It seems > I've been accepting the last several patches without giving feedback though. So thank you for feedback on this patch. > 1) the recent patches do not adhere to the existing whitespace conventions. > Please fix this. Sorry for that. Looks like you already committed the patch. I will send you a patch fixing just the whitespaces in my recent changes. > 2) the code in this patch is unnecessarily clumsy: It's a matter of opinion. In general, I rather see less levels of indentation. That's why I used this construct. But right, you are the maintainer. This code is too short to say that it is more readable and the code produced by the compiler will be the same. Jan

1 0

RE: (ITS#7357) Pass-through radius auth. with RFC2865
by jet＠transniaga.co.th 22 Aug '12

22 Aug '12

Howard Chu wrote: > > jet(a)transniaga.co.th wrote: > > Full_Name: Jetasik Anantakunupakorn > > Version: 2.4.32 > > OS: FreeBSD 9.0-RELEASE amd64 > > URL: > > http://www.openldap.org/lists/openldap-technical/201208/msg00172.html > > Submission from: (NULL) (58.11.65.20) > > > > > > Pass-through radius authentication in contrib's passwd > > module(radius.c) does not include either a NAS-IP or a NAS-Identifier, > > according to radius RFC 2865 one of these attributes is mandatory in the > access request. > > > > The thing is that the previous version of Radius RFC standard(RFC > > 2138) specified that the access request "SHOULD" contain either a > > NAS-IP or a NAS-Identifier but the current version use "MUST" instead. > > > A patch for this is now in git master, please test. > Awesome!Thanks a lot. Properly tested with no error. -- JET JETASIK

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs