On 21 August 2012 23:17, Howard Chu hyc@symas.com wrote:

mbooth@apache.org wrote:

...

Full_Name: Mat Booth Version: 2.4.32 OS: Windows XP URL: http://people.apache.org/~mbooth/0001-Fix-build-error-syntax-error-missing-b... Submission from: (NULL) (77.86.30.139)

The provided patch fixes a build problem for Visual Studio 2005 that was introduced with OpenLDAP 2.4.32.

Thanks for the report. A different fix is now in git master.

...

• libraries/libldap/init.c

Use C89-style variable declarations because Visual C does not support C99-style declarations. Avoids a "syntax error : missing ; before type" compile-time error with Microsoft compilers.

-- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

Thanks for committing a better fix -- I wasn't sure if the LDAP_MUTEX_* macros needed to be in that scope for a reason I couldn't discern. :-)

Mat