- openldap-bugs - openldap.org

(ITS#8637) OpenLDAP crashing when defining multiple olcDbURI for chaining
by okuznik＠symas.com 25 Aug '17

25 Aug '17

This configuration should have been rejected by back-config just like it is rejected by slapd.conf. Patch to have this happen is at: ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170825-ITS8637.patch This doesn't reject online modifications just touching olcDBURI, but I think back ldap has no idea when it's configured as a slave to the chain overlay, so it can't do much. --=20 Ond=C5=99ej Kuzn=C3=ADk Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

1 0

Re: (ITS#8444) Out-of-sync issue with memberOf overlay, Delta-syncrepl MMR and >2 nodes
by okuznik＠symas.com 25 Aug '17

25 Aug '17

On Thu, Aug 24, 2017 at 03:55:32PM +0100, Ond=C5=99ej Kuzn=C3=ADk wrote: > I think it looks like this: syncproc_checkpoint modifies the suffix > entry, that calls slap_graduate_commit_csn and the csn is removed from > be_pending_csn_list. accesslog_response then can't find the CSN there > and has nothing to insert into its own pending csn list. Strange that > changing the overlay order (accesslog vs. syncprov) doesn't change this > behaviour, something I'd expect if the above is the reason this happens= . In any case, having the checkpoint modification get its own CSN entry lets the main operation CSN entry persist, which fixes this issue and all operations that need a CSN seem to get it. Patch is available at: ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170825-ITS8444.patch --=20 Ond=C5=99ej Kuzn=C3=ADk Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

1 0

(ITS#8717) Connection delete callback registreed with LDAP_OPT_CONNECT_CB is not called on TLS failure
by ipuleston＠sonicwall.com 25 Aug '17

25 Aug '17

Full_Name: Ian Puleston Version: 2.4.40 OS: VxWorks URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (204.118.31.9) If connect and delete callbacks are registered via LDAP_OPT_CONNECT_CB, then the lc_add callback is called when the TCP connects, but if TLS then fails to connect the lc_del does not get called. If these callbacks are doing something like allocating/freeing resources this can lead to a resource leak. When I am seeing this, the sequence of calls leading to the lc_add callback is as follows: ldap_new_connection -> ldap_int_open_connection -> ldap_connect_to_host -> ldap_int_connect_cbs() Then if ldap_connect_to_host returned 0 for synchronous success this call happens: ldap_new_connection -> ldap_int_open_connection -> ldap_int_tls_start And if that fails and returns something other than LDAP_SUCCESS then ldap_int_open_connection exits. So we got a call to lc_add but no corresponding call to lc_del. And note that there is not call to ldap_free_connection, presumably because ldap-new-connection did not succeed, hence the lc_del callback does not get called from there. In my case when I see this it is on a referral with the above calls made from ldap_chase_v3referrals, hence it is happening synchronously. Whether the same would happen with an asynchronous connect I don't know. I do have a working fix which is to make the lc_del callbacks directly from ldap_int_open_connection if ldap_int_tls_start fails. I will supply a patch for that shortly.

1 0

Re: (ITS#8444) Out-of-sync issue with memberOf overlay, Delta-syncrepl MMR and >2 nodes
by okuznik＠symas.com 24 Aug '17

24 Aug '17

On Wed, Aug 23, 2017 at 02:42:29PM +0100, Ond=C5=99ej Kuzn=C3=ADk wrote: > It is caused by the cookie not containing CSN and a race between the > syncCookie check in do_syncrep2 and syncrepl_message_to_op. >=20 > This race is probably fine with plain syncrepl which is idempotent, but > deltasync changes get their own dn in each accesslog instance and some > can be applied twice unless we know how to find out we've already seen > them - they need to mention the CSN. >=20 > The CSN itself gets lost on at least one occasion - when there's a > checkpoint triggered. Not 100 % sure why the cookie gets eaten because > of it, the op pointer is different between the syncprov_op_response tha= t > calls syncprov_checkpoint and the one that decides CSN hasn't changed. Yes, whenever a checkpoint happens, the syncCookie in cn=3Daccesslog only contains rid=3DXXX,sid=3DYYY. I thought that was because the checkpoint results in a new accesslog entry and that would be transmitted first, but that's not the case, there is no accesslog entry nor anything sent to the client (as observed by ldapsearch -E sync=3Drp). I think it looks like this: syncproc_checkpoint modifies the suffix entry, that calls slap_graduate_commit_csn and the csn is removed from be_pending_csn_list. accesslog_response then can't find the CSN there and has nothing to insert into its own pending csn list. Strange that changing the overlay order (accesslog vs. syncprov) doesn't change this behaviour, something I'd expect if the above is the reason this happens. --=20 Ond=C5=99ej Kuzn=C3=ADk Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

1 0

Re: (ITS#8444) Out-of-sync issue with memberOf overlay, Delta-syncrepl MMR and >2 nodes
by okuznik＠symas.com 23 Aug '17

23 Aug '17

It is caused by the cookie not containing CSN and a race between the syncCookie check in do_syncrep2 and syncrepl_message_to_op. This race is probably fine with plain syncrepl which is idempotent, but deltasync changes get their own dn in each accesslog instance and some can be applied twice unless we know how to find out we've already seen them - they need to mention the CSN. The CSN itself gets lost on at least one occasion - when there's a checkpoint triggered. Not 100 % sure why the cookie gets eaten because of it, the op pointer is different between the syncprov_op_response that calls syncprov_checkpoint and the one that decides CSN hasn't changed. --=20 Ond=C5=99ej Kuzn=C3=ADk Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

1 0

Re: (ITS#8716) Install error
by quanah＠symas.com 21 Aug '17

21 Aug '17

--On Monday, August 21, 2017 4:45 PM +0000 germinouz(a)gmail.com wrote: Hello, The ITS system is for reporting bugs in the software, not for asking question on how to do things such as build software. Please redirect your question to openldap-technical(a)openldap.org if you need help with how to set up a proper environment for building software. I would note the error is rather obvious from the config.log you supplied: > configure:5786: cc -I /usr/local/BerkeleyDB/6.2.32/include > -L/usr/local/lib -L/usr/local/BerkeleyDB/6.2.32/lib > -R/data/BerkeleyDB/6.2.32/lib conftest.c >> &5 > cc: error: unrecognized command line option '-R' Hope that helps! This ITS will be closed. Regards, Quanah -- Quanah Gibson-Mount Product Architect Symas Corporation Packaged, certified, and supported LDAP solutions powered by OpenLDAP: <http://www.symas.com>

1 0

(ITS#8716) Install error
by germinouz＠gmail.com 21 Aug '17

21 Aug '17

Full_Name: Frank Vincent Version: 2.4.45 OS: RedHat7 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (81.93.27.65) When I install on RH7, I get an error. [root@localhost openldap-2.4.45]# ./configure --prefix=/data/openldap Configuring OpenLDAP 2.4.45-Release ... checking build system type... x86_64-unknown-linux-gnu checking host system type... x86_64-unknown-linux-gnu checking target system type... x86_64-unknown-linux-gnu checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for gawk... gawk checking whether make sets $(MAKE)... yes checking configure arguments... done checking for cc... cc checking for ar... ar checking for style of include used by make... GNU checking whether the C compiler works... no configure: error: in `/root/data/openldap-2.4.45': configure: error: C compiler cannot create executables See `config.log' for more details. [root@localhost openldap-2.4.45]# cat config.log This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. It was created by configure, which was generated by GNU Autoconf 2.65. Invocation command line was $ ./configure --prefix=/data/openldap ## --------- ## ## Platform. ## ## --------- ## hostname = localhost.localdomain uname -m = x86_64 uname -r = 3.10.0-514.el7.x86_64 uname -s = Linux uname -v = #1 SMP Wed Oct 19 11:24:13 EDT 2016 /usr/bin/uname -p = x86_64 /bin/uname -X = unknown /bin/arch = x86_64 /usr/bin/arch -k = unknown /usr/convex/getsysinfo = unknown /usr/bin/hostinfo = unknown /bin/machine = unknown /usr/bin/oslevel = unknown /bin/universe = unknown PATH: /usr/local/sbin PATH: /usr/local/bin PATH: /usr/sbin PATH: /usr/bin PATH: /root/bin PATH: /usr/java/jdk1.8.0_131/bin PATH: /opt/apache-tomcat-8.0.36/bin ## ----------- ## ## Core tests. ## ## ----------- ## configure:2890: checking build system type configure:2904: result: x86_64-unknown-linux-gnu configure:2924: checking host system type configure:2937: result: x86_64-unknown-linux-gnu configure:2957: checking target system type configure:2970: result: x86_64-unknown-linux-gnu configure:3012: checking for a BSD-compatible install configure:3080: result: /usr/bin/install -c configure:3091: checking whether build environment is sane configure:3128: result: yes configure:3190: checking for gawk configure:3206: found /usr/bin/gawk configure:3217: result: gawk configure:3228: checking whether make sets $(MAKE) configure:3250: result: yes configure:3467: checking configure arguments configure:5060: result: done configure:5232: checking for cc configure:5248: found /usr/bin/cc configure:5259: result: cc configure:5282: checking for ar configure:5298: found /usr/bin/ar configure:5309: result: ar configure:5367: checking for style of include used by make configure:5395: result: GNU configure:5724: checking for C compiler version configure:5733: cc --version >&5 cc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-11) Copyright (C) 2015 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. configure:5744: $? = 0 configure:5733: cc -v >&5 Using built-in specs. COLLECT_GCC=cc COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/lto-wrapper Target: x86_64-redhat-linux Configured with: ../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-linker-hash-style=gnu --enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto --enable-plugin --enable-initfini-array --disable-libgcj --with-isl=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/isl-install --with-cloog=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/cloog-install --enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64 --build=x86_64-redhat-linux Thread model: posix gcc version 4.8.5 20150623 (Red Hat 4.8.5-11) (GCC) configure:5744: $? = 0 configure:5733: cc -V >&5 cc: error: unrecognized command line option '-V' cc: fatal error: no input files compilation terminated. configure:5744: $? = 4 configure:5733: cc -qversion >&5 cc: error: unrecognized command line option '-qversion' cc: fatal error: no input files compilation terminated. configure:5744: $? = 4 configure:5764: checking whether the C compiler works configure:5786: cc -I /usr/local/BerkeleyDB/6.2.32/include -L/usr/local/lib -L/usr/local/BerkeleyDB/6.2.32/lib -R/data/BerkeleyDB/6.2.32/lib conftest.c >&5 cc: error: unrecognized command line option '-R' configure:5790: $? = 1 configure:5828: result: no configure: failed program was: | /* confdefs.h */ | #define PACKAGE_NAME "" | #define PACKAGE_TARNAME "" | #define PACKAGE_VERSION "" | #define PACKAGE_STRING "" | #define PACKAGE_BUGREPORT "" | #define PACKAGE_URL "" | #define OPENLDAP_PACKAGE "OpenLDAP" | #define OPENLDAP_VERSION "2.4.45" | #define LDAP_VENDOR_VERSION 20445 | #define LDAP_VENDOR_VERSION_MAJOR 2 | #define LDAP_VENDOR_VERSION_MINOR 4 | #define LDAP_VENDOR_VERSION_PATCH 45 | #define HAVE_MKVERSION 1 | /* end confdefs.h. */ | | int | main () | { | | ; | return 0; | } configure:5833: error: in `/root/data/openldap-2.4.45': configure:5837: error: C compiler cannot create executables See `config.log' for more details. ## ---------------- ## ## Cache variables. ## ## ---------------- ## ac_cv_build=x86_64-unknown-linux-gnu ac_cv_env_CC_set= ac_cv_env_CC_value= ac_cv_env_CFLAGS_set= ac_cv_env_CFLAGS_value= ac_cv_env_CPPFLAGS_set=set ac_cv_env_CPPFLAGS_value='-I /usr/local/BerkeleyDB/6.2.32/include' ac_cv_env_CPP_set= ac_cv_env_CPP_value= ac_cv_env_LDFLAGS_set=set ac_cv_env_LDFLAGS_value='-L/usr/local/lib -L/usr/local/BerkeleyDB/6.2.32/lib -R/data/BerkeleyDB/6.2.32/lib' ac_cv_env_LIBS_set= ac_cv_env_LIBS_value= ac_cv_env_build_alias_set= ac_cv_env_build_alias_value= ac_cv_env_host_alias_set= ac_cv_env_host_alias_value= ac_cv_env_target_alias_set= ac_cv_env_target_alias_value= ac_cv_host=x86_64-unknown-linux-gnu ac_cv_path_install='/usr/bin/install -c' ac_cv_prog_AR=ar ac_cv_prog_AWK=gawk ac_cv_prog_CC=cc ac_cv_prog_make_make_set=yes ac_cv_shtool=build/shtool ac_cv_target=x86_64-unknown-linux-gnu ## ----------------- ## ## Output variables. ## ## ----------------- ## ACLOCAL='${SHELL} /root/data/openldap-2.4.45/build/missing --run aclocal-1.9' AMDEPBACKSLASH='\' AMDEP_FALSE='#' AMDEP_TRUE='' AMTAR='${SHELL} /root/data/openldap-2.4.45/build/missing --run tar' AR='ar' AS='' AUTH_LIBS='' AUTOCONF='${SHELL} /root/data/openldap-2.4.45/build/missing --run autoconf' AUTOHEADER='${SHELL} /root/data/openldap-2.4.45/build/missing --run autoheader' AUTOMAKE='${SHELL} /root/data/openldap-2.4.45/build/missing --run automake-1.9' AWK='gawk' BDB_LIBS='' BUILD_ACCESSLOG='no' BUILD_AUDITLOG='no' BUILD_BDB='no' BUILD_COLLECT='' BUILD_CONSTRAINT='no' BUILD_DDS='no' BUILD_DENYOP='no' BUILD_DEREF='no' BUILD_DNSSRV='no' BUILD_DYNGROUP='no' BUILD_DYNLIST='no' BUILD_HDB='no' BUILD_LASTMOD='no' BUILD_LDAP='no' BUILD_LIBS_DYNAMIC='' BUILD_MDB='no' BUILD_MEMBEROF='no' BUILD_META='no' BUILD_MONITOR='no' BUILD_NDB='no' BUILD_NULL='no' BUILD_PASSWD='no' BUILD_PERL='no' BUILD_PPOLICY='no' BUILD_PROXYCACHE='no' BUILD_REFINT='no' BUILD_RELAY='no' BUILD_RETCODE='no' BUILD_RWM='no' BUILD_SEQMOD='no' BUILD_SHELL='no' BUILD_SLAPD='no' BUILD_SLAPI='no' BUILD_SOCK='no' BUILD_SQL='no' BUILD_SSSVLV='no' BUILD_SYNCPROV='no' BUILD_THREAD='no' BUILD_TRANSLUCENT='no' BUILD_UNIQUE='no' BUILD_VALSORT='no' CC='cc' CCDEPMODE='' CFLAGS='' CPP='' CPPFLAGS='-I /usr/local/BerkeleyDB/6.2.32/include' CYGPATH_W='echo' DEFS='' DEPDIR='.deps' DLLTOOL='' ECHO='echo' ECHO_C='' ECHO_N='-n' ECHO_T='' EGREP='' EXEEXT='' GREP='' ICU_LIBS='' INSTALL_DATA='${INSTALL} -m 644' INSTALL_PROGRAM='${INSTALL}' INSTALL_SCRIPT='${INSTALL}' INSTALL_STRIP_PROGRAM='${SHELL} $(install_sh) -c -s' KRB4_LIBS='' KRB5_LIBS='' LDAP_LIBS='' LDFLAGS='-L/usr/local/lib -L/usr/local/BerkeleyDB/6.2.32/lib -R/data/BerkeleyDB/6.2.32/lib' LIBOBJS='' LIBS='' LIBSLAPI='' LIBSRCS='' LIBTOOL='' LN_S='' LTHREAD_LIBS='' LTLIBOBJS='' LTSTATIC='' LUTIL_LIBS='' MAKEINFO='${SHELL} /root/data/openldap-2.4.45/build/missing --run makeinfo' MODULES_LIBS='' MOD_PERL_LDFLAGS='' MYSQL='' OBJDUMP='' OBJEXT='' OL_MKDEP='' OL_MKDEP_FLAGS='' OPENLDAP_LIBRELEASE='2.4' OPENLDAP_LIBVERSION='12:8:10' OPENLDAP_RELEASE_DATE='2017/06/01' PACKAGE='OpenLDAP' PACKAGE_BUGREPORT='' PACKAGE_NAME='' PACKAGE_STRING='' PACKAGE_TARNAME='' PACKAGE_URL='' PACKAGE_VERSION='' PATH_SEPARATOR=':' PERLBIN='' PERL_CPPFLAGS='' PLAT='' RANLIB='' SASL_LIBS='' SET_MAKE='' SHELL='/bin/sh' SLAPD_DYNAMIC_BACKENDS='' SLAPD_DYNAMIC_OVERLAYS='' SLAPD_GMP_LIBS='' SLAPD_LIBS='' SLAPD_MODULES_CPPFLAGS='' SLAPD_MODULES_LDFLAGS='' SLAPD_NDB_INCS='' SLAPD_NDB_LIBS='' SLAPD_NO_STATIC='' SLAPD_PERL_LDFLAGS='' SLAPD_SLAPI_DEPEND='' SLAPD_SLP_LIBS='' SLAPD_SQL_INCLUDES='' SLAPD_SQL_LDFLAGS='' SLAPD_SQL_LIBS='' SLAPD_STATIC_BACKENDS='back-ldif' SLAPD_STATIC_OVERLAYS='' SLAPI_LIBS='' STRIP='' TLS_LIBS='' VERSION='2.4.45' WITH_ACI_ENABLED='' WITH_MODULES_ENABLED='' WITH_SASL='' WITH_TLS='' WRAP_LIBS='' ac_ct_CC='' am__fastdepCC_FALSE='' am__fastdepCC_TRUE='' am__include='include' am__leading_dot='.' am__quote='' am__tar='${AMTAR} chof - "$$tardir"' am__untar='${AMTAR} xf -' bindir='${exec_prefix}/bin' build='x86_64-unknown-linux-gnu' build_alias='' build_cpu='x86_64' build_os='linux-gnu' build_vendor='unknown' datadir='${datarootdir}' datarootdir='${prefix}/share' docdir='${datarootdir}/doc/${PACKAGE}' dvidir='${docdir}' exec_prefix='NONE' host='x86_64-unknown-linux-gnu' host_alias='' host_cpu='x86_64' host_os='linux-gnu' host_vendor='unknown' htmldir='${docdir}' includedir='${prefix}/include' infodir='${datarootdir}/info' install_sh='/root/data/openldap-2.4.45/build/install-sh' ldap_subdir='/openldap' libdir='${exec_prefix}/lib' libexecdir='${exec_prefix}/libexec' localedir='${datarootdir}/locale' localstatedir='${prefix}/var' mandir='${datarootdir}/man' mkdir_p='mkdir -p --' oldincludedir='/usr/include' pdfdir='${docdir}' prefix='/data/openldap' program_transform_name='s,x,x,' psdir='${docdir}' sbindir='${exec_prefix}/sbin' sharedstatedir='${prefix}/com' sysconfdir='${prefix}/etc' target='x86_64-unknown-linux-gnu' target_alias='' target_cpu='x86_64' target_os='linux-gnu' target_vendor='unknown' top_builddir='/root/data/openldap-2.4.45' ## ----------- ## ## confdefs.h. ## ## ----------- ## /* confdefs.h */ #define PACKAGE_NAME "" #define PACKAGE_TARNAME "" #define PACKAGE_VERSION "" #define PACKAGE_STRING "" #define PACKAGE_BUGREPORT "" #define PACKAGE_URL "" #define OPENLDAP_PACKAGE "OpenLDAP" #define OPENLDAP_VERSION "2.4.45" #define LDAP_VENDOR_VERSION 20445 #define LDAP_VENDOR_VERSION_MAJOR 2 #define LDAP_VENDOR_VERSION_MINOR 4 #define LDAP_VENDOR_VERSION_PATCH 45 #define HAVE_MKVERSION 1 configure: exit 77

1 0

(ITS#8715) Typo in man page description of olcTLSCipherSuite?
by james＠turnersoft.co.uk 19 Aug '17

19 Aug '17

Full_Name: James Turner Version: 2.4 OS: Ubuntu 16.04 LTS URL: Submission from: (NULL) (81.86.27.193) File: /doc/man/man5/slapd-config.5 The following example is given at line 832 (correct for Git master branch at time of writing): TLSCiphersuite SECURE256:!AES-128-CBC Shouldn't this read: olcTLSCiphersuite: SECURE256:!AES-128-CBC

1 0

Re: (ITS#8714) RFE: Sendout EXTENDED operation message in back-sock
by michael＠stroeder.com 18 Aug '17

18 Aug '17

This is a multi-part message in MIME format. --------------4BA376E6A3936AB8C247B47A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The attached patch file is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by Michael Ströder <michael(a)stroeder.com>. I have not assigned rights and/or interest in this work to any party. I, Michael Ströder, hereby place the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice. This patch can also be found here: ftp://ftp.openldap.org/incoming/0001-ITS-8714-Send-out-EXTENDED-operation-m… --------------4BA376E6A3936AB8C247B47A Content-Type: text/x-patch; name="0001-ITS-8714-Send-out-EXTENDED-operation-message-from-back-sock.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-ITS-8714-Send-out-EXTENDED-operation-message-from-back-"; filename*1="sock.patch" =46rom 732c5646e0a03be8b58e52527b25742f0495807e Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Michael=3D20Str=3DC3=3DB6der?=3D <michael(a)stroeder.com>= Date: Fri, 18 Aug 2017 18:47:41 +0200 Subject: [PATCH] ITS#8714 Send out EXTENDED operation message from back-s= ock to external program --- doc/man/man5/slapd-sock.5 | 19 +++++++++++- servers/slapd/back-sock/Makefile.in | 4 +-- servers/slapd/back-sock/config.c | 12 ++++++-- servers/slapd/back-sock/extended.c | 58 ++++++++++++++++++++++++++++++= ++++++ servers/slapd/back-sock/init.c | 2 +- servers/slapd/back-sock/proto-sock.h | 2 ++ 6 files changed, 91 insertions(+), 6 deletions(-) create mode 100644 servers/slapd/back-sock/extended.c diff --git a/doc/man/man5/slapd-sock.5 b/doc/man/man5/slapd-sock.5 index 1ac4f7fdd..0c4fc3fdd 100644 --- a/doc/man/man5/slapd-sock.5 +++ b/doc/man/man5/slapd-sock.5 @@ -49,7 +49,7 @@ be sent and from which replies are received. =20 When used as an overlay, these additional directives are defined: .TP -.B sockops [ bind | unbind | search | compare | modify | modrdn | add | = delete ]* +.B sockops [ bind | unbind | search | compare | modify | modrdn | add | = delete | extended ]* Specify which request types to send to the external program. The default= is empty (no requests are sent). .TP @@ -115,6 +115,18 @@ dn: <DN> .PP .RS .nf +EXTENDED +msgid: <message id> +<repeat { "suffix:" <database suffix DN> }> +oid: <OID> +valuelen: <length of <value>> +value: <credentials> +<blank line> +.fi +.RE +.PP +.RS +.nf MODIFY msgid: <message id> <repeat { "suffix:" <database suffix DN> }> @@ -292,6 +304,11 @@ access to the pseudo_attribute of the searchBase; .B search (=3Ds) access to the attributes and values used in the filter is not checked. +.LP +The +.B extended +operation does not require any access special rights. +The external program has to implement any sort of access control. =20 .SH EXAMPLE There is an example script in the slapd/back\-sock/ directory diff --git a/servers/slapd/back-sock/Makefile.in b/servers/slapd/back-soc= k/Makefile.in index 3e527e545..efb916246 100644 --- a/servers/slapd/back-sock/Makefile.in +++ b/servers/slapd/back-sock/Makefile.in @@ -18,9 +18,9 @@ ## in OpenLDAP Software. =20 SRCS =3D init.c config.c opensock.c search.c bind.c unbind.c add.c \ - delete.c modify.c modrdn.c compare.c result.c + delete.c modify.c modrdn.c compare.c result.c extended.c OBJS =3D init.lo config.lo opensock.lo search.lo bind.lo unbind.lo add.l= o \ - delete.lo modify.lo modrdn.lo compare.lo result.lo + delete.lo modify.lo modrdn.lo compare.lo result.lo extended.lo =20 LDAP_INCDIR=3D ../../../include =20 LDAP_LIBDIR=3D ../../../libraries diff --git a/servers/slapd/back-sock/config.c b/servers/slapd/back-sock/c= onfig.c index dc3f1365c..2dcf68bf6 100644 --- a/servers/slapd/back-sock/config.c +++ b/servers/slapd/back-sock/config.c @@ -106,6 +106,7 @@ static ConfigOCs osocs[] =3D { #define SOCK_OP_MODRDN 0x020 #define SOCK_OP_ADD 0x040 #define SOCK_OP_DELETE 0x080 +#define SOCK_OP_EXTENDED 0x100 =20 #define SOCK_REP_RESULT 0x001 #define SOCK_REP_SEARCH 0x002 @@ -127,6 +128,7 @@ static slap_verbmasks ov_ops[] =3D { { BER_BVC("modrdn"), SOCK_OP_MODRDN }, { BER_BVC("add"), SOCK_OP_ADD }, { BER_BVC("delete"), SOCK_OP_DELETE }, + { BER_BVC("extended"), SOCK_OP_EXTENDED }, { BER_BVNULL, 0 } }; =20 @@ -249,7 +251,9 @@ static BI_op_bind *sockfuncs[] =3D { sock_back_modify, sock_back_modrdn, sock_back_add, - sock_back_delete + sock_back_delete, + 0, /* abandon not supported */ + sock_back_extended }; =20 static const int sockopflags[] =3D { @@ -260,7 +264,9 @@ static const int sockopflags[] =3D { SOCK_OP_MODIFY, SOCK_OP_MODRDN, SOCK_OP_ADD, - SOCK_OP_DELETE + SOCK_OP_DELETE, + 0, /* abandon not supported */ + SOCK_OP_EXTENDED }; =20 static int sock_over_op( @@ -283,6 +289,7 @@ static int sock_over_op( case LDAP_REQ_MODRDN: which =3D op_modrdn; break; case LDAP_REQ_ADD: which =3D op_add; break; case LDAP_REQ_DELETE: which =3D op_delete; break; + case LDAP_REQ_EXTENDED: which =3D op_extended; break; default: return SLAP_CB_CONTINUE; } @@ -365,6 +372,7 @@ sock_over_setup() sockover.on_bi.bi_op_modrdn =3D sock_over_op; sockover.on_bi.bi_op_add =3D sock_over_op; sockover.on_bi.bi_op_delete =3D sock_over_op; + sockover.on_bi.bi_extended =3D sock_over_op; sockover.on_response =3D sock_over_response; =20 sockover.on_bi.bi_cf_ocs =3D osocs; diff --git a/servers/slapd/back-sock/extended.c b/servers/slapd/back-sock= /extended.c new file mode 100644 index 000000000..15493ea98 --- /dev/null +++ b/servers/slapd/back-sock/extended.c @@ -0,0 +1,58 @@ +/* extended.c - sock backend extended routines */ +/* $OpenLDAP$ */ +/* This work is part of OpenLDAP Software <http://www.openldap.org/>. + * + * Copyright 2000-2017 The OpenLDAP Foundation. + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted only as authorized by the OpenLDAP + * Public License. + * + * A copy of this license is available in the file LICENSE in the + * top-level directory of the distribution or, alternatively, at + * <http://www.OpenLDAP.org/license.html>. + */ + +#include "portable.h" + +#include <stdio.h> +#include <ac/string.h> + +#include "slap.h" +#include "back-sock.h" + +int +sock_back_extended( Operation *op, SlapReply *rs ) +{ + int rc; + struct sockinfo *si =3D (struct sockinfo *) op->o_bd->be_private; + FILE *fp; + + Debug( LDAP_DEBUG_ARGS, "=3D=3D> sock_back_extended(%s)\n", + op->ore_reqoid.bv_val, op->o_req_dn.bv_val, 0 ); + + if ( (fp =3D opensock( si->si_sockpath )) =3D=3D NULL ) { + send_ldap_error( op, rs, LDAP_OTHER, + "could not open socket" ); + return( -1 ); + } + + /* write out the request to the extended process */ + fprintf( fp, "EXTENDED\n" ); + fprintf( fp, "msgid: %ld\n", (long) op->o_msgid ); + sock_print_conn( fp, op->o_conn, si ); + sock_print_suffixes( fp, op->o_bd ); + fprintf( fp, "oid: %s\n", op->ore_reqoid.bv_val ); + if (op->ore_reqdata) { + fprintf( fp, "valuelen: %lu\n", op->ore_reqdata->bv_len ); + fprintf( fp, "value: %s\n", op->ore_reqdata->bv_val ); + } + fprintf( fp, "\n" ); + + /* read in the results and send them along */ + rc =3D sock_read_and_send_results( op, rs, fp ); + fclose( fp ); + + return( rc ); +} diff --git a/servers/slapd/back-sock/init.c b/servers/slapd/back-sock/ini= t.c index dcfe61a44..92e68782f 100644 --- a/servers/slapd/back-sock/init.c +++ b/servers/slapd/back-sock/init.c @@ -53,7 +53,7 @@ sock_back_initialize( bi->bi_op_delete =3D sock_back_delete; bi->bi_op_abandon =3D 0; =20 - bi->bi_extended =3D 0; + bi->bi_extended =3D sock_back_extended; =20 bi->bi_chk_referrals =3D 0; =20 diff --git a/servers/slapd/back-sock/proto-sock.h b/servers/slapd/back-so= ck/proto-sock.h index fa02ab896..8b3b5f3ef 100644 --- a/servers/slapd/back-sock/proto-sock.h +++ b/servers/slapd/back-sock/proto-sock.h @@ -40,6 +40,8 @@ extern BI_op_modrdn sock_back_modrdn; extern BI_op_add sock_back_add; extern BI_op_delete sock_back_delete; =20 +extern BI_op_extended sock_back_extended; + extern int sock_back_init_cf( BackendInfo *bi ); =20 LDAP_END_DECL --=20 2.14.0 --------------4BA376E6A3936AB8C247B47A--

1 0

(ITS#8714) RFE: Sendout EXTENDED operation message in back-sock
by michael＠stroeder.com 18 Aug '17

18 Aug '17

Full_Name: Michael Str.der Version: master / RE24 OS: irrelevant URL: Submission from: (NULL) (213.240.182.101) back-sock should also send extended operations to external listener. Patch will follow.

1 0

(ITS#8713) Delete slapd-ldbm.5 man page
by quanah＠openldap.org 16 Aug '17

16 Aug '17

Full_Name: Quanah Gibson-Mount Version: HEAD OS: N/A URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (47.208.148.239) We should delete the stub man page for slapd-ldbm(5) from our repository, as it died with OpenLDAP 2.3.

1 0

Re: (ITS#8712) haproxy
by michael＠stroeder.com 16 Aug '17

16 Aug '17

dup of ITS#8711

1 0

Re: (ITS#8711) haproxy
by michael＠stroeder.com 16 Aug '17

16 Aug '17

This is a cryptographically signed message in MIME format. --------------ms000008090101090902090203 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable marceloandril(a)yahoo.com.br wrote: > Full_Name: marcelo > Version: 2.4.44 > OS: centos 7.2 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (177.69.83.5) >=20 >=20 > Good morning, I'm having a problem using syncrepl by haproxy. The serve= r can not > re-create the database. I am using mdb. 1. The ITS is for reporting bugs to the OpenLDAP team, not for asking usa= ge questions. Please post those to openldap-technical mailing list: https://www.openldap.org/lists/mm/listinfo/openldap-technical 2. I'd recommend against pointing to a HA address in syncrepl config stat= ements. You can have more than one syncrepl statement within a database configuration and= let slapd do the fail-over to another available provider internally. Ciao, Michael. --------------ms000008090101090902090203 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCC CucwggT9MIID5aADAgECAhBFRleVrRF8X5GwbV0tcLCgMA0GCSqGSIb3DQEBCwUAMHUxCzAJ BgNVBAYTAklMMRYwFAYDVQQKEw1TdGFydENvbSBMdGQuMSkwJwYDVQQLEyBTdGFydENvbSBD ZXJ0aWZpY2F0aW9uIEF1dGhvcml0eTEjMCEGA1UEAxMaU3RhcnRDb20gQ2xhc3MgMSBDbGll bnQgQ0EwHhcNMTYwOTE2MDcxNjUxWhcNMTkxMjE2MDcxNjUxWjBEMR0wGwYDVQQDDBRtaWNo YWVsQHN0cm9lZGVyLmNvbTEjMCEGCSqGSIb3DQEJARYUbWljaGFlbEBzdHJvZWRlci5jb20w ggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQChMBt5jtuLXsNQ5U7rBbZit8sknIwz hfaousT3d/fssQ6qZwe9l1yklILSXVMqI7/bxbiqcd3zrz+imdSlZPrFBHGfh04DZHCfss2F RwSswGejqP1qE3hPvZi96wFfOMqenpN+pSXqNJ1OPBCJ8a+8ZEioFKoEj3HkCCXjbmezAgms FuA7aFE9BfjJ2eQKw8B9G8X1FjvOTinYSZ2F+qHpKgywl4HTx0dMnYy+Pwu4DDIHkEaVH+uj K1/ed76WUEH51mX9m2Xu0onfQlSM3me6EvAAZiIDsCEbF9WttRuJbpfCFo0m2uW7BBugS7EG Jro1nRSQVnpJyTFgHb5EGMVVAgMBAAGjggG4MIIBtDAOBgNVHQ8BAf8EBAMCBLAwHQYDVR0l BBYwFAYIKwYBBQUHAwIGCCsGAQUFBwMEMAkGA1UdEwQCMAAwHQYDVR0OBBYEFFh1801TSuxT Nltnv9rOjrZzUUgNMB8GA1UdIwQYMBaAFCSBbDlhvkkPj7cbRivJKLUnSG1oMG8GCCsGAQUF BwEBBGMwYTAkBggrBgEFBQcwAYYYaHR0cDovL29jc3Auc3RhcnRzc2wuY29tMDkGCCsGAQUF BzAChi1odHRwOi8vYWlhLnN0YXJ0c3NsLmNvbS9jZXJ0cy9zY2EuY2xpZW50MS5jcnQwOAYD VR0fBDEwLzAtoCugKYYnaHR0cDovL2NybC5zdGFydHNzbC5jb20vc2NhLWNsaWVudDEuY3Js MB8GA1UdEQQYMBaBFG1pY2hhZWxAc3Ryb2VkZXIuY29tMCMGA1UdEgQcMBqGGGh0dHA6Ly93 d3cuc3RhcnRzc2wuY29tLzBHBgNVHSAEQDA+MDwGCysGAQQBgbU3AQIFMC0wKwYIKwYBBQUH AgEWH2h0dHBzOi8vd3d3LnN0YXJ0c3NsLmNvbS9wb2xpY3kwDQYJKoZIhvcNAQELBQADggEB AKiJ9wpjJeHdEzHDZyqmhn4cHcRj9Ag7ZQK0meq1N3oQ9M1YeVge6vZe20LXojgXsNUQGLSt 1lW2s7fABkL9CF+/RtWznHxlp4YpWX/RgbHBo3uXKNA5JUOjbxQ2+1b1jaTp/FUrSIISAxgd RpeYAODJ0db1x8Q+l66DtIVjj7ktWISdJWE2Opn4QnaRwdj6n35Rul4S2ikUsmxtGrHLpjRR XJqbsGa0RZdJyUKlZ2ZRAoRz4jKHOogQcig937sR5Ut2pGOhrScEhgARY2c8Gs2olRTL3pue mE4vjY0g1Nwr9RzeFwMuasiFh4yD34i6jIRfoNzuLPgydjsJ0grw0akwggXiMIIDyqADAgEC AhBrp4p9CteI1lEK+Vnk57ThMA0GCSqGSIb3DQEBCwUAMH0xCzAJBgNVBAYTAklMMRYwFAYD VQQKEw1TdGFydENvbSBMdGQuMSswKQYDVQQLEyJTZWN1cmUgRGlnaXRhbCBDZXJ0aWZpY2F0 ZSBTaWduaW5nMSkwJwYDVQQDEyBTdGFydENvbSBDZXJ0aWZpY2F0aW9uIEF1dGhvcml0eTAe Fw0xNTEyMTYwMTAwMDVaFw0zMDEyMTYwMTAwMDVaMHUxCzAJBgNVBAYTAklMMRYwFAYDVQQK Ew1TdGFydENvbSBMdGQuMSkwJwYDVQQLEyBTdGFydENvbSBDZXJ0aWZpY2F0aW9uIEF1dGhv cml0eTEjMCEGA1UEAxMaU3RhcnRDb20gQ2xhc3MgMSBDbGllbnQgQ0EwggEiMA0GCSqGSIb3 DQEBAQUAA4IBDwAwggEKAoIBAQC9fdr3w6J9g/Zbgv3bW1+uHht1wLUZr5gkrLtXedg17Ake fMyUGwrQdvwObhajcVmnKVxhrUwkZPXRAwZZosRHfEIi5FH7x6SV/8Sp5lZEuiMnvMFG2MzL A84J6Ws5T4NfXZ0qn4TPgnr3X2vPVS51M7Ua9nIJgn8jvTra4eyyQzxvuA/GZwKg7VQfDCmC S+kICslYYWgXOMt2xlsSslxLce0CGWRsT8EpMyt1iDflSjXZIsE7m1uTyHaKZspMLyIyz6my Su8j8BWWHpChNNeTrFuhVfrOAyDPFJVUvKZCLKBhibTLloyy+LatoWELrjdI4a8StZY8+dIR 9t4APXGzAgMBAAGjggFkMIIBYDAOBgNVHQ8BAf8EBAMCAQYwHQYDVR0lBBYwFAYIKwYBBQUH AwIGCCsGAQUFBwMEMBIGA1UdEwEB/wQIMAYBAf8CAQAwMgYDVR0fBCswKTAnoCWgI4YhaHR0 cDovL2NybC5zdGFydHNzbC5jb20vc2ZzY2EuY3JsMGYGCCsGAQUFBwEBBFowWDAkBggrBgEF BQcwAYYYaHR0cDovL29jc3Auc3RhcnRzc2wuY29tMDAGCCsGAQUFBzAChiRodHRwOi8vYWlh LnN0YXJ0c3NsLmNvbS9jZXJ0cy9jYS5jcnQwHQYDVR0OBBYEFCSBbDlhvkkPj7cbRivJKLUn SG1oMB8GA1UdIwQYMBaAFE4L7xqkQFulF2mHMMo0aEPQQa7yMD8GA1UdIAQ4MDYwNAYEVR0g ADAsMCoGCCsGAQUFBwIBFh5odHRwOi8vd3d3LnN0YXJ0c3NsLmNvbS9wb2xpY3kwDQYJKoZI hvcNAQELBQADggIBAIvj94fsAYuErQ8BAluc4SMnIwS9NPBwAm5SH9uh2NCXTq7im61g7F1L IiNI/+wq37fUuaMbz4g7VarKQTgf8ubs0p7NZWcIe7Bvem2AWaXBsxsaRTYw5kG3DN8pd1hS EUuFoTa7DmNeFe8tiK1BrL3rbA/m48jp4AiFXgvxprJrW7izsyetOrRHPbkW4Y07v29MdhaP v3u1JELyszXqOzjIYo4sWlC8iDQXwgSW/ntvWy2n4LuiaozlCfXl149tKeqvwlvrla2Yklue /quWp9j9ou4T/OY0CXMuY+B8wNK0ohd2D4ShgFlMSjzAFRoHGKF81snTr2d1A7Ew02oF6UQy CkC2aNNsK5cWOojBar5c7HplX9aHYUCZouxIeU28SONJAxnATgR4cJ2jrpmYSz/kliUJ46S6 UpVDo/ebn9c6PaM/XtDYCCaM/7XX6wc3s++sbQ7CtCn1Ax7df6ufQbwyO0V+oFa9H0KAsjHM zcwk3EV2B2NLatidKE/m7G+rB9m+FlVgIiSp0mGlg43QO9Kh1+JqvTCIzv2bJJkmPMLQJNuK KwHNL8F4GGp6jbAV+WL+LDeGfVcq8DHS3LrD+xyYEXQBiqZEdiPVOMxLDSUCXsDO0uCWpaNQ 8j6y6S9p0xE/Ga0peVLadVHhqf9nXqKaxnr358VgfrxzUIrvOaOjMYIDzDCCA8gCAQEwgYkw dTELMAkGA1UEBhMCSUwxFjAUBgNVBAoTDVN0YXJ0Q29tIEx0ZC4xKTAnBgNVBAsTIFN0YXJ0 Q29tIENlcnRpZmljYXRpb24gQXV0aG9yaXR5MSMwIQYDVQQDExpTdGFydENvbSBDbGFzcyAx IENsaWVudCBDQQIQRUZXla0RfF+RsG1dLXCwoDANBglghkgBZQMEAgEFAKCCAhMwGAYJKoZI hvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMTcwODE2MTQ1NjE2WjAvBgkq hkiG9w0BCQQxIgQgjUYirXwB1vZ8ZgRUkmA7Vma22C9NdA0dwIExgTvCSPAwbAYJKoZIhvcN AQkPMV8wXTALBglghkgBZQMEASowCwYJYIZIAWUDBAECMAoGCCqGSIb3DQMHMA4GCCqGSIb3 DQMCAgIAgDANBggqhkiG9w0DAgIBQDAHBgUrDgMCBzANBggqhkiG9w0DAgIBKDCBmgYJKwYB BAGCNxAEMYGMMIGJMHUxCzAJBgNVBAYTAklMMRYwFAYDVQQKEw1TdGFydENvbSBMdGQuMSkw JwYDVQQLEyBTdGFydENvbSBDZXJ0aWZpY2F0aW9uIEF1dGhvcml0eTEjMCEGA1UEAxMaU3Rh cnRDb20gQ2xhc3MgMSBDbGllbnQgQ0ECEEVGV5WtEXxfkbBtXS1wsKAwgZwGCyqGSIb3DQEJ EAILMYGMoIGJMHUxCzAJBgNVBAYTAklMMRYwFAYDVQQKEw1TdGFydENvbSBMdGQuMSkwJwYD VQQLEyBTdGFydENvbSBDZXJ0aWZpY2F0aW9uIEF1dGhvcml0eTEjMCEGA1UEAxMaU3RhcnRD b20gQ2xhc3MgMSBDbGllbnQgQ0ECEEVGV5WtEXxfkbBtXS1wsKAwDQYJKoZIhvcNAQEBBQAE ggEACOKnuhh5CM7f4xCZlgoANk4aov5w0qSDFFj5t8MkTa0lD17Ik2/yuVPP1Q3SqYg3pfDX 1RyhQ7cAQpcHjU3p+cjcTh9zHGkNekVzzrHpZn73NpAxJtvnawXQpW4uUQiywp1iBbaFRBPV VePCPXnkLq6uWdh4Ihx/FSBBa1cb0Mt8r+I6xIO/nTrHDDrPvv7KtgKac9KhFanhNDC6xk5t vjGhyXnHuc4vvWUCh7qshPTDWO2rabVGCLaJ0zZA2Q/5Me8WJ5GVEHHCqZqLt0PbP+pQa11B Lxpbrpnjw4alcSVvZ1JCvVbQKeBXYGKvQNYN+J6zzSujIs7I/C4QhPn6rgAAAAAAAA== --------------ms000008090101090902090203--

1 0

(ITS#8712) haproxy
by marceloandril＠yahoo.com.br 16 Aug '17

16 Aug '17

Full_Name: marcelo Version: 2.4.44 OS: centos 7.2 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (177.69.83.5) Good morning, I'm having a problem using syncrepl by haproxy. The server can not re-create the database. I am using mdb. Log: slapd[22501]: dn_callback : entries have identical CSN slapd[22501]: syncrepl_entry: rid=001 entry unchanged, ignored slapd[22501]: do_syncrep2: rid=001 (-1) Can't contact LDAP server slapd[22501]: do_syncrepl: rid=001 rc -1 retrying

1 0

(ITS#8711) haproxy
by marceloandril＠yahoo.com.br 16 Aug '17

16 Aug '17

Full_Name: marcelo Version: 2.4.44 OS: centos 7.2 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (177.69.83.5) Good morning, I'm having a problem using syncrepl by haproxy. The server can not re-create the database. I am using mdb. Log: slapd[22501]: dn_callback : entries have identical CSN slapd[22501]: syncrepl_entry: rid=001 entry unchanged, ignored slapd[22501]: do_syncrep2: rid=001 (-1) Can't contact LDAP server slapd[22501]: do_syncrepl: rid=001 rc -1 retrying

1 0

Re: (ITS#8707) slapd: Add systemd service notification support
by fumiyas＠osstech.co.jp 13 Aug '17

13 Aug '17

On Sat, 12 Aug 2017 02:58:20 +0900, Ryan Tandy wrote: > > I've added slapd.service file. Please check. > > Looks good to me. Thanks again for working on this! :) > > Just minor comments: > > > - $(srcdir)/slapd.conf > slapd.conf.tmp ; \ > > + $(srcdir)/slapd.conf > slapd.conf.tmp || exit $$?; \ > > > - $(srcdir)/slapd.ldif > slapd.ldif.tmp ; \ > > + $(srcdir)/slapd.ldif > slapd.ldif.tmp || exit $$? > > Is there any difference between this and using && instead of ;? (Not asking for any change, I just want to make sure I understand.) In Makefile, /bin/sh is invoked without -e option. > > + if test -n "$(systemdsystemunitdir)"; then \ > > This is echoed while the rest aren't; maybe it could be either appended to the above command, or change to @if. Fixed. Thanks! -- -- Name: SATOH Fumiyasu @ OSS Technology Corp. (fumiyas @ osstech co jp) -- Business Home: http://www.OSSTech.co.jp/ -- GitHub Home: https://GitHub.com/fumiyas/ -- PGP Fingerprint: BBE1 A1C9 525A 292E 6729 CDEC ADC2 9DCA 5E1C CBCA

1 0

Re: (ITS#8710) mdb_copy wait for writer to complete
by hyc＠symas.com 12 Aug '17

12 Aug '17

muthukumardce(a)gmail.com wrote: > Full_Name: Muthukumar > Version: LMDB 0.82 > OS: OSX > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (49.207.184.177) > > > # Writer > > ``` > import lmdb > > db_path = "test.db" > DB_MAX_SIZE = 40 * 1000 * 1000 * 1000 > env = lmdb.Environment(db_path, DB_MAX_SIZE, sync=True) > txn = env.begin(write=True, buffers=True) > for i in xrange(5000000): > value = "*" * 100 > txn.put("i="+str(i), value) > txn.commit() > ``` > > I ran the above python program in my machine which took almost 8 secs to > complete. Simultaneously i try to copy the database using mdb_copy, but it > started copying only after the write program completes its execution. > > Please note: First i run the writer program then the mdb_copy, if i start > mdb_copy first it runs smoothly. > > Please help. The ITS is for bug reports, not help requests. Use the openldap-technical mailing list for assistance. The mdb_copy program needs to acquire the DB write mutex before executing, to ensure it gets a consistent snapshot. It obviously can't do that until any other active writer finishes. Closing this ITS. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8710) mdb_copy wait for writer to complete
by muthukumardce＠gmail.com 11 Aug '17

11 Aug '17

Full_Name: Muthukumar Version: LMDB 0.82 OS: OSX URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (49.207.184.177) # Writer ``` import lmdb db_path = "test.db" DB_MAX_SIZE = 40 * 1000 * 1000 * 1000 env = lmdb.Environment(db_path, DB_MAX_SIZE, sync=True) txn = env.begin(write=True, buffers=True) for i in xrange(5000000): value = "*" * 100 txn.put("i="+str(i), value) txn.commit() ``` I ran the above python program in my machine which took almost 8 secs to complete. Simultaneously i try to copy the database using mdb_copy, but it started copying only after the write program completes its execution. Please note: First i run the writer program then the mdb_copy, if i start mdb_copy first it runs smoothly. Please help.

1 0

Re: (ITS#8707) slapd: Add systemd service notification support
by ryan＠nardis.ca 11 Aug '17

11 Aug '17

On Fri, Aug 11, 2017 at 08:10:09PM +0900, SATOH Fumiyasu wrote: >I've added slapd.service file. Please check. Looks good to me. Thanks again for working on this! :) Just minor comments: >- $(srcdir)/slapd.conf > slapd.conf.tmp ; \ >+ $(srcdir)/slapd.conf > slapd.conf.tmp || exit $$?; \ >- $(srcdir)/slapd.ldif > slapd.ldif.tmp ; \ >+ $(srcdir)/slapd.ldif > slapd.ldif.tmp || exit $$? Is there any difference between this and using && instead of ;? (Not asking for any change, I just want to make sure I understand.) >+ if test -n "$(systemdsystemunitdir)"; then \ This is echoed while the rest aren't; maybe it could be either appended to the above command, or change to @if.

1 0

Re: (ITS#8707) slapd: Add systemd service notification support
by fumiyas＠osstech.co.jp 11 Aug '17

11 Aug '17

Hi, I've added slapd.service file. Please check. * https://github.com/osstech-jp/openldap/pull/4 * https://patch-diff.githubusercontent.com/raw/osstech-jp/openldap/pull/4.pat… On Thu, 10 Aug 2017 19:26:48 +0900, fumiyas wrote: > > > I've revised the patch for master to check if the listener initialization > > > suceeds or not. With this patch, `slapd -d0` can return non-zero exit code > > > if the listener initialization fails, thus systemd can detect slapd.service > > > startup failure. > > > > Nice catch! That change looks correct to me, but I hope Howard will check it too. Actually it's probably relevant for any init system; possibly worth splitting out as its own commit? > > This patch does NOT affect SysV-init system because an init script > for slapd normally does NOT use the -d option. > > > Just checking, do you plan to add the service file and its installation (conditional on enabled systemd support) in this branch as well, or should I work on that myself if I want it? > > Yes, I'll do that later. -- -- Name: SATOH Fumiyasu @ OSS Technology Corp. (fumiyas @ osstech co jp) -- Business Home: http://www.OSSTech.co.jp/ -- GitHub Home: https://GitHub.com/fumiyas/ -- PGP Fingerprint: BBE1 A1C9 525A 292E 6729 CDEC ADC2 9DCA 5E1C CBCA

1 0

Re: (ITS#8707) slapd: Add systemd service notification support
by fumiyas＠osstech.co.jp 10 Aug '17

10 Aug '17

On Thu, 10 Aug 2017 02:16:56 +0900, Ryan Tandy wrote: > > I've revised the patch for master to check if the listener initialization > > suceeds or not. With this patch, `slapd -d0` can return non-zero exit code > > if the listener initialization fails, thus systemd can detect slapd.service > > startup failure. > > Nice catch! That change looks correct to me, but I hope Howard will check it too. Actually it's probably relevant for any init system; possibly worth splitting out as its own commit? This patch does NOT affect SysV-init system because an init script for slapd normally does NOT use the -d option. > Just checking, do you plan to add the service file and its installation (conditional on enabled systemd support) in this branch as well, or should I work on that myself if I want it? Yes, I'll do that later. Thank you. -- -- Name: SATOH Fumiyasu @ OSS Technology Corp. (fumiyas @ osstech co jp) -- Business Home: http://www.OSSTech.co.jp/ -- GitHub Home: https://GitHub.com/fumiyas/ -- PGP Fingerprint: BBE1 A1C9 525A 292E 6729 CDEC ADC2 9DCA 5E1C CBCA

1 0

(ITS#8709) pw-totp: OpenSSL 1.1 compatibility
by fumiyas＠osstech.co.jp 10 Aug '17

10 Aug '17

Full_Name: SATOH Fumiyasu Version: master OS: URL: Submission from: (NULL) (118.240.43.13) Current contrib/slapd-modules/passwd/totp is not compatible with OpenSSL 1.1+. I've created a patch to fix that. Please see the following patch I post: * https://patch-diff.githubusercontent.com/raw/osstech-jp/openldap/pull/5.pat… * https://github.com/osstech-jp/openldap/pull/5

1 0

Re: (ITS#8707) slapd: Add systemd service notification support
by ryan＠nardis.ca 09 Aug '17

09 Aug '17

On Wed, Aug 09, 2017 at 05:13:44PM +0900, SATOH Fumiyasu wrote: >I've revised the patch for master to check if the listener initialization >suceeds or not. With this patch, `slapd -d0` can return non-zero exit code >if the listener initialization fails, thus systemd can detect slapd.service >startup failure. Nice catch! That change looks correct to me, but I hope Howard will check it too. Actually it's probably relevant for any init system; possibly worth splitting out as its own commit? Just checking, do you plan to add the service file and its installation (conditional on enabled systemd support) in this branch as well, or should I work on that myself if I want it? Thanks!

1 0

Re: (ITS#8707) slapd: Add systemd service notification support
by fumiyas＠osstech.co.jp 09 Aug '17

09 Aug '17

On Tue, 08 Aug 2017 04:23:27 +0900, Ryan Tandy wrote: > > + rc = sd_notifyf( 1, > > + "READY=1\n" > > + "STATUS=slapd: ready to serve connections...\n" > > + "MAINPID=%lu", > > + (unsigned long) getpid() ); > I see you've placed this call later than the parent's exit point. Any comments about the timing of this relative to the parent's exit, and to the listener startup and so on? Are the listeners more likely to be ready to serve connections at this point? I seem to recall that in the past there was opposition to moving the parent's exit later, but I can't remember why. (and I still wish we could do that, and dispense with the ldapsearch-loop hacks...) I've revised the patch for master to check if the listener initialization suceeds or not. With this patch, `slapd -d0` can return non-zero exit code if the listener initialization fails, thus systemd can detect slapd.service startup failure. * https://github.com/osstech-jp/openldap/pull/4 * https://patch-diff.githubusercontent.com/raw/osstech-jp/openldap/pull/4.pat… -- -- Name: SATOH Fumiyasu @ OSS Technology Corp. (fumiyas @ osstech co jp) -- Business Home: http://www.OSSTech.co.jp/ -- GitHub Home: https://GitHub.com/fumiyas/ -- PGP Fingerprint: BBE1 A1C9 525A 292E 6729 CDEC ADC2 9DCA 5E1C CBCA

1 0

(ITS#8708) SASL EXTERNAL binds and sasl-secprops minssf
by dhawes＠gmail.com 08 Aug '17

08 Aug '17

Full_Name: David Hawes Version: 2.4.45 OS: Linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (2001:468:c80:2103:0:523:da5e:da5e) With ITS #8568 [1], I notice that the first SASL EXTERNAL (using TLS client auth) bind on a connection succeeds, but subsequent SASL EXTERNAL binds on the same connection fail with: slapd[31088]: conn=1009 op=3 RESULT tag=97 err=48 text=SASL(-15): mechanism too weak for this user: mech EXTERNAL is too weak when: sasl-secprops minssf=128 In previous OpenLDAP versions, both the initial and subsequent SASL EXTERNAL binds succeed due to the bug in #8568. This was a misconfiguration on my part (I should have kept the default of 0), but I wonder if the initial SASL bind should also fail. It seems to succeed because tls_ssf is used in connection.c: slap_sasl_external( c, c->c_tls_ssf, &authid ); [1] http://www.openldap.org/its/index.cgi/Software%20Bugs?id=8568;selectid=8568

1 0

Re: (ITS#8707) slapd: Add systemd service notification support
by ryan＠nardis.ca 08 Aug '17

08 Aug '17

On Tue, Aug 08, 2017 at 03:10:35PM +0900, SATOH Fumiyasu wrote: >My slapd.service file: > >[Unit] >Description=OpenLDAP Server >After=syslog.target network-online.target >Documentation=man:slapd >Documentation=man:slapd.conf >Documentation=man:slapd-config >Documentation=man:slapd-bdb >Documentation=man:slapd-hdb >Documentation=man:slapd-mdb > >[Service] >Type=notify >ExecStart=%LIBEXECDIR%/slapd -d 0 -h "ldapi:/// ldap:///" > >[Install] >WantedBy=multi-user.target > >Any comment? No comment, looks good to me. :)

1 0

Re: (ITS#8707) slapd: Add systemd service notification support
by fumiyas＠osstech.co.jp 08 Aug '17

08 Aug '17

Hi, Sorry, I'm not good at English. :-) On Tue, 08 Aug 2017 05:12:02 +0900, Ryan Tandy wrote: > > I guess MAINPID= is actually needed, unless we run slapd with -d, regardless of > > whether we set Type=forking or Type=notify. Not exactly "needed", but better to > > have it than not. > > I experimented a bit with a service file. It seems to work well with either Type=forking and NotifyAccess=all, or Type=notify and ExecStart=slapd -d none. The latter (disabling forking) is definitely what systemd upstream recommends. I think so too. I don't like forking, thus I use "Type=notify" and "ExecStart=slapd -d0 ..." in my slapd.service file. > In either case, MAINPID= didn't actually seem to help anything. Yes. > NotifyAccess=main has a chicken-and-egg problem, because systemd needs to know the main PID in order for us to send it the message containing the PID! :) I think the only reasonable way to leave forking enabled would be to also require a PIDFile= setting, which solves that problem. But I'd rather sidestep the entire thing, omit MAINPID= as well, and > Looking at the systemctl output I still think STATUS= is redundant and could be omitted. > > So I guess my recommendation for the notify call boils down to: > > rc = sd_notify( 1, "READY=1" ); Agreed. I'll fix servers/slapd/daemon.c later. Thank you. > and a slapd.service along the lines of: > > [Unit] > Description=OpenLDAP server > > [Service] > Type=notify > ExecStart=%LIBEXECDIR%/slapd -h 'ldap:/// ldapi:///' -d0 > > [Install] > WantedBy=multi-user.target > > (basically identical to the example in systemd.service(5).) My slapd.service file: [Unit] Description=OpenLDAP Server After=syslog.target network-online.target Documentation=man:slapd Documentation=man:slapd.conf Documentation=man:slapd-config Documentation=man:slapd-bdb Documentation=man:slapd-hdb Documentation=man:slapd-mdb [Service] Type=notify ExecStart=%LIBEXECDIR%/slapd -d 0 -h "ldapi:/// ldap:///" [Install] WantedBy=multi-user.target Any comment? -- -- Name: SATOH Fumiyasu @ OSS Technology Corp. (fumiyas @ osstech co jp) -- Business Home: http://www.OSSTech.co.jp/ -- GitHub Home: https://GitHub.com/fumiyas/ -- PGP Fingerprint: BBE1 A1C9 525A 292E 6729 CDEC ADC2 9DCA 5E1C CBCA

1 0

Re: (ITS#8707) slapd: Add systemd service notification support
by ryan＠nardis.ca 07 Aug '17

07 Aug '17

On Mon, Aug 07, 2017 at 01:12:02PM -0700, Ryan Tandy wrote: >Side note: the version message from slapd appears in the journal >twice, once with the timestamp and once without... not sure exactly >why! Sorry, meant to delete this paragraph before sending. The difference between "-dnone" and "-d0" is precisely an extra log to stderr :)

1 0

Re: (ITS#8707) slapd: Add systemd service notification support
by ryan＠nardis.ca 07 Aug '17

07 Aug '17

On Mon, Aug 07, 2017 at 12:23:27PM -0700, Ryan Tandy wrote: >I guess MAINPID= is actually needed, unless we run slapd with -d, regardless of >whether we set Type=forking or Type=notify. Not exactly "needed", but better to >have it than not. I experimented a bit with a service file. It seems to work well with either Type=forking and NotifyAccess=all, or Type=notify and ExecStart=slapd -d none. The latter (disabling forking) is definitely what systemd upstream recommends. In either case, MAINPID= didn't actually seem to help anything. NotifyAccess=main has a chicken-and-egg problem, because systemd needs to know the main PID in order for us to send it the message containing the PID! :) I think the only reasonable way to leave forking enabled would be to also require a PIDFile= setting, which solves that problem. But I'd rather sidestep the entire thing, omit MAINPID= as well, and Looking at the systemctl output I still think STATUS= is redundant and could be omitted. So I guess my recommendation for the notify call boils down to: rc = sd_notify( 1, "READY=1" ); and a slapd.service along the lines of: [Unit] Description=OpenLDAP server [Service] Type=notify ExecStart=%LIBEXECDIR%/slapd -h 'ldap:/// ldapi:///' -d0 [Install] WantedBy=multi-user.target (basically identical to the example in systemd.service(5).) Side note: the version message from slapd appears in the journal twice, once with the timestamp and once without... not sure exactly why!

1 0

Re: (ITS#8707) slapd: Add systemd service notification support
by ryan＠nardis.ca 07 Aug '17

07 Aug '17

On Mon, Aug 07, 2017 at 01:30:44PM +0000, fumiyas(a)osstech.co.jp wrote: >I've created patches for slapd to add systemd service notification >(sd_notify(3)) support. Thanks for working on this! I'm also interested in having this feature. What do you think about including a slapd.service file? I know OpenLDAP has traditionally not included an init script, but systemd units are intended to be distro-agnostic as far as possible, and shipped by upstream projects in most cases, unlike init scripts. Ideally I'd like to include a template in the source and have the build system fill in the autoconf'ed path (i.e. to slapd) and have 'make install' install it to the right place. Autoconf bits look fine to me. >+ rc = sd_notifyf( 1, >+ "READY=1\n" >+ "STATUS=slapd: ready to serve connections...\n" >+ "MAINPID=%lu", >+ (unsigned long) getpid() ); unset_environment=1 seems reasonable, it's a little unfortunate that we can't call (for example) sd_notify("STOPPING=1") afterward, but it feels worthwhile compared to having to sanitize the environment when forking a child process. I'm not sure the STATUS= message adds value compared to just the basic readiness notification; can you comment on why you included it? I guess MAINPID= is actually needed, unless we run slapd with -d, regardless of whether we set Type=forking or Type=notify. Not exactly "needed", but better to have it than not. I see you've placed this call later than the parent's exit point. Any comments about the timing of this relative to the parent's exit, and to the listener startup and so on? Are the listeners more likely to be ready to serve connections at this point? I seem to recall that in the past there was opposition to moving the parent's exit later, but I can't remember why. (and I still wish we could do that, and dispense with the ldapsearch-loop hacks...) cheers, Ryan

1 0

(ITS#8707) slapd: Add systemd service notification support
by fumiyas＠osstech.co.jp 07 Aug '17

07 Aug '17

Full_Name: SATOH Fumiyasu Version: master OS: URL: Submission from: (NULL) (118.240.43.13) I've created patches for slapd to add systemd service notification (sd_notify(3)) support. Please see the following URLs: * Patch for master * https://github.com/osstech-jp/openldap/commit/4313f8685ac3365fe71639d378740… * Patch for 2.4.x (OPENLDAP_REL_ENG_2_4) * https://github.com/osstech-jp/openldap/commit/977d4483470d150839714cece64ae…

1 0

Re: (ITS#8706) illogical return from ldap_search_ext_s()
by hyc＠symas.com 05 Aug '17

05 Aug '17

kurt.w.heberlein(a)hpe.com wrote: > Full_Name: Kurt Heberlein > Version: 2.4.40+patches > OS: Debian Wheezy > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (66.168.54.228) > > > Using simple binding with TLS, i have a successfully bound (authenticated) user, > and using the same LDAP*, i experience intermittent failures attempting to > retrieve the user's memberOf list. The failure manifests itself as a return > from ldap_search_ext_s() with a return code of LDAP_SUCCESS but a NULL results > pointer. > > Most of the time this call correctly returns the list of groups the user is a > member of, but intermittently it returns a NULL list even though the return code > is LDAP_SUCCESS. There is no other error indication. What am i missing? Read RFC 4511. The ITS is for bug reports, not technical questions. There's no bug here. Closing this ITS. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8706) illogical return from ldap_search_ext_s()
by kurt.w.heberlein＠hpe.com 04 Aug '17

04 Aug '17

Full_Name: Kurt Heberlein Version: 2.4.40+patches OS: Debian Wheezy URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (66.168.54.228) Using simple binding with TLS, i have a successfully bound (authenticated) user, and using the same LDAP*, i experience intermittent failures attempting to retrieve the user's memberOf list. The failure manifests itself as a return from ldap_search_ext_s() with a return code of LDAP_SUCCESS but a NULL results pointer. Most of the time this call correctly returns the list of groups the user is a member of, but intermittently it returns a NULL list even though the return code is LDAP_SUCCESS. There is no other error indication. What am i missing? The call looks like this: ret = ldap_search_ext_s(lp, base, scope, filter, attrs, 0, NULL, NULL, NULL, -1, &res); if(ret != LDAP_SUCCESS) { ... } else { assert(res != NULL); for(msg = ldap_first_message(lp, res); msg != NULL; msg = ldap_next_message(lp, msg)) { ... Where lp is the LDAP* pointer of for the successful bind of user base = "DC=EMEA,DC=AD,DC=SOMECOMPANY,DC=COM" scope = LDAP_SCOPE_SUBTREE filter = "(&(objectClass=user)(sAMAccountName=someusername))" attrs = attrs[0] = "memberOf" attrs[0] = NULL i dont find any documentation that indicates that res could be NULL after LDAP_SUCCESS is returned from the search. Thanks

1 0

Re: (ITS#8690) syncprov memory leak
by quanah＠symas.com 04 Aug '17

04 Aug '17

--On Tuesday, August 01, 2017 8:33 PM +0000 quanah(a)symas.com wrote: > With the patch applied, test019 sporadically segfaults after doing a > delete op on an entry. Took me 12/50 iterations with back-mdb, 2/50 > with back-bdb. But just 1/1 on two other occasions, so while it's not > every iteration, it's fairly repeatable. I will work on getting a > backtrace as well. With the current code, test050 sporadically fails (Took me 8/50 iterations): 5983d09b do_syncrep2: rid=012 cookie=rid=012,sid=002,csn=20170804014043.003558Z#000000#003#000000 5983d09b bdb_delete: deleted id=00000018 dn="cn=To be deleted by server 3,dc=example,dc=com" 5983d09b send_ldap_result: conn=-1 op=0 p=0 5983d09b send_ldap_result: err=0 matched="" text="" 5983d09b syncprov_sendresp: to=002, cookie=rid=011,sid=001,csn=20170804014043.003558Z#000000#003#000000 5983d09b => send_search_entry: conn 1012 dn="cn=To be deleted by server 3,dc=example,dc=com" ber_flush2: 175 bytes to sd 26 5983d09b <= send_search_entry: conn 1012 exit. 5983d09b slap_graduate_commit_csn: removing 0x7f93ac113800 20170804014043.003558Z#000000#003#000000 5983d09b syncrepl_entry: rid=013 be_delete cn=To be deleted by server 3,dc=example,dc=com (0) 5983d09b slap_queue_csn: queueing 0x7f93ac107860 20170804014043.003558Z#000000#003#000000 5983d09b bdb_modify: dc=example,dc=com 5983d09b bdb_modify: txn1 id: 8000004e 5983d09b bdb_dn2entry("dc=example,dc=com") 5983d09b bdb_modify: txn2 id: 8000004f 5983d09b bdb_modify_internal: 0x00000001: dc=example,dc=com 5983d09b bdb_modify_internal: replace contextCSN 5983d09b => entry_encode(0x00000001): dc=example,dc=com 5983d09b <= entry_encode(0x00000001): dc=example,dc=com 5983d09b syncprov_sendresp: to=004, cookie=rid=011,sid=001,csn= 5983d09b slap_build_sync_ctrl: ber_flatten2 failed (-1) 5983d09b send_ldap_result: conn=1013 op=1 p=3 5983d09b send_ldap_result: err=80 matched="" text="internal error" 5983d09b send_ldap_response: msgid=2 tag=101 err=80 ber_flush2: 146 bytes to sd 30 5983d09b conn=1013 op=1 SEARCH RESULT tag=101 err=80 duration=-1427710511.244ms nentries=0 text=internal error Aug 3 18:40:43 ub16 kernel: [42374.949965] slapd[30897]: segfault at 8000004e ip 00007f93bccb5cc0 sp 00007f93ba1aaa10 error 4 in libc-2.23.so[7f93bcc67000+1c0000] --Quanah -- Quanah Gibson-Mount Product Architect Symas Corporation Packaged, certified, and supported LDAP solutions powered by OpenLDAP: <http://www.symas.com>

1 0

(ITS#8705) Windows registry key creation incorrect
by quanah＠openldap.org 03 Aug '17

03 Aug '17

Full_Name: Quanah Gibson-Mount Version: 2.4.45 OS: Windows 10 64-bit URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (47.208.148.239) When installing OpenLDAP on windows, it creates a registry key for the Eventlog to map startup/shutdown events. There was an attempt to fix the problem with the key value back in 2003, 6e8adce9d94ffff125d6acce669c35245d73d0df. However, the fix is incorrect. Without 6e8adce9d94ffff125d6acce669c35245d73d0df, the key value is set to (on a 64-bit install): "C:\Program Files\OpenLDAP\slapd.exe service" With 6e8adce9d94ffff125d6acce669c35245d73d0df, the key value is set to (on a 64-bit install): "C:\Program" The value that works is: "C:\Program Files\OpenLDAP\slapd.exe" The goal of 6e8adce9d94ffff125d6acce669c35245d73d0df was to strip of " service", but since it simply parses on a single space, if the install path has a space elsewhere in it, you end up with the incorrect value noted above.

1 0

Re: (ITS#8701) account usability control for password less logins
by benjamin.chang＠oracle.com 02 Aug '17

02 Aug '17

Question about a proposed workaround: Would it be possible to use slapo-ppolicy to set the pwdPolicySubentry attribute for each user to provide the desired 1.3.6.1.4.1.42.2.27.9.5.8 control response (see http://ldapwiki.com/wiki/Account%20Usability%20Request%20Control), i.e., can pwdPolicySubentry be used supply the sub-entry and related operational attributes needed to validate users for password-less logins?

1 0

Re: (ITS#8690) syncprov memory leak
by quanah＠symas.com 01 Aug '17

01 Aug '17

--On Tuesday, July 11, 2017 9:17 PM +0000 quanah(a)symas.com wrote: > --On Tuesday, July 11, 2017 1:25 AM +0000 quanah(a)openldap.org wrote: > >> Full_Name: Quanah Gibson-Mount >> Version: 2.4.45 >> OS: Linux >> URL: ftp://ftp.openldap.org/incoming/ >> Submission from: (NULL) (47.208.148.239) With the patch applied, test019 sporadically segfaults after doing a delete op on an entry. Took me 12/50 iterations with back-mdb, 2/50 with back-bdb. But just 1/1 on two other occasions, so while it's not every iteration, it's fairly repeatable. I will work on getting a backtrace as well. --Quanah -- Quanah Gibson-Mount Product Architect Symas Corporation Packaged, certified, and supported LDAP solutions powered by OpenLDAP: <http://www.symas.com>

1 0

Re: (ITS#8702) SLAPD_MAX_DAEMON_THREADS is too small
by quanah＠symas.com 01 Aug '17

01 Aug '17

--On Friday, July 28, 2017 5:56 PM +0000 hyc(a)openldap.org wrote: > Was benchmarking on an Oracle M8 box with 2048 SPARC VCPUs. With 1024 > slapd threads configured, we needed 64 listener threads and 64 > threadqueues to eliminate slapd bottlenecks, but the current default in > daemon.c only allows up to 16 listener threads. > > It's a #ifndef so easily overridable at compile time, but 16 is probably > too small in this age of processors with more and more cores. It would be nice if instead of something hard coded, it was instead configurable by switching its usage to dynamically allocated arrays. --Quanah -- Quanah Gibson-Mount Product Architect Symas Corporation Packaged, certified, and supported LDAP solutions powered by OpenLDAP: <http://www.symas.com>

1 0

(ITS#8704) LMDB add option to use prev meta page
by hyc＠openldap.org 31 Jul '17

31 Jul '17

Full_Name: Howard Chu Version: LMDB 0.9 OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (83.136.45.220) Submitted by: hyc Generally, running LMDB in NOSYNC mode means all integrity guarantees are gone, in even of a system crash. However, if some other thread runs mdb_env_sync periodically it's possible that the older DB state is still consistent, even if slightly out of date. I have always intended to add an env flag for using the older meta page, to potentially access a DB even after the latest txn snapshot was corrupted. A patch for this has been contributed, although support in the command-line tools still needs to be added.

1 0

Re: (ITS#8703) slapd should create its PID file before dropping privileges
by michael＠orlitzky.com 29 Jul '17

29 Jul '17

The problem scenario looks like the following: 1. I run "/etc/init.d/slapd start" to start the daemon. 2. slapd drops to the "slapd" user. 3. slapd writes its PID file, now owned by the "slapd" user. 4. Someone compromises the daemon, which sits on the open network. 5. The attacker is generally limited in what he can do because the daemon doesn't run as root. However, he can write "1" into the slapd.pid file, and he does. 6. I run "/etc/init.d/slapd stop" to stop the daemon while I investigate the weird behavior resulting from the hack. 7. Oops, the machine reboots, because I killed PID 1.

1 0

Re: (ITS#8703) slapd should create its PID file before dropping privileges
by hyc＠symas.com 29 Jul '17

29 Jul '17

michael(a)orlitzky.com wrote: > Full_Name: Michael Orlitzky > Version: 2.4.45 > OS: Gentoo > URL: > Submission from: (NULL) (98.218.46.55) > > > The slapd daemon should create its PID file before dropping privileges. This > represents a minor security issue; additional factors are needed to make it > exploitable. > > Why? > > The purpose of the PID file is to hold the PID of the running daemon, > so that later it can be stopped, restarted, or otherwise signalled > (many daemons reload their configurations in response to a SIGHUP). > To fulfill that purpose, the contents of the PID file need to be > trustworthy. If the PID file is writable by a non-root user, then he > can replace its contents with the PID of a root process. Not sure this is a valid concern. The uid used to run services should not actually have a valid login shell, and thus should not ever be usable for any purpose other than running the daemon from init. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8703) slapd should create its PID file before dropping privileges
by michael＠orlitzky.com 28 Jul '17

28 Jul '17

Full_Name: Michael Orlitzky Version: 2.4.45 OS: Gentoo URL: Submission from: (NULL) (98.218.46.55) The slapd daemon should create its PID file before dropping privileges. This represents a minor security issue; additional factors are needed to make it exploitable. Why? The purpose of the PID file is to hold the PID of the running daemon, so that later it can be stopped, restarted, or otherwise signalled (many daemons reload their configurations in response to a SIGHUP). To fulfill that purpose, the contents of the PID file need to be trustworthy. If the PID file is writable by a non-root user, then he can replace its contents with the PID of a root process. Afterwards, any attempt to signal the PID contained in the PID file will instead signal a root process chosen by the non-root user (a vulnerability). This is commonly exploitable by init scripts that are run as root and which blindly trust the contents of their PID files. If one daemon flushes its cache in response to SIGUSR2 and another daemon drops all connections in response to SIGUSR2, it is not hard to imagine a denial-of-service by the user of the first daemon against the second.

1 0

(ITS#8702) SLAPD_MAX_DAEMON_THREADS is too small
by hyc＠openldap.org 28 Jul '17

28 Jul '17

Full_Name: Howard Chu Version: HEAD OS: Solaris 11.3 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (31.216.236.133) Submitted by: hyc Was benchmarking on an Oracle M8 box with 2048 SPARC VCPUs. With 1024 slapd threads configured, we needed 64 listener threads and 64 threadqueues to eliminate slapd bottlenecks, but the current default in daemon.c only allows up to 16 listener threads. It's a #ifndef so easily overridable at compile time, but 16 is probably too small in this age of processors with more and more cores.

1 0

(ITS#8701) account usability control for password less logins
by manikya.prabhu.salveru＠oracle.com 27 Jul '17

27 Jul '17

Full_Name: Manikya Version: 2.4.44 OS: Solaris 11.3 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (141.143.213.56) Solaris ldap clients are configured for pam_ldap and requires a control to validate users for password less logins. http://docs.oracle.com/cd/E19253-01/816-4556/schemas-250/index.html >From open-ds documentation. account usability control The account usability control provides a pair of request and response controls that can be used to determine whether a user account may be used for authenticating to the server. The request control has an OID of 1.3.6.1.4.1.42.2.27.9.5.8 and does not include a value. It should only be included in search request messages. The corresponding response control has an OID of 1.3.6.1.4.1.42.2.27.9.5.8 (the same as the request control), and it will be included in any search result entry messages for a search request that includes the account usability request control. The value for the account usability response control is encoded as follows: ACCOUNT_USABLE_RESPONSE ::= CHOICE { is_available [0] INTEGER, -- Seconds before expiration -- is_not_available [1] MORE_INFO } MORE_INFO ::= SEQUENCE { inactive [0] BOOLEAN DEFAULT FALSE, reset [1] BOOLEAN DEFAULT FALSE, expired [2] BOOLEAN DEFAULT_FALSE, remaining_grace [3] INTEGER OPTIONAL, seconds_before_unlock [4] INTEGER OPTIONAL } If the user account is available, then the control will include the number of seconds until the user's password expires, or -1 if password expiration is not enabled. If the user's account is not available, then the control will provide the reason it is unavailable.

1 0

(ITS#8700) Compile error
by papachoco＠gmail.com 27 Jul '17

27 Jul '17

Full_Name: Carlos Sanchez Version: 2.4.45 OS: macOS 10.12.6 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (68.97.40.67) I am getting the error below while compiling openldap 2.4.45 on the latest macOS sierra (10.12.6). I am only setting two configuration options configure-options = --disable-slapd --disable-slurpd Undefined symbols for architecture x86_64: "_ERR_remove_thread_state", referenced from: _tlso_destroy in libldap.a(tls_o.o) ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) make[2]: *** [apitest] Error 1 make[1]: *** [all-common] Error 1 make: *** [all-common] Error 1 openldap_client: Command failed with exit code 2: make

1 0

(ITS#8699) More for cursor_del with DUPSORT
by hyc＠openldap.org 26 Jul '17

26 Jul '17

Full_Name: Howard Chu Version: LMDB 0.9.21 OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (31.216.236.133) Submitted by: hyc When deleting a series of records in a loop using mdb_cursor_get(MDB_NEXT) in a DUPSORT DB, when deleting the last dup of one key, the first dup of the next key gets skipped on the next iteration. This appears to be due to an incomplete fix to ITS#8622

1 0

(ITS#8698) ppolicy: responses from pwdCheckModule discarded when using an extended password modify
by tim＠bishnet.net 26 Jul '17

26 Jul '17

Full_Name: Tim Bishop Version: 2.4.42 OS: Ubuntu 16.04 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (2001:630:340:1141::13) Whilst this issue was discovered on OpenLDAP 2.4.42, the code is unchanged on the latest version, so I believe it is still applicable there. The high-level overview of the problem is that when using the ppolicy overlay with an external pwdCheckModule, and a password is changed using the LDAPv3 Password Modify (RFC 3062) extended operation (ie. ldappasswd), the message returned by the pwdCheckModule is not passed back to the user. All other failure messages generated in ppolicy are returned correctly. I've looked into this and discovered the cause of the problem. We can start by looking at where the message is returned: https://github.com/openldap/openldap/blob/OPENLDAP_REL_ENG_2_4_42/servers/s… The check_password_quality function calls out to the pwdCheckModule which sets txt to point at a malloc'd string. Here we set rs->sr_text to point to that, and make a note to free it later. This is the exception, in all other cases, as can be seen a few lines below, rs->sr_text is set to a static string. Later on, the result is returned to the user: https://github.com/openldap/openldap/blob/OPENLDAP_REL_ENG_2_4_42/servers/s… And then after that, it is free'd. This all works fine for a normal password modify operation. The problem occurs when we wrap this in an extended password modify: https://github.com/openldap/openldap/blob/OPENLDAP_REL_ENG_2_4_42/servers/s… This line is where the call into ppolicy originates (with a few steps in between), and then on line 237 below we see a call to send_ldap_extended (which returns rs->sr_text to the user) that includes a pointer to rs. In cases where rs->sr_text is a static string this is fine, but where we've set it to a response from pwdCheckModule it has at this point been free'd and set to NULL before send_ldap_extended gets a chance to send it. The result is that confusingly the response from pwdCheckModule is returned for non-extended password changes, but not for extended ones. I don't have a fix for this since I'm not familiar enough with the slapd code. But I'd imagine it'd require setting a flag either in rs or op to note when free'ing of rs->sr_text is required, and then move that free call as far out as necessary (back to where rs is created in connection.c?) so that rs->sr_text is always available.

1 0

(ITS#8697) Remove refptr symbols from slapd.def
by quanah＠openldap.org 20 Jul '17

20 Jul '17

Full_Name: Quanah Gibson-Mount Version: 2.4.45 OS: Windows 10 64-bit URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (47.208.148.239) When building OpenLDAP with a newer version of gcc, dlltool now exports a ton of ".refptr.FUNCTION" values out to the slapd.def file. This breaks the build process, as they aren't real functions. This is due to this change to gcc: https://gcc.gnu.org/ml/gcc-patches/2013-03/msg00858.html Fix is simple enough, simply update our sed that we run against slapd.def: quanah@ub16:~/git/openldap/openldap-head/servers/slapd$ git diff . diff --git a/servers/slapd/Makefile.in b/servers/slapd/Makefile.in index 177ad28..0327537 100644 --- a/servers/slapd/Makefile.in +++ b/servers/slapd/Makefile.in @@ -210,7 +210,7 @@ slapd.def: libbackends.a liboverlays.a version.o dlltool --exclude-symbols main,ServiceMain@8 --export-all-symbols \ --output-def $@.tmp $$objs; echo EXPORTS > $@ - $(SED) -e 1,2d -e 's/ @ [0-9][0-9]*//' $@.tmp | sort >> $@ + $(SED) -e 1,2d -e 's/ @ [0-9][0-9]*//' -e '/\.refptr\./d' $@.tmp | sort >> $@ $(RM) $@.tmp symdummy.c: slapd.def

1 0

(ITS#8696) deadlock with 3-way delta-MMR and syncprov-checkpoint
by ryan＠openldap.org 20 Jul '17

20 Jul '17

Full_Name: Ryan Tandy Version: 2.4.45 OS: Debian URL: Submission from: (NULL) (24.68.41.160) Submitted by: ryan This is rather similar to ITS#8429 (the deadlock is at the same location), but not enough for me to be sure it's the same. cat > slapd.conf << EOF include /path/to/core.schema include /path/to/cosine.schema serverid 1 ldap://:9001 serverid 2 ldap://:9002 serverid 3 ldap://:9003 database mdb directory db maxsize 104857600 envflags writemap index objectClass,cn,entryCSN,entryUUID,uid eq suffix dc=example,dc=com rootdn cn=root,dc=example,dc=com rootpw secret access to * by * read sizelimit unlimited syncrepl rid=1 provider="ldap://:9001" searchbase="dc=example,dc=com" type=refreshAndPersist retry="10 +" bindmethod=simple binddn="cn=root,dc=example,dc=com" credentials="secret" syncdata=accesslog logbase="cn=accesslog" logfilter="(&(objectClass=auditWriteObject)(reqResult=0))" syncrepl rid=2 provider="ldap://:9002" searchbase="dc=example,dc=com" type=refreshAndPersist retry="10 +" bindmethod=simple binddn="cn=root,dc=example,dc=com" credentials="secret" syncdata=accesslog logbase="cn=accesslog" logfilter="(&(objectClass=auditWriteObject)(reqResult=0))" syncrepl rid=3 provider="ldap://:9003" searchbase="dc=example,dc=com" type=refreshAndPersist retry="10 +" bindmethod=simple binddn="cn=root,dc=example,dc=com" credentials="secret" syncdata=accesslog logbase="cn=accesslog" logfilter="(&(objectClass=auditWriteObject)(reqResult=0))" mirrormode on overlay syncprov syncprov-checkpoint 10 1 syncprov-reloadhint TRUE overlay accesslog logdb cn=accesslog logops writes logsuccess true logpurge 07+00:00 01+00:00 database mdb directory accesslog maxsize 104857600 envflags writemap index entryCSN,objectClass,reqEnd,reqResult,reqStart eq suffix cn=accesslog access to * by * read sizelimit unlimited overlay syncprov syncprov-nopresent TRUE syncprov-reloadhint TRUE EOF cat > data.ldif << EOF dn: dc=example,dc=com objectClass: domain dn: uid=u0,dc=example,dc=com objectclass: account dn: cn=g0,dc=example,dc=com objectClass: groupOfNames member: EOF Start up all three slapds and get them synced and settled. I also executed no-op modifications on each node to ensure every server had CSNs from all the others. cat > groupmod.ldif << EOF dn: cn=g0,dc=example,dc=com add: member member: uid=u0,dc=example,dc=com dn: cn=g0,dc=example,dc=com delete: member member: uid=u0,dc=example,dc=com EOF Execute the above modification on one node and watch the other two. After a few times, I reliably get one or both nodes hanging. If I disable syncprov-checkpoint, I cannot reproduce the hang. Backtrace from a hung node: Thread 6 (Thread 0x7f77093d0700 (LWP 28817)): #0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185 #1 0x0000560c5a9af3b7 in ldap_pvt_thread_cond_wait (cond=0x560c5b9696c0, mutex=0x560c5b969698) at thr_posix.c:277 #2 0x0000560c5a9add6e in ldap_int_thread_pool_wrapper (xpool=0x560c5b969690) at tpool.c:683 #3 0x00007f7718a4a494 in start_thread (arg=0x7f77093d0700) at pthread_create.c:333 #4 0x00007f771878ca8f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97 Thread 5 (Thread 0x7f7709bd1700 (LWP 28816)): #0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185 #1 0x0000560c5a9af3b7 in ldap_pvt_thread_cond_wait (cond=0x560c5b9696c0, mutex=0x560c5b969698) at thr_posix.c:277 #2 0x0000560c5a9add6e in ldap_int_thread_pool_wrapper (xpool=0x560c5b969690) at tpool.c:683 #3 0x00007f7718a4a494 in start_thread (arg=0x7f7709bd1700) at pthread_create.c:333 #4 0x00007f771878ca8f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97 Thread 4 (Thread 0x7f770a3d2700 (LWP 28815)): #0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185 #1 0x0000560c5a9af3b7 in ldap_pvt_thread_cond_wait (cond=0x560c5b993fc8, mutex=0x560c5b993fa0) at thr_posix.c:277 #2 0x0000560c5a9ac942 in ldap_pvt_thread_rmutex_lock (rmutex=0x560c5b993f68, owner=140149249615616) at rmutex.c:129 #3 0x0000560c5a98bd4c in accesslog_op_mod (op=0x7f770a3d14e0, rs=0x7f770a3d1120) at accesslog.c:1994 #4 0x0000560c5a941763 in overlay_op_walk (op=0x7f770a3d14e0, rs=0x7f770a3d1120, which=op_modify, oi=0x560c5b992a00, on=0x560c5b993d20) at backover.c:661 #5 0x0000560c5a941a50 in over_op_func (op=0x7f770a3d14e0, rs=0x7f770a3d1120, which=op_modify) at backover.c:730 #6 0x0000560c5a941b84 in over_op_modify (op=0x7f770a3d14e0, rs=0x7f770a3d1120) at backover.c:769 #7 0x0000560c5a92ef07 in syncrepl_message_to_op (si=0x560c5b992580, op=0x7f770a3d14e0, msg=0x7f76f4103bd0) at syncrepl.c:2417 #8 0x0000560c5a929f7e in do_syncrep2 (op=0x7f770a3d14e0, si=0x560c5b992580) at syncrepl.c:1014 #9 0x0000560c5a92c160 in do_syncrepl (ctx=0x7f770a3d1c10, arg=0x560c5b992980) at syncrepl.c:1565 #10 0x0000560c5a8b11cd in connection_read_thread (ctx=0x7f770a3d1c10, argv=0xc) at connection.c:1296 #11 0x0000560c5a9ade15 in ldap_int_thread_pool_wrapper (xpool=0x560c5b969690) at tpool.c:696 #12 0x00007f7718a4a494 in start_thread (arg=0x7f770a3d2700) at pthread_create.c:333 #13 0x00007f771878ca8f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97 Thread 3 (Thread 0x7f770abd3700 (LWP 28814)): #0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185 #1 0x0000560c5a9af3b7 in ldap_pvt_thread_cond_wait (cond=0x560c5b9696c0, mutex=0x560c5b969698) at thr_posix.c:277 #2 0x0000560c5a9add6e in ldap_int_thread_pool_wrapper (xpool=0x560c5b969690) at tpool.c:683 #3 0x00007f7718a4a494 in start_thread (arg=0x7f770abd3700) at pthread_create.c:333 #4 0x00007f771878ca8f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97 Thread 2 (Thread 0x7f770b3d4700 (LWP 28813)): #0 0x00007f771878d083 in epoll_wait () at ../sysdeps/unix/syscall-template.S:84 #1 0x0000560c5a8ac6b3 in slapd_daemon_task (ptr=0x560c5bd176e0) at daemon.c:2539 #2 0x00007f7718a4a494 in start_thread (arg=0x7f770b3d4700) at pthread_create.c:333 #3 0x00007f771878ca8f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97 Thread 1 (Thread 0x7f7719293400 (LWP 28812)): #0 0x00007f7718a4b6cd in pthread_join (threadid=140149266401024, thread_return=0x0) at pthread_join.c:90 #1 0x0000560c5a9af2f8 in ldap_pvt_thread_join (thread=140149266401024, thread_return=0x0) at thr_posix.c:197 #2 0x0000560c5a8ad99c in slapd_daemon () at daemon.c:2932 #3 0x0000560c5a88c105 in main (argc=8, argv=0x7ffd119da7b8) at main.c:1017

1 0

(ITS#8695) _sleep is deprecated
by quanah＠openldap.org 20 Jul '17

20 Jul '17

Full_Name: Quanah Gibson-Mount Version: 2.4.45 OS: Windows 10 64-bit URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (47.208.148.239) When building OpenLDAP, we find: C:/msys64/home/build/sold-master/openldap/tests/progs/slapd-read.c: In function 'do_read': C:/msys64/home/build/sold-master/openldap/tests/progs/slapd-read.c:384:11: warning: '_sleep' is deprecated [-Wdeprecated-declarations] sleep( delay ); ^~~~~ In file included from C:/msys64/home/build/sold-master/openldap/include/ac/stdlib.h:26:0, from C:/msys64/home/build/sold-master/openldap/tests/progs/slapd-read.c:24: C:/msys64/mingw64/x86_64-w64-mingw32/include/stdlib.h:613:24: note: declared here _CRTIMP void __cdecl _sleep(unsigned long _Duration) __MINGW_ATTRIB_DEPRECATED; ^~~~~~ This comes from: include/ac/unistd.h The correct function call is Sleep #ifdef _WIN32 #define sleep Sleep #endif should resolve it.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs