openldap-bugs

openldap-bugs@openldap.org

1 participants
21001 discussions

Re[3]: (ITS#9127) memory leak in mdb_entry_decode()
by grapvar＠gmail.com 10 Dec '19

10 Dec '19

Howard Chu, 02 Dec 2019 18:20 MSK: > > Since this is allocated in thread-local memory, there is no actual leak. If so, why does the op->o_tmpfree() exist ? Konstantin Andreev. Konstantin Andreev, 02 Dec 2019 16:57 MSK: > > mdb_entry_decode() leaks allocated [Entry] on error. Here is a fix for the master branch: > > --- a/servers/slapd/back-mdb/id2entry.c > +++ b/servers/slapd/back-mdb/id2entry.c > @@ -1130,8 +1130,12 @@ done: > *e = x; > rc = 0; > > -leave: > +clr_mvc: > if (mvc) > mdb_cursor_close(mvc); > return rc; > +leave: > + /* can't mdb_entry_return() because [Entry *x] init is incomplete */ > + op->o_tmpfree( x, op->o_tmpmemctx ); > + goto clr_mvc; > } > > and for 2.4 branch, if you care: > ...

1 0

(ITS#9136) mdb index degradation failure
by grapvar＠gmail.com 10 Dec '19

10 Dec '19

Full_Name: Konstantin Andreev Version: 2.4.48, git/master/44a7b46/20191203 OS: Solaris 11.3 x64 URL: Submission from: (NULL) (79.135.238.172) When * the number of entries containing particular attr/val, e.g. `o=1', reaches MDB_IDL_DB_MAX+1 ( = 0x10000 = 65536 ), and * this attribute is equality-indexed the index record for this attr/val switches from the enumeration to the range format ( see back-mdb/idl.c`mdb_idl_insert_keys ). The only scenario to switch index record back to the enumeration is as described in the ITS#9135 and probability of this scenario is nearly negligible. So, the switch to the range format is irreversible and permanent. Moreover, this range only widens and, with time, tends to eventually extend to the end of the dit id space. So, the index record for this particular attibute value gradually becomes useless. What makes this issue even worth. Contrast to bdb, the "range" index records are immortal in the mdb: * they offer many-thousand list of search candidates (in terms of mdb_search()) for particular attribute value even if all instances of this value are removed from the dit. * "range" records survive after slapindex * they even survive after dropping/creating an index itself The only way to get rid of the "range" index records and actualize index is to create a new mdb and populate it from the ground up. This has maintainance costs.

1 0

(ITS#9135) mdb index corruption during legitimate delete
by grapvar＠gmail.com 10 Dec '19

10 Dec '19

Full_Name: Konstantin Andreev Version: 2.4.48, git/master/44a7b46/20191203 OS: Solaris 11.3 x64 URL: Submission from: (NULL) (79.135.238.172) Here is a test case. 1) choose an attribute that has an equality index in your dit; 2) for this attribute choose a value that does not (and did not) exist in the dit yet; Let assume you chose [o=1] attr/val pair. 3) add MDB_IDL_DB_MAX+1 ( = 0x10000 = 65536 ) entries having [o=1] attr/val pair. 4) delete last MDB_IDL_DB_MAX-1 of them in the order inverted as compared to the order of addition Now you have two entries having [o=1] attr/val pair. Let assume they are | $ ldapsearch -s sub -b 'ou=T' '(o=1)' o | dn: cn=1,ou=T | o: 1 | | dn: cn=2,ou=T | o: 1 5) delete one of the remaining entries, e.g. cn=2,ou=T Repeat the search: | $ ldapsearch -s sub -b 'ou=T' '(o=1)' o | $ Nope, the remaining entry has been lost from the index forever. But it is still in the dit: | $ ldapsearch -s one -b 'ou=T' '(objectclass=*)' o | dn: cn=1,ou=T | o: 1 | | dn: ou=A,ou=T | ... You need to slapindex to restore `o' index to a valid state, but you may not know you need to repair the index. The probability of this scenario is negligible, because indexed entries never form continuous block of ids of many-thousand length, but the code for this scenario exists and has a bug. Here is a fix for master branch: --- a/servers/slapd/back-mdb/idl.c +++ b/servers/slapd/back-mdb/idl.c @@ -644,12 +644,19 @@ mdb_idl_delete_keys( /* The range has collapsed... */ rc = mdb_cursor_del( cursor, MDB_NODUPDATA ); if ( rc != 0 ) { err = "c_del dup"; goto fail; } + data.mv_size = sizeof(ID); + data.mv_data = & lo2; + rc = mdb_cursor_put( cursor, &key, &data, 0 ); + if ( rc != 0 ) { + err = "c_put enum"; + goto fail; + } } else { /* position on lo */ rc = mdb_cursor_get( cursor, &key, &data, MDB_NEXT_DUP ); if ( id == lo ) data.mv_data = &lo2; else {

1 0

Re: (ITS#8980) Async mode and TLS Non-Blocking Issue
by quanah＠symas.com 05 Dec '19

05 Dec '19

--On Thursday, December 5, 2019 9:27 PM +0000 "Sun, Wei" <Wei.Sun(a)netapp.com> wrote: > It seems to be that on the 2.4.48 release, in file tls2.c, > LDAP_USE_NON_BLOCKING_TLS is tied to LDAP_DEVEL, however, on the main > branch, it is enabled by default? Because it is a 2.5 feature. Regards, Quanah -- Quanah Gibson-Mount Product Architect Symas Corporation Packaged, certified, and supported LDAP solutions powered by OpenLDAP: <http://www.symas.com>

1 0

Re: (ITS#8980) Async mode and TLS Non-Blocking Issue
by Wei.Sun＠netapp.com 05 Dec '19

05 Dec '19

--_000_4B8DDDAECDE04C58897F00FACBF3BB46netappcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGksDQpJIGhhdmUgdHdvIHF1ZXN0aW9ucyBhYm91dCBlbmFibGluZyBMREFQX1VTRV9OT05fQkxP Q0tJTkdfVExTLg0KDQpJIGFtIGhpdHRpbmcgYSBwcm9ibGVtIHdoZW4gSSBydW4gYSB0ZXN0IHRo YXQgZG9lcyBhIGxkYXBzZWFyY2ggdG8gYSBzdG9wcGVkIHNsZGFwZCBzZXJ2ZXIgdG8gc2ltdWxh dGUgYSBjb21tdW5pY2F0aW9uIGVycm9yLCBhbmQgdGhlIGNvbW1hbmQgaHVuZyBiZWNhdXNlIExE QVBfVVNFX05PTl9CTE9DS0lOR19UTFMgaXMgbm90IGVuYWJsZWQuDQoNCkl0IHNlZW1zIHRvIGJl IHRoYXQgb24gdGhlIDIuNC40OCByZWxlYXNlLCBpbiBmaWxlIHRsczIuYywgTERBUF9VU0VfTk9O X0JMT0NLSU5HX1RMUyBpcyB0aWVkIHRvIExEQVBfREVWRUwsIGhvd2V2ZXIsIG9uIHRoZSBtYWlu IGJyYW5jaCwgaXQgaXMgZW5hYmxlZCBieSBkZWZhdWx0Pw0KDQovLyBSZWxlYXNlIDIuNC40OA0K I2lmZGVmIExEQVBfREVWRUwNCiNkZWZpbmUgTERBUF9VU0VfTk9OX0JMT0NLSU5HX1RMUw0KI2Vu ZGlmIC8qIExEQVBfREVWRUwgKi8NCg0KLy8gTWFzdGVyDQojaWZuZGVmIEhBVkVfTU9aTlNTDQoj ZGVmaW5lIExEQVBfVVNFX05PTl9CTE9DS0lOR19UTFMNCiNlbmRpZg0KDQpJcyB0aGlzIGJlY2F1 c2Ugd2UgYXJlIG1pc3NpbmcgdGhlIGNvbW1pdCDigJwxYTcxMmJmMSDigJMgRW5hYmxlIGZlYXR1 cmVzIHRoYXQgd2VyZSBoaWRkZW4gYmVoaW5kIExEQVBfREVWRUzigJ0/IFdhcyB0aGUgaW50ZW50 aW9uIHRvIGVuYWJsZSBMREFQX1VTRV9OT05fQkxPQ0tJTkdfVExTICBieSBkZWZhdWx0Pw0KDQpU aGUgc2Vjb25kIHF1ZXN0aW9uLCB3aGVuIEkgdHJpZWQgdG8gZW5hYmxlIExEQVBfVVNFX05PTl9C TE9DS0lOR19UTFMgdGhyb3VnaCBDRkxBR1MsIEkgYW0gaGl0dGluZyB0aGlzIG90aGVyIGlzc3Vl IG1lbnRpb25lZCBpbiB0aGUgSVRTIzg5ODAsIGluIHRoZSBzZWNvbmQgZml4Lg0KDQotICAgICAg IHJldHVybiBTU0xfY29ubmVjdCggcyApIC0gMTsNCisgICAgICAgaW50IHJjID0gU1NMX2Nvbm5l Y3QoIHMgKSAtIDE7DQorDQorI2lmZGVmIExEQVBfVVNFX05PTl9CTE9DS0lOR19UTFMNCisgICAg ICAgaW50IHNzbGVyciA9IFNTTF9nZXRfZXJyb3IocywgcmMrMSk7DQorICAgICAgIGludCBzb2Nr ZXJyID0gc29ja19lcnJubygpOw0KKw0KKyAgICAgICBpZiAoIHJjIDwgMCApIHsNCisgICAgICAg ICAgICAgIGlmICggc3NsZXJyID09IFNTTF9FUlJPUl9XQU5UX1JFQUQgfHwgc3NsZXJyID09IFNT TF9FUlJPUl9XQU5UX1dSSVRFICkgew0KKyAgICAgICAgICAgICAgICAgICAgICByYyA9IDA7DQor ICAgICAgICAgICAgICB9IGVsc2UgaWYgKCggc3NsZXJyID09IFNTTF9FUlJPUl9TWVNDQUxMICkg JiYNCisgICAgICAgICAgICAgICAgICAgICAgKCBzb2NrZXJyID09IEVBR0FJTiB8fCBzb2NrZXJy ID09IEVOT1RDT05OICkpIHsNCisgICAgICAgICAgICAgICAgICAgICAgcmMgPSAwOw0KKyAgICAg ICAgICAgICAgfQ0KKyAgICAgICB9DQorI2VuZGlmIC8qIExEQVBfVVNFX05PTl9CTE9DS0lOR19U TFMgKi8NCg0KV2hlbiBJIHN0b3BwZWQgdGhlIHNsZGFwZCwgSSBnb3QgU1NMX0VSUk9SX1dBTlRf UkVBRCwocmVzb3VyY2UgdGVtcG9yYXJpbHkgdW5hdmFpbGFibGUpIHdoaWNoIGlzIGV4cGVjdGVk LiBIb3dldmVyIEkgZXhwZWN0IHRoZSBjb25uZWN0aW9uIHRvIGZhaWwsIGFuZCByZXR1cm4gYmFj ayB0byB0aGUgY2FsbGVyLCBhbmQgc3RvcHBlZCBzZWFyY2guIEhvd2V2ZXIsIGR1ZSB0byBhYm92 ZSBjb2RlLCBJdCBpbnN0ZWFkIGdvdCBhIFJDPTAsIHdoaWNoIGlzIGEgc3VjY2Vzcy4gU28gdGhl IGNvZGUga2VwdCBnb2luZyBhbmQgc2VudCB0aGUgaW5pdGlhbCByZXF1ZXN0LiBUaGlzIGxlYWRz IHRvIGFib3V0IGEgMiBtaW51dGVzIGRlbGF5IGluIHJldHVybmluZyBiYWNrIHRvIHRoZSBjYWxs ZXIsIHRoYXQgY2F1c2VzIG15IGFwcGxpY2F0aW9uIHRvIGZhaWwuICBJIGFtIG5vdCBhbiBleHBl cnQgb24gb3BlbmxkYXAsIGJ1dCBzaG91bGQgYWJvdmUgY29kZSBiZSBjaGFuZ2VkIHRvIHJldHVy biBzb21lIGVycm9yIGluc3RlYWQgb2Ygc3VjY2Vzcz8NCg0KSSBkb27igJl0IGhhdmUgdGhlIHBy b2JsZW0gaW4gdGhlIG1hc3RlciBicmFuY2gsIHNpbmNlIHRoaXMgcGFydCBvZiB0aGUgY29kZSBp cyBub3QgZW5hYmxlZCBpbiB0bHNfby5jLg0KDQpUaGFua3MgZm9yIHlvdXIgYXR0ZW50aW9uIQ0K DQpXZWkNCg0K --_000_4B8DDDAECDE04C58897F00FACBF3BB46netappcom_ Content-Type: text/html; charset="utf-8" Content-ID: <B36A38E291A95144874A650A7555D2AA(a)namprd06.prod.outlook.com> Content-Transfer-Encoding: base64 PGh0bWwgeG1sbnM6bz0idXJuOnNjaGVtYXMtbWljcm9zb2Z0LWNvbTpvZmZpY2U6b2ZmaWNlIiB4 bWxuczp3PSJ1cm46c2NoZW1hcy1taWNyb3NvZnQtY29tOm9mZmljZTp3b3JkIiB4bWxuczptPSJo dHRwOi8vc2NoZW1hcy5taWNyb3NvZnQuY29tL29mZmljZS8yMDA0LzEyL29tbWwiIHhtbG5zPSJo dHRwOi8vd3d3LnczLm9yZy9UUi9SRUMtaHRtbDQwIj4NCjxoZWFkPg0KPG1ldGEgaHR0cC1lcXVp dj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9dXRmLTgiPg0KPG1l dGEgbmFtZT0iR2VuZXJhdG9yIiBjb250ZW50PSJNaWNyb3NvZnQgV29yZCAxNSAoZmlsdGVyZWQg bWVkaXVtKSI+DQo8c3R5bGU+PCEtLQ0KLyogRm9udCBEZWZpbml0aW9ucyAqLw0KQGZvbnQtZmFj ZQ0KCXtmb250LWZhbWlseToiQ2FtYnJpYSBNYXRoIjsNCglwYW5vc2UtMToyIDQgNSAzIDUgNCA2 IDMgMiA0O30NCkBmb250LWZhY2UNCgl7Zm9udC1mYW1pbHk6RGVuZ1hpYW47DQoJcGFub3NlLTE6 MiAxIDYgMCAzIDEgMSAxIDEgMTt9DQpAZm9udC1mYWNlDQoJe2ZvbnQtZmFtaWx5OkNhbGlicmk7 DQoJcGFub3NlLTE6MiAxNSA1IDIgMiAyIDQgMyAyIDQ7fQ0KQGZvbnQtZmFjZQ0KCXtmb250LWZh bWlseToiXEBEZW5nWGlhbiI7DQoJcGFub3NlLTE6MiAxIDYgMCAzIDEgMSAxIDEgMTt9DQovKiBT dHlsZSBEZWZpbml0aW9ucyAqLw0KcC5Nc29Ob3JtYWwsIGxpLk1zb05vcm1hbCwgZGl2Lk1zb05v cm1hbA0KCXttYXJnaW46MGluOw0KCW1hcmdpbi1ib3R0b206LjAwMDFwdDsNCglmb250LXNpemU6 MTIuMHB0Ow0KCWZvbnQtZmFtaWx5OiJDYWxpYnJpIixzYW5zLXNlcmlmO30NCmE6bGluaywgc3Bh bi5Nc29IeXBlcmxpbmsNCgl7bXNvLXN0eWxlLXByaW9yaXR5Ojk5Ow0KCWNvbG9yOiMwNTYzQzE7 DQoJdGV4dC1kZWNvcmF0aW9uOnVuZGVybGluZTt9DQphOnZpc2l0ZWQsIHNwYW4uTXNvSHlwZXJs aW5rRm9sbG93ZWQNCgl7bXNvLXN0eWxlLXByaW9yaXR5Ojk5Ow0KCWNvbG9yOiM5NTRGNzI7DQoJ dGV4dC1kZWNvcmF0aW9uOnVuZGVybGluZTt9DQpwcmUNCgl7bXNvLXN0eWxlLXByaW9yaXR5Ojk5 Ow0KCW1zby1zdHlsZS1saW5rOiJIVE1MIFByZWZvcm1hdHRlZCBDaGFyIjsNCgltYXJnaW46MGlu Ow0KCW1hcmdpbi1ib3R0b206LjAwMDFwdDsNCglmb250LXNpemU6MTAuMHB0Ow0KCWZvbnQtZmFt aWx5OiJDb3VyaWVyIE5ldyI7fQ0Kc3Bhbi5FbWFpbFN0eWxlMTcNCgl7bXNvLXN0eWxlLXR5cGU6 cGVyc29uYWwtY29tcG9zZTsNCglmb250LWZhbWlseToiQ2FsaWJyaSIsc2Fucy1zZXJpZjsNCglj b2xvcjp3aW5kb3d0ZXh0O30NCnNwYW4uSFRNTFByZWZvcm1hdHRlZENoYXINCgl7bXNvLXN0eWxl LW5hbWU6IkhUTUwgUHJlZm9ybWF0dGVkIENoYXIiOw0KCW1zby1zdHlsZS1wcmlvcml0eTo5OTsN Cgltc28tc3R5bGUtbGluazoiSFRNTCBQcmVmb3JtYXR0ZWQiOw0KCWZvbnQtZmFtaWx5OiJDb3Vy aWVyIE5ldyI7fQ0KLk1zb0NocERlZmF1bHQNCgl7bXNvLXN0eWxlLXR5cGU6ZXhwb3J0LW9ubHk7 DQoJZm9udC1mYW1pbHk6IkNhbGlicmkiLHNhbnMtc2VyaWY7fQ0KQHBhZ2UgV29yZFNlY3Rpb24x DQoJe3NpemU6OC41aW4gMTEuMGluOw0KCW1hcmdpbjoxLjBpbiAxLjBpbiAxLjBpbiAxLjBpbjt9 DQpkaXYuV29yZFNlY3Rpb24xDQoJe3BhZ2U6V29yZFNlY3Rpb24xO30NCi0tPjwvc3R5bGU+DQo8 L2hlYWQ+DQo8Ym9keSBsYW5nPSJFTi1VUyIgbGluaz0iIzA1NjNDMSIgdmxpbms9IiM5NTRGNzIi Pg0KPGRpdiBjbGFzcz0iV29yZFNlY3Rpb24xIj4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPjxzcGFu IHN0eWxlPSJmb250LXNpemU6MTEuMHB0Ij5IaSwgPG86cD48L286cD48L3NwYW4+PC9wPg0KPHAg Y2xhc3M9Ik1zb05vcm1hbCI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMS4wcHQiPkkgaGF2ZSB0 d28gcXVlc3Rpb25zIGFib3V0IGVuYWJsaW5nDQo8L3NwYW4+PHNwYW4gc3R5bGU9ImZvbnQtc2l6 ZToxMC4wcHQ7Zm9udC1mYW1pbHk6JnF1b3Q7Q291cmllciBOZXcmcXVvdDs7Y29sb3I6YmxhY2si PkxEQVBfVVNFX05PTl9CTE9DS0lOR19UTFM8L3NwYW4+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZTox MS4wcHQiPi4NCjxvOnA+PC9vOnA+PC9zcGFuPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPjxz cGFuIHN0eWxlPSJmb250LXNpemU6MTEuMHB0Ij48bzpwPiZuYnNwOzwvbzpwPjwvc3Bhbj48L3A+ DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48c3BhbiBzdHlsZT0iZm9udC1zaXplOjExLjBwdCI+SSBh bSBoaXR0aW5nIGEgcHJvYmxlbSB3aGVuIEkgcnVuIGEgdGVzdCB0aGF0IGRvZXMgYSBsZGFwc2Vh cmNoIHRvIGEgc3RvcHBlZCBzbGRhcGQgc2VydmVyIHRvIHNpbXVsYXRlIGEgY29tbXVuaWNhdGlv biBlcnJvciwgYW5kIHRoZSBjb21tYW5kIGh1bmcgYmVjYXVzZQ0KPC9zcGFuPjxzcGFuIHN0eWxl PSJmb250LXNpemU6MTAuMHB0O2ZvbnQtZmFtaWx5OiZxdW90O0NvdXJpZXIgTmV3JnF1b3Q7O2Nv bG9yOmJsYWNrIj5MREFQX1VTRV9OT05fQkxPQ0tJTkdfVExTPC9zcGFuPjxzcGFuIHN0eWxlPSJm b250LXNpemU6MTEuMHB0Ij4gaXMgbm90IGVuYWJsZWQuPG86cD48L286cD48L3NwYW4+PC9wPg0K PHAgY2xhc3M9Ik1zb05vcm1hbCI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMS4wcHQiPjxvOnA+ Jm5ic3A7PC9vOnA+PC9zcGFuPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPjxzcGFuIHN0eWxl PSJmb250LXNpemU6MTEuMHB0Ij5JdCBzZWVtcyB0byBiZSB0aGF0IG9uIHRoZSAyLjQuNDggcmVs ZWFzZSwgaW4gZmlsZSB0bHMyLmMsIExEQVBfVVNFX05PTl9CTE9DS0lOR19UTFMgaXMgdGllZCB0 byBMREFQX0RFVkVMLCBob3dldmVyLCBvbiB0aGUgbWFpbiBicmFuY2gsIGl0IGlzIGVuYWJsZWQg YnkgZGVmYXVsdD8NCjxvOnA+PC9vOnA+PC9zcGFuPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwi PjxzcGFuIHN0eWxlPSJmb250LXNpemU6MTEuMHB0Ij48bzpwPiZuYnNwOzwvbzpwPjwvc3Bhbj48 L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIiBzdHlsZT0iYmFja2dyb3VuZDp3aGl0ZSI+PHNwYW4g c3R5bGU9ImZvbnQtc2l6ZToxMC4wcHQ7Zm9udC1mYW1pbHk6JnF1b3Q7Q291cmllciBOZXcmcXVv dDs7Y29sb3I6YmxhY2siPi8vIFJlbGVhc2UgMi40LjQ4PG86cD48L286cD48L3NwYW4+PC9wPg0K PHAgY2xhc3M9Ik1zb05vcm1hbCIgc3R5bGU9ImJhY2tncm91bmQ6d2hpdGUiPjxzcGFuIHN0eWxl PSJmb250LXNpemU6MTAuMHB0O2ZvbnQtZmFtaWx5OiZxdW90O0NvdXJpZXIgTmV3JnF1b3Q7O2Nv bG9yOmJsYWNrIj4jaWZkZWYgTERBUF9ERVZFTDxvOnA+PC9vOnA+PC9zcGFuPjwvcD4NCjxwIGNs YXNzPSJNc29Ob3JtYWwiIHN0eWxlPSJiYWNrZ3JvdW5kOndoaXRlIj48c3BhbiBzdHlsZT0iZm9u dC1zaXplOjEwLjBwdDtmb250LWZhbWlseTomcXVvdDtDb3VyaWVyIE5ldyZxdW90Oztjb2xvcjpi bGFjayI+I2RlZmluZSBMREFQX1VTRV9OT05fQkxPQ0tJTkdfVExTPG86cD48L286cD48L3NwYW4+ PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCIgc3R5bGU9ImJhY2tncm91bmQ6d2hpdGUiPjxzcGFu IHN0eWxlPSJmb250LXNpemU6MTAuMHB0O2ZvbnQtZmFtaWx5OiZxdW90O0NvdXJpZXIgTmV3JnF1 b3Q7O2NvbG9yOmJsYWNrIj4jZW5kaWYgLyogTERBUF9ERVZFTCAqLzxvOnA+PC9vOnA+PC9zcGFu PjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiIHN0eWxlPSJiYWNrZ3JvdW5kOndoaXRlIj48c3Bh biBzdHlsZT0iZm9udC1zaXplOjEwLjBwdDtmb250LWZhbWlseTomcXVvdDtDb3VyaWVyIE5ldyZx dW90Oztjb2xvcjpibGFjayI+PG86cD4mbmJzcDs8L286cD48L3NwYW4+PC9wPg0KPHAgY2xhc3M9 Ik1zb05vcm1hbCIgc3R5bGU9ImJhY2tncm91bmQ6d2hpdGUiPjxzcGFuIHN0eWxlPSJmb250LXNp emU6MTAuMHB0O2ZvbnQtZmFtaWx5OiZxdW90O0NvdXJpZXIgTmV3JnF1b3Q7O2NvbG9yOmJsYWNr Ij4vLyBNYXN0ZXI8bzpwPjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIiBz dHlsZT0iYmFja2dyb3VuZDp3aGl0ZSI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMC4wcHQ7Zm9u dC1mYW1pbHk6JnF1b3Q7Q291cmllciBOZXcmcXVvdDs7Y29sb3I6YmxhY2siPiNpZm5kZWYgSEFW RV9NT1pOU1M8bzpwPjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIiBzdHls ZT0iYmFja2dyb3VuZDp3aGl0ZSI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMC4wcHQ7Zm9udC1m YW1pbHk6JnF1b3Q7Q291cmllciBOZXcmcXVvdDs7Y29sb3I6YmxhY2siPiNkZWZpbmUgTERBUF9V U0VfTk9OX0JMT0NLSU5HX1RMUzxvOnA+PC9vOnA+PC9zcGFuPjwvcD4NCjxwIGNsYXNzPSJNc29O b3JtYWwiIHN0eWxlPSJiYWNrZ3JvdW5kOndoaXRlIj48c3BhbiBzdHlsZT0iZm9udC1zaXplOjEw LjBwdDtmb250LWZhbWlseTomcXVvdDtDb3VyaWVyIE5ldyZxdW90Oztjb2xvcjpibGFjayI+I2Vu ZGlmDQo8bzpwPjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48c3BhbiBz dHlsZT0iZm9udC1zaXplOjExLjBwdCI+PG86cD4mbmJzcDs8L286cD48L3NwYW4+PC9wPg0KPHAg Y2xhc3M9Ik1zb05vcm1hbCI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMS4wcHQiPklzIHRoaXMg YmVjYXVzZSB3ZSBhcmUgbWlzc2luZyB0aGUgY29tbWl0IOKAnDFhNzEyYmYxIOKAkyBFbmFibGUg ZmVhdHVyZXMgdGhhdCB3ZXJlIGhpZGRlbiBiZWhpbmQgTERBUF9ERVZFTOKAnT8gV2FzIHRoZSBp bnRlbnRpb24gdG8gZW5hYmxlIExEQVBfVVNFX05PTl9CTE9DS0lOR19UTFMgJm5ic3A7YnkgZGVm YXVsdD88bzpwPjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48c3BhbiBz dHlsZT0iZm9udC1zaXplOjExLjBwdCI+PG86cD4mbmJzcDs8L286cD48L3NwYW4+PC9wPg0KPHAg Y2xhc3M9Ik1zb05vcm1hbCI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMS4wcHQiPlRoZSBzZWNv bmQgcXVlc3Rpb24sIHdoZW4gSSB0cmllZCB0byBlbmFibGUNCjwvc3Bhbj48c3BhbiBzdHlsZT0i Zm9udC1zaXplOjEwLjBwdDtmb250LWZhbWlseTomcXVvdDtDb3VyaWVyIE5ldyZxdW90Oztjb2xv cjpibGFjayI+TERBUF9VU0VfTk9OX0JMT0NLSU5HX1RMUzwvc3Bhbj48c3BhbiBzdHlsZT0iZm9u dC1zaXplOjExLjBwdCI+IHRocm91Z2ggQ0ZMQUdTLCBJIGFtIGhpdHRpbmcgdGhpcyBvdGhlciBp c3N1ZSBtZW50aW9uZWQgaW4gdGhlIElUUyM4OTgwLCBpbiB0aGUgc2Vjb25kIGZpeC48bzpwPjwv bzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48c3BhbiBzdHlsZT0iZm9udC1z aXplOjExLjBwdCI+PG86cD4mbmJzcDs8L286cD48L3NwYW4+PC9wPg0KPHAgY2xhc3M9Ik1zb05v cm1hbCIgc3R5bGU9ImJhY2tncm91bmQ6d2hpdGUiPjxzcGFuIHN0eWxlPSJmb250LXNpemU6MTAu MHB0O2ZvbnQtZmFtaWx5OiZxdW90O0NvdXJpZXIgTmV3JnF1b3Q7O2NvbG9yOmJsYWNrIj4tJm5i c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IHJldHVybiBTU0xfY29ubmVjdCggcyAp IC0gMTs8bzpwPjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIiBzdHlsZT0i YmFja2dyb3VuZDp3aGl0ZSI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMC4wcHQ7Zm9udC1mYW1p bHk6JnF1b3Q7Q291cmllciBOZXcmcXVvdDs7Y29sb3I6YmxhY2siPiYjNDM7Jm5ic3A7Jm5ic3A7 Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IGludCByYyA9IFNTTF9jb25uZWN0KCBzICkgLSAxOzxv OnA+PC9vOnA+PC9zcGFuPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiIHN0eWxlPSJiYWNrZ3Jv dW5kOndoaXRlIj48c3BhbiBzdHlsZT0iZm9udC1zaXplOjEwLjBwdDtmb250LWZhbWlseTomcXVv dDtDb3VyaWVyIE5ldyZxdW90Oztjb2xvcjpibGFjayI+JiM0Mzs8bzpwPjwvbzpwPjwvc3Bhbj48 L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIiBzdHlsZT0iYmFja2dyb3VuZDp3aGl0ZSI+PHNwYW4g c3R5bGU9ImZvbnQtc2l6ZToxMC4wcHQ7Zm9udC1mYW1pbHk6JnF1b3Q7Q291cmllciBOZXcmcXVv dDs7Y29sb3I6YmxhY2siPiYjNDM7I2lmZGVmIExEQVBfVVNFX05PTl9CTE9DS0lOR19UTFM8bzpw PjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIiBzdHlsZT0iYmFja2dyb3Vu ZDp3aGl0ZSI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMC4wcHQ7Zm9udC1mYW1pbHk6JnF1b3Q7 Q291cmllciBOZXcmcXVvdDs7Y29sb3I6YmxhY2siPiYjNDM7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7Jm5ic3A7IGludCBzc2xlcnIgPSBTU0xfZ2V0X2Vycm9yKHMsIHJjJiM0MzsxKTs8 bzpwPjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIiBzdHlsZT0iYmFja2dy b3VuZDp3aGl0ZSI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMC4wcHQ7Zm9udC1mYW1pbHk6JnF1 b3Q7Q291cmllciBOZXcmcXVvdDs7Y29sb3I6YmxhY2siPiYjNDM7Jm5ic3A7Jm5ic3A7Jm5ic3A7 Jm5ic3A7Jm5ic3A7Jm5ic3A7IGludCBzb2NrZXJyID0gc29ja19lcnJubygpOzxvOnA+PC9vOnA+ PC9zcGFuPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiIHN0eWxlPSJiYWNrZ3JvdW5kOndoaXRl Ij48c3BhbiBzdHlsZT0iZm9udC1zaXplOjEwLjBwdDtmb250LWZhbWlseTomcXVvdDtDb3VyaWVy IE5ldyZxdW90Oztjb2xvcjpibGFjayI+JiM0Mzs8bzpwPjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBj bGFzcz0iTXNvTm9ybWFsIiBzdHlsZT0iYmFja2dyb3VuZDp3aGl0ZSI+PHNwYW4gc3R5bGU9ImZv bnQtc2l6ZToxMC4wcHQ7Zm9udC1mYW1pbHk6JnF1b3Q7Q291cmllciBOZXcmcXVvdDs7Y29sb3I6 YmxhY2siPiYjNDM7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IGlmICggcmMg Jmx0OyAwICkgezxvOnA+PC9vOnA+PC9zcGFuPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiIHN0 eWxlPSJiYWNrZ3JvdW5kOndoaXRlIj48c3BhbiBzdHlsZT0iZm9udC1zaXplOjEwLjBwdDtmb250 LWZhbWlseTomcXVvdDtDb3VyaWVyIE5ldyZxdW90Oztjb2xvcjpibGFjayI+JiM0MzsmbmJzcDsm bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz cDsmbmJzcDsmbmJzcDsgaWYgKCBzc2xlcnIgPT0gU1NMX0VSUk9SX1dBTlRfUkVBRCB8fCBzc2xl cnIgPT0gU1NMX0VSUk9SX1dBTlRfV1JJVEUgKSB7PG86cD48L286cD48L3NwYW4+PC9wPg0KPHAg Y2xhc3M9Ik1zb05vcm1hbCIgc3R5bGU9ImJhY2tncm91bmQ6d2hpdGUiPjxzcGFuIHN0eWxlPSJm b250LXNpemU6MTAuMHB0O2ZvbnQtZmFtaWx5OiZxdW90O0NvdXJpZXIgTmV3JnF1b3Q7O2NvbG9y OmJsYWNrIj4mIzQzOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyByYyA9IDA7PG86cD48L286cD48L3NwYW4+PC9wPg0K PHAgY2xhc3M9Ik1zb05vcm1hbCIgc3R5bGU9ImJhY2tncm91bmQ6d2hpdGUiPjxzcGFuIHN0eWxl PSJmb250LXNpemU6MTAuMHB0O2ZvbnQtZmFtaWx5OiZxdW90O0NvdXJpZXIgTmV3JnF1b3Q7O2Nv bG9yOmJsYWNrIj4mIzQzOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyB9IGVsc2UgaWYgKCggc3NsZXJy ID09IFNTTF9FUlJPUl9TWVNDQUxMICkgJmFtcDsmYW1wOzxvOnA+PC9vOnA+PC9zcGFuPjwvcD4N CjxwIGNsYXNzPSJNc29Ob3JtYWwiIHN0eWxlPSJiYWNrZ3JvdW5kOndoaXRlIj48c3BhbiBzdHls ZT0iZm9udC1zaXplOjEwLjBwdDtmb250LWZhbWlseTomcXVvdDtDb3VyaWVyIE5ldyZxdW90Oztj b2xvcjpibGFjayI+JiM0MzsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz cDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsm bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgKCBzb2NrZXJyID09IEVBR0FJTiB8fCBzb2Nr ZXJyID09IEVOT1RDT05OICkpIHs8bzpwPjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNv Tm9ybWFsIiBzdHlsZT0iYmFja2dyb3VuZDp3aGl0ZSI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZTox MC4wcHQ7Zm9udC1mYW1pbHk6JnF1b3Q7Q291cmllciBOZXcmcXVvdDs7Y29sb3I6YmxhY2siPiYj NDM7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7 Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7Jm5ic3A7IHJjID0gMDs8bzpwPjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0i TXNvTm9ybWFsIiBzdHlsZT0iYmFja2dyb3VuZDp3aGl0ZSI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6 ZToxMC4wcHQ7Zm9udC1mYW1pbHk6JnF1b3Q7Q291cmllciBOZXcmcXVvdDs7Y29sb3I6YmxhY2si PiYjNDM7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IH08bzpwPjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBj bGFzcz0iTXNvTm9ybWFsIiBzdHlsZT0iYmFja2dyb3VuZDp3aGl0ZSI+PHNwYW4gc3R5bGU9ImZv bnQtc2l6ZToxMC4wcHQ7Zm9udC1mYW1pbHk6JnF1b3Q7Q291cmllciBOZXcmcXVvdDs7Y29sb3I6 YmxhY2siPiYjNDM7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IH08bzpwPjwv bzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIiBzdHlsZT0iYmFja2dyb3VuZDp3 aGl0ZSI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMC4wcHQ7Zm9udC1mYW1pbHk6JnF1b3Q7Q291 cmllciBOZXcmcXVvdDs7Y29sb3I6YmxhY2siPiYjNDM7I2VuZGlmIC8qIExEQVBfVVNFX05PTl9C TE9DS0lOR19UTFMgKi88bzpwPjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFs Ij48c3BhbiBzdHlsZT0iZm9udC1zaXplOjExLjBwdCI+PG86cD4mbmJzcDs8L286cD48L3NwYW4+ PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMS4wcHQi PldoZW4gSSBzdG9wcGVkIHRoZSBzbGRhcGQsIEkgZ290IFNTTF9FUlJPUl9XQU5UX1JFQUQsKHJl c291cmNlIHRlbXBvcmFyaWx5IHVuYXZhaWxhYmxlKSB3aGljaCBpcyBleHBlY3RlZC4gSG93ZXZl ciBJIGV4cGVjdCB0aGUgY29ubmVjdGlvbiB0byBmYWlsLCBhbmQgcmV0dXJuIGJhY2sgdG8gdGhl IGNhbGxlciwgYW5kIHN0b3BwZWQgc2VhcmNoLiBIb3dldmVyLA0KIGR1ZSB0byBhYm92ZSBjb2Rl LCBJdCBpbnN0ZWFkIGdvdCBhIFJDPTAsIHdoaWNoIGlzIGEgc3VjY2Vzcy4gU28gdGhlIGNvZGUg a2VwdCBnb2luZyBhbmQgc2VudCB0aGUgaW5pdGlhbCByZXF1ZXN0LiBUaGlzIGxlYWRzIHRvIGFi b3V0IGEgMiBtaW51dGVzIGRlbGF5IGluIHJldHVybmluZyBiYWNrIHRvIHRoZSBjYWxsZXIsIHRo YXQgY2F1c2VzIG15IGFwcGxpY2F0aW9uIHRvIGZhaWwuICZuYnNwO0kgYW0gbm90IGFuIGV4cGVy dCBvbiBvcGVubGRhcCwgYnV0DQogc2hvdWxkIGFib3ZlIGNvZGUgYmUgY2hhbmdlZCB0byByZXR1 cm4gc29tZSBlcnJvciBpbnN0ZWFkIG9mIHN1Y2Nlc3M/PG86cD48L286cD48L3NwYW4+PC9wPg0K PHAgY2xhc3M9Ik1zb05vcm1hbCI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMS4wcHQiPjxvOnA+ Jm5ic3A7PC9vOnA+PC9zcGFuPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPjxzcGFuIHN0eWxl PSJmb250LXNpemU6MTEuMHB0Ij5JIGRvbuKAmXQgaGF2ZSB0aGUgcHJvYmxlbSBpbiB0aGUgbWFz dGVyIGJyYW5jaCwgc2luY2UgdGhpcyBwYXJ0IG9mIHRoZSBjb2RlIGlzIG5vdCBlbmFibGVkIGlu IHRsc19vLmMuPG86cD48L286cD48L3NwYW4+PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+PHNw YW4gc3R5bGU9ImZvbnQtc2l6ZToxMS4wcHQiPjxvOnA+Jm5ic3A7PC9vOnA+PC9zcGFuPjwvcD4N CjxwIGNsYXNzPSJNc29Ob3JtYWwiPjxzcGFuIHN0eWxlPSJmb250LXNpemU6MTEuMHB0Ij5UaGFu a3MgZm9yIHlvdXIgYXR0ZW50aW9uITxvOnA+PC9vOnA+PC9zcGFuPjwvcD4NCjxwIGNsYXNzPSJN c29Ob3JtYWwiPjxzcGFuIHN0eWxlPSJmb250LXNpemU6MTEuMHB0Ij48bzpwPiZuYnNwOzwvbzpw Pjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48c3BhbiBzdHlsZT0iZm9udC1zaXpl OjExLjBwdCI+V2VpPG86cD48L286cD48L3NwYW4+PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+ PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMS4wcHQiPjxvOnA+Jm5ic3A7PC9vOnA+PC9zcGFuPjwv cD4NCjwvZGl2Pg0KPC9ib2R5Pg0KPC9odG1sPg0K --_000_4B8DDDAECDE04C58897F00FACBF3BB46netappcom_--

1 0

Re: (ITS#9128) Fix for slapd-mdb start Bus Error in strchrlen
by hyc＠symas.com 04 Dec '19

04 Dec '19

requate(a)univention.de wrote: > Full_Name: Arvid Requate > Version: 2.4.45 > OS: UCS / Debian Linux > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (92.210.162.23) > > > In our CI tests we observed a situation where the slapd-mdb failed to start, > terminating due to a "bus error" and slapcat showed the same behaviour. I turned > out that the data.mdb file had an "Attribute;option" string right at the end of > it and strchrlen tried to access a memory location past the end of the page > while scanning for another ';', see stack trace down below. Thanks for the report, fix applied to master. > > This patch fixed the issue for us: > ========================================================= > Author: Arvid Requate <requate(a)univention.de> > Date: Tue Dec 3 23:33:10 2019 +0100 > > Avoid bus error with slapd-mdb/slapcat > > diff --git a/servers/slapd/ad.c b/servers/slapd/ad.c > index 801f18d34..31a94a725 100644 > --- a/servers/slapd/ad.c > +++ b/servers/slapd/ad.c > @@ -145,7 +145,7 @@ static char *strchrlen( > { > const char *p; > > - for( p=beg; *p && p < end; p++ ) { > + for( p=beg; p < end && *p; p++ ) { > if( *p == ch ) { > *len = p - beg; > return (char *) p; > ========================================================= > > This is the stack trace: > ========================================================= > $ gdb slapcat > bt > #0 0x00005555555d0dc4 in strchrlen (len=<synthetic pointer>, ch=59 ';', > end=0x7fff6bd62000 <error: Cannot access memory at address 0x7fff6bd62000>, > beg=0x7fff6bd61ff5 "entry-de-de"<error: Cannot access memory at address > 0x7fff6bd62000>) at ../../../../servers/slapd/ad.c:148 > #1 slap_bv2ad (bv=bv@entry=0x7fffffffdbe0, ad=ad@entry=0x7fffffffdbb8, > text=text@entry=0x7fffffffdbb0) at ../../../../servers/slapd/ad.c:224 > #2 0x00007fffee70e043 in mdb_ad_read (mdb=mdb@entry=0x555555a58240, > txn=<optimized out>) at ../../../../../servers/slapd/back-mdb/attr.c:573 > #3 0x00007fffee6fe4ad in mdb_db_open (be=0x7fffffffdd90, cr=0x7fffffffdf80) at > ../../../../../servers/slapd/back-mdb/init.c:263 > #4 0x00005555555fa601 in over_db_open (be=<optimized out>, cr=0x7fffffffdf80) > at ../../../../servers/slapd/backover.c:149 > #5 0x000055555559a317 in backend_startup_one (be=be@entry=0x555555a580a0, > cr=cr@entry=0x7fffffffdf80) at ../../../../servers/slapd/backend.c:224 > #6 0x000055555559a4cb in backend_startup (be=be@entry=0x555555a580a0) at > ../../../../servers/slapd/backend.c:278 > #7 0x00005555555bc0e1 in slap_startup (be=0x555555a580a0) at > ../../../../servers/slapd/init.c:219 > #8 0x00005555555ffc84 in slap_tool_init (progname=progname@entry=0x55555561d2c1 > "slapcat", tool=tool@entry=2, argc=<optimized out>, argv=<optimized out>) at > ../../../../servers/slapd/slapcommon.c:908 > #9 0x00005555555fec90 in slapcat (argc=<optimized out>, argv=<optimized out>) > at ../../../../servers/slapd/slapcat.c:53 > #10 0x0000555555570867 in main (argc=1, argv=0x7fffffffe568) at > ../../../../servers/slapd/main.c:410 > ========================================================= > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#9128) Fix for slapd-mdb start Bus Error in strchrlen
by requate＠univention.de 03 Dec '19

03 Dec '19

Full_Name: Arvid Requate Version: 2.4.45 OS: UCS / Debian Linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (92.210.162.23) In our CI tests we observed a situation where the slapd-mdb failed to start, terminating due to a "bus error" and slapcat showed the same behaviour. I turned out that the data.mdb file had an "Attribute;option" string right at the end of it and strchrlen tried to access a memory location past the end of the page while scanning for another ';', see stack trace down below. This patch fixed the issue for us: ========================================================= Author: Arvid Requate <requate(a)univention.de> Date: Tue Dec 3 23:33:10 2019 +0100 Avoid bus error with slapd-mdb/slapcat diff --git a/servers/slapd/ad.c b/servers/slapd/ad.c index 801f18d34..31a94a725 100644 --- a/servers/slapd/ad.c +++ b/servers/slapd/ad.c @@ -145,7 +145,7 @@ static char *strchrlen( { const char *p; - for( p=beg; *p && p < end; p++ ) { + for( p=beg; p < end && *p; p++ ) { if( *p == ch ) { *len = p - beg; return (char *) p; ========================================================= This is the stack trace: ========================================================= $ gdb slapcat bt #0 0x00005555555d0dc4 in strchrlen (len=<synthetic pointer>, ch=59 ';', end=0x7fff6bd62000 <error: Cannot access memory at address 0x7fff6bd62000>, beg=0x7fff6bd61ff5 "entry-de-de"<error: Cannot access memory at address 0x7fff6bd62000>) at ../../../../servers/slapd/ad.c:148 #1 slap_bv2ad (bv=bv@entry=0x7fffffffdbe0, ad=ad@entry=0x7fffffffdbb8, text=text@entry=0x7fffffffdbb0) at ../../../../servers/slapd/ad.c:224 #2 0x00007fffee70e043 in mdb_ad_read (mdb=mdb@entry=0x555555a58240, txn=<optimized out>) at ../../../../../servers/slapd/back-mdb/attr.c:573 #3 0x00007fffee6fe4ad in mdb_db_open (be=0x7fffffffdd90, cr=0x7fffffffdf80) at ../../../../../servers/slapd/back-mdb/init.c:263 #4 0x00005555555fa601 in over_db_open (be=<optimized out>, cr=0x7fffffffdf80) at ../../../../servers/slapd/backover.c:149 #5 0x000055555559a317 in backend_startup_one (be=be@entry=0x555555a580a0, cr=cr@entry=0x7fffffffdf80) at ../../../../servers/slapd/backend.c:224 #6 0x000055555559a4cb in backend_startup (be=be@entry=0x555555a580a0) at ../../../../servers/slapd/backend.c:278 #7 0x00005555555bc0e1 in slap_startup (be=0x555555a580a0) at ../../../../servers/slapd/init.c:219 #8 0x00005555555ffc84 in slap_tool_init (progname=progname@entry=0x55555561d2c1 "slapcat", tool=tool@entry=2, argc=<optimized out>, argv=<optimized out>) at ../../../../servers/slapd/slapcommon.c:908 #9 0x00005555555fec90 in slapcat (argc=<optimized out>, argv=<optimized out>) at ../../../../servers/slapd/slapcat.c:53 #10 0x0000555555570867 in main (argc=1, argv=0x7fffffffe568) at ../../../../servers/slapd/main.c:410 =========================================================

1 0

Re[2]: (ITS#9127) memory leak in mdb_entry_decode()
by grapvar＠gmail.com 02 Dec '19

02 Dec '19

Howard Chu, 02 Dec 2019 18:20 MSK: > > Since this is allocated in thread-local memory, there is no actual leak. It is the op->o_tmpalloc() who is thread-local, however, each op->o_tmpalloc() is eventually complimented by op->o_tmpfree(). But not this one. Why the exception? -- Konstantin Andreev. Konstantin Andreev, 02 Dec 2019 16:57 MSK: > > mdb_entry_decode() leaks allocated [Entry] on error. Here is a fix for the master branch: > > --- a/servers/slapd/back-mdb/id2entry.c > +++ b/servers/slapd/back-mdb/id2entry.c > @@ -1130,8 +1130,12 @@ done: > *e = x; > rc = 0; > > -leave: > +clr_mvc: > if (mvc) > mdb_cursor_close(mvc); > return rc; > +leave: > + /* can't mdb_entry_return() because [Entry *x] init is incomplete */ > + op->o_tmpfree( x, op->o_tmpmemctx ); > + goto clr_mvc; > } > > and for 2.4 branch, if you care: > ...

1 0

Re: (ITS#8629) slapauth segfault with GSSAPI + olcAuthzRegexp using internal LDAP search + ppolicy overlay
by ondra＠mistotebe.net 02 Dec '19

02 Dec '19

A fix for this bug has now been committed to master (b71235ac45fcd702f9c7d188dbfd24e611ce1a93) and should be part of 2.4.49. Regards, -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

1 0

Re: (ITS#9127) memory leak in mdb_entry_decode()
by hyc＠symas.com 02 Dec '19

02 Dec '19

grapvar(a)gmail.com wrote: > Full_Name: Konstantin Andreev > Version: 2.4.48 > OS: Solaris 11.3 x64 > URL: > Submission from: (NULL) (79.135.238.172) > > > servers/slapd/back-mdb/id2entry.c`mdb_entry_decode() leaks allocated [Entry] on > error. > Here is a fix for the master branch: Since this is allocated in thread-local memory, there is no actual leak. > --- a/servers/slapd/back-mdb/id2entry.c > +++ b/servers/slapd/back-mdb/id2entry.c > @@ -1130,8 +1130,12 @@ done: > *e = x; > rc = 0; > > -leave: > +clr_mvc: > if (mvc) > mdb_cursor_close(mvc); > return rc; > +leave: > + /* can't mdb_entry_return() because [Entry *x] init is incomplete */ > + op->o_tmpfree( x, op->o_tmpmemctx ); > + goto clr_mvc; > } > > and for 2.4 branch, if you care: > > --- a/servers/slapd/back-mdb/id2entry.c > +++ b/servers/slapd/back-mdb/id2entry.c > @@ -695,12 +695,13 @@ > if (i > mdb->mi_numads) { > rc = mdb_ad_read(mdb, txn); > if (rc) > - return rc; > + goto leave; > if (i > mdb->mi_numads) { > Debug( LDAP_DEBUG_ANY, > "mdb_entry_decode: attribute index %d not recognized\n", > i, 0, 0 ); > - return LDAP_OTHER; > + rc = LDAP_OTHER; > + goto leave; > } > } > a->a_desc = mdb->mi_ads[i]; > @@ -745,7 +746,7 @@ > Debug( LDAP_DEBUG_ANY, > "mdb_entry_decode: attributeType %s value #%d provided more than once\n", > a->a_desc->ad_cname.bv_val, j, 0 ); > - return rc; > + goto leave; > } > } > a->a_next = a+1; > @@ -758,4 +759,8 @@ > 0, 0, 0 ); > *e = x; > return 0; > +leave: > + /* can't mdb_entry_return() because [Entry *x] init is incomplete */ > + op->o_tmpfree( x, op->o_tmpmemctx ); > + return rc; > } > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs