openldap-bugs

openldap-bugs@openldap.org

1 participants
20963 discussions

(ITS#5036) test034-translucent fails on HEAD
by h.b.furuseth＠usit.uio.no 03 Jul '07

03 Jul '07

Full_Name: Hallvard B Furuseth Version: HEAD OS: Linux URL: ftp://ftp.openldap.org/incoming/Hallvard-Furuseth.070703.tgz.1 Submission from: (NULL) (129.240.202.105) Submitted by: hallvard test034-translucent fails. Output: $ ./run test034 Cleaning up test run directory leftover from previous run. Running ./scripts/test034-translucent... running defines.sh == thr_debug: Leaked 1 mutexes. == == thr_debug: Leaked 1 mutexes. == Running slapadd to build remote slapd database... == thr_debug: Leaked 6 mutexes. == Starting remote slapd on TCP/IP port 9011... Starting local slapd on TCP/IP port 9012... Testing slapd Translucent Proxy operations... Testing search: no remote data defined... Populating remote database... Testing search: remote database via local slapd... Testing add: prohibited local record... Testing add: valid local record, no_glue... Testing modrdn: valid local record, no_glue... Dynamically configuring local slapd without translucent_no_glue... modifying entry "olcOverlay={0}translucent,olcDatabase={2}bdb,cn=config" ldap_modify: No such object (32) matched DN: cn=config ldapmodify of dynamic config failed (32) Enclosing logs from testrun directory. Configuration: --disable-dynamic --enable-crypt --enable-lmpasswd --enable-spasswd --enable-rlookups --enable-slapi --enable-wrappers --disable-backends --enable-bdb --enable-ldap --enable-relay --enable-null --enable-meta --enable-overlays CC=gcc-4.2.0 'CPPFLAGS=-DLDAP_DEPRECATED -DLDAP_THREAD_DEBUG -DLDAP_RDWR_DEBUG'

1 0

Re: (ITS#4943) tpool.c pause vs. finish
by h.b.furuseth＠usit.uio.no 03 Jul '07

03 Jul '07

Cut&paste errors... h.b.furuseth(a)usit.uio.no writes: > I forgot keys must be pointers. s/keys/thread-specific data/ > So ldap_pvt_thread_unique_id() would > malloc it if not already set, and fill in with the incremented pointers. s/incremented pointers/incremented counter/.

1 0

Re: (ITS#4943) tpool.c pause vs. finish
by h.b.furuseth＠usit.uio.no 03 Jul '07

03 Jul '07

h.b.furuseth(a)usit.uio.no writes: > Oh, and make max_pending 0 or greater, since > negative numbers confuse pool_query(). I'll do that one, since it fixes a bug and removes no functionality. (And I forgot a few others, e.g. swapkey() function I mentioned earlier, but guess I'd prefer to stick to single-file changes for now.) >> OK, suppose we use a pthread thread-specific key here. What are you >> proposing for the unique value? > > An unsigned long counter, maintained by libldap_r. If the thread-local > variable is zero (thus uninitialized), increment the counter and grab > its value. I forgot keys must be pointers. So ldap_pvt_thread_unique_id() would malloc it if not already set, and fill in with the incremented pointers. For pool threads that'd not be necessary: The thread-local could hold the pointer to the thread context, and the thread could have unique ID (thread_context - thread_keys + 1). The "+1" in case others think thread ID 0 means no thread, like tpool thought recently. The comp.programming.threads question took off in an unexpected direction, so I'm not holding my breath about answers to DCE threads and the like. OS/390 threads - a quick google does seem to indicate that OS/400 threads (and thus presumably OS/390) resemble DCE threads. At least they have a pthread_getunique_np() function, and possibly "field1-3". -- Regards, Hallvard

1 0

Re: (ITS#5027) loglevel if none specified
by ando＠sys-net.it 03 Jul '07

03 Jul '07

steve(a)stevenwills.com wrote: > a great deal of logging is done. This seems inconsistent. Either the docs or the > code are incorrect. Which is right? The man page is incorrect. By default, loglevel is stats. Fixed in HEAD/re23. Thanks, p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it --------------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Email: pierangelo.masarati(a)sys-net.it ---------------------------------------

1 0

Re: (ITS#5032) cannot build on x86_64, needs newer libtool
by bgmilne＠staff.telkomsa.net 02 Jul '07

02 Jul '07

--nextPart2297483.Rso0kROPCI Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Saturday, 30 June 2007, h.b.furuseth(a)usit.uio.no wrote: > Full_Name: Hallvard B Furuseth > Version: RE23, HEAD > OS: RedHat Linux/x86_64 > URL: > Submission from: (NULL) (129.240.202.105) > Submitted by: hallvard > > > libtool translates -ldb-4.3 to /usr/lib/libdb-4.3.so, which breaks. > "cc -ldb-4.3" uses /lib64/libdb-4.3.so. Only if the 32bit package is installed (which unfortunately happens by defa= ult=20 e.g. with 'yum install db4-devel' you get both i386 and x86_64). On RHEL5: # rpm -e db4-devel-4.3.29-9.fc6.i386 works around this. Regards, Buchan =2D-=20 Buchan Milne ISP Systems Specialist - Monitoring/Authentication Team Leader B.Eng,RHCE(803004789010797),LPIC-2(LPI000074592) http://en.wikipedia.org/wiki/List_of_Internet_slang_phrases --nextPart2297483.Rso0kROPCI Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQBGiQdQrJK6UGDSBKcRAp3mAKDCZ+E3X5R85vVnxKGKwGmzU8elawCfRSfV dpfd0S1AdPcYJoQOt5UZbxc= =4+i/ -----END PGP SIGNATURE----- --nextPart2297483.Rso0kROPCI--

1 0

Re: (ITS#5032) cannot build on x86_64, needs newer libtool
by h.b.furuseth＠usit.uio.no 02 Jul '07

02 Jul '07

I just forgot to autoconf:-( It works if I use libtool-1.5.24 and run libtoolize --copy --force aclocal autoconf However I'm doing something wrong. With libtool 1.5.22, which OpenLDAP uses now, the build/ltmain.sh and build/config.* I generate don't match the existing ones. Nor aclocal.m4 when I run aclocal, but then I don't know which automake version to use. Is OpenLDAP using a patched libtool? One of the differences is that ltmain.sh contains VERSION=1.5.22-OpenLDAP, while I get VERSION=1.5.22. build/README is outdated, it says we use libtool 1.4.3. -- Regards, Hallvard

1 0

Re: (ITS#4943) tpool.c pause vs. finish
by h.b.furuseth＠usit.uio.no 01 Jul '07

01 Jul '07

hyc(a)symas.com writes: >h.b.furuseth(a)usit.uio.no wrote: >> I wonder if we've been waiting for each other... Anyway, I've committed >> some pending fixes now that HEAD passes all tests for me. I've some >> more cleanup, but if we are close to a freeze I don't know if that means >> I should rush it in or wait until afterwards. > > Cleanup as in tidying the code, or as in fixing functionality? One cleanup (move thread start before queuing task in pool_submit(), one mini functionality: Make thread counts int instead of long, since pool_query() wants that. Oh, and make max_pending 0 or greater, since negative numbers confuse pool_query(). >> Another time when tls.c code loses information is if pointers are wider >> than long, which does happen. (Don't know how it is nowadays, but I >> remember plenty of postings about it some years ago.) > > Probably the OpenSSL API should have used a void * here. Too bad. Yup. I've seen mention it is coming in future version. > OK, suppose we use a pthread thread-specific key here. What are you > proposing for the unique value? An unsigned long counter, maintained by libldap_r. If the thread-local variable is zero (thus uninitialized), increment the counter and grab its value. >>>>> It's really >>>>> not hard. If we were to disallow increasing the number of threads at >>>>> runtime, we could simply allocate a block of thread stacks all at once, >>>>> which would then allow our thread IDs to be simple integers from 0-N. >> >> IIRC disallowing that would fix some other tpool problem too, but I >> don't remember what. > > I'm not really keen on that since I like having the ability to both increase > and decrease the setting dynamically. Me too, the only pro is it makes implementation simpler. >> Which led me to notice that the setstacksize call now _decreases_ the >> stack size on some hosts. I don't suppose that was intentional, so I >> guess it should be >> size_t cursize; >> if( pthread_attr_getstacksize( &attr, &cursize ) >> || cursize < LDAP_PVT_THREAD_STACK_SIZE ) >> pthread_attr_setstacksize( &attr, LDAP_PVT_THREAD_STACK_SIZE ); >> in thr_posix and I don't know what in other thr_* files. A RE24 change >> I guess, since reduces the max number of threads before slapd gets into >> trouble. > > I don't consider this a bug. If someone wants a larger thread stack > they can recompile to get it. Or perhaps we should make it a tunable > variable and add a config keyword for it. OK -- Regards, Hallvard

1 0

Re: (ITS#4943) tpool.c pause vs. finish
by hyc＠symas.com 01 Jul '07

01 Jul '07

h.b.furuseth(a)usit.uio.no wrote: > I wonder if we've been waiting for each other... Anyway, I've committed > some pending fixes now that HEAD passes all tests for me. I've some > more cleanup, but if we are close to a freeze I don't know if that means > I should rush it in or wait until afterwards. Cleanup as in tidying the code, or as in fixing functionality? > >>> We did have code which compared thread IDs with '==' for >>> quite some time. Do you remember if anyone complained, or if the >>> switch to using ldap_pvt_thread_equal() was a "just in case" fix? >> Yes, I needed to use pthread_equal() on OS/390 since their thread type >> was a structure. > > I'm not sure, but I gather that's derived from the DCE threads reference > implementation where pthread_t has three members 'field1', 'field2' and > 'field3'. tls.c can't stuff all of them in a long, so the old one may > not get a unique ID. OTOH DCE has a pthread_getunique_np() call which > uses just the 2nd field as a unique integer thread ID, I expect we could > use that. Except I don't have a host to test such a change on. Dunno > why pthread_equal checks all three fields. I've asked on > comp.programming.threads. I don't remember which version of the spec OS/390 implemented, it was certainly old but it wasn't DCE. Might have been Draft 6 IIRC. > Also I note that the DCE struct will get four padding bytes on a 64-bit > host which aligns the struct at 8*n addresses, and the compiler is not > obliged to preserve these during struct copy. > > On the other hand DCE threads are based on an extremely outdated Posix > draft, so I don't know how relevant it is now. Yes, Draft 4, and I don't know of any systems that still use that exclusively. > Another time when tls.c code loses information is if pointers are wider > than long, which does happen. (Don't know how it is nowadays, but I > remember plenty of postings about it some years ago.) Probably the OpenSSL API should have used a void * here. Too bad. > [Using address of the thread's stack] >>>> That's what the LDAP_PVT_THREAD_STACK_SIZE macro tells you. > > As modified by PTHREAD_STACK_MIN and pthread_attr_getguardsize(). And > slight other variations, apparently. I tried on a few hosts and Solaris > would a few times use some extra space near the stack of a thread or two. > > OTOH we could allocate stack memory ourselves and then use > pthread_attr_setstack() to put the stack just where we want it. > > However this doesn't help tls.c with threads that have been created by > _other_ packages. And the SSL id_callback function apparently has no > way to return failure:-( > > All in all I still like a thread-specific key better - they are the > standard way of doing things like this. We only need it for pthreads > since the other thread types as far as I can tell have integer IDs. OK, suppose we use a pthread thread-specific key here. What are you proposing for the unique value? >>>> It's really >>>> not hard. If we were to disallow increasing the number of threads at >>>> runtime, we could simply allocate a block of thread stacks all at once, >>>> which would then allow our thread IDs to be simple integers from 0-N. > > IIRC disallowing that would fix some other tpool problem too, but I > don't remember what. I'm not really keen on that since I like having the ability to both increase and decrease the setting dynamically. > Which led me to notice that the setstacksize call now _decreases_ the > stack size on some hosts. I don't suppose that was intentional, so I > guess it should be > size_t cursize; > if( pthread_attr_getstacksize( &attr, &cursize ) > || cursize < LDAP_PVT_THREAD_STACK_SIZE ) > pthread_attr_setstacksize( &attr, LDAP_PVT_THREAD_STACK_SIZE ); > in thr_posix and I don't know what in other thr_* files. A RE24 change > I guess, since reduces the max number of threads before slapd gets into > trouble. I don't consider this a bug. If someone wants a larger thread stack they can recompile to get it. Or perhaps we should make it a tunable variable and add a config keyword for it. -- -- Howard Chu Chief Architect, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: Tranlucent Overlay (ITS#4889)
by ghenry＠suretecsystems.com 01 Jul '07

01 Jul '07

<quote who="Hallvard B Furuseth"> > ghenry(a)suretecsystems.com writes: >>> I have time, a manpage fix doesn't require testing:-) I'm just unsure >>> what it should say. Pierangelo's latest message kind of implied that >>> it >>> can be used with older overlays but not newer ones. >>> Should we say which ones? > > Well, yes. Shouldn't suddenly tell people they shouldn't be doing what > they are doing in cases when it's all right. But I don't know which > ones. Ping Pierangelo? > > -- > Hallvard >

1 0

Re: Tranlucent Overlay (ITS#4889)
by h.b.furuseth＠usit.uio.no 01 Jul '07

01 Jul '07

ghenry(a)suretecsystems.com writes: >> I have time, a manpage fix doesn't require testing:-) I'm just unsure >> what it should say. Pierangelo's latest message kind of implied that it >> can be used with older overlays but not newer ones. >> Should we say which ones? Well, yes. Shouldn't suddenly tell people they shouldn't be doing what they are doing in cases when it's all right. But I don't know which ones. -- Hallvard

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs