https://bugs.openldap.org/show_bug.cgi?id=6138
Howard Chu <hyc(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |IN_PROGRESS
Ever confirmed|0 |1
--- Comment #7 from Howard Chu <hyc(a)openldap.org> ---
(In reply to Hallvard Furuseth from comment #0)
> Full_Name: Hallvard B Furuseth
> Version: HEAD
> OS:
> URL:
> Submission from: (NULL) (129.240.6.233)
> Submitted by: hallvard
>
>
> Might make this a tracking issue for Cancel/Abandon problems.
> And/or copy some to separate ITSes, but they all seem interconnected:
>
>
> Cancel(abandoned operation)-requests are not rejected. Thus slapd
> sets o_cancel and turns an active Abandon into a Cancel. Presumably
> that can confuse Cancel/Abandon handlers, like that in Syncprov.
>
> Similarly, Abandon(abandoned/cancelled operation) is not ignored.
> connection_abandon() re-abandons abandoned/cancelled operations too.
Both of the above checks are now uncommented / enabled.
> However Syncprov:RefreshAndPersist abuses op->o_abandon: It sets it to
> mean "Suppress the response. A copy of this operation will send it."
> So if Cancel(op with o_abandon!=0) is fixed to respond protocolError
> "already abandoned", presumably that breaks Cancel(RefreshAndPersist).
>
> I'm not touching it with a flagpole - I don't know syncprov. Help?
syncprov has been changed to use the new SLAPD_ASYNCOP returncode so
it no longer needs to muck with this.
> Overlay retcode does something similar - sends a response and then sets
> o_abandon.
I can't see any reason why this is needed. It's been there since the initial
commit but I'm removing it. Any return code != SLAP_CB_CONTINUE already
prevents the frontend from sending its own response so there's no reason
to set this here.
> Cancel/Abandon can in any case fail by targeting the wrong operation
> though: A connection can have multiple messages with the same IDs when
> the response is sent and the client reuses the message ID, before the
> old operation in slapd can clean up and finish.
>
> syncprov_op_abandon() identifies messages by (connid, msgid). Can
> multiple messages with the same ID break that, or more importantly,
> break what gets sent/written with syncrepl?
Sounds like bad practice in clients, but should still be safe. The messages are
queued in order, so only the first matching message will be abandoned.
Presumably the first incoming abandon request can only refer to the first
queued operation of that ID.
> Anyway, the current code needs an o_abandon value which means "suppress
> response". Or maybe "abandoned, except as far as future Abandon and
> Cancel operations are concerned". Syncprov and Retcode need to handle
> the various possible orderings of Cancel/Abandon vs Suppress, including
> when they forward o_abandon from one operation to another. I haven't
> looked too closely at that code either.
Mooted by use of SLAPD_ASYNCOP returncode.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=5555
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |TEST
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=5555
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|IN_PROGRESS |RESOLVED
--- Comment #18 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
Commits:
• 73e7034d
by andrew.findlay(a)skills-1st.co.uk at 2021-07-26T22:02:55+00:00
ITS#5555 - Correct documentation for SASL AuthzTo Check
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8890
--- Comment #14 from tg(a)debian.org <tg(a)debian.org> ---
The bug is mistitled.
It should be “adapt to 64-bit time_t on systems with 32-bit long”, which has
become a fairly standard setup in the last 15 years and will become even more
so in the next… less than 17 years, I suppose.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8742
--- Comment #3 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
Commits:
• cb5ba678
by Quanah Gibson-Mount at 2021-07-26T16:36:26+00:00
ITS#8742 - More for bringing slapd.conf.5 and slapd-config.5 in sync
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=9593
Issue ID: 9593
Summary: excessive null check in set_chase()
Product: OpenLDAP
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: ---
Component: slapd
Assignee: bugs(a)openldap.org
Reporter: grapvar(a)gmail.com
Target Milestone: ---
Looks like slap_set_join( cp, nset, '|', vals ) can't return null, so return
value at line 411 should be treated like one at line 402:
servers/slapd/sets.c:399, set_chase():
for ( i = 0; !BER_BVISNULL( &set[ i ] ); i++ ) {
vals = gatherer( cp, &set[ i ], desc );
if ( vals != NULL ) {
/*402: */ nset = slap_set_join( cp, nset, '|', vals );
}
}
ber_bvarray_free_x( set, cp->set_op->o_tmpmemctx );
if ( closure ) {
for ( i = 0; !BER_BVISNULL( &nset[ i ] ); i++ ) {
vals = gatherer( cp, &nset[ i ], desc );
if ( vals != NULL ) {
/*411: */ nset = slap_set_join( cp, nset, '|', vals );
if ( nset == NULL ) {
break;
}
}
}
}
diff --git a/servers/slapd/sets.c b/servers/slapd/sets.c
index fc7b72c8b..17a6ec2c1 100644
--- a/servers/slapd/sets.c
+++ b/servers/slapd/sets.c
@@ -409,9 +409,6 @@ set_chase( SLAP_SET_GATHER gatherer,
vals = gatherer( cp, &nset[ i ], desc );
if ( vals != NULL ) {
nset = slap_set_join( cp, nset, '|', vals );
- if ( nset == NULL ) {
- break;
- }
If I'm wrong, return value at line 402 must be checked for null.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8491
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|2.6.0 |2.7.0
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8890
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|2.6.0 |2.7.0
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8498
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|2.6.0 |2.7.0
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8962
--- Comment #4 from smb6620294(a)gmail.com ---
Free Online units Converters Tool & calculator
The free-online-converters.com is a Unit Converter of Light Seconds, Light
Years, Steps, Terameters, areas, currency, density, energy, force, length,
mass, power, pressure, speed, temperature, volume, and bytes. ours provide
purpose only to provide free information. Is it an informative online Tool
enough? In this tool, you can check the equal value of both things like how
many inches in one centimeter, or other value-able units, etc. Ours tries to
provide you to some units conversions like Cable Lengths (International), Cable
Lengths (U.S.), length units Angstroms, Cable Lengths (Imperial), Centimeters,
Chains, Cubits,Decameters,Decimeters,Ells, Fathoms, Feet, Feet (French
measure), Feet (U.S. Survey), Fingers, Fingers (cloth), French,
Furlongs,Gigameters,Hands,Inches,Kilofeet,Kilometers, Leagues, Leagues (land),
Light Days, Light Hours, Light Minutes, Line, Marathons, Megameters, Meters,
Metric Feet, Metric Inches, Metric Miles, Mickeys, Microinches, Micrometers,
Microns, Mil, Miles, Millimeters, Myriameters, Nails (cloth), Nanometers,
Nautical Leagues, Nautical Miles (International), Paces, Palms, Parsecs, Picas,
Picometers, Points (PostScript),Quarters, Rods, Ropes, shaku, smoots, spans
,Twips And Yards.
https://www.free-online-converters.com/blog/what-website-would-i-use-to-mak…https://www.free-online-converters.comhttps://eshoppii.euhttps://free-online-converters.blogspot.comhttps://ar.free-online-converters.comhttps://cs.free-online-converters.com
--
You are receiving this mail because:
You are on the CC list for the issue.