openldap-bugs June 2016

openldap-bugs@openldap.org

29 participants
73 discussions

(ITS#8453) lmdb: fix warning on Apple platforms
by catwell＠archlinux.us 27 Jun '16

27 Jun '16

Full_Name: Pierre Chapuis Version: OS: macOS / iOS URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (90.79.254.46) Apple compilers (and probably others) do not allow calling sprintf with fewer arguments than the format calls for. The warning is: mdb.c:10720:46: warning: data argument not used by format string [-Wformat-extra-args] (int)mr[i].mr_pid, (size_t)mr[i].mr_tid, txnid); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.3.sdk/usr/include/secure/_stdio.h:47:56: note: expanded from macro 'sprintf' __builtin___sprintf_chk (str, 0, __darwin_obsz(str), __VA_ARGS__) ^~~~~~~~~~~ Proposed patch against current LMDB sterer: diff --git a/libraries/liblmdb/mdb.c b/libraries/liblmdb/mdb.c index 79a958b..84afe4f 100644 --- a/libraries/liblmdb/mdb.c +++ b/libraries/liblmdb/mdb.c @@ -10715,9 +10715,13 @@ mdb_reader_list(MDB_env *env, MDB_msg_func *func, void *ctx) for (i=0; i<rdrs; i++) { if (mr[i].mr_pid) { txnid_t txnid = mr[i].mr_txnid; - sprintf(buf, txnid == (txnid_t)-1 ? - "%10d %"Z"x -\n" : "%10d %"Z"x %"Y"u\n", - (int)mr[i].mr_pid, (size_t)mr[i].mr_tid, txnid); + if (txnid == (txnid_t)-1) { + sprintf(buf, "%10d %"Z"x -\n", + (int)mr[i].mr_pid, (size_t)mr[i].mr_tid); + } else { + sprintf(buf, "%10d %"Z"x %"Z"u\n", + (int)mr[i].mr_pid, (size_t)mr[i].mr_tid, txnid); + } if (first) { first = 0; rc = func(" pid thread txnid\n", ctx);

1 0

(ITS#8452) LMDB: mdb_env_copyfd2 can deadlock due to missing mdb_env_cthr_toggle check
by lmb＠cloudflare.com 27 Jun '16

27 Jun '16

Full_Name: Lorenz Bauer Version: git c367c1f69685 OS: OS X URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (2a06:98c0:1000:1200:156f:df88:ee9a:7775) The function mdb_env_copyfd2 with MDB_CP_COMPACT enabled can currently deadlock, since a call to mdb_env_cthr_toggle is not checked. The testcase at https://gist.github.com/lmb/17a528cdadde73fb231a2a1ed84714f7 reproduces this issue as follows: - Use pthread_sigmask to ignore SIGPIPE - Create new pipe - Spawn thread with mdb_env_copyfd2 using MDB_CP_COMPACT - Close read side of the pipe in main thread - Join thread and check rc code On LMDB master the testase e hangs instead of returning EPIPE. The following patch fixes the deadlock, but since I'm not very familiar with the codebase it's likely incorrect. diff --git a/libraries/liblmdb/mdb.c b/libraries/liblmdb/mdb.c index 79a958b..97ff7c7 100644 --- a/libraries/liblmdb/mdb.c +++ b/libraries/liblmdb/mdb.c @@ -9988,11 +9988,15 @@ mdb_env_copyfd1(MDB_env *env, HANDLE fd) rc = mdb_env_cwalk(&my, &txn->mt_dbs[MAIN_DBI].md_root, 0); if (rc == MDB_SUCCESS && my.mc_wlen[my.mc_toggle]) rc = mdb_env_cthr_toggle(&my, 1); - mdb_env_cthr_toggle(&my, -1); + rc = mdb_env_cthr_toggle(&my, -1); + if (rc) + goto done; pthread_mutex_lock(&my.mc_mutex); while(my.mc_new) pthread_cond_wait(&my.mc_cond, &my.mc_mutex); pthread_mutex_uocock(&my.mc_mutex); + +done: THREAD_FINISH(thr); mdb_txn_abort(txn);

1 0

Re: (ITS#8450) race condition in ldap_int_utils_init
by hyc＠symas.com 27 Jun '16

27 Jun '16

doug.leavitt(a)oracle.com wrote: > Full_Name: Doug Leavitt > Version: 2.4.44 > OS: Solaris > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (137.254.4.13) > > > There is a race condition in ldap_int_utils_init that can be triggered when > multiple threads enter ldap_int_utils_init from ldap_init_initialize about the > same time. The done flag gets set immediately, before the various mutexes are > initialized. If thread A sets done, and thread B tests for done==1 before thread > A has completed the mutex inits, thread B can attempt to use an uninitialized > mutex and fail/core dump etc. > > Additionally if judt the done=1 is moved to the bottom of the function thwo > threads can both be initializing the same mutexes multiple times causes other > mayhem. > > The short term workaround for Solaris (THR APIs) is to move setting of done=1 to > after the mutex inits, and to protect the mutex inits using another statically > initialized mutex within ldap_int_utils_init. > I know a similar workaround could be made for POSIX threads and possibly some of > the other supported thread models, but this approach seems kludgely. Static initializers would be the simplest fix, certainly. On Windows we'd have to use something similar to pthread_once() for initialization, instead. > I suspect the correct solution may be to somehow refactor ldap_int_utils_init > out of libldap and into libldap_r in a cleaner multi-platform manner than the > example above. > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8099) Documentation bug with 'tls_cipher(_)suite' option
by ryan＠nardis.ca 24 Jun '16

24 Jun '16

Thanks for that. Fixed in git master.

1 0

Re: (ITS#8099) Documentation bug with 'tls_cipher(_)suite' option
by nightdragon＠gmx.at 24 Jun '16

24 Jun '16

The bug also exists in your doc (http://www.openldap.org/doc/admin24/guide.html) at chapter "5.2.5.8. olcSyncrepl" and "6.2.3.7. syncrepl"

1 0

Re: (ITS#8099) Documentation bug with 'tls_cipher(_)suite' option
by nightdragon＠gmx.at 24 Jun '16

24 Jun '16

This is a multipart message in MIME format. ------=_NextPart_000_0067_01D1CE86.D61EFE70 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit your doc (http://www.openldap.org/doc/admin24/guide.html) at chapter "5.2.5.8. olcSyncrepl" and "6.2.3.7. syncrepl" ------=_NextPart_000_0067_01D1CE86.D61EFE70 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" = xmlns:o=3D"urn:schemas-microsoft-com:office:office" = xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" = xmlns=3D"http://www.w3.org/TR/REC-html40"><head><META = HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; = charset=3Dus-ascii"><meta name=3DGenerator content=3D"Microsoft Word 15 = (filtered medium)"><style></style></head><body lang=3DDE-AT = link=3D"#0563C1" vlink=3D"#954F72"><div class=3DWordSection1><p = class=3DMsoNormal><span lang=3DEN-US>your doc (<a = href=3D"http://www.openldap.org/doc/admin24/guide.html">http://www.openld= ap.org/doc/admin24/guide.html</a>) at chapter „5.2.5.8. = olcSyncrepl“ and „6.2.3.7. = syncrepl“<o:p></o:p></span></p><p class=3DMsoNormal><span = lang=3DEN-US><o:p> </o:p></span></p><p class=3DMsoNormal><span = lang=3DEN-US><o:p> </o:p></span></p></div></body></html> ------=_NextPart_000_0067_01D1CE86.D61EFE70--

1 0

(ITS#8450) race condition in ldap_int_utils_init
by doug.leavitt＠oracle.com 24 Jun '16

24 Jun '16

Full_Name: Doug Leavitt Version: 2.4.44 OS: Solaris URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (137.254.4.13) There is a race condition in ldap_int_utils_init that can be triggered when multiple threads enter ldap_int_utils_init from ldap_init_initialize about the same time. The done flag gets set immediately, before the various mutexes are initialized. If thread A sets done, and thread B tests for done==1 before thread A has completed the mutex inits, thread B can attempt to use an uninitialized mutex and fail/core dump etc. Additionally if judt the done=1 is moved to the bottom of the function thwo threads can both be initializing the same mutexes multiple times causes other mayhem. The short term workaround for Solaris (THR APIs) is to move setting of done=1 to after the mutex inits, and to protect the mutex inits using another statically initialized mutex within ldap_int_utils_init. Example patch: -- util-int.c.~1~ 2016-02-05 17:57:45.000000000 -0600 +++ util-int.c 2016-06-24 13:20:09.793308570 -0500 @@ -89,12 +89,16 @@ # endif # if defined(HAVE_GETHOSTBYADDR_R) && \ (GETHOSTBDDDDR_R_NARGS < 7) || (8 < GETHOSTBYADDR_R_NARGS) /* Don't know how to handle this version, pretend it's not there */ # undef HAVE_GETHOSTBYADDR_R # endif +#if defined( HAVE_THR ) + /* use static mutex to protect mutex initialization */ +static mutex_t ldap_int_utils_init_mutex = DEFAULTMUTEX; +#endif /* HAVE_THR */ #endif /* LDAP_R_COMPILE */ char *ldap_pvt_ctime( const time_t *tp, char *buf ) { #ifdef USE_CTIME_R # if (CTIME_R_NARGS > 3) || (CTIME_R_NARGS < 2) @@69697,15 +701,22 @@ void ldap_int_utils_init( void ) { static int done=0; if (done) return; - done=1; #ifdef LDAP_R_COMPILE +#if defined( HAVE_THR ) + /* use static mutex to protect mutex initialization */ + (void) mutex_lock(&ldap_int_utils_init_mutex); + if (done) { + (void) mutex_unlock(&ldap_int_utils_init_mutex); + return; + } +#endif /* HAVE_THR */ #if !defined( USE_CTIME_R ) && !defined( HAVE_REENTRANT_FUNCTIONS ) ldap_pvt_thread_mutex_init( &ldap_int_ctime_mutex ); #endif #if !defined( USE_GMTIME_R ) && !defined( USE_LOCALTIME_R ) ldap_pvt_thread_mutex_init( &ldap_int_gmtime_mutex ); #endif @@ -715,15 +726,20 @@ ldap_pvt_thread_mutex_init( &ldap_int_gettime_mutex ); #ifdef HAVE_GSSAPI ldap_pvt_thread_mutex_init( &ldap_int_gssapi_mutex ); #endif -#endif /* call other module init functions here... */ + done=1; +#if defined( HAVE_THR ) + /* use static mutex to protect mutex initialization */ + (void) mutex_unlock(&ldap_int_utils_init_mutex); +#endif /* HAVE_THR */ +#endif } #if defined( NEED_COPY_HOSTENT ) # undef NEED_SAFE_REALLOC #define NEED_SAFE_REALLOC I know a similar workaround could be made for POSIX threads and possibly some of the other supported thread models, but this approach seems kludgely. I suspect the correct solution may be to somehow refactor ldap_int_utils_init out of libldap and into libldap_r in a cleaner multi-platform manner than the example above.

1 0

Re: (ITS#8449) slapadd - config file
by quanah＠openldap.org 23 Jun '16

23 Jun '16

--On Thursday, June 23, 2016 10:24 AM +0000 s.gopinath(a)nic.in wrote: > Full_Name: SGopinath > Version: 2.4.44 > OS: Debian 8 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (164.100.167.137) > > > Dear Sir, > > I follow the steps provided in the Admin guide and doing source > installation. > > It compiles well and make install is okay. > > After that when I give > > usr/local/sbin/slapadd -F /usr/local/etc/config=cn -l > /r%r/local/etc/openldap/slapd.ldif > > It says... > 576baa27 invalid config directory /usr/local/etc/config=cn, error 2 > slapadd: bad configuration directory! Use /usr/local/etc/slapd.d. This is a typo that will be fixed with the next release. Generally the ITS system is for reporting bugs, not asking usage questions. In the future, please use openldap-technical(a)openldap.org for these types of questions. --Quanah -- Quanah Gibson-Mount Release and QA Engineer <http://www.openldap.org>

1 0

(ITS#8449) slapadd - config file
by s.gopinath＠nic.in 23 Jun '16

23 Jun '16

Full_Name: SGopinath Version: 2.4.44 OS: Debian 8 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (164.100.167.137) Dear Sir, I follow the steps provided in the Admin guide and doing source installation. It compiles well and make install is okay. After that when I give usr/local/sbin/slapadd -F /usr/local/etc/config=cn -l /r%r/local/etc/openldap/slapd.ldif It says... 576baa27 invalid config directory /usr/local/etc/config=cn, error 2 slapadd: bad configuration directory! Please help. Thanks, S.Gopinath

1 0

Re: (ITS#8447) LMDB: Overwriting values in MDB_DUPSORT databases broken
by h.b.furuseth＠usit.uio.no 22 Jun '16

22 Jun '16

On 21. juni 2016 01:35, hyc(a)symas.com wrote: > This is a misuse of MDB_CURRENT: as documented, the new value is supposed to > be the same size as the existing value. No, that's not what the doc says. "MDB_CURRENT - (...) intended to be used when the new data is the same size as the old. Otherwise it will simply perform a delete of the old record followed by an insert." I think LMDB should check the size, even if you change the doc to match the code rather than the other way around. If you want to avoid error checks, I'd rather avoid EINVAL checks like key==NULL which are easier for the user to check than "old size = new size". -- Hallvard

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs June 2016