--001a113faca2cd5c170535ccd806
Content-Type: text/plain; charset=UTF-8
This is LibreSSL's response.
---------- Forwarded message ---------
From: Bob Beck <beck(a)obtuse.com>
Date: Tue, Jun 21, 2016 at 11:45 AM
Subject: Re: OpenSSL v1.1 API
To: Connor Taffe <cpaynetaffe(a)gmail.com>
Cc: <libressl(a)openbsd.org>
I would say we would plan on it "when we need it" - We will support TLS
1.3 as
it stabilizes, but at this stage I couldn't say when/if particular
OpenSSL'isms
might be supported.
BoringSSL hasn't pulled in X509_NAME_get0_der either yet - so I think we
will
be taking what I would describe as a cautious and selective approach to
new features from OpenSSL - During the same time as we've moved from about
750,000 of code at the fork to about 350,000 - OpenSSL is now over 1,000,000
lines - So we're probably not going to be about wholesale code importing
from OpenSSL - We will be taking things selectively and with a degree
of caution.
Of note - we *do* support a newer API - libtls - which may be more
than fine for most of OpenLDAP's needs:
See
http://man.openbsd.org/OpenBSD-current/man3/tls_init.3
and/or
http://www.openbsd.org/papers/libtls-fsec-2015/
On Mon, Jun 20, 2016 at 09:21:43AM +0000, Connor Taffe wrote:
> Hey,
>
> Does LibreSSL plan to implement the OpenSSL v1.1 API?
>
> I've submitted a patch to OpenLDAP to allow compilation with LibreSSL
> v2.4.1. The patch currently checks if LIBRESSL_VERSION_NUMBER is defined
> and if so uses the fallback code for versions of OpenSSL < 1.1.
>
> The maintainers would like to cap the version on the LibreSSL check if
> implementation of the OpenSSL v1.1 API is planned.
>
> Specifically (to this case) OpenSSL added the SSL_CTX_up_ref function in
> commit c5ebfcab713a82a1d46a51c8c2668c419425b387 in March of this year, and
> added X509_NAME_get0_der in commit
7ab507495b86371756575d606af556b4fd74e27a
> in January of this year.
>
> ---------- Forwarded message ---------
> From: Howard Chu <hyc(a)symas.com>
> Date: Mon, Jun 20, 2016 at 1:38 AM
> Subject: Re: (ITS#8445) LibreSSL v2.4 compile
> To: Connor Taffe <cpaynetaffe(a)gmail.com>, <openldap-its(a)openldap.org>
>
>
> Connor Taffe wrote:
> > Fixed, attached is a patch.
>
> I'm a bit concerned that you're only checking for the existence of
LIBRESSL
> instead of actually comparing the version number. Since the OpenSSL change
> is
> based on their v1.1 API, do you know if/when LibreSSL plans to adopt the
> new API?
>
> > On Sun, Jun 19, 2016 at 8:02 PM Howard Chu <hyc(a)symas.com
> > <mailto:hyc@symas.com>> wrote:
> >
> > cpaynetaffe(a)gmail.com <mailto:cpaynetaffe@gmail.com> wrote:
> > > Full_Name: Connor Taffe
> > > Version: master
> > > OS: Ubuntu devel
> > > URL: ftp://ftp.openldap.org/incoming/
> > > Submission from: (NULL) (50.25.160.41)
> > >
> > >
> > > Compiling against LibreSSL v2.4.1 failed linking with
> SSL_CTX_up_ref and
> > > X509_NAME_get0_der undefined. I added checking if
> > LIBRESSL_VERSION_NUMBER to the
> > > same conditional compilation ifs that are defined for old
versions
> of
> > OpenSSL.
> > >
> > > https://github.com/cptaffe/openldap
> >
> > Please read the Developer Guidelines. I'm not going to pull an
> arbitrary repo
> > to find someone's patch.
> >
> > http://www.openldap.org/devel/contributing.html
> >
> > --
> > -- Howard Chu
> > CTO, Symas Corp. http://www.symas.com
> > Director, Highland Sun http://highlandsun.com/hyc/
> > Chief Architect, OpenLDAP http://www.openldap.org/project/
> >
>
>
> --
> -- Howard Chu
> CTO, Symas Corp. http://www.symas.com
> Director, Highland Sun http://highlandsun.com/hyc/
> Chief Architect, OpenLDAP http://www.openldap.org/project/
--001a113faca2cd5c170535ccd806
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">This is LibreSSL's response.<br><br><div class=3D"gmai=
l_quote"><div dir=3D"ltr">---------- Forwarded message ---------<br>From: B=
ob Beck <<a href=3D"mailto:beck@obtuse.com">beck(a)obtuse.com</a>><br>D=
ate: Tue, Jun 21, 2016 at 11:45 AM<br>Subject: Re: OpenSSL v1.1 API<br>To: =
Connor Taffe <<a href=3D"mailto:cpaynetaffe@gmail.com">cpaynetaffe@gmail=
.com</a>><br>Cc: <<a href=3D"mailto:libressl@openbsd.org">libressl@o=
penbsd.org</a>><br></div><br><br><br>
I would say we would plan on it=C2=A0 "when we need it" - We will=
support TLS 1.3 as<br>
it stabilizes, but at this stage I couldn't say when/if particular Open=
SSL'isms<br>
might be supported.<br>
<br>
BoringSSL hasn't pulled in X509_NAME_get0_der either yet - so I think w=
e will<br>
be taking what I would describe as a cautious and selective approach to<br>
new features from OpenSSL - During the same time as we've moved from ab=
out<br>
750,000 of code at the fork to about 350,000 - OpenSSL is now over 1,000,00=
0<br>
lines - So we're probably not going to be about wholesale code importin=
g<br>
from OpenSSL - We will be taking things selectively and with a degree<br>
of caution.<br>
<br>
Of note - we *do* support a newer API - libtls - which may be more<br>
than fine for most of OpenLDAP's needs:<br>
<br>
See<br>
<a href=3D"http://man.openbsd.org/OpenBSD-current/man3/tls_init.3" rel=3D"n=
oreferrer" target=3D"_blank">http://man.openbsd.org/OpenBSD-current/man3/tl=
s_init.3</a><br>
and/or<br>
<a href=3D"http://www.openbsd.org/papers/libtls-fsec-2015/" rel=3D"noreferr=
er" target=3D"_blank">http://www.openbsd.org/papers/libtls-fsec-2015/</a><b=
r>
<br>
<br>
On Mon, Jun 20, 2016 at 09:21:43AM +0000, Connor Taffe wrote:<br>
> Hey,<br>
><br>
> Does LibreSSL plan to implement the OpenSSL v1.1 API?<br>
><br>
> I've submitted a patch to OpenLDAP to allow compilation with Libre=
SSL<br>
> v2.4.1. The patch currently checks if LIBRESSL_VERSION_NUMBER is defin=
ed<br>
> and if so uses the fallback code for versions of OpenSSL < 1.1.<br>
><br>
> The maintainers would like to cap the version on the LibreSSL check if=
<br>
> implementation of the OpenSSL v1.1 API is planned.<br>
><br>
> Specifically (to this case) OpenSSL added the SSL_CTX_up_ref function =
in<br>
> commit c5ebfcab713a82a1d46a51c8c2668c419425b387 in March of this year,=
and<br>
> added X509_NAME_get0_der in commit 7ab507495b86371756575d606af556b4fd7=
4e27a<br>
> in January of this year.<br>
><br>
> ---------- Forwarded message ---------<br>
> From: Howard Chu <<a href=3D"mailto:hyc@symas.com" target=3D"_blank=
">hyc(a)symas.com</a>><br>
> Date: Mon, Jun 20, 2016 at 1:38 AM<br>
> Subject: Re: (ITS#8445) LibreSSL v2.4 compile<br>
> To: Connor Taffe <<a href=3D"mailto:cpaynetaffe@gmail.com" target=
=3D"_blank">cpaynetaffe(a)gmail.com</a>>, <<a href=3D"mailto:openldap-i=
ts(a)openldap.org" target=3D"_blank">openldap-its(a)openldap.org</a>><br>
><br>
><br>
> Connor Taffe wrote:<br>
> > Fixed, attached is a patch.<br>
><br>
> I'm a bit concerned that you're only checking for the existenc=
e of LIBRESSL<br>
> instead of actually comparing the version number. Since the OpenSSL ch=
ange<br>
> is<br>
> based on their v1.1 API, do you know if/when LibreSSL plans to adopt t=
he<br>
> new API?<br>
><br>
> > On Sun, Jun 19, 2016 at 8:02 PM Howard Chu <<a href=3D"mailto:=
hyc(a)symas.com" target=3D"_blank">hyc(a)symas.com</a><br>
> > <mailto:<a href=3D"mailto:hyc@symas.com" target=3D"_blank">hyc=
@symas.com</a>>> wrote:<br>
> ><br>
> >=C2=A0 =C2=A0 =C2=A0<a href=3D"mailto:cpaynetaffe@gmail.com" targe=
t=3D"_blank">cpaynetaffe(a)gmail.com</a> <mailto:<a href=3D"mailto:cpaynet=
affe(a)gmail.com" target=3D"_blank">cpaynetaffe(a)gmail.com</a>> wrote:<br>
> >=C2=A0 =C2=A0 =C2=A0 > Full_Name: Connor Taffe<br>
> >=C2=A0 =C2=A0 =C2=A0 > Version: master<br>
> >=C2=A0 =C2=A0 =C2=A0 > OS: Ubuntu devel<br>
> >=C2=A0 =C2=A0 =C2=A0 > URL: <a href=3D"ftp://ftp.openldap.org/i=
ncoming/" rel=3D"noreferrer" target=3D"_blank">ftp://ftp.openldap.org/incom=
ing/</a><br>
> >=C2=A0 =C2=A0 =C2=A0 > Submission from: (NULL) (50.25.160.41)<b=
r>
> >=C2=A0 =C2=A0 =C2=A0 ><br>
> >=C2=A0 =C2=A0 =C2=A0 ><br>
> >=C2=A0 =C2=A0 =C2=A0 > Compiling against LibreSSL v2.4.1 failed=
linking with<br>
> SSL_CTX_up_ref and<br>
> >=C2=A0 =C2=A0 =C2=A0 > X509_NAME_get0_der undefined. I added ch=
ecking if<br>
> >=C2=A0 =C2=A0 =C2=A0LIBRESSL_VERSION_NUMBER to the<br>
> >=C2=A0 =C2=A0 =C2=A0 > same conditional compilation ifs that ar=
e defined for old versions<br>
> of<br>
> >=C2=A0 =C2=A0 =C2=A0OpenSSL.<br>
> >=C2=A0 =C2=A0 =C2=A0 ><br>
> >=C2=A0 =C2=A0 =C2=A0 > <a href=3D"https://github.com/cptaffe/op=
enldap" rel=3D"noreferrer" target=3D"_blank">https://github.com/cptaffe/ope=
nldap</a><br>
> ><br>
> >=C2=A0 =C2=A0 =C2=A0Please read the Developer Guidelines. I'm =
not going to pull an<br>
> arbitrary repo<br>
> >=C2=A0 =C2=A0 =C2=A0to find someone's patch.<br>
> ><br>
> >=C2=A0 =C2=A0 =C2=A0<a href=3D"http://www.openldap.org/devel/contr=
ibuting.html" rel=3D"noreferrer" target=3D"_blank">http://www.openldap.org/=
devel/contributing.html</a><br>
> ><br>
> >=C2=A0 =C2=A0 =C2=A0--<br>
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-- Howard Chu<br>
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0CTO, Symas Corp. <a href=3D"http=
://www.symas.com" rel=3D"noreferrer" target=3D"_blank">http://www.symas.com=
</a><br>
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Director, Highland Sun <a href=
=3D"http://highlandsun.com/hyc/" rel=3D"noreferrer" target=3D"_blank">http:=
//highlandsun.com/hyc/</a><br>
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Chief Architect, OpenLDAP <a hre=
f=3D"http://www.openldap.org/project/" rel=3D"noreferrer" target=3D"_blank"=
>http://www.openldap.org/project/</a><br>
> ><br>
><br>
><br>
> --<br>
>=C2=A0 =C2=A0 -- Howard Chu<br>
>=C2=A0 =C2=A0 CTO, Symas Corp.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
<a href=3D"http://www.symas.com" rel=3D"noreferrer" target=3D"_blank">http:=
//www.symas.com</a><br>
>=C2=A0 =C2=A0 Director, Highland Sun=C2=A0 =C2=A0 =C2=A0<a href=3D"http=
://highlandsun.com/hyc/" rel=3D"noreferrer" target=3D"_blank">http://highla=ndsun.com/hyc/</a><br>
>=C2=A0 =C2=A0 Chief Architect, OpenLDAP=C2=A0 <a href=3D"http://www.ope=nldap.org/project/" rel=3D"noreferrer" target=3D"_blank">http://www.openlda=
p.org/project/</a><br>
</div></div>
--001a113faca2cd5c170535ccd806--
lukaswhl(a)gmail.com wrote:
> Full_Name: Lukas W
> Version: mdb.master c367c1f69685a4d307acb8cea6945c1d67e1cc7e
> OS: Linux
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (114.23.231.86)
>
>
> Replacing values in sub-databases (with MDB_DUPSORT) can lead to the new data's
> length being ignored. This specific example reproduces the problem (creating the
> entries "1"->"ABC", and "1"->2a2abc"):
>
> […]
> mdb_dbi_open(txn, NULL, MDB_DUPSORT, &dbi);
> key.mv_size = 2;
> key.mv_data = "1";
> data.mv_size = 4;
> data.mv_data = "ABC";
> mdb_put(txn, dbi, &key, &data, 0);
> data.mv_data = "abc";
> mdb_put(txn, dbi, &key, &data, 0);
>
> If one later tries to change a value of one of the existing entries, the new
> value is being copied, but the size is not changed. This could lead to database
> corruption if the new value is longer than the old one as the length of the new
> value is used in memcpy.
>
> key.mv_ze % = 2;
> key.mv_data = "1";
> data.mv_size = 4;
> data.mv_data = "abc";
> mdb_cursor_get(cursor, &key, &data, MDB_GET_BOTH);
>
> data.mv_size = 2;
> data.mv_data = "Q";
> mdb_cursor_put(cursor, &key, &data, MDB_CURRENT);
This is a misuse of MDB_CURRENT: as documented, the new value is supposed to
be the same size as the existing value.
>
> mdb_cursor_get(cursor, &key, &data, MDB_GET_CURRENT);
> printf("%s (%d)\n", data.mv_size);
>
> This will output "Q (4)", while it should output "Q (2)". Note that the data in
> the DB probably is "Q\0c", printf just stops at the null character.
> The value is written in mdb.c:7516. Context:
>
> […]
> /* same size, just replace it. Note that we could
> * also reuse this node if the new data is smaller,
> * but instead we opt to shrink the node in that case.
> */
> if (F_ISSET(flags, MDB_RESERVE))
> data->mv_data = olddata.mv_data;
> else if (!(mc->mc_flags & C_SUB))
> memcpy(olddata.mv_data, data->mv_data, data->mv_size);
> else {
> 7516: memcpy(NODEKEY(leaf), key->mv_data, key->mv_size);
> goto fix_parent;
> }
> […]
>
>
>
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
Full_Name: Lukas W
Version: mdb.master c367c1f69685a4d307acb8cea6945c1d67e1cc7e
OS: Linux
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (114.23.231.86)
Replacing values in sub-databases (with MDB_DUPSORT) can lead to the new data's
length being ignored. This specific example reproduces the problem (creating the
entries "1"->"ABC", and "1"->2a2abc"):
[ ]
mdb_dbi_open(txn, NULL, MDB_DUPSORT, &dbi);
key.mv_size = 2;
key.mv_data = "1";
data.mv_size = 4;
data.mv_data = "ABC";
mdb_put(txn, dbi, &key, &data, 0);
data.mv_data = "abc";
mdb_put(txn, dbi, &key, &data, 0);
If one later tries to change a value of one of the existing entries, the new
value is being copied, but the size is not changed. This could lead to database
corruption if the new value is longer than the old one as the length of the new
value is used in memcpy.
key.mv_ze % = 2;
key.mv_data = "1";
data.mv_size = 4;
data.mv_data = "abc";
mdb_cursor_get(cursor, &key, &data, MDB_GET_BOTH);
data.mv_size = 2;
data.mv_data = "Q";
mdb_cursor_put(cursor, &key, &data, MDB_CURRENT);
mdb_cursor_get(cursor, &key, &data, MDB_GET_CURRENT);
printf("%s (%d)\n", data.mv_size);
This will output "Q (4)", while it should output "Q (2)". Note that the data in
the DB probably is "Q\0c", printf just stops at the null character.
The value is written in mdb.c:7516. Context:
[ ]
/* same size, just replace it. Note that we could
* also reuse this node if the new data is smaller,
* but instead we opt to shrink the node in that case.
*/
if (F_ISSET(flags, MDB_RESERVE))
data->mv_data = olddata.mv_data;
else if (!(mc->mc_flags & C_SUB))
memcpy(olddata.mv_data, data->mv_data, data->mv_size);
else {
7516: memcpy(NODEKEY(leaf), key->mv_data, key->mv_size);
goto fix_parent;
}
[ ]
Connor Taffe wrote:
> Good point,
>
> I was assuming that LibreSSL was focused on only maintaining compatibility
> with v1.0.1 though, as they've created their own libtls for future programs.
>
> Git grep didn't show anything in the v2.4.1 portable repo.
> The v1.1 API is still in pre-release it looks like, and the relevant functions
> have
> only been in OpenSSL since January and March respectively according to git.
> In fact LibreSSL has had only a handful of commits this year in portable,
> mostly focused on building with cmake and some fixes, but no API additions.
>
> Neither function is available in the -current OpenBSD cvs tree either.
>
> I've emailed libressl(a)openbsd.org <mailto:libressl@openbsd.org> to inquire
> further.
Thanks. In the meantime I think the sane thing to do is just invert the
current #if. Swap the code so it's
#if OPENSSL_VERSION_NUMBER >= 0x01010000
new stuff
#else
old stuff
#endif
then we can ignore this until LibreSSL catches up.
>
> On Mon, Jun 20, 2016 at 1:38 AM Howard Chu <hyc(a)symas.com
> <mailto:hyc@symas.com>> wrote:
>
> Connor Taffe wrote:
> > Fixed, attached is a patch.
>
> I'm a bit concerned that you're only checking for the existence of LIBRESSL
> instead of actually comparing the version number. Since the OpenSSL change is
> based on their v1.1 API, do you know if/when LibreSSL plans to adopt the
> new API?
>
> > On Sun, Jun 19, 2016 at 8:02 PM Howard Chu <hyc(a)symas.com
> <mailto:hyc@symas.com>
> > <mailto:hyc@symas.com <mailto:hyc@symas.com>>> wrote:
> >
> > cpaynetaffe(a)gmail.com <mailto:cpaynetaffe@gmail.com>
> <mailto:cpaynetaffe@gmail.com <mailto:cpaynetaffe@gmail.com>> wrote:
> > > Full_Name: Connor Taffe
> > > Version: master
> > > OS: Ubuntu devel
> > > URL: ftp://ftp.openldap.org/incoming/
> > > Submission from: (NULL) (50.25.160.41)
> > >
> > >
> > > Compiling against LibreSSL v2.4.1 failed linking with
> SSL_CTX_up_ref and
> > > X509_NAME_get0_der undefined. I added checking if
> > LIBRESSL_VERSION_NUMBER to the
> > > same conditional compilation ifs that are defined for old
> versions of
> > OpenSSL.
> > >
> > > https://github.com/cptaffe/openldap
> >
> > Please read the Developer Guidelines. I'm not going to pull an
> arbitrary repo
> > to find someone's patch.
> >
> > http://www.openldap.org/devel/contributing.html
> >
> > --
> > -- Howard Chu
> > CTO, Symas Corp. http://www.symas.com
> > Director, Highland Sun http://highlandsun.com/hyc/
> > Chief Architect, OpenLDAP http://www.openldap.org/project/
> >
>
>
> --
> -- Howard Chu
> CTO, Symas Corp. http://www.symas.com
> Director, Highland Sun http://highlandsun.com/hyc/
> Chief Architect, OpenLDAP http://www.openldap.org/project/
>
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
--001a1147bbbc1ed3a40535b28599
Content-Type: text/plain; charset=UTF-8
Good point,
I was assuming that LibreSSL was focused on only maintaining compatibility
with v1.0.1 though, as they've created their own libtls for future programs.
Git grep didn't show anything in the v2.4.1 portable repo.
The v1.1 API is still in pre-release it looks like, and the relevant
functions have
only been in OpenSSL since January and March respectively according to git.
In fact LibreSSL has had only a handful of commits this year in portable,
mostly focused on building with cmake and some fixes, but no API additions.
Neither function is available in the -current OpenBSD cvs tree either.
I've emailed libressl(a)openbsd.org to inquire further.
On Mon, Jun 20, 2016 at 1:38 AM Howard Chu <hyc(a)symas.com> wrote:
> Connor Taffe wrote:
> > Fixed, attached is a patch.
>
> I'm a bit concerned that you're only checking for the existence of LIBRESSL
> instead of actually comparing the version number. Since the OpenSSL change
> is
> based on their v1.1 API, do you know if/when LibreSSL plans to adopt the
> new API?
>
> > On Sun, Jun 19, 2016 at 8:02 PM Howard Chu <hyc(a)symas.com
> > <mailto:hyc@symas.com>> wrote:
> >
> > cpaynetaffe(a)gmail.com <mailto:cpaynetaffe@gmail.com> wrote:
> > > Full_Name: Connor Taffe
> > > Version: master
> > > OS: Ubuntu devel
> > > URL: ftp://ftp.openldap.org/incoming/
> > > Submission from: (NULL) (50.25.160.41)
> > >
> > >
> > > Compiling against LibreSSL v2.4.1 failed linking with
> SSL_CTX_up_ref and
> > > X509_NAME_get0_der undefined. I added checking if
> > LIBRESSL_VERSION_NUMBER to the
> > > same conditional compilation ifs that are defined for old
> versions of
> > OpenSSL.
> > >
> > > https://github.com/cptaffe/openldap
> >
> > Please read the Developer Guidelines. I'm not going to pull an
> arbitrary repo
> > to find someone's patch.
> >
> > http://www.openldap.org/devel/contributing.html
> >
> > --
> > -- Howard Chu
> > CTO, Symas Corp. http://www.symas.com
> > Director, Highland Sun http://highlandsun.com/hyc/
> > Chief Architect, OpenLDAP http://www.openldap.org/project/
> >
>
>
> --
> -- Howard Chu
> CTO, Symas Corp. http://www.symas.com
> Director, Highland Sun http://highlandsun.com/hyc/
> Chief Architect, OpenLDAP http://www.openldap.org/project/
>
--001a1147bbbc1ed3a40535b28599
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Good point,<div><br></div><div>=C2=A0I was assuming that L=
ibreSSL was focused on only=C2=A0<span style=3D"line-height:1.5">maintainin=
g=C2=A0</span><span style=3D"line-height:1.5">compatibility</span></div><di=
v><span style=3D"line-height:1.5">with v1.0.1 though, as they've create=
d their own libtls for future programs.</span></div><div><div><br></div><di=
v>Git grep didn't show anything in the v2.4.1 portable repo.</div><div>=
The v1.1 API is still in pre-release it looks like, and the relevant functi=
ons have</div><div>only been in OpenSSL since January and March respectivel=
y according to git.</div><div>In fact LibreSSL has had only a handful of co=
mmits this year in portable,</div><div>mostly focused on building with cmak=
e and some fixes, but no API additions.</div><div><br></div><div>Neither fu=
nction is available in the -current OpenBSD cvs tree either.</div><div><br>=
</div><div>I've emailed <a href=3D"mailto:libressl@openbsd.org">libress=
l(a)openbsd.org</a>=C2=A0to inquire further.</div></div></div><br><div class=
=3D"gmail_quote"><div dir=3D"ltr">On Mon, Jun 20, 2016 at 1:38 AM Howard Ch=
u <<a href=3D"mailto:hyc@symas.com">hyc(a)symas.com</a>> wrote:<br></di=
v><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:=
1px #ccc solid;padding-left:1ex">Connor Taffe wrote:<br>
> Fixed, attached is a patch.<br>
<br>
I'm a bit concerned that you're only checking for the existence of =
LIBRESSL<br>
instead of actually comparing the version number. Since the OpenSSL change =
is<br>
based on their v1.1 API, do you know if/when LibreSSL plans to adopt the ne=
w API?<br>
<br>
> On Sun, Jun 19, 2016 at 8:02 PM Howard Chu <<a href=3D"mailto:hyc@s=
ymas.com" target=3D"_blank">hyc(a)symas.com</a><br>
> <mailto:<a href=3D"mailto:hyc@symas.com" target=3D"_blank">hyc@syma=
s.com</a>>> wrote:<br>
><br>
>=C2=A0 =C2=A0 =C2=A0<a href=3D"mailto:cpaynetaffe@gmail.com" target=3D"=
_blank">cpaynetaffe(a)gmail.com</a> <mailto:<a href=3D"mailto:cpaynetaffe@=
gmail.com" target=3D"_blank">cpaynetaffe(a)gmail.com</a>> wrote:<br>
>=C2=A0 =C2=A0 =C2=A0 > Full_Name: Connor Taffe<br>
>=C2=A0 =C2=A0 =C2=A0 > Version: master<br>
>=C2=A0 =C2=A0 =C2=A0 > OS: Ubuntu devel<br>
>=C2=A0 =C2=A0 =C2=A0 > URL: <a href=3D"ftp://ftp.openldap.org/incomi=
ng/" rel=3D"noreferrer" target=3D"_blank">ftp://ftp.openldap.org/incoming/<=
/a><br>
>=C2=A0 =C2=A0 =C2=A0 > Submission from: (NULL) (50.25.160.41)<br>
>=C2=A0 =C2=A0 =C2=A0 ><br>
>=C2=A0 =C2=A0 =C2=A0 ><br>
>=C2=A0 =C2=A0 =C2=A0 > Compiling against LibreSSL v2.4.1 failed link=
ing with SSL_CTX_up_ref and<br>
>=C2=A0 =C2=A0 =C2=A0 > X509_NAME_get0_der undefined. I added checkin=
g if<br>
>=C2=A0 =C2=A0 =C2=A0LIBRESSL_VERSION_NUMBER to the<br>
>=C2=A0 =C2=A0 =C2=A0 > same conditional compilation ifs that are def=
ined for old versions of<br>
>=C2=A0 =C2=A0 =C2=A0OpenSSL.<br>
>=C2=A0 =C2=A0 =C2=A0 ><br>
>=C2=A0 =C2=A0 =C2=A0 > <a href=3D"https://github.com/cptaffe/openlda=
p" rel=3D"noreferrer" target=3D"_blank">https://github.com/cptaffe/openldap=
</a><br>
><br>
>=C2=A0 =C2=A0 =C2=A0Please read the Developer Guidelines. I'm not g=
oing to pull an arbitrary repo<br>
>=C2=A0 =C2=A0 =C2=A0to find someone's patch.<br>
><br>
>=C2=A0 =C2=A0 =C2=A0<a href=3D"http://www.openldap.org/devel/contributi=
ng.html" rel=3D"noreferrer" target=3D"_blank">http://www.openldap.org/devel=
/contributing.html</a><br>
><br>
>=C2=A0 =C2=A0 =C2=A0--<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-- Howard Chu<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0CTO, Symas Corp. <a href=3D"http://ww=w.symas.com" rel=3D"noreferrer" target=3D"_blank">http://www.symas.com</a><=
br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Director, Highland Sun <a href=3D"htt=
p://highlandsun.com/hyc/" rel=3D"noreferrer" target=3D"_blank">http://highl=andsun.com/hyc/</a><br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Chief Architect, OpenLDAP <a href=3D"=
http://www.openldap.org/project/" rel=3D"noreferrer" target=3D"_blank">http=
://www.openldap.org/project/</a><br>
><br>
<br>
<br>
--<br>
=C2=A0 =C2=A0-- Howard Chu<br>
=C2=A0 =C2=A0CTO, Symas Corp.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a hr=
ef=3D"http://www.symas.com" rel=3D"noreferrer" target=3D"_blank">http://www=
.symas.com</a><br>
=C2=A0 =C2=A0Director, Highland Sun=C2=A0 =C2=A0 =C2=A0<a href=3D"http://hi=ghlandsun.com/hyc/" rel=3D"noreferrer" target=3D"_blank">http://highlandsun=
.com/hyc/</a><br>
=C2=A0 =C2=A0Chief Architect, OpenLDAP=C2=A0 <a href=3D"http://www.openldap=
.org/project/" rel=3D"noreferrer" target=3D"_blank">http://www.openldap.org=
/project/</a><br>
</blockquote></div>
--001a1147bbbc1ed3a40535b28599--
Connor Taffe wrote:
> Fixed, attached is a patch.
I'm a bit concerned that you're only checking for the existence of LIBRESSL
instead of actually comparing the version number. Since the OpenSSL change is
based on their v1.1 API, do you know if/when LibreSSL plans to adopt the new API?
> On Sun, Jun 19, 2016 at 8:02 PM Howard Chu <hyc(a)symas.com
> <mailto:hyc@symas.com>> wrote:
>
> cpaynetaffe(a)gmail.com <mailto:cpaynetaffe@gmail.com> wrote:
> > Full_Name: Connor Taffe
> > Version: master
> > OS: Ubuntu devel
> > URL: ftp://ftp.openldap.org/incoming/
> > Submission from: (NULL) (50.25.160.41)
> >
> >
> > Compiling against LibreSSL v2.4.1 failed linking with SSL_CTX_up_ref and
> > X509_NAME_get0_der undefined. I added checking if
> LIBRESSL_VERSION_NUMBER to the
> > same conditional compilation ifs that are defined for old versions of
> OpenSSL.
> >
> > https://github.com/cptaffe/openldap
>
> Please read the Developer Guidelines. I'm not going to pull an arbitrary repo
> to find someone's patch.
>
> http://www.openldap.org/devel/contributing.html
>
> --
> -- Howard Chu
> CTO, Symas Corp. http://www.symas.com
> Director, Highland Sun http://highlandsun.com/hyc/
> Chief Architect, OpenLDAP http://www.openldap.org/project/
>
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/