October 2015 - openldap-bugs

Re: (ITS#8216) Windows 'make test' failures

by hyc＠symas.com

h.b.furuseth(a)usit.uio.no wrote: > On 25/10/15 09:57, hyc(a)symas.com wrote: >> mhardin(a)symas.com wrote: >>> test0-c-concurrency: problems reported by slapd-tester >> > test039-glue-ldap-concurrency: seems to fail for the same reasons as test008 >> >> libtool incompatibility; it leaves shell scripts for the actual tester >> programs in the progs directory, with the real executables under progs/.libs. >> Windows' spawn can't execute shell scripts. Solution is to manually copy the >> real executables from .libs before running the test. >> >> Simple workaround. Won't fix this. > > Does it work to change tests/scripts/defines.sh:PROGDIR to > "./progs/.libs"? If so we just need a test for whether or > not to do that, in configure.in and/or in defines.sh. Tried that, it turned out to not be the problem. Windows just wanted the .exe suffix on the command names. Fixed now in master. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

7 years, 7 months

1
0
0 / 0

Re: (ITS#8274) Review lmdb cyrus-sasl backend changes

by nacho.resa＠gmail.com

--f46d04218485a9382e0522fea6a1 Content-Type: text/plain; charset=UTF-8 Done: http://lists.andrew.cmu.edu/pipermail/cyrus-sasl/2015-October/002846.html On Mon, Oct 26, 2015 at 10:06 AM, Howard Chu <hyc(a)symas.com> wrote: > nacho.resa(a)gmail.com wrote: > >> Full_Name: Ignacio Casal Quinteiro >> Version: >> OS: >> URL: ftp://ftp.openldap.org/incoming/ >> Submission from: (NULL) (89.202.223.30) >> >> >> Hi Howard Chu, >> >> since you made the backend for cyrus-sasl, any chance you could review the >> patches here: >> https://github.com/nice-software/cyrus-sasl/commits/wip/lmdb >> before they get upstream? >> > > Patches for Cyrus SASL should be discussed on the Cyrus SASL mailing list. > > -- > -- Howard Chu > CTO, Symas Corp. http://www.symas.com > Director, Highland Sun http://highlandsun.com/hyc/ > Chief Architect, OpenLDAP http://www.openldap.org/project/ > -- Ignacio Casal Quinteiro --f46d04218485a9382e0522fea6a1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Done: <a href=3D"http://lists.andrew.cmu.edu/pipermail/cyr= us-sasl/2015-October/002846.html">http://lists.andrew.cmu.edu/pipermail/cyr= us-sasl/2015-October/002846.html</a><br></div><div class=3D"gmail_extra"><b= r><div class=3D"gmail_quote">On Mon, Oct 26, 2015 at 10:06 AM, Howard Chu <= span dir=3D"ltr"><<a href=3D"mailto:hyc@symas.com" target=3D"_blank">hyc= @symas.com</a>></span> wrote:<br><blockquote class=3D"gmail_quote" style= =3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><a href= =3D"mailto:nacho.resa@gmail.com" target=3D"_blank">nacho.resa(a)gmail.com</a>= wrote:<br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> Full_Name: Ignacio Casal Quinteiro<br> Version:<br> OS:<br> URL: <a href=3D"ftp://ftp.openldap.org/incoming/" rel=3D"noreferrer" target= =3D"_blank">ftp://ftp.openldap.org/incoming/</a><br> Submission from: (NULL) (89.202.223.30)<br> <br> <br> Hi Howard Chu,<br> <br> since you made the backend for cyrus-sasl, any chance you could review the<= br> patches here: <a href=3D"https://github.com/nice-software/cyrus-sasl/commit= s/wip/lmdb" rel=3D"noreferrer" target=3D"_blank">https://github.com/nice-so= ftware/cyrus-sasl/commits/wip/lmdb</a><br> before they get upstream?<br> </blockquote> <br> Patches for Cyrus SASL should be discussed on the Cyrus SASL mailing list.<= span class=3D"HOEnZb"><font color=3D"#888888"><br> <br> -- <br> =C2=A0 -- Howard Chu<br> =C2=A0 CTO, Symas Corp.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"= http://www.symas.com" rel=3D"noreferrer" target=3D"_blank">http://www.symas= .com</a><br> =C2=A0 Director, Highland Sun=C2=A0 =C2=A0 =C2=A0<a href=3D"http://highland= sun.com/hyc/" rel=3D"noreferrer" target=3D"_blank">http://highlandsun.com/h= yc/</a><br> =C2=A0 Chief Architect, OpenLDAP=C2=A0 <a href=3D"http://www.openldap.org/p= roject/" rel=3D"noreferrer" target=3D"_blank">http://www.openldap.org/proje= ct/</a><br> </font></span></blockquote></div><br><br clear=3D"all"><br>-- <br><div clas= s=3D"gmail_signature">Ignacio Casal Quinteiro</div> </div> --f46d04218485a9382e0522fea6a1--

7 years, 7 months

1
0
0 / 0

Re: (ITS#8274) Review lmdb cyrus-sasl backend changes

by hyc＠symas.com

nacho.resa(a)gmail.com wrote: > Full_Name: Ignacio Casal Quinteiro > Version: > OS: > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (89.202.223.30) > > > Hi Howard Chu, > > since you made the backend for cyrus-sasl, any chance you could review the > patches here: https://github.com/nice-software/cyrus-sasl/commits/wip/lmdb > before they get upstream? Patches for Cyrus SASL should be discussed on the Cyrus SASL mailing list. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

7 years, 7 months

1
0
0 / 0

Re: (ITS#8270) win32: fix conversion error

by nacho.resa＠gmail.com

--f46d042184850fb03c0522fcd987 Content-Type: text/plain; charset=UTF-8 Howard, any chance to get this in or should I change something else? Also, any chance you could have a look at "ITS#8274"? Thanks in advance! On Tue, Oct 20, 2015 at 10:37 PM, Ignacio Casal Quinteiro < nacho.resa(a)gmail.com> wrote: > > > On Tue, Oct 20, 2015 at 10:09 PM, Howard Chu <hyc(a)symas.com> wrote: > >> nacho.resa(a)gmail.com wrote: >> >>> --047d7bb03a5ac118d20522842ead >>> Content-Type: text/plain; charset=UTF-8 >>> >>> So I took another closer look at this issue and I went for this possible >>> solution: >>> >>> https://github.com/nice-software/lmdb/commit/03987789735141dc68ae8b2d0e5a... >>> >> >> That looks OK. >> >> Basically it errors out because MSVC needs stdcall on that method. >>> >> >> You realize of course, that this change actually has no effect on the >> code here? stdcall uses Pascal argument order instead of C order but it's >> moot since the function only has 1 argument. >> > > yeah... but if this fixes the error I am fine with it, after all it end > ups being just a define > > >> >> >>> Cheers. >>> >>> On Mon, Oct 19, 2015 at 2:55 PM, Ignacio Casal Quinteiro < >>> nacho.resa(a)gmail.com> wrote: >>> >>> Sorry! I did indeed meant to change just the windows part, for some >>>> reason >>>> I thought it was already ifdeffed that part. >>>> >>>> >>>> https://github.com/nice-software/lmdb/commit/42577fe173923c1166f8382a5352... >>>> >>>> This is the right patch. >>>> >>>> On Mon, Oct 19, 2015 at 1:43 PM, Hallvard Breien Furuseth < >>>> h.b.furuseth(a)usit.uio.no> wrote: >>>> >>>> On 19. okt. 2015 08:57, nacho.resa(a)gmail.com wrote: >>>>> >>>>> I do not understand, I tested also with mingw64 (...) >>>>>> >>>>>> >>>>> There's no LPTHREAD_START_ROUTINE type on non-Windows machines. >>>>> You could replace 'start' with '(LPTHREAD_START_ROUTINE)(start)' >>>>> in the _WIN32 variant of '#define THREAD_CREATE...'. >>>>> >>>>> However, it's still wrong to call a function via another prototype. >>>>> Maybe that'd fall on 32-bit Windows or something, I don't know >>>>> how LPTHREAD_START_ROUTINE is defined. The safe way would be to >>>>> give mdb_env_copythr() a prototype which does not need a cast. >>>>> There is some code for that already. Maybe it can be improved. >>>>> >>>>> -- >>>>> Hallvard >>>>> >>>>> >>>> >>>> >>>> -- >>>> Ignacio Casal Quinteiro >>>> >>>> >>> >>> >>> >> >> -- >> -- Howard Chu >> CTO, Symas Corp. http://www.symas.com >> Director, Highland Sun http://highlandsun.com/hyc/ >> Chief Architect, OpenLDAP http://www.openldap.org/project/ >> > > > > -- > Ignacio Casal Quinteiro > -- Ignacio Casal Quinteiro --f46d042184850fb03c0522fcd987 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div><div>Howard, any chance to get this in or should I ch= ange something else?<br></div>Also, any chance you could have a look at &qu= ot;ITS#8274"?<br><br></div>Thanks in advance!<br></div><div class=3D"g= mail_extra"><br><div class=3D"gmail_quote">On Tue, Oct 20, 2015 at 10:37 PM= , Ignacio Casal Quinteiro <span dir=3D"ltr"><<a href=3D"mailto:nacho.res= a(a)gmail.com" target=3D"_blank">nacho.resa(a)gmail.com</a>></span> wrote:<b= r><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:= 1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><br><div class=3D"gmail_e= xtra"><br><div class=3D"gmail_quote"><span class=3D"">On Tue, Oct 20, 2015 = at 10:09 PM, Howard Chu <span dir=3D"ltr"><<a href=3D"mailto:hyc@symas.c= om" target=3D"_blank">hyc(a)symas.com</a>></span> wrote:<br><blockquote cl= ass=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;p= adding-left:1ex"><a href=3D"mailto:nacho.resa@gmail.com" target=3D"_blank">= nacho.resa(a)gmail.com</a> wrote:<br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> --047d7bb03a5ac118d20522842ead<br> Content-Type: text/plain; charset=3DUTF-8<span><br> <br> So I took another closer look at this issue and I went for this possible<br= > solution:<br> <a href=3D"https://github.com/nice-software/lmdb/commit/03987789735141dc68a= e8b2d0e5ad52d82cc80d0" rel=3D"noreferrer" target=3D"_blank">https://github.= com/nice-software/lmdb/commit/03987789735141dc68ae8b2d0e5ad52d82cc80d0</a><= br> </span></blockquote> <br> That looks OK.<span><br> <br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> Basically it errors out because MSVC needs stdcall on that method.<br> </blockquote> <br></span> You realize of course, that this change actually has no effect on the code = here? stdcall uses Pascal argument order instead of C order but it's mo= ot since the function only has 1 argument.<span><br></span></blockquote><di= v><br></div></span><div>yeah... but if this fixes the error I am fine with = it, after all it end ups being just a define<br></div><div><div class=3D"h5= "><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 = .8ex;border-left:1px #ccc solid;padding-left:1ex"><span> <br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> <br> Cheers.<br> <br> On Mon, Oct 19, 2015 at 2:55 PM, Ignacio Casal Quinteiro <<br> <a href=3D"mailto:nacho.resa@gmail.com" target=3D"_blank">nacho.resa(a)gmail.= com</a>> wrote:<br> <br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> Sorry! I did indeed meant to change just the windows part, for some reason<= br> I thought it was already ifdeffed that part.<br> <br> <a href=3D"https://github.com/nice-software/lmdb/commit/42577fe173923c1166f= 8382a53523a31479f9d43" rel=3D"noreferrer" target=3D"_blank">https://github.= com/nice-software/lmdb/commit/42577fe173923c1166f8382a53523a31479f9d43</a><= br> <br> This is the right patch.<br> <br> On Mon, Oct 19, 2015 at 1:43 PM, Hallvard Breien Furuseth <<br> <a href=3D"mailto:h.b.furuseth@usit.uio.no" target=3D"_blank">h.b.furuseth@= usit.uio.no</a>> wrote:<br> <br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> On 19. okt. 2015 08:57, <a href=3D"mailto:nacho.resa@gmail.com" target=3D"_= blank">nacho.resa(a)gmail.com</a> wrote:<br> <br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> I do not understand, I tested also with mingw64 (...)<br> <br> </blockquote> <br> There's no LPTHREAD_START_ROUTINE type on non-Windows machines.<br> You could replace 'start' with '(LPTHREAD_START_ROUTINE)(start)= '<br> in the _WIN32 variant of '#define THREAD_CREATE...'.<br> <br> However, it's still wrong to call a function via another prototype.<br> Maybe that'd fall on 32-bit Windows or something, I don't know<br> how LPTHREAD_START_ROUTINE is defined.=C2=A0 The safe way would be to<br> give mdb_env_copythr() a prototype which does not need a cast.<br> There is some code for that already. Maybe it can be improved.<br> <br> --<br> Hallvard<br> <br> </blockquote> <br> <br> <br> --<br> Ignacio Casal Quinteiro<br> <br> </blockquote> <br> <br> <br> </blockquote> <br> <br> -- <br></span><div><div> =C2=A0 -- Howard Chu<br> =C2=A0 CTO, Symas Corp.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"= http://www.symas.com" rel=3D"noreferrer" target=3D"_blank">http://www.symas= .com</a><br> =C2=A0 Director, Highland Sun=C2=A0 =C2=A0 =C2=A0<a href=3D"http://highland= sun.com/hyc/" rel=3D"noreferrer" target=3D"_blank">http://highlandsun.com/h= yc/</a><br> =C2=A0 Chief Architect, OpenLDAP=C2=A0 <a href=3D"http://www.openldap.org/p= roject/" rel=3D"noreferrer" target=3D"_blank">http://www.openldap.org/proje= ct/</a><br> </div></div></blockquote></div></div></div><span class=3D"HOEnZb"><font col= or=3D"#888888"><br><br clear=3D"all"><br>-- <br><div>Ignacio Casal Quinteir= o</div> </font></span></div></div> </blockquote></div><br><br clear=3D"all"><br>-- <br><div class=3D"gmail_sig= nature">Ignacio Casal Quinteiro</div> </div> --f46d042184850fb03c0522fcd987--

7 years, 7 months

1
0
0 / 0

(ITS#8288) Asyncronous Disconnect Handlers Not Firing

by jeremyc＠ssimicro.com

Full_Name: Jeremy Childs Version: 2.4.42 OS: FreeBSD/Linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (64.247.138.35) Im seeing an issue with async reconnects in libldap 2.4.42 - when the remote server disconnects unexpectedly and there are requests in the queue, request.c:196 calls ldap_free_connection with the force parameter set to 0. Since apap_free_connection wont actually free anything (or call the disconnect handler) until the refcount is zero, nothing happens. Testing with the force parameter set to 1 addresses the issue, the pending requests get freed, and the connection itself frees, calling the disconnect handler in the process.

7 years, 7 months

1
0
0 / 0

Re: (ITS#8216) Windows 'make test' failures

by h.b.furuseth＠usit.uio.no

On 25/10/15 09:57, hyc(a)symas.com wrote: > mhardin(a)symas.com wrote: >> test0-c-concurrency: problems reported by slapd-tester > > test039-glue-ldap-concurrency: seems to fail for the same reasons as test008 > > libtool incompatibility; it leaves shell scripts for the actual tester > programs in the progs directory, with the real executables under progs/.libs. > Windows' spawn can't execute shell scripts. Solution is to manually copy the > real executables from .libs before running the test. > > Simple workaround. Won't fix this. Does it work to change tests/scripts/defines.sh:PROGDIR to "./progs/.libs"? If so we just need a test for whether or not to do that, in configure.in and/or in defines.sh.

7 years, 7 months

1
0
0 / 0

Re: (ITS#8216) Windows 'make test' failures

by h.b.furuseth＠usit.uio.no

On 25/10/15 09:57, hyc(a)symas.com wrote: >> test043-delta-syncrepl: lmdb always fails, hdb/bdb sometimes > > Attribute ordering, the replicated data is correct. Won't fix this. Sounds like you can just replace "$LDIFFILTER -s bdb=a,hdb=a" with "$LDIFFILTER -s a" or add ",mdb=a".

7 years, 7 months

1
0
0 / 0

Re: (ITS#8204) rfc2782 shuffle implementation doesn't treat equal-weight records equally

by hyc＠symas.com

Sergio.Gelato(a)astro.su.se wrote: > Full_Name: Sergio Gelato > Version: 2.4.40 > OS: Linux > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (85.225.123.9) > > > As currently implemented (since ITS#7027, > 5de85b922aaa5bfa6eb53db6000adf01ebdb0736) the algorithm to shuffle DNS SRV > records of a given priority according to their weights is flawed: if all records > have the same weight, the implementation is biased towards the first record and > against the last. In the most extreme case of two records of weight 1, the > current implementation will never swap them (whereas one would have hoped for a > swap 50% of the time). The problem can be cured by changing (r <= 0) to (r < 0). > (The wording of the RFC may have contributed to this error; I suspect it was > written with real random deviates in mind, not integer ones. In any event, the > principle that records of equal weight should have the same probability of being > picked trumps the RFC since the latter only says what algorithm SHOULD be > used.) > > I've written and tested a patch for this and found it to solve the above > problem. My patch also addresses another (operationally minor, which is why I'm > not reporting it separately) issue in the same piece of code: what if at least > two, but not all, of the records of a given priority have weight zero? One > should be prepared to switch to a Fisher-Yates shuffle if "total" becomes zero > during the iteration. > > (Yet another potential issue is overflow of "total" on platforms where > INT_MAX==32767 if the sum of the weights exceeds that value. Consider declaring > it uint32_t or u_long.) I see no patch nor URL. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

7 years, 7 months

1
0
0 / 0

Re: (ITS#8194) Service slapd falldown in a search with client ldapsearch

by hyc＠symas.com

richard.larrieu-manan(a)cgi.com wrote: > Ok. > > Here is the command line to do the research with the client ldapsearch : > /opt/openldap/bin/ldapsearch -xLLL -h ldapp02 -p 389 -D cn=3Dadmin,ou=3Dsys= > tem,dc=3Dent,dc=3Dfr -b ou=3Dsupp,ou=3Dpersonnes,ou=3DCRRA,dc=3Dent,dc=3Dfr= > -w jungle dn | wc -l > > After 1 or 2 search the slapd server goes. I believe this was fixed as ITS#8203 in 2.4.42. Please try that and followup again, thanks. > > Thx. > > -----Message d'origine----- > De=A0: Michael Str=F6der [mailto:michael@stroeder.com]=20 > Envoy=E9=A0: vendredi 10 juillet 2015 12:35 > =C0=A0: LARRIEU-MANAN, Richard; openldap-its(a)OpenLDAP.org > Objet=A0: Re: (ITS#8194) Service slapd falldown in a search with client lda= > psearch > > Maybe I missed something but I can't which search requests are causing this= > . > > Could you please also add some information about your ldapsearch commands? > > Ciao, Michael. > > > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

7 years, 7 months

1
0
0 / 0

Re: (ITS#8191) mdb_txn_commit(empty txn) does not sync

by hyc＠symas.com

h.b.furuseth(a)usit.uio.no wrote: > On 07/07/15 21:44, h.b.furuseth(a)usit.uio.no wrote: >> My feeling is that this is a quirk the user should not need to >> know about, and it's cleaner to sy r rather than to document it. > > ...cleaner to sync rather than... The doc should say that committing an empty txn is a no-op. If you want to do a sync without writing data, use mdb_env_sync() yourself. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

7 years, 7 months

1
0
0 / 0

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs October 2015