November 2013 - openldap-bugs

Re: (ITS#7735) Memory leaks on Multi-Master replications

by dmitrii.fonariuk＠gmail.com

--047d7b33cb784de6d004ea68c04b Content-Type: text/plain; charset=ISO-8859-1 Hi Quanah, I have installed two patches, compiled binary and run modify requests test. I see that the memory is no longer leaking. great!!! patches helped. excellent work! Thanks! --Dmitrii --047d7b33cb784de6d004ea68c04b Content-Type: text/html; charset=ISO-8859-1 <div dir="ltr"><div class="gmail_extra"> <p class="MsoNormal">Hi Quanah,</p><p class="MsoNormal"><br></p><p class="MsoNormal">I have installed two patches, compiled binary and run modify requests test. I see that the memory is no longer leaking. great!!! patches helped. excellent work!</p><p class="MsoNormal"> </p><p class="MsoNormal"><br></p><p class="MsoNormal">Thanks!</p><p class="MsoNormal"><br></p><p class="MsoNormal">--Dmitrii</p> </div></div> --047d7b33cb784de6d004ea68c04b--

10 years

1
0
0 / 0

Re: (ITS#7739) Include of include badly handled while converting from slapd.conf to slapd.d

by hyc＠symas.com

raphael.ouazana(a)linagora.com wrote: > Full_Name: Raphael Ouazana > Version: 2.4.37 > OS: Linux > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (88.173.78.196) > > > Hi, > > If I have for example a main slapd.conf with: > include <path>schema.conf > > And a simple schema.conf: > include <path>core.schema > include <path>cosine.schema > include <path>inetorgperson.schema > > When I try to convert slapd.conf to slapd.d with slaptest, the resulting > configuration is incorrect: the schema file are not included. > Try again, using a different name than "schema.conf" -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

10 years

1
0
0 / 0

(ITS#7739) Include of include badly handled while converting from slapd.conf to slapd.d

by raphael.ouazana＠linagora.com

Full_Name: Raphael Ouazana Version: 2.4.37 OS: Linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (88.173.78.196) Hi, If I have for example a main slapd.conf with: include <path>schema.conf And a simple schema.conf: include <path>core.schema include <path>cosine.schema include <path>inetorgperson.schema When I try to convert slapd.conf to slapd.d with slaptest, the resulting configuration is incorrect: the schema file are not included. Regards, Raphaël Ouazana.

10 years

1
0
0 / 0

Re: (ITS#7723) slapd crashes on multi core machines if a search request is *immediately* followed by an unbind

by hyc＠symas.com

jsynacek(a)redhat.com wrote: > On 10/15/2013 01:10 PM, michael.vishchers(a)7p-group.com wrote: >> It is not the client loop that is multithreading but the ldap server. >> >> And it is not a misuse of the API but a problem that may be raised by day t= >> o day network problems. >> >> I've boiled down the problem to a few simple configurations that work (or b= >> etter, fail ;-) with both 2.4.23 and 2.4.36. A tgz file containing a setup = >> with start script and testclient is attached. It should be sufficient to re= >> produce the fault. >> >> The problem occurs only if we use session variable substitution in the rwm = >> overlay, and only if a search is *immediately* (e.g. caused by network loss= >> and client timeout) followed by an unbind. >> > > I modified the reproducer a bit (the start script) and find out a few things. > You can find the reproducer I'm using at [1]. > > Valgrind's helgrind shows some lock problems in the rwm overlay and also in > back-ldap and connection.c. After correcting those the issue seems to be gone. > > You can find helgrind logs at [2] (before the fix) and [3] (after). > > Also, ElectricFence reveals some problems [4], which I didn't fix yet. > > A fix attempt can be found at [5]. I'm not sure if that is a correct fix, or it > just masked the real issue. But I didn't to manage to reproduce the problem > after applying it. I already explained the problem. The other issues you identified are not relevant, and your patch is not correct. Reread Followup #4 of this ITS. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

10 years

1
0
0 / 0

Re: (ITS#7723) slapd crashes on multi core machines if a search request is *immediately* followed by an unbind

by jsynacek＠redhat.com

On 10/15/2013 01:10 PM, michael.vishchers(a)7p-group.com wrote: > It is not the client loop that is multithreading but the ldap server. > > And it is not a misuse of the API but a problem that may be raised by day t= > o day network problems. > > I've boiled down the problem to a few simple configurations that work (or b= > etter, fail ;-) with both 2.4.23 and 2.4.36. A tgz file containing a setup = > with start script and testclient is attached. It should be sufficient to re= > produce the fault. > > The problem occurs only if we use session variable substitution in the rwm = > overlay, and only if a search is *immediately* (e.g. caused by network loss= > and client timeout) followed by an unbind. > I modified the reproducer a bit (the start script) and find out a few things. You can find the reproducer I'm using at [1]. Valgrind's helgrind shows some lock problems in the rwm overlay and also in back-ldap and connection.c. After correcting those the issue seems to be gone. You can find helgrind logs at [2] (before the fix) and [3] (after). Also, ElectricFence reveals some problems [4], which I didn't fix yet. A fix attempt can be found at [5]. I'm not sure if that is a correct fix, or it just masked the real issue. But I didn't to manage to reproduce the problem after applying it. [1] http://jsynacek.fedorapeople.org/openldap/its7723/reproducer/ [2] http://jsynacek.fedorapeople.org/openldap/its7723/results/slapd1-helgrind... [3] http://jsynacek.fedorapeople.org/openldap/its7723/results/slapd1-helgrind... [4] http://jsynacek.fedorapeople.org/openldap/its7723/results/slapd1-broken-e... [5] http://jsynacek.fedorapeople.org/openldap/its7723/0001-fix-possible-race-... Cheers, -- Jan Synacek Software Engineer, Red Hat

10 years

1
0
0 / 0

Re: (ITS#7735) Memory leaks on Multi-Master replications

by quanah＠zimbra.com

--On Friday, November 01, 2013 10:39 PM +0400 Dmitrii Fonariuk <dmitrii.fonariuk(a)gmail.com> wrote: > > > hi Quanah, > > it's a good news! unfortunately I can't test the changes now. Tuesday I > rebuild the source with patch, do the tests and report to you. > > thank you for your efforts. You will also need to grab <http://www.openldap.org/devel/gitweb.cgi?p=openldap.git;a=patch;h=ed09222...> --Quanah -- Quanah Gibson-Mount Architect - Server Zimbra, Inc. -------------------- Zimbra :: the leader in open source messaging and collaboration

10 years

1
0
0 / 0

Re: (ITS#7700) DOC: OL AdminGuide not updated

by marco.pizzoli＠gmail.com

On Sat, Nov 2, 2013 at 10:56 PM, Gavin Henry <openldap-its(a)openldap.org> wrote: >> I noticed other errors on the Admin Guide. > > Hi Marco, > > Many thanks for taking the time to read our documentation and report missing > items and errors. It's been a pleasure :-) [cut] >> 6.2.3.3 -> I think it could be useful to specify that in case that >> server is consumer, all modifications coming from syncrepl still >> continue to be received and written > > Do you have any more wording you'd like to contribute as per: > > http://www.openldap.org/devel/contributing.html I'm afraid I cannot get what you are asking me to do. Are you asking me to just add the disclaimer or to reword my point in order to be feasible for direct inclusion in the AdminGuide? > >> 6.2.3.6 -> "Note: When the backend to pass a query to is selected, >> slapd looks at the suffix line(s) in each database definition in the >> order they appear in the file. >> Thus, if one database suffix is a prefix of another, it must >> appear BEFORE it in the config file." > > And with the ldif backend for dynamic configuration, cn=config Of course :-) And what if I found errors also on this page? :-) http://www.openldap.org/devel/contributing.html#patches "Each software change should be conCise, self-contained, and made against up-to-date source code." "One patch per functional change, and" -> and what? Regards Marco

10 years

1
0
0 / 0

Re: (ITS#7700) DOC: OL AdminGuide not updated

by marco.pizzoli＠gmail.com

I noticed other errors on the Admin Guide. I put all of my findings in the following list: 6.2.2.1 -> mdb is not present as a choice 6.2.3.3 -> I think it could be useful to specify that in case that server is consumer, all modifications coming from syncrepl still continue to be received and written 6.2.3.6 -> "Note: When the backend to pass a query to is selected, slapd looks at the suffix line(s) in each database definition in the order they appear in the file. Thus, if one database suffix is a prefix of another, it must appear BEFORE it in the config file." 6.2.3.7 - as "syncrepl" options don't appear the following: "keepalive", "network-timeout", "timeout", "tls_protocol_min" and "suffixmassage" -> "The syncrepl replication mechanism is supported by the bdb, hdb AND MDB backends" 9.4.1 -> "Table ZZZ.ZZZ: Entity Specifiers"

10 years

1
0
0 / 0

Re: (ITS#7735) Memory leaks on Multi-Master replications

by dmitrii.fonariuk＠gmail.com

--047d7b6d9b248244f904ea21e406 Content-Type: text/plain; charset=ISO-8859-1 hi Quanah, it's a good news! unfortunately I can't test the changes now. tuesday I rebuild the source with patch, do the tests and report to you. thank you for your efforts. -- Dmitrii --047d7b6d9b248244f904ea21e406 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>hi Quanah,</div><div><br></div>it's a good news! = unfortunately I can't test the changes=A0now. tuesday I rebuild the sou= rce with=A0<span style=3D"font-family:arial,sans-serif;font-size:13px">patc= h</span>, do the tests and report to you.<br> <div>thank you for your efforts.<br></div><div class=3D"gmail_extra"><br>--= Dmitrii </div></div> --047d7b6d9b248244f904ea21e406--

10 years

1
0
0 / 0

Re: (ITS#7735) Memory leaks on Multi-Master replications

by quanah＠zimbra.com

--On Friday, November 01, 2013 4:43 PM +0000 quanah(a)zimbra.com wrote: > So we really need to be able to try and reproduce your issue. Hi Dmitrii, After further examination, we believe the root cause of the issue has been identified. Please rebuild your source with this patch: <http://www.openldap.org/devel/gitweb.cgi?p=openldap.git;a=patch;h=0645878...> and report back if it resolves the memory leak. Thanks! --Quanah -- Quanah Gibson-Mount Architect - Server Zimbra, Inc. -------------------- Zimbra :: the leader in open source messaging and collaboration

10 years

1
0
0 / 0

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs November 2013