https://bugs.openldap.org/show_bug.cgi?id=9921
Issue ID: 9921 Summary: Tautology in clients/tools/common.c:print_vlv() Product: OpenLDAP Version: 2.6.3 Hardware: All OS: All Status: UNCONFIRMED Keywords: needs_review Severity: normal Priority: --- Component: client tools Assignee: bugs@openldap.org Reporter: dpa-openldap@aegee.org Target Milestone: ---
https://git.openldap.org/openldap/openldap/-/blob/master/clients/tools/commo... contains:
tool_write_ldif( ldif ? LDIF_PUT_COMMENT : LDIF_PUT_VALUE, ldif ? "vlvResult" : "vlvResult", buf, rc );
The second parameter is always vlvResult, irrespective of the value of ldif.
https://bugs.openldap.org/show_bug.cgi?id=9921
Howard Chu hyc@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED
--- Comment #1 from Howard Chu hyc@openldap.org --- fixed in master
https://bugs.openldap.org/show_bug.cgi?id=9921
--- Comment #2 from dpa-openldap@aegee.org dpa-openldap@aegee.org --- I found this by running the Cland Static Analyzer under CodeChecker with the Cross Translation Unit (CTU) option. The complete results, including false positives, are at https://mail.aegee.org/dpa/scan99/openldap26/ .
https://bugs.openldap.org/show_bug.cgi?id=9921
--- Comment #3 from Howard Chu hyc@openldap.org --- Looks like a lot of garbage. For example, every error assertion on this page is wrong:
https://mail.aegee.org/dpa/scan99/openldap26/ldapcompare.c_clangsa_77822a93f...
If you can find any actual valid errors, feel free to fix them. Won't waste my time wading thru the noise.
https://bugs.openldap.org/show_bug.cgi?id=9921
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED Keywords|needs_review | Target Milestone|--- |2.7.0
https://bugs.openldap.org/show_bug.cgi?id=9921
--- Comment #4 from Quanah Gibson-Mount quanah@openldap.org --- head:
commit 0b4098ca9080e78436cbd9f383047a9583888376 Author: Howard Chu hyc@openldap.org Date: Mon Sep 26 11:55:27 2022 +0100
ITS#9921 fix vlvResult comment
https://bugs.openldap.org/show_bug.cgi?id=9921
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|2.7.0 |2.5.18
https://bugs.openldap.org/show_bug.cgi?id=9921
--- Comment #5 from Quanah Gibson-Mount quanah@openldap.org --- RE25:
• f640d170 by Howard Chu at 2024-05-08T15:30:13+00:00 ITS#9921 fix vlvResult comment
RE26:
• cfcb9960 by Howard Chu at 2024-05-08T15:30:06+00:00 ITS#9921 fix vlvResult comment
-
openldap-its＠openldap.org