https://bugs.openldap.org/show_bug.cgi?id=9624
Issue ID: 9624 Summary: Issues in client state tracking Product: OpenLDAP Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: --- Component: lloadd Assignee: bugs@openldap.org Reporter: ondra@mistotebe.net Target Milestone: ---
There are two places that don't track client state (BINDING/OPEN) correctly: - handle_one_request() reads c_state/c_io_state without holding the appropriate mutex - operation_unlink_client() assumes that if state is BINDING, the operation we're just unlinking is a bind request. However the client could have sent another operation without waiting for the bind response, we shouldn't touch state when disposing of those
https://bugs.openldap.org/show_bug.cgi?id=9624
Ondřej Kuzník ondra@mistotebe.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |2.5.7
https://bugs.openldap.org/show_bug.cgi?id=9624
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@openldap.org |ondra@mistotebe.net
https://bugs.openldap.org/show_bug.cgi?id=9624
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |IN_PROGRESS Ever confirmed|0 |1
--- Comment #1 from Quanah Gibson-Mount quanah@openldap.org --- https://git.openldap.org/openldap/openldap/-/merge_requests/369
https://bugs.openldap.org/show_bug.cgi?id=9624
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |TEST Status|IN_PROGRESS |RESOLVED
--- Comment #2 from Quanah Gibson-Mount quanah@openldap.org ---
Commits: • 7c17f061 by Ondřej Kuzník at 2021-08-04T15:30:36+00:00 ITS#9624 We've already checked before we call request_extended
• 71de64fa by Ondřej Kuzník at 2021-08-04T15:30:36+00:00 ITS#9624 Make sure we reset only for Binds
• 8b24104d by Ondřej Kuzník at 2021-08-04T15:30:36+00:00 ITS#9624 Read state while holding relevant mutex, cache if needed
https://bugs.openldap.org/show_bug.cgi?id=9624
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|TEST |FIXED
--- Comment #3 from Quanah Gibson-Mount quanah@openldap.org --- RE25:
Commits: • 3a958ec7 by Ondřej Kuzník at 2021-08-04T16:36:30+00:00 ITS#9624 We've already checked before we call request_extended
• 4e3843eb by Ondřej Kuzník at 2021-08-04T16:36:35+00:00 ITS#9624 Make sure we reset only for Binds
• ffc2e4aa by Ondřej Kuzník at 2021-08-04T16:36:39+00:00 ITS#9624 Read state while holding relevant mutex, cache if needed
https://bugs.openldap.org/show_bug.cgi?id=9624
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED
-
openldap-its＠openldap.org