[Issue 9989] New: «make clean» shall not delete libraries/libldap/ldap.pc and libraries/liblber/lber.pc
https://bugs.openldap.org/show_bug.cgi?id=9989
Issue ID: 9989 Summary: «make clean» shall not delete libraries/libldap/ldap.pc and libraries/liblber/lber.pc Product: OpenLDAP Version: 2.6.3 Hardware: All OS: All Status: UNCONFIRMED Keywords: needs_review Severity: normal Priority: --- Component: build Assignee: bugs@openldap.org Reporter: dpa-openldap@aegee.org Target Milestone: ---
«./configure» and «./config.status» do create ./libraries/libldap/ldap.pc, ./libraries/liblber/lber.pc, while «make clean» deletes both .pc files.
«make install» fails, if ./libraries/libldap/ldap.pc or ./libraries/liblber/lber.pc are missing.
«./configure && make clean && make depend && make install» is a valid workflow for many other (autoconf/automake based) projects.
./libraries/libldap/ldap.pc and ./libraries/liblber/lber.pc shall be deleted by «make distclean», and kept by «make clean».
See also https://www.gnu.org/prep/standards/html_node/Standard-Targets.html for the idea behind «make clean» vs «make distclean».
https://bugs.openldap.org/show_bug.cgi?id=9989
Howard Chu hyc@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|UNCONFIRMED |RESOLVED
--- Comment #1 from Howard Chu hyc@openldap.org --- We don't have a "distclean" target. "clean" removes all generated files. This is not an automake-based project.
There's no bug here, closing this ticket.
https://bugs.openldap.org/show_bug.cgi?id=9989
--- Comment #2 from dpa-openldap@aegee.org dpa-openldap@aegee.org --- According to the GNU Standard targets - https://www.gnu.org/prep/standards/html_node/Standard-Targets.html - files created by ./configure shall not be deleted by «make clean».
https://bugs.openldap.org/show_bug.cgi?id=9989
Ondřej Kuzník ondra@mistotebe.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CONFIRMED Resolution|INVALID |--- Ever confirmed|0 |1
--- Comment #3 from Ondřej Kuzník ondra@mistotebe.net --- The project doesn't treat pkg-config as very useful and will not treat issues with the .pc files as priority. However you are welcome to submit patches or even offer to maintain this part of the build system.
https://bugs.openldap.org/show_bug.cgi?id=9989
--- Comment #4 from dpa-openldap@aegee.org dpa-openldap@aegee.org --- Proposed patch:
diff --git a/build/lib.mk b/build/lib.mk index 442c0d303..c50ef5284 100644 --- a/build/lib.mk +++ b/build/lib.mk @@ -40,7 +40,7 @@ lint5: lint5-local FORCE clean-common: FORCE $(RM) $(LIBRARY) ../$(LIBRARY) $(XLIBRARY) \ $(PROGRAMS) $(XPROGRAMS) $(XSRCS) $(XXSRCS) \ - *.o *.lo a.out *.exe *.pc core version.c .libs/* + *.o *.lo a.out *.exe core version.c .libs/*
depend-common: FORCE $(MKDEP) $(DEFS) $(DEFINES) $(SRCS) $(XXSRCS)
https://bugs.openldap.org/show_bug.cgi?id=9989
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|needs_review | Target Milestone|--- |2.5.15
https://bugs.openldap.org/show_bug.cgi?id=9989
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Resolution|--- |TEST
--- Comment #5 from Quanah Gibson-Mount quanah@openldap.org --- Commits: • 3c284d26 by Дилян Палаузов at 2023-02-15T18:50:28+00:00 ITS#9989 Keep .pc files on «make clean»
https://bugs.openldap.org/show_bug.cgi?id=9989
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|TEST |FIXED
--- Comment #6 from Quanah Gibson-Mount quanah@openldap.org --- RE26:
• a9f0a885 by Дилян Палаузов at 2023-04-24T18:46:49+00:00 ITS#9989 Keep .pc files on «make clean»
RE25:
• ad9db644 by Дилян Палаузов at 2023-04-24T18:47:17+00:00 ITS#9989 Keep .pc files on «make clean»
https://bugs.openldap.org/show_bug.cgi?id=9989
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED
-
openldap-its＠openldap.org