https://bugs.openldap.org/show_bug.cgi?id=9876
Issue ID: 9876 Summary: Coverity report on OpenLDAP libraries and client tools Product: OpenLDAP Version: 2.6.2 Hardware: All OS: All Status: UNCONFIRMED Keywords: needs_review Severity: normal Priority: --- Component: libraries Assignee: bugs@openldap.org Reporter: simon.pichugin@gmail.com Target Milestone: ---
Created attachment 906 --> https://bugs.openldap.org/attachment.cgi?id=906&action=edit Covscan report for OpenLDAP 2.6.2
I've got a report from our Coverity Scan system. It had a lot of false positives so I've filtered it a bit. Please, find below the report with only RESOURCE_LEAK, LOCK, and MISSING_LOCK issues.
I think there are still some false positives left, but I hope it's worth checking by core OpenLDAP developers.
The report: https://spichugi.fedorapeople.org/openldap-covscan-2.6.2.html
Thank you!
https://bugs.openldap.org/show_bug.cgi?id=9876
--- Comment #1 from Howard Chu hyc@openldap.org --- Thanks for the report.
The lock issues are all false positives. Each case where a function returns with a lock held, that is the intended behavior. Etc...
Some of the leaks may be legit. We've tended to ignore the ones in the client tools since they're one-shot programs, and immediately exit anyway. Feel free to submit patches for those if they bother you, I don't think they're worth the trouble.
I'll fix the library leaks.
https://bugs.openldap.org/show_bug.cgi?id=9876
--- Comment #2 from Howard Chu hyc@openldap.org --- Also, as always, it's better to run these against master, since that's where the patches will be written.
https://bugs.openldap.org/show_bug.cgi?id=9876
--- Comment #3 from Howard Chu hyc@openldap.org --- The leaks reported in ucstr.c, passwd.c, and ldapmap.c are false positives.
https://bugs.openldap.org/show_bug.cgi?id=9876
--- Comment #4 from Simon Pichugin simon.pichugin@gmail.com --- I agree that the client tools' issues are minor and can be sanely waived.
For the rest of the report, thank you for checking!
And sure, I'll be rerunning with the master in the future, no problem with that. Thanks!
https://bugs.openldap.org/show_bug.cgi?id=9876
Howard Chu hyc@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED
--- Comment #5 from Howard Chu hyc@openldap.org --- Forgot to note, fixed in master 78618653c23168b0cc143eca54264191fa5a8bd6
https://bugs.openldap.org/show_bug.cgi?id=9876
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|needs_review | Target Milestone|--- |2.5.13
https://bugs.openldap.org/show_bug.cgi?id=9876
--- Comment #6 from Quanah Gibson-Mount quanah@openldap.org --- head:
• 78618653 by Howard Chu at 2022-07-05T03:49:34+01:00 ITS#9876 Coverity fixes: plug memleaks
RE26:
• b98cfc24 by Howard Chu at 2022-07-07T15:48:31+00:00 ITS#9876 Coverity fixes: plug memleaks
RE25:
• 27043804 by Howard Chu at 2022-07-07T15:53:59+00:00 ITS#9876 Coverity fixes: plug memleaks
https://bugs.openldap.org/show_bug.cgi?id=9876
--- Comment #7 from Quanah Gibson-Mount quanah@openldap.org --- head:
• c07e961d by Ondřej Kuzník at 2022-07-08T15:45:55+00:00 ITS#9876 Some more leaks plugged
RE26:
• 832bcdfe by Ondřej Kuzník at 2022-07-11T16:40:42+00:00 ITS#9876 Some more leaks plugged
RE25:
• 68d1634d by Ondřej Kuzník at 2022-07-11T16:41:26+00:00 ITS#9876 Some more leaks plugged
https://bugs.openldap.org/show_bug.cgi?id=9876
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED
-
openldap-its＠openldap.org