https://bugs.openldap.org/show_bug.cgi?id=9929
Issue ID: 9929 Summary: slapo-dynlist unnecessary search for dynamic lists Product: OpenLDAP Version: 2.5.12 Hardware: All OS: All Status: UNCONFIRMED Keywords: needs_review Severity: normal Priority: --- Component: overlays Assignee: bugs@openldap.org Reporter: hyc@openldap.org Target Milestone: ---
An extra initial search is performed by slapo-dynlist to make dynamic groups filterable. This search is not needed for dynamic lists, but is still occurring.
https://bugs.openldap.org/show_bug.cgi?id=9929
Howard Chu hyc@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |TEST Status|UNCONFIRMED |RESOLVED
--- Comment #1 from Howard Chu hyc@openldap.org --- fixed in master
https://bugs.openldap.org/show_bug.cgi?id=9929
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |2.5.14 Keywords|needs_review | Resolution|TEST |FIXED
--- Comment #2 from Quanah Gibson-Mount quanah@openldap.org --- head:
• a64320d8 by Howard Chu at 2022-10-09T11:51:54+01:00 ITS#9929 dynlist: avoid unnecessary search for dynamic lists
• a3c7e507 by Howard Chu at 2022-10-09T15:04:31+01:00 ITS#9929 dynlist: more for prev commit
• 01cf74be by Howard Chu at 2022-10-09T16:41:04+01:00 ITS#9929 more for prev commit
RE26:
• 24313f81 by Howard Chu at 2022-10-10T17:07:09+00:00 ITS#9929 dynlist: avoid unnecessary search for dynamic lists
RE25:
• b98ee408 by Howard Chu at 2022-10-10T17:09:23+00:00 ITS#9929 dynlist: avoid unnecessary search for dynamic lists
https://bugs.openldap.org/show_bug.cgi?id=9929
--- Comment #3 from Quanah Gibson-Mount quanah@openldap.org --- head:
• d337ae75 by Howard Chu at 2022-12-01T15:39:03+00:00 ITS#9929 slapo-dynlist: more performance tweaks
Minimize cost of dynamic lists while still making them filterable: require their attrs to be explicitly mapped if filtering is to be supported.
Also check config scope in compare op
• cc79020b by Howard Chu at 2022-12-01T15:39:03+00:00 ITS#9929: more performance tweaks
For simple (non-nested) member compares, avoid unnecessary fetches of dyngroups that can't match the filter. cache filter/entry instance info across multiple dyn entries to avoid refetching each filter entry for each dyngruop test.
• 9d53f7cc by Howard Chu at 2022-12-01T15:39:03+00:00 ITS#9929 preserve e_name for memberOf values
• 00610ee8 by Howard Chu at 2022-12-01T15:39:03+00:00 ITS#9121 dynlist: cleanup unused code
• c8e039aa by Howard Chu at 2022-12-01T15:39:03+00:00 ITS#9929 plug memleaks
RE26:
• ebb4e03c by Howard Chu at 2022-12-05T16:31:30+00:00 ITS#9929 slapo-dynlist: more performance tweaks
Minimize cost of dynamic lists while still making them filterable: require their attrs to be explicitly mapped if filtering is to be supported.
Also check config scope in compare op
• d7cd8d80 by Howard Chu at 2022-12-05T16:31:35+00:00 ITS#9929: more performance tweaks
For simple (non-nested) member compares, avoid unnecessary fetches of dyngroups that can't match the filter. cache filter/entry instance info across multiple dyn entries to avoid refetching each filter entry for each dyngruop test.
• dcbc2242 by Howard Chu at 2022-12-05T16:31:42+00:00 ITS#9929 preserve e_name for memberOf values
• f9562b20 by Howard Chu at 2022-12-05T16:31:49+00:00 ITS#9121 dynlist: cleanup unused code
• fdbe6948 by Howard Chu at 2022-12-05T16:31:54+00:00 ITS#9929 plug memleaks
RE25:
• 1911fd13 by Howard Chu at 2022-12-05T16:32:30+00:00 ITS#9929 slapo-dynlist: more performance tweaks
Minimize cost of dynamic lists while still making them filterable: require their attrs to be explicitly mapped if filtering is to be supported.
Also check config scope in compare op
• 9603dddd by Howard Chu at 2022-12-05T16:32:35+00:00 ITS#9929: more performance tweaks
For simple (non-nested) member compares, avoid unnecessary fetches of dyngroups that can't match the filter. cache filter/entry instance info across multiple dyn entries to avoid refetching each filter entry for each dyngruop test.
• 7b9c77db by Howard Chu at 2022-12-05T16:32:40+00:00 ITS#9929 preserve e_name for memberOf values
• 7167fac7 by Howard Chu at 2022-12-05T16:32:44+00:00 ITS#9121 dynlist: cleanup unused code
• febb37db by Howard Chu at 2022-12-05T16:32:49+00:00 ITS#9929 plug memleaks
https://bugs.openldap.org/show_bug.cgi?id=9929
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@openldap.org |hyc@openldap.org
https://bugs.openldap.org/show_bug.cgi?id=9929
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED