https://bugs.openldap.org/show_bug.cgi?id=9700
Issue ID: 9700 Summary: Need to determine new library ABI versioning starting point Product: OpenLDAP Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Keywords: needs_review Severity: normal Priority: --- Component: build Assignee: bugs@openldap.org Reporter: quanah@openldap.org Target Milestone: ---
With the change in how OpenLDAP client libraries are versioned vs prior releases, we need to determine a useful starting point for the current ABI prior to release.
Since current libldap is versioned as libldap.so.2, we may want to start with ol_api_current=2
https://bugs.openldap.org/show_bug.cgi?id=9700
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |blocker Target Milestone|--- |2.6.0
https://bugs.openldap.org/show_bug.cgi?id=9700
--- Comment #1 from Ryan Tandy ryan@openldap.org --- https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.... https://autotools.io/libtool/version.html
Using -release versioning was added in 2.2, commit f1f1b0f69b560aca08745e3e01faddb3321fd264. For returning to the other style, I would expect the library would resume where it left off, also taking into account any ABI changes that happened in the interim.
The last release without -release was 2.1.30, the version-info was 2:130:0. Is this just built from the version string? 2:600:0 I guess is a technically correct libtool version (if unnecessarily large) *IF* libldap 2.6.0 is ABI-compatible with 2.1.30... This also assumes there will never be an ABI change before 3.0.0.
0:0:0 is probably still appropriate for master at all times.
https://bugs.openldap.org/show_bug.cgi?id=9700
--- Comment #2 from Quanah Gibson-Mount quanah@openldap.org --- We don't want to continue using the version string for the ABI.
Will start at 2:200:0 for the 2.6 release
https://bugs.openldap.org/show_bug.cgi?id=9700
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|needs_review | Assignee|bugs@openldap.org |quanah@openldap.org
https://bugs.openldap.org/show_bug.cgi?id=9700
--- Comment #3 from Ryan Tandy ryan@openldap.org --- (In reply to Quanah Gibson-Mount from comment #2)
Will start at 2:200:0 for the 2.6 release
One final thought here: even if things are backwards compatible, I think there were clearly new public symbols added in the mean time? at least ldap_connect, ldap_dup, ldap_init_fd, and various controls functions... So shouldn't the new library be at least 3:0:1? (same SONAME libldap.so.2, but incrementing the "current" interface #...)
https://bugs.openldap.org/show_bug.cgi?id=9700
--- Comment #4 from Quanah Gibson-Mount quanah@openldap.org --- Not per https://www.usenix.org/legacy/publications/library/proceedings/als00/2000pap..., section 3.2.1, where only the minor version is incremented to note that the interface has added new functions.
https://bugs.openldap.org/show_bug.cgi?id=9700
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |TEST Status|UNCONFIRMED |RESOLVED
--- Comment #5 from Quanah Gibson-Mount quanah@openldap.org --- Commits: • 7b216087 by Quanah Gibson-Mount at 2021-09-23T19:22:21+00:00 ITS#9700 - Set initial ABI version for OpenLDAP libldap/liblber
https://bugs.openldap.org/show_bug.cgi?id=9700
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|TEST |FIXED Status|RESOLVED |VERIFIED
-
openldap-its＠openldap.org