https://bugs.openldap.org/show_bug.cgi?id=10553
Issue ID: 10553 Summary: Fix types to allow compilation on windows Product: LMDB Version: 1.0.0 Hardware: All OS: Windows Status: UNCONFIRMED Keywords: needs_review Severity: normal Priority: --- Component: liblmdb Assignee: bugs@openldap.org Reporter: christopher@gmerlin.de Target Milestone: ---
Created attachment 1178 --> https://bugs.openldap.org/attachment.cgi?id=1178&action=edit Patch including ac041af3d
Compilation on windows fails because of pointer type errors. Commit ac041af3dd044d433e73432839cc323bffa357f3 does not fix all of those compilation failures:
* NtMapViewOfSection() expects void * in its 3rd argument. * 7th expects SIZE_T *, but in mdb_env_copyfd0() a DWORD * is passed.
https://bugs.openldap.org/show_bug.cgi?id=10553
--- Comment #1 from Howard Chu hyc@openldap.org --- (In reply to christopher@gmerlin.de from comment #0)
Created attachment 1178 [details] Patch including ac041af3d
Compilation on windows fails because of pointer type errors. Commit ac041af3dd044d433e73432839cc323bffa357f3 does not fix all of those compilation failures:
- NtMapViewOfSection() expects void * in its 3rd argument.
- 7th expects SIZE_T *, but in mdb_env_copyfd0() a DWORD * is passed.
This patch looks incorrect. In particular, NtMapViewOfSection's 3rd argument must be the *address of* a `void *`. The current code in git correctly casts `(void **)&addr`. Casting to `(void *)` is incorrect.
https://bugs.openldap.org/show_bug.cgi?id=10553
Howard Chu hyc@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |TEST Status|UNCONFIRMED |RESOLVED
--- Comment #2 from Howard Chu hyc@openldap.org --- mdb_env_copyfd0 fixed in 6c1fc84aa979e00f5e505409138a49ceed69ac4f
https://bugs.openldap.org/show_bug.cgi?id=10553
Howard Chu hyc@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.0.1 Keywords|needs_review |
https://bugs.openldap.org/show_bug.cgi?id=10553
--- Comment #3 from Quanah Gibson-Mount quanah@openldap.org --- mdb.master3:
• 6c1fc84a by Howard Chu at 2026-07-29T14:26:30+01:00 ITS#10553 lmdb: env_copyfd0, use SIZE_T on Windows
mdb.RE/1.0:
• 39addc87 by Howard Chu at 2026-07-29T14:27:11+01:00 ITS#10553 lmdb: env_copyfd0, use SIZE_T on Windows
https://bugs.openldap.org/show_bug.cgi?id=10553
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@openldap.org |hyc@openldap.org
https://bugs.openldap.org/show_bug.cgi?id=10553
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|TEST |FIXED Status|RESOLVED |VERIFIED
-
openldap-its＠openldap.org