[Issue 10329] New: Additional issues with pcache, and a test

List overview All Threads
Download

newer

older

[Issue 10429] NULL Pointer...

[Issue 10366] New: Is 'second...

openldap-its＠openldap.org

23 Apr 2025 23 Apr '25

9:55 a.m.

https://bugs.openldap.org/show_bug.cgi?id=10329

Issue ID: 10329 Summary: Additional issues with pcache, and a test Product: OpenLDAP Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Keywords: needs_review Severity: normal Priority: --- Component: overlays Assignee: bugs@openldap.org Reporter: aweits@rit.edu Target Milestone: ---

Created attachment 1062 --> https://bugs.openldap.org/attachment.cgi?id=1062&action=edit test & patches

Hello again!

Further testing revealed some more issues in pcache [re: ITS#10270]. I've attached an update to test020-proxycache as well. These are based off the current git HEAD.

-- You are receiving this mail because: You are on the CC list for the issue.

Show replies by date

openldap-its＠openldap.org

26 Apr 26 Apr

10:42 a.m.

New subject: [Issue 10329] Additional issues with pcache, and a test

https://bugs.openldap.org/show_bug.cgi?id=10329

--- Comment #1 from Howard Chu hyc@openldap.org --- Not sure the test changes are workable. We can't really rely on consistent timing, especially when running tests on VMs.

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

29 Apr 29 Apr

8:52 a.m.

New subject: [Issue 10329] Additional issues with pcache, and a test

https://bugs.openldap.org/show_bug.cgi?id=10329

Quanah Gibson-Mount quanah@openldap.org changed:

--- Comment #2 from Quanah Gibson-Mount quanah@openldap.org --- slapd code commits OK

tests need rewriting as timing cannot be guaranteed with the current test suite.

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

8:52 a.m.

New subject: [Issue 10329] Additional issues with pcache, and a test

https://bugs.openldap.org/show_bug.cgi?id=10329

Quanah Gibson-Mount quanah@openldap.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@openldap.org |hyc@openldap.org

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

13 May 13 May

9:56 a.m.

New subject: [Issue 10329] Additional issues with pcache, and a test

https://bugs.openldap.org/show_bug.cgi?id=10329

Howard Chu hyc@openldap.org changed:

--- Comment #3 from Howard Chu hyc@openldap.org --- Code changes only https://git.openldap.org/openldap/openldap/-/merge_requests/770

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

12:26 p.m.

New subject: [Issue 10329] Additional issues with pcache, and a test

https://bugs.openldap.org/show_bug.cgi?id=10329

--- Comment #4 from aweits@rit.edu aweits@rit.edu --- Apologies for not responding sooner - I can look at redoing the test and opening a new ITS for that in a few weeks or so (if that's appropriate)... Thanks for taking care of this!

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

20 May 20 May

8:54 a.m.

New subject: [Issue 10329] Additional issues with pcache, and a test

https://bugs.openldap.org/show_bug.cgi?id=10329

Quanah Gibson-Mount quanah@openldap.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|2.5.20 |2.5.21

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

27 May 27 May

8:31 a.m.

New subject: [Issue 10329] Additional issues with pcache, and a test

https://bugs.openldap.org/show_bug.cgi?id=10329

Quanah Gibson-Mount quanah@openldap.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|2.5.21 |2.6.11

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

5 Jun 5 Jun

5:45 a.m.

New subject: [Issue 10329] Additional issues with pcache, and a test

https://bugs.openldap.org/show_bug.cgi?id=10329

--- Comment #5 from aweits@rit.edu aweits@rit.edu --- I just registered on gitlab, I have some additional feedback on the patches (the change in refresh_query() should be below the return code check from be_search()).

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

27 Jun 27 Jun

4:54 a.m.

New subject: [Issue 10329] Additional issues with pcache, and a test

https://bugs.openldap.org/show_bug.cgi?id=10329

--- Comment #6 from aweits@rit.edu aweits@rit.edu --- Created attachment 1082 --> https://bugs.openldap.org/attachment.cgi?id=1082&action=edit fix on top of hyc/its10329 for the logic in refresh_query()

fix for the logic in refresh_query()

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

30 Jun 30 Jun

9:17 a.m.

New subject: [Issue 10329] Additional issues with pcache, and a test

https://bugs.openldap.org/show_bug.cgi?id=10329

--- Comment #7 from Howard Chu hyc@openldap.org --- (In reply to aweits@rit.edu from comment #6)

...

Created attachment 1082 [details] fix on top of hyc/its10329 for the logic in refresh_query()

fix for the logic in refresh_query()

I've applied this patch to the merge request.

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

25 Nov 25 Nov

10:41 a.m.

New subject: [Issue 10329] Additional issues with pcache, and a test

https://bugs.openldap.org/show_bug.cgi?id=10329

Quanah Gibson-Mount quanah@openldap.org changed:

--- Comment #8 from Quanah Gibson-Mount quanah@openldap.org --- head:

• 326e088d by Andrew Elble at 2025-11-04T18:36:40+00:00 ITS#10329 slapo-pcache: clear out already freed op req DN

• ba18e871 by Andrew Elble at 2025-11-04T18:36:40+00:00 ITS#10329 slapo-pcache: in refresh, set q_uuid on query if it changes pos/neg

• 5359362d by Andrew Elble at 2025-11-04T18:36:40+00:00 ITS#10329 slapo-pcache: (re)set expiry time if query is pos/neg

• 9ae25391 by Andrew Elble at 2025-11-04T18:36:40+00:00 ITS#10329 slapo-pcache: template match must be case insensitive

• 34813d9c by Howard Chu at 2025-11-04T18:36:40+00:00 ITS#10329 slapo-pcache: don't clobber original request DN

RE26:

• 3ec871f5 by Andrew Elble at 2025-11-25T18:22:39+00:00 ITS#10329 slapo-pcache: clear out already freed op req DN

• 0c13135a by Andrew Elble at 2025-11-25T18:22:54+00:00 ITS#10329 slapo-pcache: in refresh, set q_uuid on query if it changes pos/neg

• 13a11822 by Andrew Elble at 2025-11-25T18:23:02+00:00 ITS#10329 slapo-pcache: (re)set expiry time if query is pos/neg

• b2148038 by Andrew Elble at 2025-11-25T18:23:08+00:00 ITS#10329 slapo-pcache: template match must be case insensitive

• 993dc2b7 by Howard Chu at 2025-11-25T18:23:16+00:00 ITS#10329 slapo-pcache: don't clobber original request DN

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

29 Jan 29 Jan

4:48 p.m.

New subject: [Issue 10329] Additional issues with pcache, and a test

https://bugs.openldap.org/show_bug.cgi?id=10329

Quanah Gibson-Mount quanah@openldap.org changed:

-- You are receiving this mail because: You are on the CC list for the issue.

Age (days ago)

294

Last active (days ago)

openldap-bugs@openldap.org

12 comments

1 participants

tags (0)

participants (1)

openldap-its＠openldap.org