https://bugs.openldap.org/show_bug.cgi?id=9231
Bug ID: 9231 Summary: LDAP_USE_NON_BLOCKING_TLS not defined in tls_o.c Product: OpenLDAP Version: 2.5 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: --- Component: libraries Assignee: bugs@openldap.org Reporter: ryan@openldap.org Target Milestone: ---
81588880852e83e094fea5c0b3dc7c75cf39112c (ITS#8980) added code in tls_o.c that's conditional on LDAP_USE_NON_BLOCKING_TLS. However, it's only defined in tls2.c, not in any common header.
I suspect that patch might have been developed with -DLDAP_USE_NON_BLOCKING_TLS added on the command line.
I further suspect that this addition might not even be needed at all, after fixing ITS#8650.
To do: - test async connect behaviour before/after ITS#8980 (confirm the bug and fix) - determine whether the added code is still needed, either delete it or move the #define to a header so it's actually effective
https://bugs.openldap.org/show_bug.cgi?id=9231
Ryan Tandy ryan@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |OL_2_5_REQ
https://bugs.openldap.org/show_bug.cgi?id=9231
Ryan Tandy ryan@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED
--- Comment #1 from Ryan Tandy ryan@openldap.org --- Confirmed that the tls_o.c code caused the issue described in https://bugs.openldap.org/show_bug.cgi?id=8980#c9.
The offending code has been deleted as part of ITS#9207 so this is done.
https://bugs.openldap.org/show_bug.cgi?id=9231
Ryan Tandy ryan@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|OL_2_5_REQ | Status|RESOLVED |VERIFIED
-
openldap-its＠openldap.org